[INFO] crate rs-graph 0.14.2 is already in cache [INFO] extracting crate rs-graph 0.14.2 into work/ex/clippy-test-run/sources/stable/reg/rs-graph/0.14.2 [INFO] extracting crate rs-graph 0.14.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs-graph/0.14.2 [INFO] validating manifest of rs-graph-0.14.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rs-graph-0.14.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rs-graph-0.14.2 [INFO] removed 3 missing examples [INFO] finished frobbing rs-graph-0.14.2 [INFO] frobbed toml for rs-graph-0.14.2 written to work/ex/clippy-test-run/sources/stable/reg/rs-graph/0.14.2/Cargo.toml [INFO] started frobbing rs-graph-0.14.2 [INFO] removed 3 missing examples [INFO] finished frobbing rs-graph-0.14.2 [INFO] frobbed toml for rs-graph-0.14.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs-graph/0.14.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rs-graph-0.14.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rs-graph/0.14.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5303ac8aa29fa7abf6410f87b142ab4c0498617a7f14c879bb470b6f38deb411 [INFO] running `"docker" "start" "-a" "5303ac8aa29fa7abf6410f87b142ab4c0498617a7f14c879bb470b6f38deb411"` [INFO] [stderr] warning: An explicit [[example]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other example targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a example target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/examples/edmondskarp.rs [INFO] [stderr] * /opt/crater/workdir/examples/pushrelabel.rs [INFO] [stderr] * /opt/crater/workdir/examples/dinic.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a example target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autoexamples = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling rs-graph v0.14.2 (/opt/crater/workdir) [INFO] [stderr] Checking rustop v1.0.4 [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/classes.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/classes.rs:119:44 [INFO] [stderr] | [INFO] [stderr] 119 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/branching.rs:23:44 [INFO] [stderr] | [INFO] [stderr] 23 | #[cfg_attr(feature = "cargo-clippy", allow(cyclomatic_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/maxflow/pushrelabel.rs:308:48 [INFO] [stderr] | [INFO] [stderr] 308 | #[cfg_attr(feature = "cargo-clippy", allow(many_single_char_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/shortestpath/floydwarshall.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | #![cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/classes.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/classes.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/classes.rs:119:44 [INFO] [stderr] | [INFO] [stderr] 119 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/branching.rs:23:44 [INFO] [stderr] | [INFO] [stderr] 23 | #[cfg_attr(feature = "cargo-clippy", allow(cyclomatic_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/maxflow/pushrelabel.rs:308:48 [INFO] [stderr] | [INFO] [stderr] 308 | #[cfg_attr(feature = "cargo-clippy", allow(many_single_char_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/shortestpath/floydwarshall.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | #![cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/classes.rs:100:44 [INFO] [stderr] | [INFO] [stderr] 100 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/classes.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let nodes: Vec<_> = (0..m + 1).map(|_| b.add_node()).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=m)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/vec.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | unsafe { mem::transmute(&self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const &vec::IndexItemSliceMut<'a, 'b, G, T, Idx> as *const vec::IndexItemSliceMut<'a, 'b, G, Idx, T>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/algorithms.rs:173:10 [INFO] [stderr] | [INFO] [stderr] 173 | seen.into_iter().all(|&u| u) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shortestpath/bidijkstra.rs:42:11 [INFO] [stderr] | [INFO] [stderr] 42 | pred: Vec<(G::Node, (G::Node, G::Edge))>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shortestpath/bidijkstra.rs:45:11 [INFO] [stderr] | [INFO] [stderr] 45 | succ: Vec<(G::Node, (G::Node, G::Edge))>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/shortestpath/bidijkstra.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn generic( [INFO] [stderr] 125 | | &mut self, [INFO] [stderr] 126 | | weights: Weights, [INFO] [stderr] 127 | | src: G::Node, [INFO] [stderr] ... | [INFO] [stderr] 316 | | } [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shortestpath/moorebellmanford.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | ) -> (IndexNodeVec<'a, G, Option>, Option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shortestpath/moorebellmanford.rs:103:6 [INFO] [stderr] | [INFO] [stderr] 103 | ) -> (IndexNodeVec<'a, G, Option>, Option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/linkedlistgraph.rs:542:74 [INFO] [stderr] | [INFO] [stderr] 542 | for g in [cycle::(7), peterson(), hypercube(5)].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/linkedlistgraph.rs:558:74 [INFO] [stderr] | [INFO] [stderr] 558 | for g in [cycle::(7), peterson(), hypercube(5)].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/classes.rs:31:25 [INFO] [stderr] | [INFO] [stderr] 31 | let nodes: Vec<_> = (0..m + 1).map(|_| b.add_node()).collect(); [INFO] [stderr] | ^^^^^^^^^^ help: use: `(0..=m)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/vec.rs:143:18 [INFO] [stderr] | [INFO] [stderr] 143 | unsafe { mem::transmute(&self) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&self as *const &vec::IndexItemSliceMut<'a, 'b, G, T, Idx> as *const vec::IndexItemSliceMut<'a, 'b, G, Idx, T>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/vec.rs:663:13 [INFO] [stderr] | [INFO] [stderr] 663 | *x = *x + 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `*x += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/algorithms.rs:173:10 [INFO] [stderr] | [INFO] [stderr] 173 | seen.into_iter().all(|&u| u) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shortestpath/bidijkstra.rs:42:11 [INFO] [stderr] | [INFO] [stderr] 42 | pred: Vec<(G::Node, (G::Node, G::Edge))>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shortestpath/bidijkstra.rs:45:11 [INFO] [stderr] | [INFO] [stderr] 45 | succ: Vec<(G::Node, (G::Node, G::Edge))>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/shortestpath/bidijkstra.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | / pub fn generic( [INFO] [stderr] 125 | | &mut self, [INFO] [stderr] 126 | | weights: Weights, [INFO] [stderr] 127 | | src: G::Node, [INFO] [stderr] ... | [INFO] [stderr] 316 | | } [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shortestpath/moorebellmanford.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | ) -> (IndexNodeVec<'a, G, Option>, Option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shortestpath/moorebellmanford.rs:103:6 [INFO] [stderr] | [INFO] [stderr] 103 | ) -> (IndexNodeVec<'a, G, Option>, Option) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rs-graph`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5303ac8aa29fa7abf6410f87b142ab4c0498617a7f14c879bb470b6f38deb411"` [INFO] running `"docker" "rm" "-f" "5303ac8aa29fa7abf6410f87b142ab4c0498617a7f14c879bb470b6f38deb411"` [INFO] [stdout] 5303ac8aa29fa7abf6410f87b142ab4c0498617a7f14c879bb470b6f38deb411