[INFO] crate rs-es 0.10.5 is already in cache [INFO] extracting crate rs-es 0.10.5 into work/ex/clippy-test-run/sources/stable/reg/rs-es/0.10.5 [INFO] extracting crate rs-es 0.10.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs-es/0.10.5 [INFO] validating manifest of rs-es-0.10.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rs-es-0.10.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rs-es-0.10.5 [INFO] finished frobbing rs-es-0.10.5 [INFO] frobbed toml for rs-es-0.10.5 written to work/ex/clippy-test-run/sources/stable/reg/rs-es/0.10.5/Cargo.toml [INFO] started frobbing rs-es-0.10.5 [INFO] finished frobbing rs-es-0.10.5 [INFO] frobbed toml for rs-es-0.10.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rs-es/0.10.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rs-es-0.10.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rs-es/0.10.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88bc41c099b071eb5dbc9f5ab8146db6bf1739c29363ea31f0964e7e10f831cf [INFO] running `"docker" "start" "-a" "88bc41c099b071eb5dbc9f5ab8146db6bf1739c29363ea31f0964e7e10f831cf"` [INFO] [stderr] Checking rs-es v0.10.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/json.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/json.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/json.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | outer: outer [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `outer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/bulk.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/bulk.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | actions: actions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/delete.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/delete.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/delete.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | doc_type: doc_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/delete.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | id: id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/get.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/get.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/get.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | id: id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/index.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/index.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/index.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | doc_type: doc_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/refresh.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | Filter { filter: filter } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:126:19 [INFO] [stderr] | [INFO] [stderr] 126 | Filters { filters: filters } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `filters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | Missing { field: field } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:164:18 [INFO] [stderr] | [INFO] [stderr] 164 | Nested { path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:199:20 [INFO] [stderr] | [INFO] [stderr] 199 | Children { doc_type: doc_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:449:26 [INFO] [stderr] | [INFO] [stderr] 449 | ExtendedBounds { min: min, max: max } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:449:36 [INFO] [stderr] | [INFO] [stderr] 449 | ExtendedBounds { min: min, max: max } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:624:13 [INFO] [stderr] | [INFO] [stderr] 624 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:625:13 [INFO] [stderr] | [INFO] [stderr] 625 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:628:13 [INFO] [stderr] | [INFO] [stderr] 628 | ranges: ranges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:657:13 [INFO] [stderr] | [INFO] [stderr] 657 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:1123:26 [INFO] [stderr] | [INFO] [stderr] 1123 | Ok(RangeResult { buckets: buckets }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | map_script: map_script, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_script` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/count.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/count.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | order: order, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:354:16 [INFO] [stderr] | [INFO] [stderr] 354 | Sort { fields: fields } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:619:13 [INFO] [stderr] | [INFO] [stderr] 619 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:1053:13 [INFO] [stderr] | [INFO] [stderr] 1053 | scroll: scroll, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scroll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:1054:13 [INFO] [stderr] | [INFO] [stderr] 1054 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/analyze.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/analyze.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | body: body, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/mapping.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/mapping.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/version.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | client: client [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/geo.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | coordinates: coordinates [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coordinates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/term.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | amt: amt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `amt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | unit: unit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units.rs:373:13 [INFO] [stderr] | [INFO] [stderr] 373 | amt: amt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `amt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | unit: unit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/json.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/json.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/json.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | outer: outer [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `outer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/bulk.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/bulk.rs:218:13 [INFO] [stderr] | [INFO] [stderr] 218 | actions: actions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `actions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/delete.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/delete.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/delete.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | doc_type: doc_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/delete.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | id: id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/get.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/get.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/get.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | id: id, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/index.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/index.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/index.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | doc_type: doc_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/refresh.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | Filter { filter: filter } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:126:19 [INFO] [stderr] | [INFO] [stderr] 126 | Filters { filters: filters } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `filters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:150:19 [INFO] [stderr] | [INFO] [stderr] 150 | Missing { field: field } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:164:18 [INFO] [stderr] | [INFO] [stderr] 164 | Nested { path: path } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:199:20 [INFO] [stderr] | [INFO] [stderr] 199 | Children { doc_type: doc_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:449:26 [INFO] [stderr] | [INFO] [stderr] 449 | ExtendedBounds { min: min, max: max } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:449:36 [INFO] [stderr] | [INFO] [stderr] 449 | ExtendedBounds { min: min, max: max } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:475:13 [INFO] [stderr] | [INFO] [stderr] 475 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:576:13 [INFO] [stderr] | [INFO] [stderr] 576 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:624:13 [INFO] [stderr] | [INFO] [stderr] 624 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:625:13 [INFO] [stderr] | [INFO] [stderr] 625 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:628:13 [INFO] [stderr] | [INFO] [stderr] 628 | ranges: ranges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:657:13 [INFO] [stderr] | [INFO] [stderr] 657 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:1123:26 [INFO] [stderr] | [INFO] [stderr] 1123 | Ok(RangeResult { buckets: buckets }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `buckets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | field: field, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | map_script: map_script, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_script` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/count.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/count.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | order: order, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:354:16 [INFO] [stderr] | [INFO] [stderr] 354 | Sort { fields: fields } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:410:13 [INFO] [stderr] | [INFO] [stderr] 410 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:619:13 [INFO] [stderr] | [INFO] [stderr] 619 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:1053:13 [INFO] [stderr] | [INFO] [stderr] 1053 | scroll: scroll, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `scroll` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/search/mod.rs:1054:13 [INFO] [stderr] | [INFO] [stderr] 1054 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/analyze.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/analyze.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | body: body, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/mapping.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/mapping.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/operations/version.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | client: client [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/geo.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | coordinates: coordinates [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coordinates` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query/term.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | amt: amt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `amt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | unit: unit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units.rs:373:13 [INFO] [stderr] | [INFO] [stderr] 373 | amt: amt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `amt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/units.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | unit: unit, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `unit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/json.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / if let &Some(ref x) = value { [INFO] [stderr] 41 | | map_ser.serialize_entry(&key, x)?; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | if let Some(ref x) = *value { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/bulk.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | / match response.status_code() { [INFO] [stderr] 286 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 287 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] 288 | | "Unexpected status: {}", [INFO] [stderr] 289 | | response.status_code() [INFO] [stderr] 290 | | ))), [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 285 | match *response.status_code() { [INFO] [stderr] 286 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/delete.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match response.status_code() { [INFO] [stderr] 73 | | &StatusCode::Ok => [INFO] [stderr] 74 | | Ok(response.read_response()?), [INFO] [stderr] 75 | | _ => [INFO] [stderr] 76 | | Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 77 | | response.status_code()))) [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *response.status_code() { [INFO] [stderr] 73 | StatusCode::Ok => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/delete_index.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match response.status_code() { [INFO] [stderr] 38 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 39 | | _ => Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 40 | | response.status_code()))) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *response.status_code() { [INFO] [stderr] 38 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/refresh.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match response.status_code() { [INFO] [stderr] 52 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 53 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] 54 | | "Unexpected status: {}", [INFO] [stderr] 55 | | response.status_code() [INFO] [stderr] 56 | | ))), [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *response.status_code() { [INFO] [stderr] 52 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &Map => "map", [INFO] [stderr] 51 | | &GlobalOrdinalsLowCardinality => "global_ordinals_low_cardinality", [INFO] [stderr] 52 | | &GlobalOrdinals => "global_ordinals", [INFO] [stderr] 53 | | &GlobalOrdinalsHash => "global_ordinals_hash", [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | Map => "map", [INFO] [stderr] 51 | GlobalOrdinalsLowCardinality => "global_ordinals_low_cardinality", [INFO] [stderr] 52 | GlobalOrdinals => "global_ordinals", [INFO] [stderr] 53 | GlobalOrdinalsHash => "global_ordinals_hash", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | / match self { [INFO] [stderr] 225 | | &Count => "_count", [INFO] [stderr] 226 | | &Key => "_key", [INFO] [stderr] 227 | | &Term => "_term", [INFO] [stderr] 228 | | &Expr(e) => e, [INFO] [stderr] 229 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 224 | match *self { [INFO] [stderr] 225 | Count => "_count", [INFO] [stderr] 226 | Key => "_key", [INFO] [stderr] 227 | Term => "_term", [INFO] [stderr] 228 | Expr(e) => e, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | / match self { [INFO] [stderr] 502 | | &Offset(offset) => offset.serialize(serializer), [INFO] [stderr] 503 | | &Str(tz_str) => tz_str.serialize(serializer), [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 501 | match *self { [INFO] [stderr] 502 | Offset(offset) => offset.serialize(serializer), [INFO] [stderr] 503 | Str(tz_str) => tz_str.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:679:5 [INFO] [stderr] | [INFO] [stderr] 679 | Terms(Terms<'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 679 | Terms(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:691:9 [INFO] [stderr] | [INFO] [stderr] 691 | / match self { [INFO] [stderr] 692 | | &Global(_) => "global", [INFO] [stderr] 693 | | &Filter(_) => "filter", [INFO] [stderr] 694 | | &Filters(_) => "filters", [INFO] [stderr] ... | [INFO] [stderr] 705 | | &GeohashGrid(_) => "geohash_grid", [INFO] [stderr] 706 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 691 | match *self { [INFO] [stderr] 692 | Global(_) => "global", [INFO] [stderr] 693 | Filter(_) => "filter", [INFO] [stderr] 694 | Filters(_) => "filters", [INFO] [stderr] 695 | Missing(_) => "missing", [INFO] [stderr] 696 | Nested(_) => "nested", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:716:9 [INFO] [stderr] | [INFO] [stderr] 716 | / match self { [INFO] [stderr] 717 | | &Global(ref g) => g.serialize(serializer), [INFO] [stderr] 718 | | &Filter(ref f) => f.serialize(serializer), [INFO] [stderr] 719 | | &Filters(ref f) => f.serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 730 | | &GeohashGrid(ref g) => g.serialize(serializer), [INFO] [stderr] 731 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 716 | match *self { [INFO] [stderr] 717 | Global(ref g) => g.serialize(serializer), [INFO] [stderr] 718 | Filter(ref f) => f.serialize(serializer), [INFO] [stderr] 719 | Filters(ref f) => f.serialize(serializer), [INFO] [stderr] 720 | Missing(ref m) => m.serialize(serializer), [INFO] [stderr] 721 | Nested(ref n) => n.serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:761:12 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(match ba { [INFO] [stderr] | ____________^ [INFO] [stderr] 762 | | &Global(_) => BucketAggregationResult::Global(GlobalResult::from(json, aggs)?), [INFO] [stderr] 763 | | &BucketAggregation::Filter(_) => { [INFO] [stderr] 764 | | BucketAggregationResult::Filter(FilterResult::from(json, aggs)?) [INFO] [stderr] ... | [INFO] [stderr] 801 | | } [INFO] [stderr] 802 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 761 | Ok(match *ba { [INFO] [stderr] 762 | Global(_) => BucketAggregationResult::Global(GlobalResult::from(json, aggs)?), [INFO] [stderr] 763 | BucketAggregation::Filter(_) => { [INFO] [stderr] 764 | BucketAggregationResult::Filter(FilterResult::from(json, aggs)?) [INFO] [stderr] 765 | } [INFO] [stderr] 766 | BucketAggregation::Filters(_) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:813:5 [INFO] [stderr] | [INFO] [stderr] 813 | bucket_agg_as!(as_global, Global, GlobalResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:813:5 [INFO] [stderr] | [INFO] [stderr] 813 | bucket_agg_as!(as_global, Global, GlobalResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:814:5 [INFO] [stderr] | [INFO] [stderr] 814 | bucket_agg_as!(as_filter, Filter, FilterResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:814:5 [INFO] [stderr] | [INFO] [stderr] 814 | bucket_agg_as!(as_filter, Filter, FilterResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:815:5 [INFO] [stderr] | [INFO] [stderr] 815 | bucket_agg_as!(as_filters, Filters, FiltersResult); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:815:5 [INFO] [stderr] | [INFO] [stderr] 815 | bucket_agg_as!(as_filters, Filters, FiltersResult); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:816:5 [INFO] [stderr] | [INFO] [stderr] 816 | bucket_agg_as!(as_missing, Missing, MissingResult); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:816:5 [INFO] [stderr] | [INFO] [stderr] 816 | bucket_agg_as!(as_missing, Missing, MissingResult); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:817:5 [INFO] [stderr] | [INFO] [stderr] 817 | bucket_agg_as!(as_nested, Nested, NestedResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:817:5 [INFO] [stderr] | [INFO] [stderr] 817 | bucket_agg_as!(as_nested, Nested, NestedResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:818:5 [INFO] [stderr] | [INFO] [stderr] 818 | bucket_agg_as!(as_reverse_nested, ReverseNested, ReverseNestedResult); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:818:5 [INFO] [stderr] | [INFO] [stderr] 818 | bucket_agg_as!(as_reverse_nested, ReverseNested, ReverseNestedResult); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:819:5 [INFO] [stderr] | [INFO] [stderr] 819 | bucket_agg_as!(as_children, Children, ChildrenResult); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:819:5 [INFO] [stderr] | [INFO] [stderr] 819 | bucket_agg_as!(as_children, Children, ChildrenResult); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:820:5 [INFO] [stderr] | [INFO] [stderr] 820 | bucket_agg_as!(as_terms, Terms, TermsResult); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:820:5 [INFO] [stderr] | [INFO] [stderr] 820 | bucket_agg_as!(as_terms, Terms, TermsResult); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:821:5 [INFO] [stderr] | [INFO] [stderr] 821 | bucket_agg_as!(as_range, Range, RangeResult); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:821:5 [INFO] [stderr] | [INFO] [stderr] 821 | bucket_agg_as!(as_range, Range, RangeResult); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:822:5 [INFO] [stderr] | [INFO] [stderr] 822 | bucket_agg_as!(as_date_range, DateRange, DateRangeResult); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:822:5 [INFO] [stderr] | [INFO] [stderr] 822 | bucket_agg_as!(as_date_range, DateRange, DateRangeResult); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:823:5 [INFO] [stderr] | [INFO] [stderr] 823 | bucket_agg_as!(as_histogram, Histogram, HistogramResult); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:823:5 [INFO] [stderr] | [INFO] [stderr] 823 | bucket_agg_as!(as_histogram, Histogram, HistogramResult); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:824:5 [INFO] [stderr] | [INFO] [stderr] 824 | bucket_agg_as!(as_date_histogram, DateHistogram, DateHistogramResult); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:824:5 [INFO] [stderr] | [INFO] [stderr] 824 | bucket_agg_as!(as_date_histogram, DateHistogram, DateHistogramResult); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:825:5 [INFO] [stderr] | [INFO] [stderr] 825 | bucket_agg_as!(as_geo_distance, GeoDistance, GeoDistanceResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:825:5 [INFO] [stderr] | [INFO] [stderr] 825 | bucket_agg_as!(as_geo_distance, GeoDistance, GeoDistanceResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:826:5 [INFO] [stderr] | [INFO] [stderr] 826 | bucket_agg_as!(as_geohash_grid, GeohashGrid, GeohashGridResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:826:5 [INFO] [stderr] | [INFO] [stderr] 826 | bucket_agg_as!(as_geohash_grid, GeohashGrid, GeohashGridResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 913 | aggs: extract_aggs!(json, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 917 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 931 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 935 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 948 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 952 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 987 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 991 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1002 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1006 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1017 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1021 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1034 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1038 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1079 | aggs: extract_aggs!(json, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1083 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1102 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1106 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1147 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1151 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1180 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1184 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1215 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1219 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1256 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1260 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1288 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1292 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | ScriptedMetric(ScriptedMetric<'a>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 258 | ScriptedMetric(Box>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | / match self { [INFO] [stderr] 265 | | &Min(_) => "min", [INFO] [stderr] 266 | | &Max(_) => "max", [INFO] [stderr] 267 | | &Sum(_) => "sum", [INFO] [stderr] ... | [INFO] [stderr] 276 | | &ScriptedMetric(_) => "scripted_metric" [INFO] [stderr] 277 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 264 | match *self { [INFO] [stderr] 265 | Min(_) => "min", [INFO] [stderr] 266 | Max(_) => "max", [INFO] [stderr] 267 | Sum(_) => "sum", [INFO] [stderr] 268 | Avg(_) => "avg", [INFO] [stderr] 269 | Stats(_) => "stats", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | / match self { [INFO] [stderr] 286 | | &Min(ref min) => min.serialize(serializer), [INFO] [stderr] 287 | | &Max(ref max) => max.serialize(serializer), [INFO] [stderr] 288 | | &Sum(ref sum) => sum.serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 297 | | &ScriptedMetric(ref scripted_metric) => scripted_metric.serialize(serializer) [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 285 | match *self { [INFO] [stderr] 286 | Min(ref min) => min.serialize(serializer), [INFO] [stderr] 287 | Max(ref max) => max.serialize(serializer), [INFO] [stderr] 288 | Sum(ref sum) => sum.serialize(serializer), [INFO] [stderr] 289 | Avg(ref avg) => avg.serialize(serializer), [INFO] [stderr] 290 | Stats(ref stats) => stats.serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:325:12 [INFO] [stderr] | [INFO] [stderr] 325 | Ok(match ma { [INFO] [stderr] | ____________^ [INFO] [stderr] 326 | | &Min(_) => { [INFO] [stderr] 327 | | MetricsAggregationResult::Min(from_value(json)?) [INFO] [stderr] 328 | | }, [INFO] [stderr] ... | [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 325 | Ok(match *ma { [INFO] [stderr] 326 | Min(_) => { [INFO] [stderr] 327 | MetricsAggregationResult::Min(from_value(json)?) [INFO] [stderr] 328 | }, [INFO] [stderr] 329 | Max(_) => { [INFO] [stderr] 330 | MetricsAggregationResult::Max(from_value(json)?) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | metrics_agg_as!(as_min, Min, MinResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | metrics_agg_as!(as_min, Min, MinResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | metrics_agg_as!(as_max, Max, MaxResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | metrics_agg_as!(as_max, Max, MaxResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | metrics_agg_as!(as_sum, Sum, SumResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | metrics_agg_as!(as_sum, Sum, SumResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | metrics_agg_as!(as_avg, Avg, AvgResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | metrics_agg_as!(as_avg, Avg, AvgResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | metrics_agg_as!(as_stats, Stats, StatsResult); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | metrics_agg_as!(as_stats, Stats, StatsResult); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | metrics_agg_as!(as_extended_stats, ExtendedStats, ExtendedStatsResult); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | metrics_agg_as!(as_extended_stats, ExtendedStats, ExtendedStatsResult); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | metrics_agg_as!(as_value_count, ValueCount, ValueCountResult); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | metrics_agg_as!(as_value_count, ValueCount, ValueCountResult); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | metrics_agg_as!(as_percentiles, Percentiles, PercentilesResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | metrics_agg_as!(as_percentiles, Percentiles, PercentilesResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | metrics_agg_as!(as_percentile_ranks, PercentileRanks, PercentileRanksResult); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | metrics_agg_as!(as_percentile_ranks, PercentileRanks, PercentileRanksResult); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | metrics_agg_as!(as_cardinality, Cardinality, CardinalityResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | metrics_agg_as!(as_cardinality, Cardinality, CardinalityResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | metrics_agg_as!(as_geo_bounds, GeoBounds, GeoBoundsResult); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | metrics_agg_as!(as_geo_bounds, GeoBounds, GeoBoundsResult); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | metrics_agg_as!(as_scripted_metric, ScriptedMetric, ScriptedMetricResult); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | metrics_agg_as!(as_scripted_metric, ScriptedMetric, ScriptedMetricResult); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:52:54 [INFO] [stderr] | [INFO] [stderr] 52 | let mut map = (serializer.serialize_map(Some(match self { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 53 | | &Metrics(_) => 1, [INFO] [stderr] 54 | | &Bucket(_, ref opt_aggs) => match opt_aggs { [INFO] [stderr] 55 | | &Some(_) => 2, [INFO] [stderr] 56 | | &None => 1, [INFO] [stderr] 57 | | }, [INFO] [stderr] 58 | | })))?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | let mut map = (serializer.serialize_map(Some(match *self { [INFO] [stderr] 53 | Metrics(_) => 1, [INFO] [stderr] 54 | Bucket(_, ref opt_aggs) => match opt_aggs { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:54:41 [INFO] [stderr] | [INFO] [stderr] 54 | &Bucket(_, ref opt_aggs) => match opt_aggs { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 55 | | &Some(_) => 2, [INFO] [stderr] 56 | | &None => 1, [INFO] [stderr] 57 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | &Bucket(_, ref opt_aggs) => match *opt_aggs { [INFO] [stderr] 55 | Some(_) => 2, [INFO] [stderr] 56 | None => 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match self { [INFO] [stderr] 60 | | &Metrics(ref metric_agg) => { [INFO] [stderr] 61 | | let agg_name = metric_agg.details(); [INFO] [stderr] 62 | | map.serialize_entry(agg_name, metric_agg)?; [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *self { [INFO] [stderr] 60 | Metrics(ref metric_agg) => { [INFO] [stderr] 61 | let agg_name = metric_agg.details(); [INFO] [stderr] 62 | map.serialize_entry(agg_name, metric_agg)?; [INFO] [stderr] 63 | } [INFO] [stderr] 64 | Bucket(ref bucket_agg, ref opt_aggs) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | / match opt_aggs { [INFO] [stderr] 68 | | &Some(ref other_aggs) => { [INFO] [stderr] 69 | | map.serialize_entry("aggregations", other_aggs)?; [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | &None => (), [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *opt_aggs { [INFO] [stderr] 68 | Some(ref other_aggs) => { [INFO] [stderr] 69 | map.serialize_entry("aggregations", other_aggs)?; [INFO] [stderr] 70 | } [INFO] [stderr] 71 | None => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / match val { [INFO] [stderr] 159 | | &Metrics(ref ma) => { [INFO] [stderr] 160 | | AggregationResult::Metrics(MetricsAggregationResult::from(ma, json)?) [INFO] [stderr] 161 | | } [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 158 | match *val { [INFO] [stderr] 159 | Metrics(ref ma) => { [INFO] [stderr] 160 | AggregationResult::Metrics(MetricsAggregationResult::from(ma, json)?) [INFO] [stderr] 161 | } [INFO] [stderr] 162 | Aggregation::Bucket(ref ba, ref aggs) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/count.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match response.status_code() { [INFO] [stderr] 78 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 79 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] 80 | | "Unexpected status: {}", [INFO] [stderr] 81 | | response.status_code() [INFO] [stderr] 82 | | ))), [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | match *response.status_code() { [INFO] [stderr] 78 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/count.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / match response.status_code() { [INFO] [stderr] 154 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 155 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] 156 | | "Unexpected status: {}", [INFO] [stderr] 157 | | response.status_code() [INFO] [stderr] 158 | | ))), [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 153 | match *response.status_code() { [INFO] [stderr] 154 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/highlight.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self { [INFO] [stderr] 35 | | &Encoders::Default => "default", [INFO] [stderr] 36 | | &Encoders::HTML => "html", [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *self { [INFO] [stderr] 35 | Encoders::Default => "default", [INFO] [stderr] 36 | Encoders::HTML => "html", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/highlight.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self { [INFO] [stderr] 55 | | &SettingTypes::Plain => "plain", [INFO] [stderr] 56 | | &SettingTypes::FVH => "fvh", [INFO] [stderr] 57 | | &SettingTypes::Postings => "postings", [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | SettingTypes::Plain => "plain", [INFO] [stderr] 56 | SettingTypes::FVH => "fvh", [INFO] [stderr] 57 | SettingTypes::Postings => "postings", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/highlight.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match self { [INFO] [stderr] 74 | | &IndexOptions::Offsets => "offsets", [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | match *self { [INFO] [stderr] 74 | IndexOptions::Offsets => "offsets", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/highlight.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / match self { [INFO] [stderr] 93 | | &TermVector::WithPositionsOffsets => "with_positions_offsets", [INFO] [stderr] 94 | | &TermVector::BoundaryChars => "boundary_chars", [INFO] [stderr] 95 | | &TermVector::BoundaryMaxScan => "boundary_max_scan", [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *self { [INFO] [stderr] 93 | TermVector::WithPositionsOffsets => "with_positions_offsets", [INFO] [stderr] 94 | TermVector::BoundaryChars => "boundary_chars", [INFO] [stderr] 95 | TermVector::BoundaryMaxScan => "boundary_max_scan", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `operations::search::highlight::Setting` [INFO] [stderr] --> src/operations/search/highlight.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Setting { [INFO] [stderr] 116 | | Setting { [INFO] [stderr] 117 | | setting_type: None, [INFO] [stderr] 118 | | index_options: None, [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &SearchType::DFSQueryThenFetch => "dfs_query_then_fetch", [INFO] [stderr] 67 | | &SearchType::DFSQueryAndFetch => "dfs_query_and_fetch", [INFO] [stderr] 68 | | &SearchType::QueryThenFetch => "query_then_fetch", [INFO] [stderr] 69 | | &SearchType::QueryAndFetch => "query_and_fetch", [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | SearchType::DFSQueryThenFetch => "dfs_query_then_fetch", [INFO] [stderr] 67 | SearchType::DFSQueryAndFetch => "dfs_query_and_fetch", [INFO] [stderr] 68 | SearchType::QueryThenFetch => "query_then_fetch", [INFO] [stderr] 69 | SearchType::QueryAndFetch => "query_and_fetch", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match self { [INFO] [stderr] 85 | | &Order::Asc => "asc", [INFO] [stderr] 86 | | &Order::Desc => "desc", [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *self { [INFO] [stderr] 85 | Order::Asc => "asc", [INFO] [stderr] 86 | Order::Desc => "desc", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match self { [INFO] [stderr] 116 | | &Mode::Min => "min", [INFO] [stderr] 117 | | &Mode::Max => "max", [INFO] [stderr] 118 | | &Mode::Sum => "sum", [INFO] [stderr] 119 | | &Mode::Avg => "avg", [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | match *self { [INFO] [stderr] 116 | Mode::Min => "min", [INFO] [stderr] 117 | Mode::Max => "max", [INFO] [stderr] 118 | Mode::Sum => "sum", [INFO] [stderr] 119 | Mode::Avg => "avg", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match self { [INFO] [stderr] 139 | | &Missing::First => "first".serialize(serializer), [INFO] [stderr] 140 | | &Missing::Last => "last".serialize(serializer), [INFO] [stderr] 141 | | &Missing::Custom(ref s) => s.serialize(serializer), [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | match *self { [INFO] [stderr] 139 | Missing::First => "first".serialize(serializer), [INFO] [stderr] 140 | Missing::Last => "last".serialize(serializer), [INFO] [stderr] 141 | Missing::Custom(ref s) => s.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | / match self { [INFO] [stderr] 321 | | &SortBy::Field(ref f) => f.serialize(serializer), [INFO] [stderr] 322 | | &SortBy::Distance(ref d) => d.serialize(serializer), [INFO] [stderr] 323 | | &SortBy::Script(ref s) => s.serialize(serializer), [INFO] [stderr] 324 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 320 | match *self { [INFO] [stderr] 321 | SortBy::Field(ref f) => f.serialize(serializer), [INFO] [stderr] 322 | SortBy::Distance(ref d) => d.serialize(serializer), [INFO] [stderr] 323 | SortBy::Script(ref s) => s.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | / match self { [INFO] [stderr] 331 | | &SortBy::Field(ref field) => field.to_string(), [INFO] [stderr] 332 | | _ => panic!("Can only convert field sorting ToString"), [INFO] [stderr] 333 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 330 | match *self { [INFO] [stderr] 331 | SortBy::Field(ref field) => field.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:470:9 [INFO] [stderr] | [INFO] [stderr] 470 | / match response.status_code() { [INFO] [stderr] 471 | | &StatusCode::Ok => { [INFO] [stderr] 472 | | let interim: SearchResultInterim = response.read_response()?; [INFO] [stderr] 473 | | Ok(interim.finalize()) [INFO] [stderr] ... | [INFO] [stderr] 478 | | ))), [INFO] [stderr] 479 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 470 | match *response.status_code() { [INFO] [stderr] 471 | StatusCode::Ok => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:498:9 [INFO] [stderr] | [INFO] [stderr] 498 | / match self { [INFO] [stderr] 499 | | &Source::Off => false.serialize(serializer), [INFO] [stderr] 500 | | &Source::Filter(incl, excl) => { [INFO] [stderr] 501 | | let mut d = BTreeMap::new(); [INFO] [stderr] ... | [INFO] [stderr] 515 | | } [INFO] [stderr] 516 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 498 | match *self { [INFO] [stderr] 499 | Source::Off => false.serialize(serializer), [INFO] [stderr] 500 | Source::Filter(incl, excl) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/operations/search/mod.rs:502:17 [INFO] [stderr] | [INFO] [stderr] 502 | / match incl { [INFO] [stderr] 503 | | Some(val) => { [INFO] [stderr] 504 | | d.insert("include".to_owned(), val); [INFO] [stderr] 505 | | } [INFO] [stderr] 506 | | None => (), [INFO] [stderr] 507 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 502 | if let Some(val) = incl { [INFO] [stderr] 503 | d.insert("include".to_owned(), val); [INFO] [stderr] 504 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/operations/search/mod.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | / match excl { [INFO] [stderr] 509 | | Some(val) => { [INFO] [stderr] 510 | | d.insert("exclude".to_owned(), val); [INFO] [stderr] 511 | | } [INFO] [stderr] 512 | | None => (), [INFO] [stderr] 513 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 508 | if let Some(val) = excl { [INFO] [stderr] 509 | d.insert("exclude".to_owned(), val); [INFO] [stderr] 510 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:731:9 [INFO] [stderr] | [INFO] [stderr] 731 | / match response.status_code() { [INFO] [stderr] 732 | | &StatusCode::Ok => { [INFO] [stderr] 733 | | let interim: SearchResultInterim = response.read_response()?; [INFO] [stderr] 734 | | let aggs = match &interim.aggs { [INFO] [stderr] ... | [INFO] [stderr] 755 | | ))), [INFO] [stderr] 756 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 731 | match *response.status_code() { [INFO] [stderr] 732 | StatusCode::Ok => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/operations/search/mod.rs:734:28 [INFO] [stderr] | [INFO] [stderr] 734 | let aggs = match &interim.aggs { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 735 | | &Some(ref raw_aggs) => { [INFO] [stderr] 736 | | let req_aggs = match &self.body.aggs { [INFO] [stderr] 737 | | &Some(ref aggs) => aggs, [INFO] [stderr] ... | [INFO] [stderr] 746 | | &None => None, [INFO] [stderr] 747 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 734 | let aggs = match interim.aggs { [INFO] [stderr] 735 | Some(ref raw_aggs) => { [INFO] [stderr] 736 | let req_aggs = match &self.body.aggs { [INFO] [stderr] 737 | &Some(ref aggs) => aggs, [INFO] [stderr] 738 | &None => { [INFO] [stderr] 739 | return Err(EsError::EsError( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/operations/search/mod.rs:736:40 [INFO] [stderr] | [INFO] [stderr] 736 | let req_aggs = match &self.body.aggs { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 737 | | &Some(ref aggs) => aggs, [INFO] [stderr] 738 | | &None => { [INFO] [stderr] 739 | | return Err(EsError::EsError( [INFO] [stderr] ... | [INFO] [stderr] 742 | | } [INFO] [stderr] 743 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 736 | let req_aggs = match self.body.aggs { [INFO] [stderr] 737 | Some(ref aggs) => aggs, [INFO] [stderr] 738 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:772:9 [INFO] [stderr] | [INFO] [stderr] 772 | / match response.status_code() { [INFO] [stderr] 773 | | &StatusCode::Ok => { [INFO] [stderr] 774 | | let interim: ScanResultInterim = response.read_response()?; [INFO] [stderr] 775 | | let aggs = match &interim.aggs { [INFO] [stderr] ... | [INFO] [stderr] 799 | | ))), [INFO] [stderr] 800 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 772 | match *response.status_code() { [INFO] [stderr] 773 | StatusCode::Ok => { [INFO] [stderr] 774 | let interim: ScanResultInterim = response.read_response()?; [INFO] [stderr] 775 | let aggs = match &interim.aggs { [INFO] [stderr] 776 | &Some(ref raw_aggs) => { [INFO] [stderr] 777 | let req_aggs = match &self.body.aggs { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/operations/search/mod.rs:775:28 [INFO] [stderr] | [INFO] [stderr] 775 | let aggs = match &interim.aggs { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 776 | | &Some(ref raw_aggs) => { [INFO] [stderr] 777 | | let req_aggs = match &self.body.aggs { [INFO] [stderr] 778 | | &Some(ref aggs) => aggs, [INFO] [stderr] ... | [INFO] [stderr] 787 | | &None => None, [INFO] [stderr] 788 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 775 | let aggs = match interim.aggs { [INFO] [stderr] 776 | Some(ref raw_aggs) => { [INFO] [stderr] 777 | let req_aggs = match &self.body.aggs { [INFO] [stderr] 778 | &Some(ref aggs) => aggs, [INFO] [stderr] 779 | &None => { [INFO] [stderr] 780 | return Err(EsError::EsError( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/operations/search/mod.rs:777:40 [INFO] [stderr] | [INFO] [stderr] 777 | let req_aggs = match &self.body.aggs { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 778 | | &Some(ref aggs) => aggs, [INFO] [stderr] 779 | | &None => { [INFO] [stderr] 780 | | return Err(EsError::EsError( [INFO] [stderr] ... | [INFO] [stderr] 783 | | } [INFO] [stderr] 784 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 777 | let req_aggs = match self.body.aggs { [INFO] [stderr] 778 | Some(ref aggs) => aggs, [INFO] [stderr] 779 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/operations/search/mod.rs:952:20 [INFO] [stderr] | [INFO] [stderr] 952 | if self.page.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.page.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/operations/search/mod.rs:958:34 [INFO] [stderr] | [INFO] [stderr] 958 | Err(err) => Some(Err(EsError::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `EsError::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/operations/search/mod.rs:984:12 [INFO] [stderr] | [INFO] [stderr] 984 | if self.page.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.page.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/operations/search/mod.rs:1065:19 [INFO] [stderr] | [INFO] [stderr] 1065 | let url = format!("/_search/scroll"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/_search/scroll".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:1075:9 [INFO] [stderr] | [INFO] [stderr] 1075 | / match response.status_code() { [INFO] [stderr] 1076 | | &StatusCode::Ok => { [INFO] [stderr] 1077 | | let search_result: SearchResultInterim = response.read_response()?; [INFO] [stderr] 1078 | | self.scroll_id = match search_result.scroll_id { [INFO] [stderr] ... | [INFO] [stderr] 1088 | | ))), [INFO] [stderr] 1089 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1075 | match *response.status_code() { [INFO] [stderr] 1076 | StatusCode::Ok => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:1096:9 [INFO] [stderr] | [INFO] [stderr] 1096 | / match response.status_code() { [INFO] [stderr] 1097 | | &StatusCode::Ok => Ok(()), // closed [INFO] [stderr] 1098 | | &StatusCode::NotFound => Ok(()), // previously closed [INFO] [stderr] 1099 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] ... | [INFO] [stderr] 1102 | | ))), [INFO] [stderr] 1103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1096 | match *response.status_code() { [INFO] [stderr] 1097 | StatusCode::Ok => Ok(()), // closed [INFO] [stderr] 1098 | StatusCode::NotFound => Ok(()), // previously closed [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/operations/mapping.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | let url = format!("{}", self.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.index.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/mapping.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / match response.status_code() { [INFO] [stderr] 131 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 132 | | _ => Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 133 | | response.status_code()))) [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *response.status_code() { [INFO] [stderr] 131 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/mapping.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match response.status_code() { [INFO] [stderr] 143 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 144 | | _ => Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 145 | | response.status_code()))) [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 142 | match *response.status_code() { [INFO] [stderr] 143 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/mapping.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / match response.status_code() { [INFO] [stderr] 156 | | &StatusCode::Ok => Ok(()), [INFO] [stderr] 157 | | _ => Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 158 | | response.status_code()))) [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *response.status_code() { [INFO] [stderr] 156 | StatusCode::Ok => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/compound.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &BoostMode::Multiply => "multiply", [INFO] [stderr] 44 | | &BoostMode::Replace => "replace", [INFO] [stderr] 45 | | &BoostMode::Sum => "sum", [INFO] [stderr] ... | [INFO] [stderr] 48 | | &BoostMode::Min => "min" [INFO] [stderr] 49 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | BoostMode::Multiply => "multiply", [INFO] [stderr] 44 | BoostMode::Replace => "replace", [INFO] [stderr] 45 | BoostMode::Sum => "sum", [INFO] [stderr] 46 | BoostMode::Avg => "avg", [INFO] [stderr] 47 | BoostMode::Max => "max", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/compound.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | / match self { [INFO] [stderr] 255 | | &None => "none".serialize(serializer), [INFO] [stderr] 256 | | &All => "all".serialize(serializer), [INFO] [stderr] 257 | | &Query(ref q) => q.serialize(serializer) [INFO] [stderr] 258 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 254 | match *self { [INFO] [stderr] 255 | None => "none".serialize(serializer), [INFO] [stderr] 256 | All => "all".serialize(serializer), [INFO] [stderr] 257 | Query(ref q) => q.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/full_text.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self { [INFO] [stderr] 42 | | &Boolean => "boolean", [INFO] [stderr] 43 | | &Phrase => "phrase", [INFO] [stderr] 44 | | &PhrasePrefix => "phrase_prefix" [INFO] [stderr] 45 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self { [INFO] [stderr] 42 | Boolean => "boolean", [INFO] [stderr] 43 | Phrase => "phrase", [INFO] [stderr] 44 | PhrasePrefix => "phrase_prefix" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/full_text.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self { [INFO] [stderr] 62 | | &ZeroTermsQuery::None => "none", [INFO] [stderr] 63 | | &ZeroTermsQuery::All => "all" [INFO] [stderr] 64 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *self { [INFO] [stderr] 62 | ZeroTermsQuery::None => "none", [INFO] [stderr] 63 | ZeroTermsQuery::All => "all" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/full_text.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / match self { [INFO] [stderr] 83 | | &BestFields => "best_fields", [INFO] [stderr] 84 | | &MostFields => "most_fields", [INFO] [stderr] 85 | | &CrossFields => "cross_fields", [INFO] [stderr] 86 | | &Phrase => "phrase", [INFO] [stderr] 87 | | &PhrasePrefix => "phrase_prefix" [INFO] [stderr] 88 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | match *self { [INFO] [stderr] 83 | BestFields => "best_fields", [INFO] [stderr] 84 | MostFields => "most_fields", [INFO] [stderr] 85 | CrossFields => "cross_fields", [INFO] [stderr] 86 | Phrase => "phrase", [INFO] [stderr] 87 | PhrasePrefix => "phrase_prefix" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/full_text.rs:376:9 [INFO] [stderr] | [INFO] [stderr] 376 | / match self { [INFO] [stderr] 377 | | &SimpleQueryStringFlags::All => "ALL", [INFO] [stderr] 378 | | &SimpleQueryStringFlags::None => "NONE", [INFO] [stderr] 379 | | &SimpleQueryStringFlags::And => "AND", [INFO] [stderr] ... | [INFO] [stderr] 389 | | &SimpleQueryStringFlags::Slop => "SLOP" [INFO] [stderr] 390 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 376 | match *self { [INFO] [stderr] 377 | SimpleQueryStringFlags::All => "ALL", [INFO] [stderr] 378 | SimpleQueryStringFlags::None => "NONE", [INFO] [stderr] 379 | SimpleQueryStringFlags::And => "AND", [INFO] [stderr] 380 | SimpleQueryStringFlags::Or => "OR", [INFO] [stderr] 381 | SimpleQueryStringFlags::Not => "NOT", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/functions.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match self { [INFO] [stderr] 176 | | &Modifier::None => "none".serialize(serializer), [INFO] [stderr] 177 | | &Modifier::Log => "log".serialize(serializer), [INFO] [stderr] 178 | | &Modifier::Log1p => "log1p".serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 185 | | &Modifier::Reciprocal => "reciprocal".serialize(serializer), [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 175 | match *self { [INFO] [stderr] 176 | Modifier::None => "none".serialize(serializer), [INFO] [stderr] 177 | Modifier::Log => "log".serialize(serializer), [INFO] [stderr] 178 | Modifier::Log1p => "log1p".serialize(serializer), [INFO] [stderr] 179 | Modifier::Log2p => "log2p".serialize(serializer), [INFO] [stderr] 180 | Modifier::Ln => "ln".serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/functions.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | / match self { [INFO] [stderr] 270 | | &Origin::I64(orig) => orig.serialize(serializer), [INFO] [stderr] 271 | | &Origin::U64(orig) => orig.serialize(serializer), [INFO] [stderr] 272 | | &Origin::F64(orig) => orig.serialize(serializer), [INFO] [stderr] 273 | | &Origin::Location(ref orig) => orig.serialize(serializer), [INFO] [stderr] 274 | | &Origin::Date(ref orig) => orig.serialize(serializer) [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 269 | match *self { [INFO] [stderr] 270 | Origin::I64(orig) => orig.serialize(serializer), [INFO] [stderr] 271 | Origin::U64(orig) => orig.serialize(serializer), [INFO] [stderr] 272 | Origin::F64(orig) => orig.serialize(serializer), [INFO] [stderr] 273 | Origin::Location(ref orig) => orig.serialize(serializer), [INFO] [stderr] 274 | Origin::Date(ref orig) => orig.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/functions.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | / match self { [INFO] [stderr] 306 | | &Scale::I64(s) => s.serialize(serializer), [INFO] [stderr] 307 | | &Scale::U64(s) => s.serialize(serializer), [INFO] [stderr] 308 | | &Scale::F64(s) => s.serialize(serializer), [INFO] [stderr] 309 | | &Scale::Distance(ref s) => s.serialize(serializer), [INFO] [stderr] 310 | | &Scale::Duration(ref s) => s.serialize(serializer) [INFO] [stderr] 311 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 305 | match *self { [INFO] [stderr] 306 | Scale::I64(s) => s.serialize(serializer), [INFO] [stderr] 307 | Scale::U64(s) => s.serialize(serializer), [INFO] [stderr] 308 | Scale::F64(s) => s.serialize(serializer), [INFO] [stderr] 309 | Scale::Distance(ref s) => s.serialize(serializer), [INFO] [stderr] 310 | Scale::Duration(ref s) => s.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/functions.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | / match self { [INFO] [stderr] 329 | | &Min => "min", [INFO] [stderr] 330 | | &Max => "max", [INFO] [stderr] 331 | | &Avg => "avg", [INFO] [stderr] 332 | | &Sum => "sum" [INFO] [stderr] 333 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 328 | match *self { [INFO] [stderr] 329 | Min => "min", [INFO] [stderr] 330 | Max => "max", [INFO] [stderr] 331 | Avg => "avg", [INFO] [stderr] 332 | Sum => "sum" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/geo.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / match self { [INFO] [stderr] 156 | | &Indexed => "indexed", [INFO] [stderr] 157 | | &Memory => "memory" [INFO] [stderr] 158 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *self { [INFO] [stderr] 156 | Indexed => "indexed", [INFO] [stderr] 157 | Memory => "memory" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/geo.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | / match self { [INFO] [stderr] 228 | | &Memory => "memory".serialize(serializer), [INFO] [stderr] 229 | | &Indexed => "indexed".serialize(serializer), [INFO] [stderr] 230 | | &None => "none".serialize(serializer) [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 227 | match *self { [INFO] [stderr] 228 | Memory => "memory".serialize(serializer), [INFO] [stderr] 229 | Indexed => "indexed".serialize(serializer), [INFO] [stderr] 230 | None => "none".serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/geo.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | / match self { [INFO] [stderr] 327 | | &Geohash(precision) => precision.serialize(serializer), [INFO] [stderr] 328 | | &Distance(ref dist) => dist.serialize(serializer) [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 326 | match *self { [INFO] [stderr] 327 | Geohash(precision) => precision.serialize(serializer), [INFO] [stderr] 328 | Distance(ref dist) => dist.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/term.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &ConstantScoreAuto => "constant_score_auto".serialize(serializer), [INFO] [stderr] 45 | | &ScoringBoolean => "scoring_boolean".serialize(serializer), [INFO] [stderr] 46 | | &ConstantScoreBoolean => "constant_score_boolean".serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | ConstantScoreAuto => "constant_score_auto".serialize(serializer), [INFO] [stderr] 45 | ScoringBoolean => "scoring_boolean".serialize(serializer), [INFO] [stderr] 46 | ConstantScoreBoolean => "constant_score_boolean".serialize(serializer), [INFO] [stderr] 47 | ConstantScoreFilter => "constant_score_filter".serialize(serializer), [INFO] [stderr] 48 | TopTerms(n) => format!("top_terms_{}", n).serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/term.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match self { [INFO] [stderr] 137 | | &TermsQueryIn::Values(ref q) => q.serialize(serializer), [INFO] [stderr] 138 | | &TermsQueryIn::Lookup(ref q) => q.serialize(serializer) [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 136 | match *self { [INFO] [stderr] 137 | TermsQueryIn::Values(ref q) => q.serialize(serializer), [INFO] [stderr] 138 | TermsQueryIn::Lookup(ref q) => q.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/term.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | / match self { [INFO] [stderr] 344 | | &RegexpQueryFlags::All => "ALL", [INFO] [stderr] 345 | | &RegexpQueryFlags::Anystring => "ANYSTRING", [INFO] [stderr] 346 | | &RegexpQueryFlags::Complement => "COMPLEMENT", [INFO] [stderr] ... | [INFO] [stderr] 350 | | &RegexpQueryFlags::None => "NONE" [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 343 | match *self { [INFO] [stderr] 344 | RegexpQueryFlags::All => "ALL", [INFO] [stderr] 345 | RegexpQueryFlags::Anystring => "ANYSTRING", [INFO] [stderr] 346 | RegexpQueryFlags::Complement => "COMPLEMENT", [INFO] [stderr] 347 | RegexpQueryFlags::Empty => "EMPTY", [INFO] [stderr] 348 | RegexpQueryFlags::Intersection => "INTERSECTION", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | / match self { [INFO] [stderr] 122 | | &MinimumShouldMatch::Integer(val) => val.to_string(), [INFO] [stderr] 123 | | &MinimumShouldMatch::Percentage(val) => { [INFO] [stderr] 124 | | format!("{}%", val) [INFO] [stderr] 125 | | }, [INFO] [stderr] 126 | | _ => panic!("Can't convert {:?} to String", self) [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 121 | match *self { [INFO] [stderr] 122 | MinimumShouldMatch::Integer(val) => val.to_string(), [INFO] [stderr] 123 | MinimumShouldMatch::Percentage(val) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / match self { [INFO] [stderr] 135 | | &MinimumShouldMatch::Integer(val) => val.serialize(serializer), [INFO] [stderr] 136 | | &MinimumShouldMatch::Percentage(_) => self.to_string().serialize(serializer), [INFO] [stderr] 137 | | &MinimumShouldMatch::Combination(ref comb) => comb.serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 134 | match *self { [INFO] [stderr] 135 | MinimumShouldMatch::Integer(val) => val.serialize(serializer), [INFO] [stderr] 136 | MinimumShouldMatch::Percentage(_) => self.to_string().serialize(serializer), [INFO] [stderr] 137 | MinimumShouldMatch::Combination(ref comb) => comb.serialize(serializer), [INFO] [stderr] 138 | MinimumShouldMatch::MultipleCombination(ref combs) => { [INFO] [stderr] 139 | combs.iter().map(|c| c.to_string()).join(" ").serialize(serializer) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match self { [INFO] [stderr] 168 | | &Auto => "auto".serialize(serializer), [INFO] [stderr] 169 | | &LevenshteinDistance(dist) => dist.serialize(serializer), [INFO] [stderr] 170 | | &Proportionate(p) => p.serialize(serializer) [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *self { [INFO] [stderr] 168 | Auto => "auto".serialize(serializer), [INFO] [stderr] 169 | LevenshteinDistance(dist) => dist.serialize(serializer), [INFO] [stderr] 170 | Proportionate(p) => p.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / match self { [INFO] [stderr] 217 | | &ScoreMode::Multiply => "multiply".serialize(serializer), [INFO] [stderr] 218 | | &ScoreMode::Sum => "sum".serialize(serializer), [INFO] [stderr] 219 | | &ScoreMode::Avg => "avg".serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 222 | | &ScoreMode::Min => "min".serialize(serializer) [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 216 | match *self { [INFO] [stderr] 217 | ScoreMode::Multiply => "multiply".serialize(serializer), [INFO] [stderr] 218 | ScoreMode::Sum => "sum".serialize(serializer), [INFO] [stderr] 219 | ScoreMode::Avg => "avg".serialize(serializer), [INFO] [stderr] 220 | ScoreMode::First => "first".serialize(serializer), [INFO] [stderr] 221 | ScoreMode::Max => "max".serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | / (match self { [INFO] [stderr] 314 | | // All [INFO] [stderr] 315 | | &MatchAll(ref q) => map_ser.serialize_entry("match_all", q), [INFO] [stderr] 316 | | [INFO] [stderr] ... | [INFO] [stderr] 357 | | &MoreLikeThis(ref q) => map_ser.serialize_entry("more_like_this", q) [INFO] [stderr] 358 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 313 | (match *self { [INFO] [stderr] 314 | // All [INFO] [stderr] 315 | MatchAll(ref q) => map_ser.serialize_entry("match_all", q), [INFO] [stderr] 316 | [INFO] [stderr] 317 | // Full-text [INFO] [stderr] 318 | Match(ref q) => map_ser.serialize_entry("match", q), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match self { [INFO] [stderr] 168 | | &Location::LatLon(lat, lon) => { [INFO] [stderr] 169 | | let mut d = BTreeMap::new(); [INFO] [stderr] 170 | | d.insert("lat", lat); [INFO] [stderr] ... | [INFO] [stderr] 174 | | &Location::GeoHash(ref geo_hash) => geo_hash.serialize(serializer), [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *self { [INFO] [stderr] 168 | Location::LatLon(lat, lon) => { [INFO] [stderr] 169 | let mut d = BTreeMap::new(); [INFO] [stderr] 170 | d.insert("lat", lat); [INFO] [stderr] 171 | d.insert("lon", lon); [INFO] [stderr] 172 | d.serialize(serializer) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | / match self { [INFO] [stderr] 236 | | &Corners(ref top_left, ref bottom_right) => { [INFO] [stderr] 237 | | let mut d = BTreeMap::new(); [INFO] [stderr] 238 | | d.insert("top_left", top_left); [INFO] [stderr] ... | [INFO] [stderr] 249 | | } [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 235 | match *self { [INFO] [stderr] 236 | Corners(ref top_left, ref bottom_right) => { [INFO] [stderr] 237 | let mut d = BTreeMap::new(); [INFO] [stderr] 238 | d.insert("top_left", top_left); [INFO] [stderr] 239 | d.insert("bottom_right", bottom_right); [INFO] [stderr] 240 | d.serialize(serializer) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/json.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / if let &Some(ref x) = value { [INFO] [stderr] 41 | | map_ser.serialize_entry(&key, x)?; [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | if let Some(ref x) = *value { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / match self { [INFO] [stderr] 277 | | &OneOrMany::One(ref t) => t.serialize(serializer), [INFO] [stderr] 278 | | &OneOrMany::Many(ref t) => t.serialize(serializer), [INFO] [stderr] 279 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 276 | match *self { [INFO] [stderr] 277 | OneOrMany::One(ref t) => t.serialize(serializer), [INFO] [stderr] 278 | OneOrMany::Many(ref t) => t.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | / match self { [INFO] [stderr] 309 | | &DistanceType::SloppyArc => "sloppy_arc", [INFO] [stderr] 310 | | &DistanceType::Arc => "arc", [INFO] [stderr] 311 | | &DistanceType::Plane => "plane", [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 308 | match *self { [INFO] [stderr] 309 | DistanceType::SloppyArc => "sloppy_arc", [INFO] [stderr] 310 | DistanceType::Arc => "arc", [INFO] [stderr] 311 | DistanceType::Plane => "plane", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:429:12 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(match from { [INFO] [stderr] | ____________^ [INFO] [stderr] 430 | | &String(ref string) => JsonVal::String(string.clone()), [INFO] [stderr] 431 | | &Bool(b) => JsonVal::Boolean(b), [INFO] [stderr] 432 | | &Number(ref i) => JsonVal::Number(i.clone()), [INFO] [stderr] 433 | | _ => return Err(EsError::EsError(format!("Not a JsonVal: {:?}", from))), [INFO] [stderr] 434 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 429 | Ok(match *from { [INFO] [stderr] 430 | String(ref string) => JsonVal::String(string.clone()), [INFO] [stderr] 431 | Bool(b) => JsonVal::Boolean(b), [INFO] [stderr] 432 | Number(ref i) => JsonVal::Number(i.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:449:9 [INFO] [stderr] | [INFO] [stderr] 449 | / match self { [INFO] [stderr] 450 | | &JsonVal::String(ref s) => s.serialize(serializer), [INFO] [stderr] 451 | | &JsonVal::Number(ref i) => i.serialize(serializer), [INFO] [stderr] 452 | | &JsonVal::Boolean(b) => b.serialize(serializer), [INFO] [stderr] 453 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 449 | match *self { [INFO] [stderr] 450 | JsonVal::String(ref s) => s.serialize(serializer), [INFO] [stderr] 451 | JsonVal::Number(ref i) => i.serialize(serializer), [INFO] [stderr] 452 | JsonVal::Boolean(b) => b.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units.rs:545:38 [INFO] [stderr] | [INFO] [stderr] 545 | JsonVal::Number(Number::from_f64(from as f64).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(from)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:562:9 [INFO] [stderr] | [INFO] [stderr] 562 | / match from { [INFO] [stderr] 563 | | &String(ref s) => JsonVal::String(s.clone()), [INFO] [stderr] 564 | | &Number(ref f) => JsonVal::Number(f.clone()), [INFO] [stderr] 565 | | &Bool(b) => JsonVal::Boolean(b), [INFO] [stderr] 566 | | _ => panic!("Not a String, F64, I64, U64 or Boolean"), [INFO] [stderr] 567 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 562 | match *from { [INFO] [stderr] 563 | String(ref s) => JsonVal::String(s.clone()), [INFO] [stderr] 564 | Number(ref f) => JsonVal::Number(f.clone()), [INFO] [stderr] 565 | Bool(b) => JsonVal::Boolean(b), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/bulk.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | / match response.status_code() { [INFO] [stderr] 286 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 287 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] 288 | | "Unexpected status: {}", [INFO] [stderr] 289 | | response.status_code() [INFO] [stderr] 290 | | ))), [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 285 | match *response.status_code() { [INFO] [stderr] 286 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/delete.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match response.status_code() { [INFO] [stderr] 73 | | &StatusCode::Ok => [INFO] [stderr] 74 | | Ok(response.read_response()?), [INFO] [stderr] 75 | | _ => [INFO] [stderr] 76 | | Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 77 | | response.status_code()))) [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 72 | match *response.status_code() { [INFO] [stderr] 73 | StatusCode::Ok => [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/delete_index.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match response.status_code() { [INFO] [stderr] 38 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 39 | | _ => Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 40 | | response.status_code()))) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *response.status_code() { [INFO] [stderr] 38 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/refresh.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match response.status_code() { [INFO] [stderr] 52 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 53 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] 54 | | "Unexpected status: {}", [INFO] [stderr] 55 | | response.status_code() [INFO] [stderr] 56 | | ))), [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *response.status_code() { [INFO] [stderr] 52 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match self { [INFO] [stderr] 50 | | &Map => "map", [INFO] [stderr] 51 | | &GlobalOrdinalsLowCardinality => "global_ordinals_low_cardinality", [INFO] [stderr] 52 | | &GlobalOrdinals => "global_ordinals", [INFO] [stderr] 53 | | &GlobalOrdinalsHash => "global_ordinals_hash", [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *self { [INFO] [stderr] 50 | Map => "map", [INFO] [stderr] 51 | GlobalOrdinalsLowCardinality => "global_ordinals_low_cardinality", [INFO] [stderr] 52 | GlobalOrdinals => "global_ordinals", [INFO] [stderr] 53 | GlobalOrdinalsHash => "global_ordinals_hash", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | / match self { [INFO] [stderr] 225 | | &Count => "_count", [INFO] [stderr] 226 | | &Key => "_key", [INFO] [stderr] 227 | | &Term => "_term", [INFO] [stderr] 228 | | &Expr(e) => e, [INFO] [stderr] 229 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 224 | match *self { [INFO] [stderr] 225 | Count => "_count", [INFO] [stderr] 226 | Key => "_key", [INFO] [stderr] 227 | Term => "_term", [INFO] [stderr] 228 | Expr(e) => e, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | / match self { [INFO] [stderr] 502 | | &Offset(offset) => offset.serialize(serializer), [INFO] [stderr] 503 | | &Str(tz_str) => tz_str.serialize(serializer), [INFO] [stderr] 504 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 501 | match *self { [INFO] [stderr] 502 | Offset(offset) => offset.serialize(serializer), [INFO] [stderr] 503 | Str(tz_str) => tz_str.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:679:5 [INFO] [stderr] | [INFO] [stderr] 679 | Terms(Terms<'a>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 679 | Terms(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:691:9 [INFO] [stderr] | [INFO] [stderr] 691 | / match self { [INFO] [stderr] 692 | | &Global(_) => "global", [INFO] [stderr] 693 | | &Filter(_) => "filter", [INFO] [stderr] 694 | | &Filters(_) => "filters", [INFO] [stderr] ... | [INFO] [stderr] 705 | | &GeohashGrid(_) => "geohash_grid", [INFO] [stderr] 706 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 691 | match *self { [INFO] [stderr] 692 | Global(_) => "global", [INFO] [stderr] 693 | Filter(_) => "filter", [INFO] [stderr] 694 | Filters(_) => "filters", [INFO] [stderr] 695 | Missing(_) => "missing", [INFO] [stderr] 696 | Nested(_) => "nested", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:716:9 [INFO] [stderr] | [INFO] [stderr] 716 | / match self { [INFO] [stderr] 717 | | &Global(ref g) => g.serialize(serializer), [INFO] [stderr] 718 | | &Filter(ref f) => f.serialize(serializer), [INFO] [stderr] 719 | | &Filters(ref f) => f.serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 730 | | &GeohashGrid(ref g) => g.serialize(serializer), [INFO] [stderr] 731 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 716 | match *self { [INFO] [stderr] 717 | Global(ref g) => g.serialize(serializer), [INFO] [stderr] 718 | Filter(ref f) => f.serialize(serializer), [INFO] [stderr] 719 | Filters(ref f) => f.serialize(serializer), [INFO] [stderr] 720 | Missing(ref m) => m.serialize(serializer), [INFO] [stderr] 721 | Nested(ref n) => n.serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:761:12 [INFO] [stderr] | [INFO] [stderr] 761 | Ok(match ba { [INFO] [stderr] | ____________^ [INFO] [stderr] 762 | | &Global(_) => BucketAggregationResult::Global(GlobalResult::from(json, aggs)?), [INFO] [stderr] 763 | | &BucketAggregation::Filter(_) => { [INFO] [stderr] 764 | | BucketAggregationResult::Filter(FilterResult::from(json, aggs)?) [INFO] [stderr] ... | [INFO] [stderr] 801 | | } [INFO] [stderr] 802 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 761 | Ok(match *ba { [INFO] [stderr] 762 | Global(_) => BucketAggregationResult::Global(GlobalResult::from(json, aggs)?), [INFO] [stderr] 763 | BucketAggregation::Filter(_) => { [INFO] [stderr] 764 | BucketAggregationResult::Filter(FilterResult::from(json, aggs)?) [INFO] [stderr] 765 | } [INFO] [stderr] 766 | BucketAggregation::Filters(_) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:813:5 [INFO] [stderr] | [INFO] [stderr] 813 | bucket_agg_as!(as_global, Global, GlobalResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:813:5 [INFO] [stderr] | [INFO] [stderr] 813 | bucket_agg_as!(as_global, Global, GlobalResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:814:5 [INFO] [stderr] | [INFO] [stderr] 814 | bucket_agg_as!(as_filter, Filter, FilterResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:814:5 [INFO] [stderr] | [INFO] [stderr] 814 | bucket_agg_as!(as_filter, Filter, FilterResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:815:5 [INFO] [stderr] | [INFO] [stderr] 815 | bucket_agg_as!(as_filters, Filters, FiltersResult); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:815:5 [INFO] [stderr] | [INFO] [stderr] 815 | bucket_agg_as!(as_filters, Filters, FiltersResult); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:816:5 [INFO] [stderr] | [INFO] [stderr] 816 | bucket_agg_as!(as_missing, Missing, MissingResult); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:816:5 [INFO] [stderr] | [INFO] [stderr] 816 | bucket_agg_as!(as_missing, Missing, MissingResult); [INFO] [stderr] | --------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:817:5 [INFO] [stderr] | [INFO] [stderr] 817 | bucket_agg_as!(as_nested, Nested, NestedResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:817:5 [INFO] [stderr] | [INFO] [stderr] 817 | bucket_agg_as!(as_nested, Nested, NestedResult); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:818:5 [INFO] [stderr] | [INFO] [stderr] 818 | bucket_agg_as!(as_reverse_nested, ReverseNested, ReverseNestedResult); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:818:5 [INFO] [stderr] | [INFO] [stderr] 818 | bucket_agg_as!(as_reverse_nested, ReverseNested, ReverseNestedResult); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:819:5 [INFO] [stderr] | [INFO] [stderr] 819 | bucket_agg_as!(as_children, Children, ChildrenResult); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:819:5 [INFO] [stderr] | [INFO] [stderr] 819 | bucket_agg_as!(as_children, Children, ChildrenResult); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:820:5 [INFO] [stderr] | [INFO] [stderr] 820 | bucket_agg_as!(as_terms, Terms, TermsResult); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:820:5 [INFO] [stderr] | [INFO] [stderr] 820 | bucket_agg_as!(as_terms, Terms, TermsResult); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:821:5 [INFO] [stderr] | [INFO] [stderr] 821 | bucket_agg_as!(as_range, Range, RangeResult); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:821:5 [INFO] [stderr] | [INFO] [stderr] 821 | bucket_agg_as!(as_range, Range, RangeResult); [INFO] [stderr] | --------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:822:5 [INFO] [stderr] | [INFO] [stderr] 822 | bucket_agg_as!(as_date_range, DateRange, DateRangeResult); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:822:5 [INFO] [stderr] | [INFO] [stderr] 822 | bucket_agg_as!(as_date_range, DateRange, DateRangeResult); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:823:5 [INFO] [stderr] | [INFO] [stderr] 823 | bucket_agg_as!(as_histogram, Histogram, HistogramResult); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:823:5 [INFO] [stderr] | [INFO] [stderr] 823 | bucket_agg_as!(as_histogram, Histogram, HistogramResult); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:824:5 [INFO] [stderr] | [INFO] [stderr] 824 | bucket_agg_as!(as_date_histogram, DateHistogram, DateHistogramResult); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:824:5 [INFO] [stderr] | [INFO] [stderr] 824 | bucket_agg_as!(as_date_histogram, DateHistogram, DateHistogramResult); [INFO] [stderr] | ---------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:825:5 [INFO] [stderr] | [INFO] [stderr] 825 | bucket_agg_as!(as_geo_distance, GeoDistance, GeoDistanceResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:825:5 [INFO] [stderr] | [INFO] [stderr] 825 | bucket_agg_as!(as_geo_distance, GeoDistance, GeoDistanceResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:826:5 [INFO] [stderr] | [INFO] [stderr] 826 | bucket_agg_as!(as_geohash_grid, GeohashGrid, GeohashGridResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/bucket.rs:826:5 [INFO] [stderr] | [INFO] [stderr] 826 | bucket_agg_as!(as_geohash_grid, GeohashGrid, GeohashGridResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 913 | aggs: extract_aggs!(json, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 917 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 931 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 935 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 948 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 952 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 987 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 991 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1002 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1006 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1017 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1021 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1034 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1038 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1079 | aggs: extract_aggs!(json, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1083 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1102 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1106 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1147 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1151 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1180 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1184 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1215 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1219 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1256 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1260 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:878:9 [INFO] [stderr] | [INFO] [stderr] 878 | / match $a { [INFO] [stderr] 879 | | &Some(ref aggs) => { [INFO] [stderr] 880 | | let obj = match $j.as_object() { [INFO] [stderr] 881 | | Some(field_val) => field_val, [INFO] [stderr] ... | [INFO] [stderr] 886 | | &None => None, [INFO] [stderr] 887 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1288 | aggs: extract_aggs!(from, aggs), [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/operations/search/aggregations/bucket.rs:834:9 [INFO] [stderr] | [INFO] [stderr] 834 | / pub fn aggs_ref<'a>(&'a self) -> Option<&'a AggregationsResult> { [INFO] [stderr] 835 | | self.aggs.as_ref() [INFO] [stderr] 836 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 1292 | add_aggs_ref!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:258:5 [INFO] [stderr] | [INFO] [stderr] 258 | ScriptedMetric(ScriptedMetric<'a>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 258 | ScriptedMetric(Box>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | / match self { [INFO] [stderr] 265 | | &Min(_) => "min", [INFO] [stderr] 266 | | &Max(_) => "max", [INFO] [stderr] 267 | | &Sum(_) => "sum", [INFO] [stderr] ... | [INFO] [stderr] 276 | | &ScriptedMetric(_) => "scripted_metric" [INFO] [stderr] 277 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 264 | match *self { [INFO] [stderr] 265 | Min(_) => "min", [INFO] [stderr] 266 | Max(_) => "max", [INFO] [stderr] 267 | Sum(_) => "sum", [INFO] [stderr] 268 | Avg(_) => "avg", [INFO] [stderr] 269 | Stats(_) => "stats", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | / match self { [INFO] [stderr] 286 | | &Min(ref min) => min.serialize(serializer), [INFO] [stderr] 287 | | &Max(ref max) => max.serialize(serializer), [INFO] [stderr] 288 | | &Sum(ref sum) => sum.serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 297 | | &ScriptedMetric(ref scripted_metric) => scripted_metric.serialize(serializer) [INFO] [stderr] 298 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 285 | match *self { [INFO] [stderr] 286 | Min(ref min) => min.serialize(serializer), [INFO] [stderr] 287 | Max(ref max) => max.serialize(serializer), [INFO] [stderr] 288 | Sum(ref sum) => sum.serialize(serializer), [INFO] [stderr] 289 | Avg(ref avg) => avg.serialize(serializer), [INFO] [stderr] 290 | Stats(ref stats) => stats.serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/metrics.rs:325:12 [INFO] [stderr] | [INFO] [stderr] 325 | Ok(match ma { [INFO] [stderr] | ____________^ [INFO] [stderr] 326 | | &Min(_) => { [INFO] [stderr] 327 | | MetricsAggregationResult::Min(from_value(json)?) [INFO] [stderr] 328 | | }, [INFO] [stderr] ... | [INFO] [stderr] 361 | | } [INFO] [stderr] 362 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 325 | Ok(match *ma { [INFO] [stderr] 326 | Min(_) => { [INFO] [stderr] 327 | MetricsAggregationResult::Min(from_value(json)?) [INFO] [stderr] 328 | }, [INFO] [stderr] 329 | Max(_) => { [INFO] [stderr] 330 | MetricsAggregationResult::Max(from_value(json)?) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | metrics_agg_as!(as_min, Min, MinResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | metrics_agg_as!(as_min, Min, MinResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | metrics_agg_as!(as_max, Max, MaxResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | metrics_agg_as!(as_max, Max, MaxResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | metrics_agg_as!(as_sum, Sum, SumResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | metrics_agg_as!(as_sum, Sum, SumResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | metrics_agg_as!(as_avg, Avg, AvgResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:376:5 [INFO] [stderr] | [INFO] [stderr] 376 | metrics_agg_as!(as_avg, Avg, AvgResult); [INFO] [stderr] | ---------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | metrics_agg_as!(as_stats, Stats, StatsResult); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:377:5 [INFO] [stderr] | [INFO] [stderr] 377 | metrics_agg_as!(as_stats, Stats, StatsResult); [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | metrics_agg_as!(as_extended_stats, ExtendedStats, ExtendedStatsResult); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | metrics_agg_as!(as_extended_stats, ExtendedStats, ExtendedStatsResult); [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | metrics_agg_as!(as_value_count, ValueCount, ValueCountResult); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:379:5 [INFO] [stderr] | [INFO] [stderr] 379 | metrics_agg_as!(as_value_count, ValueCount, ValueCountResult); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | metrics_agg_as!(as_percentiles, Percentiles, PercentilesResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:380:5 [INFO] [stderr] | [INFO] [stderr] 380 | metrics_agg_as!(as_percentiles, Percentiles, PercentilesResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | metrics_agg_as!(as_percentile_ranks, PercentileRanks, PercentileRanksResult); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:381:5 [INFO] [stderr] | [INFO] [stderr] 381 | metrics_agg_as!(as_percentile_ranks, PercentileRanks, PercentileRanksResult); [INFO] [stderr] | ----------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | metrics_agg_as!(as_cardinality, Cardinality, CardinalityResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:382:5 [INFO] [stderr] | [INFO] [stderr] 382 | metrics_agg_as!(as_cardinality, Cardinality, CardinalityResult); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | metrics_agg_as!(as_geo_bounds, GeoBounds, GeoBoundsResult); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | metrics_agg_as!(as_geo_bounds, GeoBounds, GeoBoundsResult); [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | / match self { [INFO] [stderr] 125 | | &AggregationResult::$st(ref res) => { [INFO] [stderr] 126 | | match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] ... | [INFO] [stderr] 131 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 132 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | metrics_agg_as!(as_scripted_metric, ScriptedMetric, ScriptedMetricResult); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/common.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | / match res { [INFO] [stderr] 127 | | &$tp::$t(ref res) => Ok(res), [INFO] [stderr] 128 | | _ => Err(EsError::EsError(format!("Wrong type: {:?}", self))) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/operations/search/aggregations/metrics.rs:384:5 [INFO] [stderr] | [INFO] [stderr] 384 | metrics_agg_as!(as_scripted_metric, ScriptedMetric, ScriptedMetricResult); [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:52:54 [INFO] [stderr] | [INFO] [stderr] 52 | let mut map = (serializer.serialize_map(Some(match self { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 53 | | &Metrics(_) => 1, [INFO] [stderr] 54 | | &Bucket(_, ref opt_aggs) => match opt_aggs { [INFO] [stderr] 55 | | &Some(_) => 2, [INFO] [stderr] 56 | | &None => 1, [INFO] [stderr] 57 | | }, [INFO] [stderr] 58 | | })))?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | let mut map = (serializer.serialize_map(Some(match *self { [INFO] [stderr] 53 | Metrics(_) => 1, [INFO] [stderr] 54 | Bucket(_, ref opt_aggs) => match opt_aggs { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:54:41 [INFO] [stderr] | [INFO] [stderr] 54 | &Bucket(_, ref opt_aggs) => match opt_aggs { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 55 | | &Some(_) => 2, [INFO] [stderr] 56 | | &None => 1, [INFO] [stderr] 57 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | &Bucket(_, ref opt_aggs) => match *opt_aggs { [INFO] [stderr] 55 | Some(_) => 2, [INFO] [stderr] 56 | None => 1, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match self { [INFO] [stderr] 60 | | &Metrics(ref metric_agg) => { [INFO] [stderr] 61 | | let agg_name = metric_agg.details(); [INFO] [stderr] 62 | | map.serialize_entry(agg_name, metric_agg)?; [INFO] [stderr] ... | [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 59 | match *self { [INFO] [stderr] 60 | Metrics(ref metric_agg) => { [INFO] [stderr] 61 | let agg_name = metric_agg.details(); [INFO] [stderr] 62 | map.serialize_entry(agg_name, metric_agg)?; [INFO] [stderr] 63 | } [INFO] [stderr] 64 | Bucket(ref bucket_agg, ref opt_aggs) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | / match opt_aggs { [INFO] [stderr] 68 | | &Some(ref other_aggs) => { [INFO] [stderr] 69 | | map.serialize_entry("aggregations", other_aggs)?; [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | &None => (), [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 67 | match *opt_aggs { [INFO] [stderr] 68 | Some(ref other_aggs) => { [INFO] [stderr] 69 | map.serialize_entry("aggregations", other_aggs)?; [INFO] [stderr] 70 | } [INFO] [stderr] 71 | None => (), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/aggregations/mod.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | / match val { [INFO] [stderr] 159 | | &Metrics(ref ma) => { [INFO] [stderr] 160 | | AggregationResult::Metrics(MetricsAggregationResult::from(ma, json)?) [INFO] [stderr] 161 | | } [INFO] [stderr] ... | [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 158 | match *val { [INFO] [stderr] 159 | Metrics(ref ma) => { [INFO] [stderr] 160 | AggregationResult::Metrics(MetricsAggregationResult::from(ma, json)?) [INFO] [stderr] 161 | } [INFO] [stderr] 162 | Aggregation::Bucket(ref ba, ref aggs) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/count.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | / match response.status_code() { [INFO] [stderr] 78 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 79 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] 80 | | "Unexpected status: {}", [INFO] [stderr] 81 | | response.status_code() [INFO] [stderr] 82 | | ))), [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 77 | match *response.status_code() { [INFO] [stderr] 78 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/count.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / match response.status_code() { [INFO] [stderr] 154 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 155 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] 156 | | "Unexpected status: {}", [INFO] [stderr] 157 | | response.status_code() [INFO] [stderr] 158 | | ))), [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 153 | match *response.status_code() { [INFO] [stderr] 154 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/highlight.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / match self { [INFO] [stderr] 35 | | &Encoders::Default => "default", [INFO] [stderr] 36 | | &Encoders::HTML => "html", [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 34 | match *self { [INFO] [stderr] 35 | Encoders::Default => "default", [INFO] [stderr] 36 | Encoders::HTML => "html", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/highlight.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self { [INFO] [stderr] 55 | | &SettingTypes::Plain => "plain", [INFO] [stderr] 56 | | &SettingTypes::FVH => "fvh", [INFO] [stderr] 57 | | &SettingTypes::Postings => "postings", [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self { [INFO] [stderr] 55 | SettingTypes::Plain => "plain", [INFO] [stderr] 56 | SettingTypes::FVH => "fvh", [INFO] [stderr] 57 | SettingTypes::Postings => "postings", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/highlight.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | / match self { [INFO] [stderr] 74 | | &IndexOptions::Offsets => "offsets", [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 73 | match *self { [INFO] [stderr] 74 | IndexOptions::Offsets => "offsets", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/highlight.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / match self { [INFO] [stderr] 93 | | &TermVector::WithPositionsOffsets => "with_positions_offsets", [INFO] [stderr] 94 | | &TermVector::BoundaryChars => "boundary_chars", [INFO] [stderr] 95 | | &TermVector::BoundaryMaxScan => "boundary_max_scan", [INFO] [stderr] 96 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *self { [INFO] [stderr] 93 | TermVector::WithPositionsOffsets => "with_positions_offsets", [INFO] [stderr] 94 | TermVector::BoundaryChars => "boundary_chars", [INFO] [stderr] 95 | TermVector::BoundaryMaxScan => "boundary_max_scan", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `operations::search::highlight::Setting` [INFO] [stderr] --> src/operations/search/highlight.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Setting { [INFO] [stderr] 116 | | Setting { [INFO] [stderr] 117 | | setting_type: None, [INFO] [stderr] 118 | | index_options: None, [INFO] [stderr] ... | [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match self { [INFO] [stderr] 66 | | &SearchType::DFSQueryThenFetch => "dfs_query_then_fetch", [INFO] [stderr] 67 | | &SearchType::DFSQueryAndFetch => "dfs_query_and_fetch", [INFO] [stderr] 68 | | &SearchType::QueryThenFetch => "query_then_fetch", [INFO] [stderr] 69 | | &SearchType::QueryAndFetch => "query_and_fetch", [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 65 | match *self { [INFO] [stderr] 66 | SearchType::DFSQueryThenFetch => "dfs_query_then_fetch", [INFO] [stderr] 67 | SearchType::DFSQueryAndFetch => "dfs_query_and_fetch", [INFO] [stderr] 68 | SearchType::QueryThenFetch => "query_then_fetch", [INFO] [stderr] 69 | SearchType::QueryAndFetch => "query_and_fetch", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | / match self { [INFO] [stderr] 85 | | &Order::Asc => "asc", [INFO] [stderr] 86 | | &Order::Desc => "desc", [INFO] [stderr] 87 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | match *self { [INFO] [stderr] 85 | Order::Asc => "asc", [INFO] [stderr] 86 | Order::Desc => "desc", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | / match self { [INFO] [stderr] 116 | | &Mode::Min => "min", [INFO] [stderr] 117 | | &Mode::Max => "max", [INFO] [stderr] 118 | | &Mode::Sum => "sum", [INFO] [stderr] 119 | | &Mode::Avg => "avg", [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 115 | match *self { [INFO] [stderr] 116 | Mode::Min => "min", [INFO] [stderr] 117 | Mode::Max => "max", [INFO] [stderr] 118 | Mode::Sum => "sum", [INFO] [stderr] 119 | Mode::Avg => "avg", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match self { [INFO] [stderr] 139 | | &Missing::First => "first".serialize(serializer), [INFO] [stderr] 140 | | &Missing::Last => "last".serialize(serializer), [INFO] [stderr] 141 | | &Missing::Custom(ref s) => s.serialize(serializer), [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | match *self { [INFO] [stderr] 139 | Missing::First => "first".serialize(serializer), [INFO] [stderr] 140 | Missing::Last => "last".serialize(serializer), [INFO] [stderr] 141 | Missing::Custom(ref s) => s.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | / match self { [INFO] [stderr] 321 | | &SortBy::Field(ref f) => f.serialize(serializer), [INFO] [stderr] 322 | | &SortBy::Distance(ref d) => d.serialize(serializer), [INFO] [stderr] 323 | | &SortBy::Script(ref s) => s.serialize(serializer), [INFO] [stderr] 324 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 320 | match *self { [INFO] [stderr] 321 | SortBy::Field(ref f) => f.serialize(serializer), [INFO] [stderr] 322 | SortBy::Distance(ref d) => d.serialize(serializer), [INFO] [stderr] 323 | SortBy::Script(ref s) => s.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:330:9 [INFO] [stderr] | [INFO] [stderr] 330 | / match self { [INFO] [stderr] 331 | | &SortBy::Field(ref field) => field.to_string(), [INFO] [stderr] 332 | | _ => panic!("Can only convert field sorting ToString"), [INFO] [stderr] 333 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 330 | match *self { [INFO] [stderr] 331 | SortBy::Field(ref field) => field.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:470:9 [INFO] [stderr] | [INFO] [stderr] 470 | / match response.status_code() { [INFO] [stderr] 471 | | &StatusCode::Ok => { [INFO] [stderr] 472 | | let interim: SearchResultInterim = response.read_response()?; [INFO] [stderr] 473 | | Ok(interim.finalize()) [INFO] [stderr] ... | [INFO] [stderr] 478 | | ))), [INFO] [stderr] 479 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 470 | match *response.status_code() { [INFO] [stderr] 471 | StatusCode::Ok => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:498:9 [INFO] [stderr] | [INFO] [stderr] 498 | / match self { [INFO] [stderr] 499 | | &Source::Off => false.serialize(serializer), [INFO] [stderr] 500 | | &Source::Filter(incl, excl) => { [INFO] [stderr] 501 | | let mut d = BTreeMap::new(); [INFO] [stderr] ... | [INFO] [stderr] 515 | | } [INFO] [stderr] 516 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 498 | match *self { [INFO] [stderr] 499 | Source::Off => false.serialize(serializer), [INFO] [stderr] 500 | Source::Filter(incl, excl) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/operations/search/mod.rs:502:17 [INFO] [stderr] | [INFO] [stderr] 502 | / match incl { [INFO] [stderr] 503 | | Some(val) => { [INFO] [stderr] 504 | | d.insert("include".to_owned(), val); [INFO] [stderr] 505 | | } [INFO] [stderr] 506 | | None => (), [INFO] [stderr] 507 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 502 | if let Some(val) = incl { [INFO] [stderr] 503 | d.insert("include".to_owned(), val); [INFO] [stderr] 504 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/operations/search/mod.rs:508:17 [INFO] [stderr] | [INFO] [stderr] 508 | / match excl { [INFO] [stderr] 509 | | Some(val) => { [INFO] [stderr] 510 | | d.insert("exclude".to_owned(), val); [INFO] [stderr] 511 | | } [INFO] [stderr] 512 | | None => (), [INFO] [stderr] 513 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 508 | if let Some(val) = excl { [INFO] [stderr] 509 | d.insert("exclude".to_owned(), val); [INFO] [stderr] 510 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:731:9 [INFO] [stderr] | [INFO] [stderr] 731 | / match response.status_code() { [INFO] [stderr] 732 | | &StatusCode::Ok => { [INFO] [stderr] 733 | | let interim: SearchResultInterim = response.read_response()?; [INFO] [stderr] 734 | | let aggs = match &interim.aggs { [INFO] [stderr] ... | [INFO] [stderr] 755 | | ))), [INFO] [stderr] 756 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 731 | match *response.status_code() { [INFO] [stderr] 732 | StatusCode::Ok => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/operations/search/mod.rs:734:28 [INFO] [stderr] | [INFO] [stderr] 734 | let aggs = match &interim.aggs { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 735 | | &Some(ref raw_aggs) => { [INFO] [stderr] 736 | | let req_aggs = match &self.body.aggs { [INFO] [stderr] 737 | | &Some(ref aggs) => aggs, [INFO] [stderr] ... | [INFO] [stderr] 746 | | &None => None, [INFO] [stderr] 747 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 734 | let aggs = match interim.aggs { [INFO] [stderr] 735 | Some(ref raw_aggs) => { [INFO] [stderr] 736 | let req_aggs = match &self.body.aggs { [INFO] [stderr] 737 | &Some(ref aggs) => aggs, [INFO] [stderr] 738 | &None => { [INFO] [stderr] 739 | return Err(EsError::EsError( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/operations/search/mod.rs:736:40 [INFO] [stderr] | [INFO] [stderr] 736 | let req_aggs = match &self.body.aggs { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 737 | | &Some(ref aggs) => aggs, [INFO] [stderr] 738 | | &None => { [INFO] [stderr] 739 | | return Err(EsError::EsError( [INFO] [stderr] ... | [INFO] [stderr] 742 | | } [INFO] [stderr] 743 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 736 | let req_aggs = match self.body.aggs { [INFO] [stderr] 737 | Some(ref aggs) => aggs, [INFO] [stderr] 738 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:772:9 [INFO] [stderr] | [INFO] [stderr] 772 | / match response.status_code() { [INFO] [stderr] 773 | | &StatusCode::Ok => { [INFO] [stderr] 774 | | let interim: ScanResultInterim = response.read_response()?; [INFO] [stderr] 775 | | let aggs = match &interim.aggs { [INFO] [stderr] ... | [INFO] [stderr] 799 | | ))), [INFO] [stderr] 800 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 772 | match *response.status_code() { [INFO] [stderr] 773 | StatusCode::Ok => { [INFO] [stderr] 774 | let interim: ScanResultInterim = response.read_response()?; [INFO] [stderr] 775 | let aggs = match &interim.aggs { [INFO] [stderr] 776 | &Some(ref raw_aggs) => { [INFO] [stderr] 777 | let req_aggs = match &self.body.aggs { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/operations/search/mod.rs:775:28 [INFO] [stderr] | [INFO] [stderr] 775 | let aggs = match &interim.aggs { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 776 | | &Some(ref raw_aggs) => { [INFO] [stderr] 777 | | let req_aggs = match &self.body.aggs { [INFO] [stderr] 778 | | &Some(ref aggs) => aggs, [INFO] [stderr] ... | [INFO] [stderr] 787 | | &None => None, [INFO] [stderr] 788 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 775 | let aggs = match interim.aggs { [INFO] [stderr] 776 | Some(ref raw_aggs) => { [INFO] [stderr] 777 | let req_aggs = match &self.body.aggs { [INFO] [stderr] 778 | &Some(ref aggs) => aggs, [INFO] [stderr] 779 | &None => { [INFO] [stderr] 780 | return Err(EsError::EsError( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/operations/search/mod.rs:777:40 [INFO] [stderr] | [INFO] [stderr] 777 | let req_aggs = match &self.body.aggs { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 778 | | &Some(ref aggs) => aggs, [INFO] [stderr] 779 | | &None => { [INFO] [stderr] 780 | | return Err(EsError::EsError( [INFO] [stderr] ... | [INFO] [stderr] 783 | | } [INFO] [stderr] 784 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 777 | let req_aggs = match self.body.aggs { [INFO] [stderr] 778 | Some(ref aggs) => aggs, [INFO] [stderr] 779 | None => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/operations/search/mod.rs:952:20 [INFO] [stderr] | [INFO] [stderr] 952 | if self.page.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.page.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/operations/search/mod.rs:958:34 [INFO] [stderr] | [INFO] [stderr] 958 | Err(err) => Some(Err(EsError::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `EsError::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/operations/search/mod.rs:984:12 [INFO] [stderr] | [INFO] [stderr] 984 | if self.page.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.page.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/operations/search/mod.rs:1065:19 [INFO] [stderr] | [INFO] [stderr] 1065 | let url = format!("/_search/scroll"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/_search/scroll".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:1075:9 [INFO] [stderr] | [INFO] [stderr] 1075 | / match response.status_code() { [INFO] [stderr] 1076 | | &StatusCode::Ok => { [INFO] [stderr] 1077 | | let search_result: SearchResultInterim = response.read_response()?; [INFO] [stderr] 1078 | | self.scroll_id = match search_result.scroll_id { [INFO] [stderr] ... | [INFO] [stderr] 1088 | | ))), [INFO] [stderr] 1089 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1075 | match *response.status_code() { [INFO] [stderr] 1076 | StatusCode::Ok => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:1096:9 [INFO] [stderr] | [INFO] [stderr] 1096 | / match response.status_code() { [INFO] [stderr] 1097 | | &StatusCode::Ok => Ok(()), // closed [INFO] [stderr] 1098 | | &StatusCode::NotFound => Ok(()), // previously closed [INFO] [stderr] 1099 | | _ => Err(EsError::EsError(format!( [INFO] [stderr] ... | [INFO] [stderr] 1102 | | ))), [INFO] [stderr] 1103 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1096 | match *response.status_code() { [INFO] [stderr] 1097 | StatusCode::Ok => Ok(()), // closed [INFO] [stderr] 1098 | StatusCode::NotFound => Ok(()), // previously closed [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:1533:9 [INFO] [stderr] | [INFO] [stderr] 1533 | / match min_a { [INFO] [stderr] 1534 | | &JsonVal::Number(ref i) => assert_eq!(Some(1.0), i.as_f64()), [INFO] [stderr] 1535 | | _ => panic!("Not an integer"), [INFO] [stderr] 1536 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1533 | match *min_a { [INFO] [stderr] 1534 | JsonVal::Number(ref i) => assert_eq!(Some(1.0), i.as_f64()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:1537:9 [INFO] [stderr] | [INFO] [stderr] 1537 | / match min_b { [INFO] [stderr] 1538 | | &JsonVal::Number(ref i) => assert_eq!(Some(2.0), i.as_f64()), [INFO] [stderr] 1539 | | _ => panic!("Not an integer"), [INFO] [stderr] 1540 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1537 | match *min_b { [INFO] [stderr] 1538 | JsonVal::Number(ref i) => assert_eq!(Some(2.0), i.as_f64()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/search/mod.rs:1580:9 [INFO] [stderr] | [INFO] [stderr] 1580 | / match min { [INFO] [stderr] 1581 | | &JsonVal::Number(ref i) => assert_eq!(Some(1.0), i.as_f64()), [INFO] [stderr] 1582 | | _ => panic!("Not an integer"), [INFO] [stderr] 1583 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1580 | match *min { [INFO] [stderr] 1581 | JsonVal::Number(ref i) => assert_eq!(Some(1.0), i.as_f64()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/operations/mapping.rs:102:23 [INFO] [stderr] | [INFO] [stderr] 102 | let url = format!("{}", self.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.index.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/mapping.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | / match response.status_code() { [INFO] [stderr] 131 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 132 | | _ => Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 133 | | response.status_code()))) [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 130 | match *response.status_code() { [INFO] [stderr] 131 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/mapping.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match response.status_code() { [INFO] [stderr] 143 | | &StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] 144 | | _ => Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 145 | | response.status_code()))) [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 142 | match *response.status_code() { [INFO] [stderr] 143 | StatusCode::Ok => Ok(response.read_response()?), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/operations/mapping.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / match response.status_code() { [INFO] [stderr] 156 | | &StatusCode::Ok => Ok(()), [INFO] [stderr] 157 | | _ => Err(EsError::EsError(format!("Unexpected status: {}", [INFO] [stderr] 158 | | response.status_code()))) [INFO] [stderr] 159 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *response.status_code() { [INFO] [stderr] 156 | StatusCode::Ok => Ok(()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/compound.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self { [INFO] [stderr] 43 | | &BoostMode::Multiply => "multiply", [INFO] [stderr] 44 | | &BoostMode::Replace => "replace", [INFO] [stderr] 45 | | &BoostMode::Sum => "sum", [INFO] [stderr] ... | [INFO] [stderr] 48 | | &BoostMode::Min => "min" [INFO] [stderr] 49 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *self { [INFO] [stderr] 43 | BoostMode::Multiply => "multiply", [INFO] [stderr] 44 | BoostMode::Replace => "replace", [INFO] [stderr] 45 | BoostMode::Sum => "sum", [INFO] [stderr] 46 | BoostMode::Avg => "avg", [INFO] [stderr] 47 | BoostMode::Max => "max", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/compound.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | / match self { [INFO] [stderr] 255 | | &None => "none".serialize(serializer), [INFO] [stderr] 256 | | &All => "all".serialize(serializer), [INFO] [stderr] 257 | | &Query(ref q) => q.serialize(serializer) [INFO] [stderr] 258 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 254 | match *self { [INFO] [stderr] 255 | None => "none".serialize(serializer), [INFO] [stderr] 256 | All => "all".serialize(serializer), [INFO] [stderr] 257 | Query(ref q) => q.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/full_text.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match self { [INFO] [stderr] 42 | | &Boolean => "boolean", [INFO] [stderr] 43 | | &Phrase => "phrase", [INFO] [stderr] 44 | | &PhrasePrefix => "phrase_prefix" [INFO] [stderr] 45 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *self { [INFO] [stderr] 42 | Boolean => "boolean", [INFO] [stderr] 43 | Phrase => "phrase", [INFO] [stderr] 44 | PhrasePrefix => "phrase_prefix" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/full_text.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match self { [INFO] [stderr] 62 | | &ZeroTermsQuery::None => "none", [INFO] [stderr] 63 | | &ZeroTermsQuery::All => "all" [INFO] [stderr] 64 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *self { [INFO] [stderr] 62 | ZeroTermsQuery::None => "none", [INFO] [stderr] 63 | ZeroTermsQuery::All => "all" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/full_text.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / match self { [INFO] [stderr] 83 | | &BestFields => "best_fields", [INFO] [stderr] 84 | | &MostFields => "most_fields", [INFO] [stderr] 85 | | &CrossFields => "cross_fields", [INFO] [stderr] 86 | | &Phrase => "phrase", [INFO] [stderr] 87 | | &PhrasePrefix => "phrase_prefix" [INFO] [stderr] 88 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | match *self { [INFO] [stderr] 83 | BestFields => "best_fields", [INFO] [stderr] 84 | MostFields => "most_fields", [INFO] [stderr] 85 | CrossFields => "cross_fields", [INFO] [stderr] 86 | Phrase => "phrase", [INFO] [stderr] 87 | PhrasePrefix => "phrase_prefix" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/full_text.rs:376:9 [INFO] [stderr] | [INFO] [stderr] 376 | / match self { [INFO] [stderr] 377 | | &SimpleQueryStringFlags::All => "ALL", [INFO] [stderr] 378 | | &SimpleQueryStringFlags::None => "NONE", [INFO] [stderr] 379 | | &SimpleQueryStringFlags::And => "AND", [INFO] [stderr] ... | [INFO] [stderr] 389 | | &SimpleQueryStringFlags::Slop => "SLOP" [INFO] [stderr] 390 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 376 | match *self { [INFO] [stderr] 377 | SimpleQueryStringFlags::All => "ALL", [INFO] [stderr] 378 | SimpleQueryStringFlags::None => "NONE", [INFO] [stderr] 379 | SimpleQueryStringFlags::And => "AND", [INFO] [stderr] 380 | SimpleQueryStringFlags::Or => "OR", [INFO] [stderr] 381 | SimpleQueryStringFlags::Not => "NOT", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/functions.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match self { [INFO] [stderr] 176 | | &Modifier::None => "none".serialize(serializer), [INFO] [stderr] 177 | | &Modifier::Log => "log".serialize(serializer), [INFO] [stderr] 178 | | &Modifier::Log1p => "log1p".serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 185 | | &Modifier::Reciprocal => "reciprocal".serialize(serializer), [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 175 | match *self { [INFO] [stderr] 176 | Modifier::None => "none".serialize(serializer), [INFO] [stderr] 177 | Modifier::Log => "log".serialize(serializer), [INFO] [stderr] 178 | Modifier::Log1p => "log1p".serialize(serializer), [INFO] [stderr] 179 | Modifier::Log2p => "log2p".serialize(serializer), [INFO] [stderr] 180 | Modifier::Ln => "ln".serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/functions.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | / match self { [INFO] [stderr] 270 | | &Origin::I64(orig) => orig.serialize(serializer), [INFO] [stderr] 271 | | &Origin::U64(orig) => orig.serialize(serializer), [INFO] [stderr] 272 | | &Origin::F64(orig) => orig.serialize(serializer), [INFO] [stderr] 273 | | &Origin::Location(ref orig) => orig.serialize(serializer), [INFO] [stderr] 274 | | &Origin::Date(ref orig) => orig.serialize(serializer) [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 269 | match *self { [INFO] [stderr] 270 | Origin::I64(orig) => orig.serialize(serializer), [INFO] [stderr] 271 | Origin::U64(orig) => orig.serialize(serializer), [INFO] [stderr] 272 | Origin::F64(orig) => orig.serialize(serializer), [INFO] [stderr] 273 | Origin::Location(ref orig) => orig.serialize(serializer), [INFO] [stderr] 274 | Origin::Date(ref orig) => orig.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/functions.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | / match self { [INFO] [stderr] 306 | | &Scale::I64(s) => s.serialize(serializer), [INFO] [stderr] 307 | | &Scale::U64(s) => s.serialize(serializer), [INFO] [stderr] 308 | | &Scale::F64(s) => s.serialize(serializer), [INFO] [stderr] 309 | | &Scale::Distance(ref s) => s.serialize(serializer), [INFO] [stderr] 310 | | &Scale::Duration(ref s) => s.serialize(serializer) [INFO] [stderr] 311 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 305 | match *self { [INFO] [stderr] 306 | Scale::I64(s) => s.serialize(serializer), [INFO] [stderr] 307 | Scale::U64(s) => s.serialize(serializer), [INFO] [stderr] 308 | Scale::F64(s) => s.serialize(serializer), [INFO] [stderr] 309 | Scale::Distance(ref s) => s.serialize(serializer), [INFO] [stderr] 310 | Scale::Duration(ref s) => s.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/functions.rs:328:9 [INFO] [stderr] | [INFO] [stderr] 328 | / match self { [INFO] [stderr] 329 | | &Min => "min", [INFO] [stderr] 330 | | &Max => "max", [INFO] [stderr] 331 | | &Avg => "avg", [INFO] [stderr] 332 | | &Sum => "sum" [INFO] [stderr] 333 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 328 | match *self { [INFO] [stderr] 329 | Min => "min", [INFO] [stderr] 330 | Max => "max", [INFO] [stderr] 331 | Avg => "avg", [INFO] [stderr] 332 | Sum => "sum" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/geo.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / match self { [INFO] [stderr] 156 | | &Indexed => "indexed", [INFO] [stderr] 157 | | &Memory => "memory" [INFO] [stderr] 158 | | }.serialize(serializer) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 155 | match *self { [INFO] [stderr] 156 | Indexed => "indexed", [INFO] [stderr] 157 | Memory => "memory" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/geo.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | / match self { [INFO] [stderr] 228 | | &Memory => "memory".serialize(serializer), [INFO] [stderr] 229 | | &Indexed => "indexed".serialize(serializer), [INFO] [stderr] 230 | | &None => "none".serialize(serializer) [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 227 | match *self { [INFO] [stderr] 228 | Memory => "memory".serialize(serializer), [INFO] [stderr] 229 | Indexed => "indexed".serialize(serializer), [INFO] [stderr] 230 | None => "none".serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/geo.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | / match self { [INFO] [stderr] 327 | | &Geohash(precision) => precision.serialize(serializer), [INFO] [stderr] 328 | | &Distance(ref dist) => dist.serialize(serializer) [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 326 | match *self { [INFO] [stderr] 327 | Geohash(precision) => precision.serialize(serializer), [INFO] [stderr] 328 | Distance(ref dist) => dist.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/term.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match self { [INFO] [stderr] 44 | | &ConstantScoreAuto => "constant_score_auto".serialize(serializer), [INFO] [stderr] 45 | | &ScoringBoolean => "scoring_boolean".serialize(serializer), [INFO] [stderr] 46 | | &ConstantScoreBoolean => "constant_score_boolean".serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *self { [INFO] [stderr] 44 | ConstantScoreAuto => "constant_score_auto".serialize(serializer), [INFO] [stderr] 45 | ScoringBoolean => "scoring_boolean".serialize(serializer), [INFO] [stderr] 46 | ConstantScoreBoolean => "constant_score_boolean".serialize(serializer), [INFO] [stderr] 47 | ConstantScoreFilter => "constant_score_filter".serialize(serializer), [INFO] [stderr] 48 | TopTerms(n) => format!("top_terms_{}", n).serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/term.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match self { [INFO] [stderr] 137 | | &TermsQueryIn::Values(ref q) => q.serialize(serializer), [INFO] [stderr] 138 | | &TermsQueryIn::Lookup(ref q) => q.serialize(serializer) [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 136 | match *self { [INFO] [stderr] 137 | TermsQueryIn::Values(ref q) => q.serialize(serializer), [INFO] [stderr] 138 | TermsQueryIn::Lookup(ref q) => q.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/term.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | / match self { [INFO] [stderr] 344 | | &RegexpQueryFlags::All => "ALL", [INFO] [stderr] 345 | | &RegexpQueryFlags::Anystring => "ANYSTRING", [INFO] [stderr] 346 | | &RegexpQueryFlags::Complement => "COMPLEMENT", [INFO] [stderr] ... | [INFO] [stderr] 350 | | &RegexpQueryFlags::None => "NONE" [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 343 | match *self { [INFO] [stderr] 344 | RegexpQueryFlags::All => "ALL", [INFO] [stderr] 345 | RegexpQueryFlags::Anystring => "ANYSTRING", [INFO] [stderr] 346 | RegexpQueryFlags::Complement => "COMPLEMENT", [INFO] [stderr] 347 | RegexpQueryFlags::Empty => "EMPTY", [INFO] [stderr] 348 | RegexpQueryFlags::Intersection => "INTERSECTION", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | / match self { [INFO] [stderr] 122 | | &MinimumShouldMatch::Integer(val) => val.to_string(), [INFO] [stderr] 123 | | &MinimumShouldMatch::Percentage(val) => { [INFO] [stderr] 124 | | format!("{}%", val) [INFO] [stderr] 125 | | }, [INFO] [stderr] 126 | | _ => panic!("Can't convert {:?} to String", self) [INFO] [stderr] 127 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 121 | match *self { [INFO] [stderr] 122 | MinimumShouldMatch::Integer(val) => val.to_string(), [INFO] [stderr] 123 | MinimumShouldMatch::Percentage(val) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / match self { [INFO] [stderr] 135 | | &MinimumShouldMatch::Integer(val) => val.serialize(serializer), [INFO] [stderr] 136 | | &MinimumShouldMatch::Percentage(_) => self.to_string().serialize(serializer), [INFO] [stderr] 137 | | &MinimumShouldMatch::Combination(ref comb) => comb.serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 134 | match *self { [INFO] [stderr] 135 | MinimumShouldMatch::Integer(val) => val.serialize(serializer), [INFO] [stderr] 136 | MinimumShouldMatch::Percentage(_) => self.to_string().serialize(serializer), [INFO] [stderr] 137 | MinimumShouldMatch::Combination(ref comb) => comb.serialize(serializer), [INFO] [stderr] 138 | MinimumShouldMatch::MultipleCombination(ref combs) => { [INFO] [stderr] 139 | combs.iter().map(|c| c.to_string()).join(" ").serialize(serializer) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match self { [INFO] [stderr] 168 | | &Auto => "auto".serialize(serializer), [INFO] [stderr] 169 | | &LevenshteinDistance(dist) => dist.serialize(serializer), [INFO] [stderr] 170 | | &Proportionate(p) => p.serialize(serializer) [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *self { [INFO] [stderr] 168 | Auto => "auto".serialize(serializer), [INFO] [stderr] 169 | LevenshteinDistance(dist) => dist.serialize(serializer), [INFO] [stderr] 170 | Proportionate(p) => p.serialize(serializer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / match self { [INFO] [stderr] 217 | | &ScoreMode::Multiply => "multiply".serialize(serializer), [INFO] [stderr] 218 | | &ScoreMode::Sum => "sum".serialize(serializer), [INFO] [stderr] 219 | | &ScoreMode::Avg => "avg".serialize(serializer), [INFO] [stderr] ... | [INFO] [stderr] 222 | | &ScoreMode::Min => "min".serialize(serializer) [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 216 | match *self { [INFO] [stderr] 217 | ScoreMode::Multiply => "multiply".serialize(serializer), [INFO] [stderr] 218 | ScoreMode::Sum => "sum".serialize(serializer), [INFO] [stderr] 219 | ScoreMode::Avg => "avg".serialize(serializer), [INFO] [stderr] 220 | ScoreMode::First => "first".serialize(serializer), [INFO] [stderr] 221 | ScoreMode::Max => "max".serialize(serializer), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/query/mod.rs:313:9 [INFO] [stderr] | [INFO] [stderr] 313 | / (match self { [INFO] [stderr] 314 | | // All [INFO] [stderr] 315 | | &MatchAll(ref q) => map_ser.serialize_entry("match_all", q), [INFO] [stderr] 316 | | [INFO] [stderr] ... | [INFO] [stderr] 357 | | &MoreLikeThis(ref q) => map_ser.serialize_entry("more_like_this", q) [INFO] [stderr] 358 | | })?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 313 | (match *self { [INFO] [stderr] 314 | // All [INFO] [stderr] 315 | MatchAll(ref q) => map_ser.serialize_entry("match_all", q), [INFO] [stderr] 316 | [INFO] [stderr] 317 | // Full-text [INFO] [stderr] 318 | Match(ref q) => map_ser.serialize_entry("match", q), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match self { [INFO] [stderr] 168 | | &Location::LatLon(lat, lon) => { [INFO] [stderr] 169 | | let mut d = BTreeMap::new(); [INFO] [stderr] 170 | | d.insert("lat", lat); [INFO] [stderr] ... | [INFO] [stderr] 174 | | &Location::GeoHash(ref geo_hash) => geo_hash.serialize(serializer), [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *self { [INFO] [stderr] 168 | Location::LatLon(lat, lon) => { [INFO] [stderr] 169 | let mut d = BTreeMap::new(); [INFO] [stderr] 170 | d.insert("lat", lat); [INFO] [stderr] 171 | d.insert("lon", lon); [INFO] [stderr] 172 | d.serialize(serializer) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | / match self { [INFO] [stderr] 236 | | &Corners(ref top_left, ref bottom_right) => { [INFO] [stderr] 237 | | let mut d = BTreeMap::new(); [INFO] [stderr] 238 | | d.insert("top_left", top_left); [INFO] [stderr] ... | [INFO] [stderr] 249 | | } [INFO] [stderr] 250 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 235 | match *self { [INFO] [stderr] 236 | Corners(ref top_left, ref bottom_right) => { [INFO] [stderr] 237 | let mut d = BTreeMap::new(); [INFO] [stderr] 238 | d.insert("top_left", top_left); [INFO] [stderr] 239 | d.insert("bottom_right", bottom_right); [INFO] [stderr] 240 | d.serialize(serializer) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / match self { [INFO] [stderr] 277 | | &OneOrMany::One(ref t) => t.serialize(serializer), [INFO] [stderr] 278 | | &OneOrMany::Many(ref t) => t.serialize(serializer), [INFO] [stderr] 279 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 276 | match *self { [INFO] [stderr] 277 | OneOrMany::One(ref t) => t.serialize(serializer), [INFO] [stderr] 278 | OneOrMany::Many(ref t) => t.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | / match self { [INFO] [stderr] 309 | | &DistanceType::SloppyArc => "sloppy_arc", [INFO] [stderr] 310 | | &DistanceType::Arc => "arc", [INFO] [stderr] 311 | | &DistanceType::Plane => "plane", [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 308 | match *self { [INFO] [stderr] 309 | DistanceType::SloppyArc => "sloppy_arc", [INFO] [stderr] 310 | DistanceType::Arc => "arc", [INFO] [stderr] 311 | DistanceType::Plane => "plane", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:429:12 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(match from { [INFO] [stderr] | ____________^ [INFO] [stderr] 430 | | &String(ref string) => JsonVal::String(string.clone()), [INFO] [stderr] 431 | | &Bool(b) => JsonVal::Boolean(b), [INFO] [stderr] 432 | | &Number(ref i) => JsonVal::Number(i.clone()), [INFO] [stderr] 433 | | _ => return Err(EsError::EsError(format!("Not a JsonVal: {:?}", from))), [INFO] [stderr] 434 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 429 | Ok(match *from { [INFO] [stderr] 430 | String(ref string) => JsonVal::String(string.clone()), [INFO] [stderr] 431 | Bool(b) => JsonVal::Boolean(b), [INFO] [stderr] 432 | Number(ref i) => JsonVal::Number(i.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:449:9 [INFO] [stderr] | [INFO] [stderr] 449 | / match self { [INFO] [stderr] 450 | | &JsonVal::String(ref s) => s.serialize(serializer), [INFO] [stderr] 451 | | &JsonVal::Number(ref i) => i.serialize(serializer), [INFO] [stderr] 452 | | &JsonVal::Boolean(b) => b.serialize(serializer), [INFO] [stderr] 453 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 449 | match *self { [INFO] [stderr] 450 | JsonVal::String(ref s) => s.serialize(serializer), [INFO] [stderr] 451 | JsonVal::Number(ref i) => i.serialize(serializer), [INFO] [stderr] 452 | JsonVal::Boolean(b) => b.serialize(serializer), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/units.rs:545:38 [INFO] [stderr] | [INFO] [stderr] 545 | JsonVal::Number(Number::from_f64(from as f64).unwrap()) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(from)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/units.rs:562:9 [INFO] [stderr] | [INFO] [stderr] 562 | / match from { [INFO] [stderr] 563 | | &String(ref s) => JsonVal::String(s.clone()), [INFO] [stderr] 564 | | &Number(ref f) => JsonVal::Number(f.clone()), [INFO] [stderr] 565 | | &Bool(b) => JsonVal::Boolean(b), [INFO] [stderr] 566 | | _ => panic!("Not a String, F64, I64, U64 or Boolean"), [INFO] [stderr] 567 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 562 | match *from { [INFO] [stderr] 563 | String(ref s) => JsonVal::String(s.clone()), [INFO] [stderr] 564 | Number(ref f) => JsonVal::Number(f.clone()), [INFO] [stderr] 565 | Bool(b) => JsonVal::Boolean(b), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `tests::TestDocument` [INFO] [stderr] --> src/lib.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | / pub fn new() -> TestDocument { [INFO] [stderr] 281 | | TestDocument { [INFO] [stderr] 282 | | str_field: "I am a test".to_owned(), [INFO] [stderr] 283 | | int_field: 1, [INFO] [stderr] 284 | | bool_field: true, [INFO] [stderr] 285 | | } [INFO] [stderr] 286 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 273 | #[derive(Default)] [INFO] [stderr] 274 | pub struct TestDocument { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:317:13 [INFO] [stderr] | [INFO] [stderr] 317 | for ref doc in documents { [INFO] [stderr] | ^^^^^^^ --------- help: try: `let doc = &documents;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.43s [INFO] running `"docker" "inspect" "88bc41c099b071eb5dbc9f5ab8146db6bf1739c29363ea31f0964e7e10f831cf"` [INFO] running `"docker" "rm" "-f" "88bc41c099b071eb5dbc9f5ab8146db6bf1739c29363ea31f0964e7e10f831cf"` [INFO] [stdout] 88bc41c099b071eb5dbc9f5ab8146db6bf1739c29363ea31f0964e7e10f831cf