[INFO] crate rrole 0.1.2 is already in cache [INFO] extracting crate rrole 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/rrole/0.1.2 [INFO] extracting crate rrole 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rrole/0.1.2 [INFO] validating manifest of rrole-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rrole-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rrole-0.1.2 [INFO] finished frobbing rrole-0.1.2 [INFO] frobbed toml for rrole-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/rrole/0.1.2/Cargo.toml [INFO] started frobbing rrole-0.1.2 [INFO] finished frobbing rrole-0.1.2 [INFO] frobbed toml for rrole-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rrole/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rrole-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rrole/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3fe5209a68a4517173a5b10f324eeec039a1ecb947fa3ba54c3f17c757a43a3 [INFO] running `"docker" "start" "-a" "c3fe5209a68a4517173a5b10f324eeec039a1ecb947fa3ba54c3f17c757a43a3"` [INFO] [stderr] Compiling rusoto_core v0.32.0 [INFO] [stderr] Checking rusoto_credential v0.11.0 [INFO] [stderr] Checking rusoto_sts v0.32.0 [INFO] [stderr] Checking rrole v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if args.mfa == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `args.mfa` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | io::stdin().read_line(&mut mfa_token).ok().expect("Failed to read input"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if args.mfa == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `args.mfa` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | io::stdin().read_line(&mut mfa_token).ok().expect("Failed to read input"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.10s [INFO] running `"docker" "inspect" "c3fe5209a68a4517173a5b10f324eeec039a1ecb947fa3ba54c3f17c757a43a3"` [INFO] running `"docker" "rm" "-f" "c3fe5209a68a4517173a5b10f324eeec039a1ecb947fa3ba54c3f17c757a43a3"` [INFO] [stdout] c3fe5209a68a4517173a5b10f324eeec039a1ecb947fa3ba54c3f17c757a43a3