[INFO] crate rquery 0.4.1 is already in cache [INFO] extracting crate rquery 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/rquery/0.4.1 [INFO] extracting crate rquery 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rquery/0.4.1 [INFO] validating manifest of rquery-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rquery-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rquery-0.4.1 [INFO] removed 0 missing tests [INFO] finished frobbing rquery-0.4.1 [INFO] frobbed toml for rquery-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/rquery/0.4.1/Cargo.toml [INFO] started frobbing rquery-0.4.1 [INFO] removed 0 missing tests [INFO] finished frobbing rquery-0.4.1 [INFO] frobbed toml for rquery-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rquery/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rquery-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rquery/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e143ae9e2b3da5085743a1fb96ae18d486022e7b05e2d6d55cfac1932dff0516 [INFO] running `"docker" "start" "-a" "e143ae9e2b3da5085743a1fb96ae18d486022e7b05e2d6d55cfac1932dff0516"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/document_test.rs [INFO] [stderr] * /opt/crater/workdir/tests/selector_test.rs [INFO] [stderr] * /opt/crater/workdir/tests/element_test.rs [INFO] [stderr] * /opt/crater/workdir/tests/querying_by_selectors_test.rs [INFO] [stderr] * /opt/crater/workdir/tests/xml_document_test.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking rquery v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/selector.rs:202:28 [INFO] [stderr] | [INFO] [stderr] 202 | scope: scope, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/selector.rs:203:28 [INFO] [stderr] | [INFO] [stderr] 203 | parts: parts [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/document/mod.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | attr_map: attr_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `attr_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/selector.rs:202:28 [INFO] [stderr] | [INFO] [stderr] 202 | scope: scope, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/selector.rs:203:28 [INFO] [stderr] | [INFO] [stderr] 203 | parts: parts [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `parts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/document/mod.rs:46:25 [INFO] [stderr] | [INFO] [stderr] 46 | attr_map: attr_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `attr_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return Ok(string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(string)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(selectors); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(selectors)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | return extract_valid_string(chars).map(|s| Selector::Id(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `extract_valid_string(chars).map(|s| Selector::Id(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | return Err(UnexpectedTokenError(token)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(UnexpectedTokenError(token))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | return Err(UnexpectedTokenError(' ')), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(UnexpectedTokenError(' '))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/document/mod.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | return hash_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hash_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | return Ok(iterator); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(iterator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return Ok(string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(string)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(selectors); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(selectors)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | return extract_valid_string(chars).map(|s| Selector::Id(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `extract_valid_string(chars).map(|s| Selector::Id(s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:138:17 [INFO] [stderr] | [INFO] [stderr] 138 | return Err(UnexpectedTokenError(token)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(UnexpectedTokenError(token))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/selector.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | return Err(UnexpectedTokenError(' ')), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(UnexpectedTokenError(' '))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/document/mod.rs:39:29 [INFO] [stderr] | [INFO] [stderr] 39 | return hash_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hash_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | return Ok(iterator); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(iterator)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/selector.rs:129:41 [INFO] [stderr] | [INFO] [stderr] 129 | extract_valid_string(chars).map(|s| Selector::TagName(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Selector::TagName` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/selector.rs:135:56 [INFO] [stderr] | [INFO] [stderr] 135 | return extract_valid_string(chars).map(|s| Selector::Id(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Selector::Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/selector.rs:189:50 [INFO] [stderr] | [INFO] [stderr] 189 | let normalized_selector = selector.split(">") [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/selector.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | inner_iter: normalized_selector.split_whitespace().into_iter().map(|s| s.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `normalized_selector.split_whitespace()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/document/mod.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | UnableToOpenFile(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | #![warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for a variant [INFO] [stderr] --> src/document/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | ParseError(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/document/mod.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | next_node_index = next_node_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_node_index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | .map_err(|err| SelectError::ParseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SelectError::ParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:110:54 [INFO] [stderr] | [INFO] [stderr] 110 | let matching_children_iter = children_iter [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 111 | | .filter_map(move |child| { [INFO] [stderr] 112 | | if child.matches(&compound_selector) { [INFO] [stderr] 113 | | Some(child) [INFO] [stderr] ... | [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | }); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | / match part { [INFO] [stderr] 189 | | &Selector::TagName(ref name) => [INFO] [stderr] 190 | | self.tag_name() == name, [INFO] [stderr] 191 | | [INFO] [stderr] ... | [INFO] [stderr] 196 | | self.attr(attr) == Some(value), [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | match *part { [INFO] [stderr] 189 | Selector::TagName(ref name) => [INFO] [stderr] 190 | self.tag_name() == name, [INFO] [stderr] 191 | [INFO] [stderr] 192 | Selector::Id(ref id) => [INFO] [stderr] 193 | self.attr("id") == Some(id), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/selector.rs:129:41 [INFO] [stderr] | [INFO] [stderr] 129 | extract_valid_string(chars).map(|s| Selector::TagName(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Selector::TagName` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/selector.rs:135:56 [INFO] [stderr] | [INFO] [stderr] 135 | return extract_valid_string(chars).map(|s| Selector::Id(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Selector::Id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/selector.rs:189:50 [INFO] [stderr] | [INFO] [stderr] 189 | let normalized_selector = selector.split(">") [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/selector.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | inner_iter: normalized_selector.split_whitespace().into_iter().map(|s| s.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `normalized_selector.split_whitespace()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/document/mod.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | next_node_index = next_node_index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_node_index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:94:22 [INFO] [stderr] | [INFO] [stderr] 94 | .map_err(|err| SelectError::ParseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `SelectError::ParseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/lib.rs:110:54 [INFO] [stderr] | [INFO] [stderr] 110 | let matching_children_iter = children_iter [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 111 | | .filter_map(move |child| { [INFO] [stderr] 112 | | if child.matches(&compound_selector) { [INFO] [stderr] 113 | | Some(child) [INFO] [stderr] ... | [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | }); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | / match part { [INFO] [stderr] 189 | | &Selector::TagName(ref name) => [INFO] [stderr] 190 | | self.tag_name() == name, [INFO] [stderr] 191 | | [INFO] [stderr] ... | [INFO] [stderr] 196 | | self.attr(attr) == Some(value), [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | match *part { [INFO] [stderr] 189 | Selector::TagName(ref name) => [INFO] [stderr] 190 | self.tag_name() == name, [INFO] [stderr] 191 | [INFO] [stderr] 192 | Selector::Id(ref id) => [INFO] [stderr] 193 | self.attr("id") == Some(id), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/selector_test.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / if let &Selector::TagName(ref string) = compound_selector.parts.last().unwrap() { [INFO] [stderr] 7 | | assert_eq!(string, tag_name) [INFO] [stderr] 8 | | } else { [INFO] [stderr] 9 | | panic!(format!("Did not match tag name \"{}\"", tag_name)); [INFO] [stderr] 10 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 6 | if let Selector::TagName(ref string) = *compound_selector.parts.last().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "e143ae9e2b3da5085743a1fb96ae18d486022e7b05e2d6d55cfac1932dff0516"` [INFO] running `"docker" "rm" "-f" "e143ae9e2b3da5085743a1fb96ae18d486022e7b05e2d6d55cfac1932dff0516"` [INFO] [stdout] e143ae9e2b3da5085743a1fb96ae18d486022e7b05e2d6d55cfac1932dff0516