[INFO] crate rpg 0.0.2 is already in cache [INFO] extracting crate rpg 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/rpg/0.0.2 [INFO] extracting crate rpg 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rpg/0.0.2 [INFO] validating manifest of rpg-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rpg-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rpg-0.0.2 [INFO] finished frobbing rpg-0.0.2 [INFO] frobbed toml for rpg-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/rpg/0.0.2/Cargo.toml [INFO] started frobbing rpg-0.0.2 [INFO] finished frobbing rpg-0.0.2 [INFO] frobbed toml for rpg-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rpg/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rpg-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rpg/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a955ba5e88af671dbc1c5080b00976523051e0f625d95d4a83feb5cd8a43c07 [INFO] running `"docker" "start" "-a" "3a955ba5e88af671dbc1c5080b00976523051e0f625d95d4a83feb5cd8a43c07"` [INFO] [stderr] Compiling names v0.11.0 [INFO] [stderr] Checking rpg v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/inventory.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | item_type: item_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | influence: influence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `influence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | stack_size: stack_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stack_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | rarity: rarity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rarity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | attribute: attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | amount: amount, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/two_dimensional.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/inventory.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | max_size: max_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `max_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | item_type: item_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `item_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | influence: influence, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `influence` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | stack_size: stack_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stack_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item_generator.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | rarity: rarity, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rarity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | attribute: attribute, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attribute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | amount: amount, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/world/two_dimensional.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | field_type: field_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/behaviour/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod behaviour; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/inventory.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | / if slot.item == new_item { [INFO] [stderr] 31 | | if slot.item.stack_size > slot.amount { [INFO] [stderr] 32 | | slot.amount += 1; [INFO] [stderr] 33 | | return Ok(()); [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | if slot.item == new_item && slot.item.stack_size > slot.amount { [INFO] [stderr] 31 | slot.amount += 1; [INFO] [stderr] 32 | return Ok(()); [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world/two_dimensional.rs:174:23 [INFO] [stderr] | [INFO] [stderr] 174 | Err(_) => return Err(file_name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(file_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/behaviour/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod behaviour; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/inventory.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | / if slot.item == new_item { [INFO] [stderr] 31 | | if slot.item.stack_size > slot.amount { [INFO] [stderr] 32 | | slot.amount += 1; [INFO] [stderr] 33 | | return Ok(()); [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | if slot.item == new_item && slot.item.stack_size > slot.amount { [INFO] [stderr] 31 | slot.amount += 1; [INFO] [stderr] 32 | return Ok(()); [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/world/two_dimensional.rs:174:23 [INFO] [stderr] | [INFO] [stderr] 174 | Err(_) => return Err(file_name), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(file_name)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/character.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `health` [INFO] [stderr] --> src/character.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | health: Health, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `inventory` [INFO] [stderr] --> src/character.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | inventory: Inventory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/entity.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/character.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | *self.attributes.get(attribute).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.attributes[attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/entity.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | for ref behaviour in &self.behaviour { [INFO] [stderr] | ^^^^^^^^^^^^^ --------------- help: try: `let behaviour = &&self.behaviour;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/item_generator.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | data_influence: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `item_generator::ItemGenerator` [INFO] [stderr] --> src/item_generator.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> ItemGenerator { [INFO] [stderr] 21 | | ItemGenerator { [INFO] [stderr] 22 | | data_name: None, [INFO] [stderr] 23 | | data_item_type: None, [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/item_generator.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|string| String::from(string)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/item_generator.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | .map(|string| String::from(string)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/item_generator.rs:205:14 [INFO] [stderr] | [INFO] [stderr] 205 | .map(|string| String::from(string)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/item.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | 751...917 => ItemRarity::Uncommon, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/item.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | 873...979 => ItemRarity::Epic, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world/two_dimensional.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / match f.write_all(campagne.as_bytes()) { [INFO] [stderr] 155 | | Err(_) => {} [INFO] [stderr] 156 | | Ok(_) => {} [INFO] [stderr] 157 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(_) = f.write_all(campagne.as_bytes()) {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world/two_dimensional.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / match f.read_to_string(&mut s) { [INFO] [stderr] 169 | | Err(_) => return Err(file_name), [INFO] [stderr] 170 | | Ok(_) => {} [INFO] [stderr] 171 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(_) = f.read_to_string(&mut s) { return Err(file_name) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event` [INFO] [stderr] --> src/behaviour/custom.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let custom = Custom::new(|event| Event::Nothing); [INFO] [stderr] | ^^^^^ help: consider using `_event` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `event` [INFO] [stderr] --> src/entity.rs:56:35 [INFO] [stderr] | [INFO] [stderr] 56 | let custom = Custom::new(|event| Event::Nothing); [INFO] [stderr] | ^^^^^ help: consider using `_event` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `field` is never read [INFO] [stderr] --> src/world/two_dimensional.rs:221:9 [INFO] [stderr] | [INFO] [stderr] 221 | field = field.contained_entity_id(23).height(2); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/character.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `health` [INFO] [stderr] --> src/character.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | health: Health, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `inventory` [INFO] [stderr] --> src/character.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | inventory: Inventory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/entity.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/character.rs:89:10 [INFO] [stderr] | [INFO] [stderr] 89 | *self.attributes.get(attribute).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.attributes[attribute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/entity.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | for ref behaviour in &self.behaviour { [INFO] [stderr] | ^^^^^^^^^^^^^ --------------- help: try: `let behaviour = &&self.behaviour;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/inventory.rs:69:20 [INFO] [stderr] | [INFO] [stderr] 69 | if let Err(_) = inv_1.add_item(random_item) { [INFO] [stderr] | _____________- ^^^^^^ [INFO] [stderr] 70 | | assert!(inv_1.is_full()); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________- help: try this: `if inv_1.add_item(random_item).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/item_generator.rs:13:21 [INFO] [stderr] | [INFO] [stderr] 13 | data_influence: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `item_generator::ItemGenerator` [INFO] [stderr] --> src/item_generator.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / pub fn new() -> ItemGenerator { [INFO] [stderr] 21 | | ItemGenerator { [INFO] [stderr] 22 | | data_name: None, [INFO] [stderr] 23 | | data_item_type: None, [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/item_generator.rs:150:14 [INFO] [stderr] | [INFO] [stderr] 150 | .map(|string| String::from(string)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/item_generator.rs:158:14 [INFO] [stderr] | [INFO] [stderr] 158 | .map(|string| String::from(string)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/item_generator.rs:205:14 [INFO] [stderr] | [INFO] [stderr] 205 | .map(|string| String::from(string)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/item.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | 751...917 => ItemRarity::Uncommon, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/item.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | 873...979 => ItemRarity::Epic, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world/two_dimensional.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / match f.write_all(campagne.as_bytes()) { [INFO] [stderr] 155 | | Err(_) => {} [INFO] [stderr] 156 | | Ok(_) => {} [INFO] [stderr] 157 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(_) = f.write_all(campagne.as_bytes()) {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/world/two_dimensional.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / match f.read_to_string(&mut s) { [INFO] [stderr] 169 | | Err(_) => return Err(file_name), [INFO] [stderr] 170 | | Ok(_) => {} [INFO] [stderr] 171 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(_) = f.read_to_string(&mut s) { return Err(file_name) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.70s [INFO] running `"docker" "inspect" "3a955ba5e88af671dbc1c5080b00976523051e0f625d95d4a83feb5cd8a43c07"` [INFO] running `"docker" "rm" "-f" "3a955ba5e88af671dbc1c5080b00976523051e0f625d95d4a83feb5cd8a43c07"` [INFO] [stdout] 3a955ba5e88af671dbc1c5080b00976523051e0f625d95d4a83feb5cd8a43c07