[INFO] crate rpf 0.1.6 is already in cache [INFO] extracting crate rpf 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/rpf/0.1.6 [INFO] extracting crate rpf 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rpf/0.1.6 [INFO] validating manifest of rpf-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rpf-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rpf-0.1.6 [INFO] finished frobbing rpf-0.1.6 [INFO] frobbed toml for rpf-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/rpf/0.1.6/Cargo.toml [INFO] started frobbing rpf-0.1.6 [INFO] finished frobbing rpf-0.1.6 [INFO] frobbed toml for rpf-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rpf/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rpf-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rpf/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f5da496a0b1aa7c55e62e27caa6bcb8bc593acc55bd1d98a17332568214f047 [INFO] running `"docker" "start" "-a" "1f5da496a0b1aa7c55e62e27caa6bcb8bc593acc55bd1d98a17332568214f047"` [INFO] [stderr] Checking ansi_term v0.6.3 [INFO] [stderr] Checking rpf v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/utils/prog.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/utils/prog.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/pathmod.rs:88:41 [INFO] [stderr] | [INFO] [stderr] 88 | if file_name.starts_with(".") { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/pathmod.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | else { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/pathmod.rs:129:41 [INFO] [stderr] | [INFO] [stderr] 129 | if file_name.starts_with(".") { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/pathmod.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | else { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ANSIString` [INFO] [stderr] --> src/utils/styled.rs:8:30 [INFO] [stderr] | [INFO] [stderr] 8 | use self::ansi_term::{Colour,ANSIString}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Red` [INFO] [stderr] --> src/utils/styled.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | use self::ansi_term::Colour::{Red}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/pathmod.rs:88:41 [INFO] [stderr] | [INFO] [stderr] 88 | if file_name.starts_with(".") { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/pathmod.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | else { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/pathmod.rs:129:41 [INFO] [stderr] | [INFO] [stderr] 129 | if file_name.starts_with(".") { return true; } [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils/pathmod.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | else { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ANSIString` [INFO] [stderr] --> src/utils/styled.rs:8:30 [INFO] [stderr] | [INFO] [stderr] 8 | use self::ansi_term::{Colour,ANSIString}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Red` [INFO] [stderr] --> src/utils/styled.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | use self::ansi_term::Colour::{Red}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/utils/prog.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | &self.exit(ExitStatus::ArgError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.exit(ExitStatus::ArgError);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/utils/pathmod.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / if file_name.starts_with(".") { return true; } [INFO] [stderr] 89 | | else { return false; } [INFO] [stderr] | |______________________________^ help: you can reduce it to: `return file_name.starts_with(".")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/pathmod.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | if file_name.starts_with(".") { return true; } [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/utils/pathmod.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / if file_name.starts_with(".") { return true; } [INFO] [stderr] 130 | | else { return false; } [INFO] [stderr] | |______________________________^ help: you can reduce it to: `return file_name.starts_with(".")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/pathmod.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | if file_name.starts_with(".") { return true; } [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/utils/status.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | &self.exit(status); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.exit(status);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/utils/status.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | &self.exit(ExitStatus::Error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.exit(ExitStatus::Error);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/utils/as_path.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!("/etc/test/dir".to_string().as_path().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(&(*"/etc/test/dir".to_string().as_path()).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(&std::path::Path::clone("/etc/test/dir".to_string().as_path()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/utils/as_path.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | assert_eq!("/etc/test/dir".as_path().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 68 | assert_eq!(&(*"/etc/test/dir".as_path()).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 68 | assert_eq!(&std::path::Path::clone("/etc/test/dir".as_path()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/utils/prog.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | &self.exit(ExitStatus::ArgError); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.exit(ExitStatus::ArgError);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/utils/pathmod.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / if file_name.starts_with(".") { return true; } [INFO] [stderr] 89 | | else { return false; } [INFO] [stderr] | |______________________________^ help: you can reduce it to: `return file_name.starts_with(".")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/pathmod.rs:88:34 [INFO] [stderr] | [INFO] [stderr] 88 | if file_name.starts_with(".") { return true; } [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/utils/pathmod.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | / if file_name.starts_with(".") { return true; } [INFO] [stderr] 130 | | else { return false; } [INFO] [stderr] | |______________________________^ help: you can reduce it to: `return file_name.starts_with(".")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils/pathmod.rs:129:34 [INFO] [stderr] | [INFO] [stderr] 129 | if file_name.starts_with(".") { return true; } [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/utils/status.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | &self.exit(status); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.exit(status);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/utils/status.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | &self.exit(ExitStatus::Error); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.exit(ExitStatus::Error);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rpf`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1f5da496a0b1aa7c55e62e27caa6bcb8bc593acc55bd1d98a17332568214f047"` [INFO] running `"docker" "rm" "-f" "1f5da496a0b1aa7c55e62e27caa6bcb8bc593acc55bd1d98a17332568214f047"` [INFO] [stdout] 1f5da496a0b1aa7c55e62e27caa6bcb8bc593acc55bd1d98a17332568214f047