[INFO] crate roxmltree 0.3.0 is already in cache [INFO] extracting crate roxmltree 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/roxmltree/0.3.0 [INFO] extracting crate roxmltree 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/roxmltree/0.3.0 [INFO] validating manifest of roxmltree-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of roxmltree-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing roxmltree-0.3.0 [INFO] finished frobbing roxmltree-0.3.0 [INFO] frobbed toml for roxmltree-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/roxmltree/0.3.0/Cargo.toml [INFO] started frobbing roxmltree-0.3.0 [INFO] finished frobbing roxmltree-0.3.0 [INFO] frobbed toml for roxmltree-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/roxmltree/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting roxmltree-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/roxmltree/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fba41f2b570f1cafaf4a0d4e11754e8d9af1011b1e26c16ffe594988b097aea [INFO] running `"docker" "start" "-a" "6fba41f2b570f1cafaf4a0d4e11754e8d9af1011b1e26c16ffe594988b097aea"` [INFO] [stderr] Checking xmlparser v0.7.0 [INFO] [stderr] Compiling rustc-test v0.3.0 [INFO] [stderr] Checking roxmltree v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:145:26 [INFO] [stderr] | [INFO] [stderr] 145 | for _ in 0..$depth { write!($f, " ")?; } [INFO] [stderr] | ^ help: use: `0..=depth` [INFO] [stderr] ... [INFO] [stderr] 159 | writeln_indented!(depth + 1, f, "{:?}", v); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:16:45 [INFO] [stderr] | [INFO] [stderr] 16 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> tests/ast.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | / fn print_children(parent: Node, depth: usize, s: &mut String) -> Result<(), fmt::Error> { [INFO] [stderr] 118 | | for child in parent.children() { [INFO] [stderr] 119 | | match child.node_type() { [INFO] [stderr] 120 | | NodeType::Element => { [INFO] [stderr] ... | [INFO] [stderr] 200 | | Ok(()) [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:145:26 [INFO] [stderr] | [INFO] [stderr] 145 | for _ in 0..$depth { write!($f, " ")?; } [INFO] [stderr] | ^ help: use: `0..=depth` [INFO] [stderr] ... [INFO] [stderr] 159 | writeln_indented!(depth + 1, f, "{:?}", v); [INFO] [stderr] | ------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.19s [INFO] running `"docker" "inspect" "6fba41f2b570f1cafaf4a0d4e11754e8d9af1011b1e26c16ffe594988b097aea"` [INFO] running `"docker" "rm" "-f" "6fba41f2b570f1cafaf4a0d4e11754e8d9af1011b1e26c16ffe594988b097aea"` [INFO] [stdout] 6fba41f2b570f1cafaf4a0d4e11754e8d9af1011b1e26c16ffe594988b097aea