[INFO] crate rox 0.1.6 is already in cache [INFO] extracting crate rox 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/rox/0.1.6 [INFO] extracting crate rox 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rox/0.1.6 [INFO] validating manifest of rox-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rox-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rox-0.1.6 [INFO] finished frobbing rox-0.1.6 [INFO] frobbed toml for rox-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/rox/0.1.6/Cargo.toml [INFO] started frobbing rox-0.1.6 [INFO] finished frobbing rox-0.1.6 [INFO] frobbed toml for rox-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rox/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rox-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rox/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc4f2b94b4f0629002754e31ae6f90a3873cd831020d9f1b27b5af0cb3a83157 [INFO] running `"docker" "start" "-a" "fc4f2b94b4f0629002754e31ae6f90a3873cd831020d9f1b27b5af0cb3a83157"` [INFO] [stderr] Compiling gmp-mpfr-sys v1.1.10 [INFO] [stderr] Checking rugint v0.2.2 [INFO] [stderr] Checking rugrat v0.2.2 [INFO] [stderr] Checking rugflo v0.2.2 [INFO] [stderr] Checking rox v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:864:16 [INFO] [stderr] | [INFO] [stderr] 864 | sources: sources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sources` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:865:16 [INFO] [stderr] | [INFO] [stderr] 865 | sel: sel, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:866:16 [INFO] [stderr] | [INFO] [stderr] 866 | sel_mask: sel_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sel_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:867:16 [INFO] [stderr] | [INFO] [stderr] 867 | sel_weight: sel_weight, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sel_weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:868:16 [INFO] [stderr] | [INFO] [stderr] 868 | remaining: remaining, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | SourceSpans { index: 0, set: set } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:162:23 [INFO] [stderr] | [INFO] [stderr] 162 | cum_len: cum_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cum_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:163:23 [INFO] [stderr] | [INFO] [stderr] 163 | filename_cum_len: filename_cum_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filename_cum_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:674:24 [INFO] [stderr] | [INFO] [stderr] 674 | Item::ErrMessage { message: message }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:700:43 [INFO] [stderr] | [INFO] [stderr] 700 | let field_i = Item::FieldDefinition { ident: ident }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:730:9 [INFO] [stderr] | [INFO] [stderr] 730 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:766:9 [INFO] [stderr] | [INFO] [stderr] 766 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:767:9 [INFO] [stderr] | [INFO] [stderr] 767 | scope: scope, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:820:26 [INFO] [stderr] | [INFO] [stderr] 820 | Item::UnsignedType { size: size }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:834:24 [INFO] [stderr] | [INFO] [stderr] 834 | Item::SignedType { size: size }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:869:23 [INFO] [stderr] | [INFO] [stderr] 869 | Item::Intrinsic { ident: ident }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1014:14 [INFO] [stderr] | [INFO] [stderr] 1014 | init_reset: init_reset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_reset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1015:14 [INFO] [stderr] | [INFO] [stderr] 1015 | event_trigger_val: event_trigger_val, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_trigger_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1252:19 [INFO] [stderr] | [INFO] [stderr] 1252 | Item::Ident { ident: ident }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1269:22 [INFO] [stderr] | [INFO] [stderr] 1269 | Item::OutIdent { ident: ident }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1296:27 [INFO] [stderr] | [INFO] [stderr] 1296 | Item::ResolvedIdent { def: def }.put_in(tree) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `def` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1312:23 [INFO] [stderr] | [INFO] [stderr] 1312 | Item::Reference { referent: referent }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `referent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1431:25 [INFO] [stderr] | [INFO] [stderr] 1431 | Item::RationalVal { val: val }.put_in(tree) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1445:22 [INFO] [stderr] | [INFO] [stderr] 1445 | Item::FloatVal { val: val }.put_in(tree) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1465:9 [INFO] [stderr] | [INFO] [stderr] 1465 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1466:9 [INFO] [stderr] | [INFO] [stderr] 1466 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1543:41 [INFO] [stderr] | [INFO] [stderr] 1543 | let expr_i = Item::ExprRelational { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1580:38 [INFO] [stderr] | [INFO] [stderr] 1580 | let expr_i = Item::ExprBitwise { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1615:36 [INFO] [stderr] | [INFO] [stderr] 1615 | let expr_i = Item::ExprShift { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1650:39 [INFO] [stderr] | [INFO] [stderr] 1650 | let expr_i = Item::ExprAddition { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1715:45 [INFO] [stderr] | [INFO] [stderr] 1715 | let expr_i = Item::ExprMultiplication { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1796:36 [INFO] [stderr] | [INFO] [stderr] 1796 | let expr_i = Item::ExprUnary { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:2085:38 [INFO] [stderr] | [INFO] [stderr] 2085 | let range_i = Item::RangeSized { is_minus: is_minus }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_minus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:2117:9 [INFO] [stderr] | [INFO] [stderr] 2117 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:2118:9 [INFO] [stderr] | [INFO] [stderr] 2118 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | signed: signed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `signed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:141:12 [INFO] [stderr] | [INFO] [stderr] 141 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | req_i: req_i, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `req_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | output_ident: output_ident, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:237:12 [INFO] [stderr] | [INFO] [stderr] 237 | req_ty: req_ty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `req_ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:238:12 [INFO] [stderr] | [INFO] [stderr] 238 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:412:9 [INFO] [stderr] | [INFO] [stderr] 412 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:416:20 [INFO] [stderr] | [INFO] [stderr] 416 | Ok(SizedExpr { ty: ty, expr: expr }) [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:416:28 [INFO] [stderr] | [INFO] [stderr] 416 | Ok(SizedExpr { ty: ty, expr: expr }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | let _ = write!(data.statements, [INFO] [stderr] | _____________^ [INFO] [stderr] 471 | | "\"1\" when {} {} {} else \"0\";\n", [INFO] [stderr] 472 | | lhs.expr.0, [INFO] [stderr] 473 | | op, [INFO] [stderr] 474 | | rhs.expr.0); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:531:17 [INFO] [stderr] | [INFO] [stderr] 531 | let _ = write!(&mut data.decls, [INFO] [stderr] | _________________^ [INFO] [stderr] 532 | | "\tconstant {}: {} := {};\n", [INFO] [stderr] 533 | | name, [INFO] [stderr] 534 | | ty, [INFO] [stderr] 535 | | expr); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:537:17 [INFO] [stderr] | [INFO] [stderr] 537 | let _ = write!(&mut data.decls, "\tsignal {}: {};\n", name, ty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:651:53 [INFO] [stderr] | [INFO] [stderr] 651 | return Ok(Castable::SizedType { ty: ty, val_i: op }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:660:41 [INFO] [stderr] | [INFO] [stderr] 660 | return Ok(Castable::Input { ty: ty, index: op }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:665:49 [INFO] [stderr] | [INFO] [stderr] 665 | return Ok(Castable::SizedType { ty: ty, val_i: val }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:670:35 [INFO] [stderr] | [INFO] [stderr] 670 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:671:35 [INFO] [stderr] | [INFO] [stderr] 671 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:722:17 [INFO] [stderr] | [INFO] [stderr] 722 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:809:21 [INFO] [stderr] | [INFO] [stderr] 809 | let _ = write!(data.statements, "1)) & {}(0);\n", expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:925:5 [INFO] [stderr] | [INFO] [stderr] 925 | write!(w, "begin -- architecture rox\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:929:5 [INFO] [stderr] | [INFO] [stderr] 929 | write!(w, "end architecture rox;\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:950:13 [INFO] [stderr] | [INFO] [stderr] 950 | let _ = write!(dst, "\t{} <= {};\n", signal, expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:994:18 [INFO] [stderr] | [INFO] [stderr] 994 | 1 => write!(dst, "\t{}(0) <= {};\n", signal, port), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:996:17 [INFO] [stderr] | [INFO] [stderr] 996 | write!(dst, "\t{} <= {}({});\n", signal, self.vhdl_type(), port) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1003:18 [INFO] [stderr] | [INFO] [stderr] 1003 | 1 => write!(dst, "\t{} <= {}(0);\n", port, signal), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1004:18 [INFO] [stderr] | [INFO] [stderr] 1004 | _ => write!(dst, "\t{} <= std_logic_vector({});\n", port, signal), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1024:21 [INFO] [stderr] | [INFO] [stderr] 1024 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1025 | | "\tconstant {}: {}(0 downto 1) := \"\";\n", [INFO] [stderr] 1026 | | name, [INFO] [stderr] 1027 | | self.vhdl_type()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1029:21 [INFO] [stderr] | [INFO] [stderr] 1029 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1030 | | "\tconstant {}: {}({} downto 0) := {};\n", [INFO] [stderr] 1031 | | name, [INFO] [stderr] 1032 | | self.vhdl_type(), [INFO] [stderr] 1033 | | self.size - 1, [INFO] [stderr] 1034 | | val); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1040:21 [INFO] [stderr] | [INFO] [stderr] 1040 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1041 | | "\tsignal {}: {}(0 downto 1);\n", [INFO] [stderr] 1042 | | name, [INFO] [stderr] 1043 | | self.vhdl_type()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1045:21 [INFO] [stderr] | [INFO] [stderr] 1045 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1046 | | "\tsignal {}: {}({} downto 0);\n", [INFO] [stderr] 1047 | | name, [INFO] [stderr] 1048 | | self.vhdl_type(), [INFO] [stderr] 1049 | | self.size - 1); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1057:21 [INFO] [stderr] | [INFO] [stderr] 1057 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1058 | | "\tsignal {}: {}(0 downto 1) := \"\";\n", [INFO] [stderr] 1059 | | name, [INFO] [stderr] 1060 | | self.vhdl_type()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1062:21 [INFO] [stderr] | [INFO] [stderr] 1062 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1063 | | "\tsignal {}: {}({} downto 0) := {};\n", [INFO] [stderr] 1064 | | name, [INFO] [stderr] 1065 | | self.vhdl_type(), [INFO] [stderr] 1066 | | self.size - 1, [INFO] [stderr] 1067 | | constant_name); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:1079:13 [INFO] [stderr] | [INFO] [stderr] 1079 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:1080:13 [INFO] [stderr] | [INFO] [stderr] 1080 | req_i: req_i, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `req_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | root_i: root_i, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `root_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/package.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | write!(fmt, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | val => Some(Index { val: val }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:281:22 [INFO] [stderr] | [INFO] [stderr] 281 | relation: relation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `relation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tree.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | write!(fmt, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | sources: sources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:864:16 [INFO] [stderr] | [INFO] [stderr] 864 | sources: sources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sources` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:865:16 [INFO] [stderr] | [INFO] [stderr] 865 | sel: sel, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:866:16 [INFO] [stderr] | [INFO] [stderr] 866 | sel_mask: sel_mask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sel_mask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:867:16 [INFO] [stderr] | [INFO] [stderr] 867 | sel_weight: sel_weight, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sel_weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/eval.rs:868:16 [INFO] [stderr] | [INFO] [stderr] 868 | remaining: remaining, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | cause: cause, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | SourceSpans { index: 0, set: set } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:162:23 [INFO] [stderr] | [INFO] [stderr] 162 | cum_len: cum_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cum_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:163:23 [INFO] [stderr] | [INFO] [stderr] 163 | filename_cum_len: filename_cum_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filename_cum_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:674:24 [INFO] [stderr] | [INFO] [stderr] 674 | Item::ErrMessage { message: message }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:700:43 [INFO] [stderr] | [INFO] [stderr] 700 | let field_i = Item::FieldDefinition { ident: ident }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:730:9 [INFO] [stderr] | [INFO] [stderr] 730 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:766:9 [INFO] [stderr] | [INFO] [stderr] 766 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:767:9 [INFO] [stderr] | [INFO] [stderr] 767 | scope: scope, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scope` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:820:26 [INFO] [stderr] | [INFO] [stderr] 820 | Item::UnsignedType { size: size }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:834:24 [INFO] [stderr] | [INFO] [stderr] 834 | Item::SignedType { size: size }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:869:23 [INFO] [stderr] | [INFO] [stderr] 869 | Item::Intrinsic { ident: ident }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1014:14 [INFO] [stderr] | [INFO] [stderr] 1014 | init_reset: init_reset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `init_reset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1015:14 [INFO] [stderr] | [INFO] [stderr] 1015 | event_trigger_val: event_trigger_val, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_trigger_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1252:19 [INFO] [stderr] | [INFO] [stderr] 1252 | Item::Ident { ident: ident }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1269:22 [INFO] [stderr] | [INFO] [stderr] 1269 | Item::OutIdent { ident: ident }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1296:27 [INFO] [stderr] | [INFO] [stderr] 1296 | Item::ResolvedIdent { def: def }.put_in(tree) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `def` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1312:23 [INFO] [stderr] | [INFO] [stderr] 1312 | Item::Reference { referent: referent }.put_in(tree) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `referent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1431:25 [INFO] [stderr] | [INFO] [stderr] 1431 | Item::RationalVal { val: val }.put_in(tree) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1445:22 [INFO] [stderr] | [INFO] [stderr] 1445 | Item::FloatVal { val: val }.put_in(tree) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1465:9 [INFO] [stderr] | [INFO] [stderr] 1465 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1466:9 [INFO] [stderr] | [INFO] [stderr] 1466 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1543:41 [INFO] [stderr] | [INFO] [stderr] 1543 | let expr_i = Item::ExprRelational { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1580:38 [INFO] [stderr] | [INFO] [stderr] 1580 | let expr_i = Item::ExprBitwise { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1615:36 [INFO] [stderr] | [INFO] [stderr] 1615 | let expr_i = Item::ExprShift { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1650:39 [INFO] [stderr] | [INFO] [stderr] 1650 | let expr_i = Item::ExprAddition { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1715:45 [INFO] [stderr] | [INFO] [stderr] 1715 | let expr_i = Item::ExprMultiplication { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:1796:36 [INFO] [stderr] | [INFO] [stderr] 1796 | let expr_i = Item::ExprUnary { kind: kind }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:2085:38 [INFO] [stderr] | [INFO] [stderr] 2085 | let range_i = Item::RangeSized { is_minus: is_minus }.put_in(tree); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_minus` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:2117:9 [INFO] [stderr] | [INFO] [stderr] 2117 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:2118:9 [INFO] [stderr] | [INFO] [stderr] 2118 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | ident: ident, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | signed: signed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `signed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:141:12 [INFO] [stderr] | [INFO] [stderr] 141 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | req_i: req_i, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `req_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | output_ident: output_ident, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:237:12 [INFO] [stderr] | [INFO] [stderr] 237 | req_ty: req_ty, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `req_ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:238:12 [INFO] [stderr] | [INFO] [stderr] 238 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:412:9 [INFO] [stderr] | [INFO] [stderr] 412 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:416:20 [INFO] [stderr] | [INFO] [stderr] 416 | Ok(SizedExpr { ty: ty, expr: expr }) [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:416:28 [INFO] [stderr] | [INFO] [stderr] 416 | Ok(SizedExpr { ty: ty, expr: expr }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `expr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | let _ = write!(data.statements, [INFO] [stderr] | _____________^ [INFO] [stderr] 471 | | "\"1\" when {} {} {} else \"0\";\n", [INFO] [stderr] 472 | | lhs.expr.0, [INFO] [stderr] 473 | | op, [INFO] [stderr] 474 | | rhs.expr.0); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:531:17 [INFO] [stderr] | [INFO] [stderr] 531 | let _ = write!(&mut data.decls, [INFO] [stderr] | _________________^ [INFO] [stderr] 532 | | "\tconstant {}: {} := {};\n", [INFO] [stderr] 533 | | name, [INFO] [stderr] 534 | | ty, [INFO] [stderr] 535 | | expr); [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:537:17 [INFO] [stderr] | [INFO] [stderr] 537 | let _ = write!(&mut data.decls, "\tsignal {}: {};\n", name, ty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:651:53 [INFO] [stderr] | [INFO] [stderr] 651 | return Ok(Castable::SizedType { ty: ty, val_i: op }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:660:41 [INFO] [stderr] | [INFO] [stderr] 660 | return Ok(Castable::Input { ty: ty, index: op }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:665:49 [INFO] [stderr] | [INFO] [stderr] 665 | return Ok(Castable::SizedType { ty: ty, val_i: val }); [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:670:35 [INFO] [stderr] | [INFO] [stderr] 670 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:671:35 [INFO] [stderr] | [INFO] [stderr] 671 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:722:17 [INFO] [stderr] | [INFO] [stderr] 722 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:809:21 [INFO] [stderr] | [INFO] [stderr] 809 | let _ = write!(data.statements, "1)) & {}(0);\n", expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:925:5 [INFO] [stderr] | [INFO] [stderr] 925 | write!(w, "begin -- architecture rox\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:929:5 [INFO] [stderr] | [INFO] [stderr] 929 | write!(w, "end architecture rox;\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:950:13 [INFO] [stderr] | [INFO] [stderr] 950 | let _ = write!(dst, "\t{} <= {};\n", signal, expr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:994:18 [INFO] [stderr] | [INFO] [stderr] 994 | 1 => write!(dst, "\t{}(0) <= {};\n", signal, port), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:996:17 [INFO] [stderr] | [INFO] [stderr] 996 | write!(dst, "\t{} <= {}({});\n", signal, self.vhdl_type(), port) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1003:18 [INFO] [stderr] | [INFO] [stderr] 1003 | 1 => write!(dst, "\t{} <= {}(0);\n", port, signal), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1004:18 [INFO] [stderr] | [INFO] [stderr] 1004 | _ => write!(dst, "\t{} <= std_logic_vector({});\n", port, signal), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1024:21 [INFO] [stderr] | [INFO] [stderr] 1024 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1025 | | "\tconstant {}: {}(0 downto 1) := \"\";\n", [INFO] [stderr] 1026 | | name, [INFO] [stderr] 1027 | | self.vhdl_type()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1029:21 [INFO] [stderr] | [INFO] [stderr] 1029 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1030 | | "\tconstant {}: {}({} downto 0) := {};\n", [INFO] [stderr] 1031 | | name, [INFO] [stderr] 1032 | | self.vhdl_type(), [INFO] [stderr] 1033 | | self.size - 1, [INFO] [stderr] 1034 | | val); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1040:21 [INFO] [stderr] | [INFO] [stderr] 1040 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1041 | | "\tsignal {}: {}(0 downto 1);\n", [INFO] [stderr] 1042 | | name, [INFO] [stderr] 1043 | | self.vhdl_type()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1045:21 [INFO] [stderr] | [INFO] [stderr] 1045 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1046 | | "\tsignal {}: {}({} downto 0);\n", [INFO] [stderr] 1047 | | name, [INFO] [stderr] 1048 | | self.vhdl_type(), [INFO] [stderr] 1049 | | self.size - 1); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1057:21 [INFO] [stderr] | [INFO] [stderr] 1057 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1058 | | "\tsignal {}: {}(0 downto 1) := \"\";\n", [INFO] [stderr] 1059 | | name, [INFO] [stderr] 1060 | | self.vhdl_type()); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/output.rs:1062:21 [INFO] [stderr] | [INFO] [stderr] 1062 | let _ = write!(dst, [INFO] [stderr] | _____________________^ [INFO] [stderr] 1063 | | "\tsignal {}: {}({} downto 0) := {};\n", [INFO] [stderr] 1064 | | name, [INFO] [stderr] 1065 | | self.vhdl_type(), [INFO] [stderr] 1066 | | self.size - 1, [INFO] [stderr] 1067 | | constant_name); [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:1079:13 [INFO] [stderr] | [INFO] [stderr] 1079 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:1080:13 [INFO] [stderr] | [INFO] [stderr] 1080 | req_i: req_i, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `req_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | tree: tree, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tree` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | root_i: root_i, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `root_i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/package.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | write!(fmt, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | val => Some(Index { val: val }), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:185:13 [INFO] [stderr] | [INFO] [stderr] 185 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:281:22 [INFO] [stderr] | [INFO] [stderr] 281 | relation: relation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `relation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tree.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | write!(fmt, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | sources: sources, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `sources` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/parse.rs:472:33 [INFO] [stderr] | [INFO] [stderr] 472 | val = val * 1000_000_000u32 + val_buf; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/parse.rs:563:49 [INFO] [stderr] | [INFO] [stderr] 563 | significand = significand * 1000_000_000_u32 + sig_buf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/parse.rs:472:33 [INFO] [stderr] | [INFO] [stderr] 472 | val = val * 1000_000_000u32 + val_buf; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/parse.rs:563:49 [INFO] [stderr] | [INFO] [stderr] 563 | significand = significand * 1000_000_000_u32 + sig_buf; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | if progress.get_bit(index.as_u32().into()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `index.as_u32()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | progress.set_bit(index.as_u32().into(), true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `index.as_u32()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:751:33 [INFO] [stderr] | [INFO] [stderr] 751 | size > 0 && val.get_bit((size - 1).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(size - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:1398:32 [INFO] [stderr] | [INFO] [stderr] 1398 | if size > 0 && val.get_bit((size - 1).into()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(size - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:1432:15 [INFO] [stderr] | [INFO] [stderr] 1432 | i.set_bit(shift.into(), true); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `shift` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | if contents_len > (u32::MAX - contents_cum_len) as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX - contents_cum_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:51:29 [INFO] [stderr] | [INFO] [stderr] 51 | if progress.get_bit(index.as_u32().into()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `index.as_u32()` [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:227:18 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn check(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:232:23 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn loc_string(&self, set: &SourceSet) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:54:26 [INFO] [stderr] | [INFO] [stderr] 54 | progress.set_bit(index.as_u32().into(), true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `index.as_u32()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:245:16 [INFO] [stderr] | [INFO] [stderr] 245 | pub fn err(&self, set: &SourceSet, message: &str) -> Error { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:336:21 [INFO] [stderr] | [INFO] [stderr] 336 | pub fn is_empty(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:340:16 [INFO] [stderr] | [INFO] [stderr] 340 | pub fn len(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rel.rs:147:40 [INFO] [stderr] | [INFO] [stderr] 147 | start = match x_mask.find_zero(end.into()) { [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rel.rs:155:37 [INFO] [stderr] | [INFO] [stderr] 155 | end = match x_mask.find_one(start.into()) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:751:33 [INFO] [stderr] | [INFO] [stderr] 751 | size > 0 && val.get_bit((size - 1).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(size - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:1398:32 [INFO] [stderr] | [INFO] [stderr] 1398 | if size > 0 && val.get_bit((size - 1).into()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(size - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/eval.rs:1432:15 [INFO] [stderr] | [INFO] [stderr] 1432 | i.set_bit(shift.into(), true); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `shift` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/node.rs:1402:18 [INFO] [stderr] | [INFO] [stderr] 1402 | mask.set_bit(size.into(), true); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/node.rs:1423:18 [INFO] [stderr] | [INFO] [stderr] 1423 | mask.set_bit(size.into(), true); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/input.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | if contents_len > (u32::MAX - contents_cum_len) as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX - contents_cum_len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:227:18 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn check(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:232:23 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn loc_string(&self, set: &SourceSet) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:245:16 [INFO] [stderr] | [INFO] [stderr] 245 | pub fn err(&self, set: &SourceSet, message: &str) -> Error { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:336:21 [INFO] [stderr] | [INFO] [stderr] 336 | pub fn is_empty(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/input.rs:340:16 [INFO] [stderr] | [INFO] [stderr] 340 | pub fn len(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rel.rs:147:40 [INFO] [stderr] | [INFO] [stderr] 147 | start = match x_mask.find_zero(end.into()) { [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/rel.rs:155:37 [INFO] [stderr] | [INFO] [stderr] 155 | end = match x_mask.find_one(start.into()) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/output.rs:224:15 [INFO] [stderr] | [INFO] [stderr] 224 | } else if ident.chars().next().unwrap() == '$' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `ident.starts_with('$')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output.rs:388:37 [INFO] [stderr] | [INFO] [stderr] 388 | ret.push(match (val.get_bit((ty.size - 1 - i).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(ty.size - 1 - i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output.rs:389:38 [INFO] [stderr] | [INFO] [stderr] 389 | mode.get_bit((ty.size - 1 - i).into())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(ty.size - 1 - i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:984:18 [INFO] [stderr] | [INFO] [stderr] 984 | fn vhdl_type(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:988:18 [INFO] [stderr] | [INFO] [stderr] 988 | fn type_name(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:992:25 [INFO] [stderr] | [INFO] [stderr] 992 | fn signal_from_port(&self, dst: &mut String, signal: &str, port: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1001:25 [INFO] [stderr] | [INFO] [stderr] 1001 | fn port_from_signal(&self, dst: &mut String, port: &str, signal: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1008:18 [INFO] [stderr] | [INFO] [stderr] 1008 | fn port_decl(&self, dst: &mut String, name: &str, dir: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1022:22 [INFO] [stderr] | [INFO] [stderr] 1022 | fn constant_decl(&self, dst: &mut String, name: &str, val: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1038:20 [INFO] [stderr] | [INFO] [stderr] 1038 | fn signal_decl(&self, dst: &mut String, name: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1053:22 [INFO] [stderr] | [INFO] [stderr] 1053 | fn register_decl(&self, dst: &mut String, name: &str, init: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/node.rs:1402:18 [INFO] [stderr] | [INFO] [stderr] 1402 | mask.set_bit(size.into(), true); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/node.rs:1423:18 [INFO] [stderr] | [INFO] [stderr] 1423 | mask.set_bit(size.into(), true); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parse.rs:252:19 [INFO] [stderr] | [INFO] [stderr] 252 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parse.rs:309:24 [INFO] [stderr] | [INFO] [stderr] 309 | pub fn reverse_rel(&self) -> TokenKind { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should use the `starts_with` method [INFO] [stderr] --> src/output.rs:224:15 [INFO] [stderr] | [INFO] [stderr] 224 | } else if ident.chars().next().unwrap() == '$' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `ident.starts_with('$')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_next_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output.rs:388:37 [INFO] [stderr] | [INFO] [stderr] 388 | ret.push(match (val.get_bit((ty.size - 1 - i).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(ty.size - 1 - i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/output.rs:389:38 [INFO] [stderr] | [INFO] [stderr] 389 | mode.get_bit((ty.size - 1 - i).into())) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(ty.size - 1 - i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tree.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn as_option(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tree.rs:222:24 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn get_sibling(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:984:18 [INFO] [stderr] | [INFO] [stderr] 984 | fn vhdl_type(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:988:18 [INFO] [stderr] | [INFO] [stderr] 988 | fn type_name(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:992:25 [INFO] [stderr] | [INFO] [stderr] 992 | fn signal_from_port(&self, dst: &mut String, signal: &str, port: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1001:25 [INFO] [stderr] | [INFO] [stderr] 1001 | fn port_from_signal(&self, dst: &mut String, port: &str, signal: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1008:18 [INFO] [stderr] | [INFO] [stderr] 1008 | fn port_decl(&self, dst: &mut String, name: &str, dir: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1022:22 [INFO] [stderr] | [INFO] [stderr] 1022 | fn constant_decl(&self, dst: &mut String, name: &str, val: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1038:20 [INFO] [stderr] | [INFO] [stderr] 1038 | fn signal_decl(&self, dst: &mut String, name: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/output.rs:1053:22 [INFO] [stderr] | [INFO] [stderr] 1053 | fn register_decl(&self, dst: &mut String, name: &str, init: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parse.rs:252:19 [INFO] [stderr] | [INFO] [stderr] 252 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parse.rs:309:24 [INFO] [stderr] | [INFO] [stderr] 309 | pub fn reverse_rel(&self) -> TokenKind { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tree.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn as_option(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tree.rs:222:24 [INFO] [stderr] | [INFO] [stderr] 222 | pub fn get_sibling(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 18s [INFO] running `"docker" "inspect" "fc4f2b94b4f0629002754e31ae6f90a3873cd831020d9f1b27b5af0cb3a83157"` [INFO] running `"docker" "rm" "-f" "fc4f2b94b4f0629002754e31ae6f90a3873cd831020d9f1b27b5af0cb3a83157"` [INFO] [stdout] fc4f2b94b4f0629002754e31ae6f90a3873cd831020d9f1b27b5af0cb3a83157