[INFO] crate rowan 0.1.3 is already in cache [INFO] extracting crate rowan 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/rowan/0.1.3 [INFO] extracting crate rowan 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rowan/0.1.3 [INFO] validating manifest of rowan-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rowan-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rowan-0.1.3 [INFO] finished frobbing rowan-0.1.3 [INFO] frobbed toml for rowan-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/rowan/0.1.3/Cargo.toml [INFO] started frobbing rowan-0.1.3 [INFO] finished frobbing rowan-0.1.3 [INFO] frobbed toml for rowan-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rowan/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rowan-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rowan/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0e4fb9700fb804baffecc0b3c51e3b3f562984a0fc0177a21f8f319d359400c1 [INFO] running `"docker" "start" "-a" "0e4fb9700fb804baffecc0b3c51e3b3f562984a0fc0177a21f8f319d359400c1"` [INFO] [stderr] Checking text_unit v0.1.6 [INFO] [stderr] Checking smol_str v0.1.9 [INFO] [stderr] Checking m_lexer v0.0.4 [INFO] [stderr] Checking rowan v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `green::GreenNodeBuilder` [INFO] [stderr] --> src/green.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Self { [INFO] [stderr] 43 | | GreenNodeBuilder { [INFO] [stderr] 44 | | parents: Vec::new(), [INFO] [stderr] 45 | | children: Vec::new(), [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/red.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | .unwrap_or(0.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| 0.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/roots.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | pub(crate) fn syntax_root(&self) -> &'a SyntaxRoot { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `green::GreenNodeBuilder` [INFO] [stderr] --> src/green.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Self { [INFO] [stderr] 43 | | GreenNodeBuilder { [INFO] [stderr] 44 | | parents: Vec::new(), [INFO] [stderr] 45 | | children: Vec::new(), [INFO] [stderr] 46 | | } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/red.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | .unwrap_or(0.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| 0.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/roots.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | pub(crate) fn syntax_root(&self) -> &'a SyntaxRoot { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.19s [INFO] running `"docker" "inspect" "0e4fb9700fb804baffecc0b3c51e3b3f562984a0fc0177a21f8f319d359400c1"` [INFO] running `"docker" "rm" "-f" "0e4fb9700fb804baffecc0b3c51e3b3f562984a0fc0177a21f8f319d359400c1"` [INFO] [stdout] 0e4fb9700fb804baffecc0b3c51e3b3f562984a0fc0177a21f8f319d359400c1