[INFO] crate routeros_rust 0.0.21 is already in cache
[INFO] extracting crate routeros_rust 0.0.21 into work/ex/clippy-test-run/sources/stable/reg/routeros_rust/0.0.21
[INFO] extracting crate routeros_rust 0.0.21 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/routeros_rust/0.0.21
[INFO] validating manifest of routeros_rust-0.0.21 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of routeros_rust-0.0.21 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing routeros_rust-0.0.21
[INFO] finished frobbing routeros_rust-0.0.21
[INFO] frobbed toml for routeros_rust-0.0.21 written to work/ex/clippy-test-run/sources/stable/reg/routeros_rust/0.0.21/Cargo.toml
[INFO] started frobbing routeros_rust-0.0.21
[INFO] finished frobbing routeros_rust-0.0.21
[INFO] frobbed toml for routeros_rust-0.0.21 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/routeros_rust/0.0.21/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting routeros_rust-0.0.21 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/routeros_rust/0.0.21:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8c07063ab3d8c6396a2eb000fff1d9d23ee09f48a3b2c4465ddd6690104bbf58
[INFO] running `"docker" "start" "-a" "8c07063ab3d8c6396a2eb000fff1d9d23ee09f48a3b2c4465ddd6690104bbf58"`
[INFO] [stderr]     Checking routeros_rust v0.0.21 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/routeros.rs:81:19
[INFO] [stderr]    |
[INFO] [stderr] 81 |         } else if len < 0x200000 {
[INFO] [stderr]    |                         ^^^^^^^^ help: consider: `0x0020_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/routeros.rs:82:27
[INFO] [stderr]    |
[INFO] [stderr] 82 |             let l = len | 0xC00000;
[INFO] [stderr]    |                           ^^^^^^^^ help: consider: `0x00C0_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/routeros.rs:86:19
[INFO] [stderr]    |
[INFO] [stderr] 86 |         } else if len < 0x10000000 {
[INFO] [stderr]    |                         ^^^^^^^^^^ help: consider: `0x1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/routeros.rs:87:27
[INFO] [stderr]    |
[INFO] [stderr] 87 |             let l = len | 0xE0000000;
[INFO] [stderr]    |                           ^^^^^^^^^^ help: consider: `0xE000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/routeros.rs:81:19
[INFO] [stderr]    |
[INFO] [stderr] 81 |         } else if len < 0x200000 {
[INFO] [stderr]    |                         ^^^^^^^^ help: consider: `0x0020_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/routeros.rs:82:27
[INFO] [stderr]    |
[INFO] [stderr] 82 |             let l = len | 0xC00000;
[INFO] [stderr]    |                           ^^^^^^^^ help: consider: `0x00C0_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/routeros.rs:86:19
[INFO] [stderr]    |
[INFO] [stderr] 86 |         } else if len < 0x10000000 {
[INFO] [stderr]    |                         ^^^^^^^^^^ help: consider: `0x1000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/routeros.rs:87:27
[INFO] [stderr]    |
[INFO] [stderr] 87 |             let l = len | 0xE0000000;
[INFO] [stderr]    |                           ^^^^^^^^^^ help: consider: `0xE000_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/routeros.rs:47:3
[INFO] [stderr]    |
[INFO] [stderr] 47 |           if self.stream.read(&mut [0]).unwrap() > 0 {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 48 | |             true
[INFO] [stderr] 49 | |         }else {
[INFO] [stderr] 50 | |             false
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `self.stream.read(&mut [0]).unwrap() > 0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:102:26
[INFO] [stderr]     |
[INFO] [stderr] 102 |         let mut c: u32 = self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:108:18
[INFO] [stderr]     |
[INFO] [stderr] 108 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:112:18
[INFO] [stderr]     |
[INFO] [stderr] 112 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:114:18
[INFO] [stderr]     |
[INFO] [stderr] 114 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:118:18
[INFO] [stderr]     |
[INFO] [stderr] 118 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:120:18
[INFO] [stderr]     |
[INFO] [stderr] 120 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:122:18
[INFO] [stderr]     |
[INFO] [stderr] 122 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:124:17
[INFO] [stderr]     |
[INFO] [stderr] 124 |             c = self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:126:18
[INFO] [stderr]     |
[INFO] [stderr] 126 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:128:18
[INFO] [stderr]     |
[INFO] [stderr] 128 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:129:18
[INFO] [stderr]     |
[INFO] [stderr] 129 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/routeros.rs:143:6
[INFO] [stderr]     |
[INFO] [stderr] 143 |         if w.len() > 0 { println!("<<< {}", w); }
[INFO] [stderr]     |            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!w.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/routeros.rs:179:7
[INFO] [stderr]     |
[INFO] [stderr] 179 |             if i.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `i.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/routeros.rs:187:23
[INFO] [stderr]     |
[INFO] [stderr] 187 |                 match w[1..].find("=") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/routeros.rs:188:36
[INFO] [stderr]     |
[INFO] [stderr] 188 |                     Some(n) => { attrs.insert(     w[..n+1].to_string() ,
[INFO] [stderr]     |                                                      ^^^^^ help: use: `..=n`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/routeros.rs:47:3
[INFO] [stderr]    |
[INFO] [stderr] 47 |           if self.stream.read(&mut [0]).unwrap() > 0 {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 48 | |             true
[INFO] [stderr] 49 | |         }else {
[INFO] [stderr] 50 | |             false
[INFO] [stderr] 51 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `self.stream.read(&mut [0]).unwrap() > 0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:102:26
[INFO] [stderr]     |
[INFO] [stderr] 102 |         let mut c: u32 = self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:108:18
[INFO] [stderr]     |
[INFO] [stderr] 108 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:112:18
[INFO] [stderr]     |
[INFO] [stderr] 112 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:114:18
[INFO] [stderr]     |
[INFO] [stderr] 114 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:118:18
[INFO] [stderr]     |
[INFO] [stderr] 118 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:120:18
[INFO] [stderr]     |
[INFO] [stderr] 120 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:122:18
[INFO] [stderr]     |
[INFO] [stderr] 122 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:124:17
[INFO] [stderr]     |
[INFO] [stderr] 124 |             c = self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:126:18
[INFO] [stderr]     |
[INFO] [stderr] 126 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:128:18
[INFO] [stderr]     |
[INFO] [stderr] 128 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/routeros.rs:129:18
[INFO] [stderr]     |
[INFO] [stderr] 129 |             c += self.read_str(1).as_bytes()[0] as u32;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.read_str(1).as_bytes()[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/routeros.rs:143:6
[INFO] [stderr]     |
[INFO] [stderr] 143 |         if w.len() > 0 { println!("<<< {}", w); }
[INFO] [stderr]     |            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!w.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/routeros.rs:179:7
[INFO] [stderr]     |
[INFO] [stderr] 179 |             if i.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `i.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/routeros.rs:187:23
[INFO] [stderr]     |
[INFO] [stderr] 187 |                 match w[1..].find("=") {
[INFO] [stderr]     |                                   ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/routeros.rs:188:36
[INFO] [stderr]     |
[INFO] [stderr] 188 |                     Some(n) => { attrs.insert(     w[..n+1].to_string() ,
[INFO] [stderr]     |                                                      ^^^^^ help: use: `..=n`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> example.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     return line;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> example.rs:36:8
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 if replies.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `replies.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> example.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     return line;
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `line`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> example.rs:36:8
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 if replies.len() == 0 {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `replies.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.81s
[INFO] running `"docker" "inspect" "8c07063ab3d8c6396a2eb000fff1d9d23ee09f48a3b2c4465ddd6690104bbf58"`
[INFO] running `"docker" "rm" "-f" "8c07063ab3d8c6396a2eb000fff1d9d23ee09f48a3b2c4465ddd6690104bbf58"`
[INFO] [stdout] 8c07063ab3d8c6396a2eb000fff1d9d23ee09f48a3b2c4465ddd6690104bbf58