[INFO] crate router 0.6.0 is already in cache [INFO] extracting crate router 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/router/0.6.0 [INFO] extracting crate router 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/router/0.6.0 [INFO] validating manifest of router-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of router-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing router-0.6.0 [INFO] finished frobbing router-0.6.0 [INFO] frobbed toml for router-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/router/0.6.0/Cargo.toml [INFO] started frobbing router-0.6.0 [INFO] finished frobbing router-0.6.0 [INFO] frobbed toml for router-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/router/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting router-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/router/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e5988f6b74488c0b28c6f087242fb0143cf57c44d09598d985c99e5519818b87 [INFO] running `"docker" "start" "-a" "e5988f6b74488c0b28c6f087242fb0143cf57c44d09598d985c99e5519818b87"` [INFO] [stderr] Checking router v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider adding a `Default` implementation for `router::Router` [INFO] [stderr] --> src/router.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> Router { [INFO] [stderr] 38 | | Router { [INFO] [stderr] 39 | | inner: Arc::new(RouterInner { [INFO] [stderr] 40 | | routers: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for router::Router { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | .or_insert(Recognizer::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Recognizer::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/router.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let ref mut route_ids = inner.route_ids; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^------------------- help: try: `let route_ids = &mut inner.route_ids;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/router.rs:139:38 [INFO] [stderr] | [INFO] [stderr] 139 | -> Option>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&Handler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/router.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | .or(self.inner.wildcard.recognize(path).ok()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.inner.wildcard.recognize(path).ok())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/router.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | self.inner.routers.get(method).map(|router| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 154 | || if let Some(_) = router.recognize(path).ok() { [INFO] [stderr] 155 | || options.push(method.clone()); [INFO] [stderr] 156 | || } [INFO] [stderr] 157 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(router) = self.inner.routers.get(method) { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/router.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | / if let Some(_) = router.recognize(path).ok() { [INFO] [stderr] 155 | | options.push(method.clone()); [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(_)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/router.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(_) = router.recognize(path).ok() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 155 | | options.push(method.clone()); [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________- help: try this: `if router.recognize(path).ok().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/router.rs:218:52 [INFO] [stderr] | [INFO] [stderr] 218 | self.handle_method(req, &path).unwrap_or( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 219 | | Err(IronError::new(NoRoute, status::NotFound)) [INFO] [stderr] 220 | | ) [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| Err(IronError::new(NoRoute, status::NotFound)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/url_for.rs:14:59 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn url_for(request: &Request, route_id: &str, params: HashMap) -> ::iron::Url { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 14 | pub fn url_for(request: &Request, route_id: &str, params: HashMap) -> ::iron::Url { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: you should consider adding a `Default` implementation for `router::Router` [INFO] [stderr] --> src/router.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / pub fn new() -> Router { [INFO] [stderr] 38 | | Router { [INFO] [stderr] 39 | | inner: Arc::new(RouterInner { [INFO] [stderr] 40 | | routers: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for router::Router { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | .or_insert(Recognizer::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Recognizer::new)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/router.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | let ref mut route_ids = inner.route_ids; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^------------------- help: try: `let route_ids = &mut inner.route_ids;` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::toplevel_ref_arg)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/router.rs:139:38 [INFO] [stderr] | [INFO] [stderr] 139 | -> Option>> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `&Handler` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::borrowed_box)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] error: use of `or` followed by a function call [INFO] [stderr] --> src/router.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | .or(self.inner.wildcard.recognize(path).ok()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.inner.wildcard.recognize(path).ok())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/router.rs:153:13 [INFO] [stderr] | [INFO] [stderr] 153 | self.inner.routers.get(method).map(|router| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 154 | || if let Some(_) = router.recognize(path).ok() { [INFO] [stderr] 155 | || options.push(method.clone()); [INFO] [stderr] 156 | || } [INFO] [stderr] 157 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(router) = self.inner.routers.get(method) { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::option_map_unit_fn)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/router.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | / if let Some(_) = router.recognize(path).ok() { [INFO] [stderr] 155 | | options.push(method.clone()); [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::if_let_some_result)] implied by #[deny(warnings)] [INFO] [stderr] = help: Consider matching on `Ok(_)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] error: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/router.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | if let Some(_) = router.recognize(path).ok() { [INFO] [stderr] | _________________- ^^^^^^^ [INFO] [stderr] 155 | | options.push(method.clone()); [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________________- help: try this: `if router.recognize(path).ok().is_some()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_pattern_matching)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/router.rs:218:52 [INFO] [stderr] | [INFO] [stderr] 218 | self.handle_method(req, &path).unwrap_or( [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 219 | | Err(IronError::new(NoRoute, status::NotFound)) [INFO] [stderr] 220 | | ) [INFO] [stderr] | |_____________________^ help: try this: `unwrap_or_else(|| Err(IronError::new(NoRoute, status::NotFound)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/url_for.rs:14:59 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn url_for(request: &Request, route_id: &str, params: HashMap) -> ::iron::Url { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:24 [INFO] [stderr] | [INFO] [stderr] 2 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::implicit_hasher)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 14 | pub fn url_for(request: &Request, route_id: &str, params: HashMap) -> ::iron::Url { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `router`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/simple_with_macro.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | let ref query = req.extensions.get::() [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 23 | let query = &req.extensions.get::() [INFO] [stderr] 24 | .unwrap().find("query").unwrap_or("/"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/url_for.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | let ref query = req.extensions.get::() [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 33 | let query = &req.extensions.get::() [INFO] [stderr] 34 | .unwrap().find("query").unwrap_or("/"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/simple.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | let ref query = req.extensions.get::() [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 24 | let query = &req.extensions.get::() [INFO] [stderr] 25 | .unwrap().find("query").unwrap_or("/"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "e5988f6b74488c0b28c6f087242fb0143cf57c44d09598d985c99e5519818b87"` [INFO] running `"docker" "rm" "-f" "e5988f6b74488c0b28c6f087242fb0143cf57c44d09598d985c99e5519818b87"` [INFO] [stdout] e5988f6b74488c0b28c6f087242fb0143cf57c44d09598d985c99e5519818b87