[INFO] crate rouste 0.2.1 is already in cache [INFO] extracting crate rouste 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/rouste/0.2.1 [INFO] extracting crate rouste 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rouste/0.2.1 [INFO] validating manifest of rouste-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rouste-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rouste-0.2.1 [INFO] finished frobbing rouste-0.2.1 [INFO] frobbed toml for rouste-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/rouste/0.2.1/Cargo.toml [INFO] started frobbing rouste-0.2.1 [INFO] finished frobbing rouste-0.2.1 [INFO] frobbed toml for rouste-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rouste/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rouste-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rouste/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a2fe89ea610d92671c153a2413c1650bebaabb94f4b7325d186e1df5feed1db [INFO] running `"docker" "start" "-a" "7a2fe89ea610d92671c153a2413c1650bebaabb94f4b7325d186e1df5feed1db"` [INFO] [stderr] Checking rouste v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:17:62 [INFO] [stderr] | [INFO] [stderr] 17 | .and_then(|ord| from_u32(ord)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `from_u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/utils.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | / if maybe_char.is_none() { [INFO] [stderr] 19 | | return None; [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________________^ help: replace_it_with: `maybe_char?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:17:62 [INFO] [stderr] | [INFO] [stderr] 17 | .and_then(|ord| from_u32(ord)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `from_u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/utils.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | / if maybe_char.is_none() { [INFO] [stderr] 19 | | return None; [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________________^ help: replace_it_with: `maybe_char?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "7a2fe89ea610d92671c153a2413c1650bebaabb94f4b7325d186e1df5feed1db"` [INFO] running `"docker" "rm" "-f" "7a2fe89ea610d92671c153a2413c1650bebaabb94f4b7325d186e1df5feed1db"` [INFO] [stdout] 7a2fe89ea610d92671c153a2413c1650bebaabb94f4b7325d186e1df5feed1db