[INFO] crate rotor-tools 0.3.2 is already in cache [INFO] extracting crate rotor-tools 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/rotor-tools/0.3.2 [INFO] extracting crate rotor-tools 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rotor-tools/0.3.2 [INFO] validating manifest of rotor-tools-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rotor-tools-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rotor-tools-0.3.2 [INFO] finished frobbing rotor-tools-0.3.2 [INFO] frobbed toml for rotor-tools-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/rotor-tools/0.3.2/Cargo.toml [INFO] started frobbing rotor-tools-0.3.2 [INFO] finished frobbing rotor-tools-0.3.2 [INFO] frobbed toml for rotor-tools-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rotor-tools/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rotor-tools-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rotor-tools/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a33160dee5a6fe1d4c45615e732dd370434b3e5ec64a8a8024786e3828d2f36b [INFO] running `"docker" "start" "-a" "a33160dee5a6fe1d4c45615e732dd370434b3e5ec64a8a8024786e3828d2f36b"` [INFO] [stderr] Checking rotor v0.6.3 [INFO] [stderr] Checking rotor-tools v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | machine: machine, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `machine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timer.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | machine: machine, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `machine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timer.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | return scope.now() + self.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `scope.now() + self.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timer.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | return goal; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `goal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/sync.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/sync.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `GenericScope` [INFO] [stderr] --> src/timer.rs:3:49 [INFO] [stderr] | [INFO] [stderr] 3 | use rotor::{Machine, Scope, Response, EventSet, GenericScope, Time}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timer.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | return scope.now() + self.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `scope.now() + self.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/timer.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | return goal; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `goal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/sync.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/sync.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `GenericScope` [INFO] [stderr] --> src/timer.rs:3:49 [INFO] [stderr] | [INFO] [stderr] 3 | use rotor::{Machine, Scope, Response, EventSet, GenericScope, Time}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.89s [INFO] running `"docker" "inspect" "a33160dee5a6fe1d4c45615e732dd370434b3e5ec64a8a8024786e3828d2f36b"` [INFO] running `"docker" "rm" "-f" "a33160dee5a6fe1d4c45615e732dd370434b3e5ec64a8a8024786e3828d2f36b"` [INFO] [stdout] a33160dee5a6fe1d4c45615e732dd370434b3e5ec64a8a8024786e3828d2f36b