[INFO] crate rotor-test 0.2.0 is already in cache [INFO] extracting crate rotor-test 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/rotor-test/0.2.0 [INFO] extracting crate rotor-test 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rotor-test/0.2.0 [INFO] validating manifest of rotor-test-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rotor-test-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rotor-test-0.2.0 [INFO] finished frobbing rotor-test-0.2.0 [INFO] frobbed toml for rotor-test-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rotor-test/0.2.0/Cargo.toml [INFO] started frobbing rotor-test-0.2.0 [INFO] finished frobbing rotor-test-0.2.0 [INFO] frobbed toml for rotor-test-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rotor-test/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rotor-test-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rotor-test/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aaec38134722449add2c4f1f1c257d12da0aec643fb88fc9757fba20580971e1 [INFO] running `"docker" "start" "-a" "aaec38134722449add2c4f1f1c257d12da0aec643fb88fc9757fba20580971e1"` [INFO] [stderr] Checking netbuf v0.3.8 [INFO] [stderr] Checking rotor v0.6.3 [INFO] [stderr] Checking rotor-tools v0.3.2 [INFO] [stderr] Checking rotor-stream v0.6.2 [INFO] [stderr] Checking rotor-test v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/stream.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 108 | | if bufs.input_closed { [INFO] [stderr] 109 | | Ok(0) [INFO] [stderr] 110 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 107 | } else if bufs.input_closed { [INFO] [stderr] 108 | Ok(0) [INFO] [stderr] 109 | } else { [INFO] [stderr] 110 | Err(io::Error::new(io::ErrorKind::WouldBlock, [INFO] [stderr] 111 | "no data in mocked input buffer")) [INFO] [stderr] 112 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `event_loop` [INFO] [stderr] --> src/scope.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | event_loop: mio::EventLoop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stream::MemIo` [INFO] [stderr] --> src/stream.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> MemIo { [INFO] [stderr] 35 | | MemIo(Arc::new(Mutex::new(Bufs { [INFO] [stderr] 36 | | input: Vec::new(), [INFO] [stderr] 37 | | input_closed: false, [INFO] [stderr] 38 | | output: Vec::new(), [INFO] [stderr] 39 | | }))) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for stream::MemIo { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/stream.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | s.write(b"hello").expect("write failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/stream.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | s.write(b"world").expect("write failed"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rotor-test`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/stream.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 108 | | if bufs.input_closed { [INFO] [stderr] 109 | | Ok(0) [INFO] [stderr] 110 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 107 | } else if bufs.input_closed { [INFO] [stderr] 108 | Ok(0) [INFO] [stderr] 109 | } else { [INFO] [stderr] 110 | Err(io::Error::new(io::ErrorKind::WouldBlock, [INFO] [stderr] 111 | "no data in mocked input buffer")) [INFO] [stderr] 112 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `event_loop` [INFO] [stderr] --> src/scope.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | event_loop: mio::EventLoop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `stream::MemIo` [INFO] [stderr] --> src/stream.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> MemIo { [INFO] [stderr] 35 | | MemIo(Arc::new(Mutex::new(Bufs { [INFO] [stderr] 36 | | input: Vec::new(), [INFO] [stderr] 37 | | input_closed: false, [INFO] [stderr] 38 | | output: Vec::new(), [INFO] [stderr] 39 | | }))) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for stream::MemIo { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "aaec38134722449add2c4f1f1c257d12da0aec643fb88fc9757fba20580971e1"` [INFO] running `"docker" "rm" "-f" "aaec38134722449add2c4f1f1c257d12da0aec643fb88fc9757fba20580971e1"` [INFO] [stdout] aaec38134722449add2c4f1f1c257d12da0aec643fb88fc9757fba20580971e1