[INFO] crate rotor-carbon 0.7.0 is already in cache [INFO] extracting crate rotor-carbon 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/rotor-carbon/0.7.0 [INFO] extracting crate rotor-carbon 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rotor-carbon/0.7.0 [INFO] validating manifest of rotor-carbon-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rotor-carbon-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rotor-carbon-0.7.0 [INFO] finished frobbing rotor-carbon-0.7.0 [INFO] frobbed toml for rotor-carbon-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/rotor-carbon/0.7.0/Cargo.toml [INFO] started frobbing rotor-carbon-0.7.0 [INFO] finished frobbing rotor-carbon-0.7.0 [INFO] frobbed toml for rotor-carbon-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rotor-carbon/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rotor-carbon-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rotor-carbon/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0078eb95d7f1567a82964e50efbd24afd2f37c50aee834743b2c85aafd5948e2 [INFO] running `"docker" "start" "-a" "0078eb95d7f1567a82964e50efbd24afd2f37c50aee834743b2c85aafd5948e2"` [INFO] [stderr] Checking rotor-carbon v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sender.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let mut buf = trans.output(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sender.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let mut buf = trans.output(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sender.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let mut buf = trans.output(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/sender.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | self.0.transport().map(|mut trans| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 18 | || let ts = get_time().sec; [INFO] [stderr] 19 | || let mut buf = trans.output(); [INFO] [stderr] 20 | || let offset = buf.len(); [INFO] [stderr] 21 | || writeln!(buf, "{} {} {}", name, value, ts).unwrap(); [INFO] [stderr] 22 | || debug_assert!(!buf[offset..buf.len()-1].contains(&b'\n')); [INFO] [stderr] 23 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(mut trans) = self.0.transport() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/sender.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | self.0.transport().map(|mut trans| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 32 | || let mut buf = trans.output(); [INFO] [stderr] 33 | || let offset = buf.len(); [INFO] [stderr] 34 | || writeln!(buf, "{} {} {}", name, value, ts).unwrap(); [INFO] [stderr] 35 | || debug_assert!(!buf[offset..buf.len()-1].contains(&b'\n')); [INFO] [stderr] 36 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(mut trans) = self.0.transport() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/sender.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.1.as_mut().map(|x| x.wakeup().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = self.1.as_mut() { x.wakeup().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/proto.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if transport.output().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transport.output().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | -> Response<(Fsm, Sink), Void> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sender.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let mut buf = trans.output(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sender.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let mut buf = trans.output(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sender.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | let mut buf = trans.output(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/sender.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | self.0.transport().map(|mut trans| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 18 | || let ts = get_time().sec; [INFO] [stderr] 19 | || let mut buf = trans.output(); [INFO] [stderr] 20 | || let offset = buf.len(); [INFO] [stderr] 21 | || writeln!(buf, "{} {} {}", name, value, ts).unwrap(); [INFO] [stderr] 22 | || debug_assert!(!buf[offset..buf.len()-1].contains(&b'\n')); [INFO] [stderr] 23 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(mut trans) = self.0.transport() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/sender.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | self.0.transport().map(|mut trans| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 32 | || let mut buf = trans.output(); [INFO] [stderr] 33 | || let offset = buf.len(); [INFO] [stderr] 34 | || writeln!(buf, "{} {} {}", name, value, ts).unwrap(); [INFO] [stderr] 35 | || debug_assert!(!buf[offset..buf.len()-1].contains(&b'\n')); [INFO] [stderr] 36 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(mut trans) = self.0.transport() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/sender.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | self.1.as_mut().map(|x| x.wakeup().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = self.1.as_mut() { x.wakeup().unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/proto.rs:50:12 [INFO] [stderr] | [INFO] [stderr] 50 | if transport.output().len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transport.output().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | -> Response<(Fsm, Sink), Void> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.49s [INFO] running `"docker" "inspect" "0078eb95d7f1567a82964e50efbd24afd2f37c50aee834743b2c85aafd5948e2"` [INFO] running `"docker" "rm" "-f" "0078eb95d7f1567a82964e50efbd24afd2f37c50aee834743b2c85aafd5948e2"` [INFO] [stdout] 0078eb95d7f1567a82964e50efbd24afd2f37c50aee834743b2c85aafd5948e2