[INFO] crate rosrust_codegen 0.7.0 is already in cache [INFO] extracting crate rosrust_codegen 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/rosrust_codegen/0.7.0 [INFO] extracting crate rosrust_codegen 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rosrust_codegen/0.7.0 [INFO] validating manifest of rosrust_codegen-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rosrust_codegen-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rosrust_codegen-0.7.0 [INFO] finished frobbing rosrust_codegen-0.7.0 [INFO] frobbed toml for rosrust_codegen-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/rosrust_codegen/0.7.0/Cargo.toml [INFO] started frobbing rosrust_codegen-0.7.0 [INFO] finished frobbing rosrust_codegen-0.7.0 [INFO] frobbed toml for rosrust_codegen-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rosrust_codegen/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rosrust_codegen-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rosrust_codegen/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c6a1e222ff5a48f2fe1b1dea20315438945f2f3a7b15c191d0a00779a340bc99 [INFO] running `"docker" "start" "-a" "c6a1e222ff5a48f2fe1b1dea20315438945f2f3a7b15c191d0a00779a340bc99"` [INFO] [stderr] Checking syn v0.14.9 [INFO] [stderr] Checking rosrust_codegen v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `trivial_regex` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/helpers.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | #[allow(unknown_lints, trivial_regex)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::trivial_regex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `trivial_regex` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/helpers.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | #[allow(unknown_lints, trivial_regex)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::trivial_regex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `trivial_regex` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/helpers.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | #[allow(unknown_lints, trivial_regex)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::trivial_regex` [INFO] [stderr] [INFO] [stderr] warning: lint name `trivial_regex` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/helpers.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | #[allow(unknown_lints, trivial_regex)] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::trivial_regex` [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:262:14 [INFO] [stderr] | [INFO] [stderr] 262 | *hashes [INFO] [stderr] | ______________^ [INFO] [stderr] 263 | | .get(&("geometry_msgs".into(), "Vector3".into())) [INFO] [stderr] 264 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&hashes[&("geometry_msgs".into(), "Vector3".into())]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:268:14 [INFO] [stderr] | [INFO] [stderr] 268 | *hashes [INFO] [stderr] | ______________^ [INFO] [stderr] 269 | | .get(&("geometry_msgs".into(), "Point".into())) [INFO] [stderr] 270 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&hashes[&("geometry_msgs".into(), "Point".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:274:14 [INFO] [stderr] | [INFO] [stderr] 274 | *hashes [INFO] [stderr] | ______________^ [INFO] [stderr] 275 | | .get(&("geometry_msgs".into(), "Quaternion".into())) [INFO] [stderr] 276 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&hashes[&("geometry_msgs".into(), "Quaternion".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:280:14 [INFO] [stderr] | [INFO] [stderr] 280 | *hashes [INFO] [stderr] | ______________^ [INFO] [stderr] 281 | | .get(&("geometry_msgs".into(), "Pose".into())) [INFO] [stderr] 282 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&hashes[&("geometry_msgs".into(), "Pose".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:286:14 [INFO] [stderr] | [INFO] [stderr] 286 | *hashes.get(&("std_msgs".into(), "Header".into())).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hashes[&("std_msgs".into(), "Header".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:290:14 [INFO] [stderr] | [INFO] [stderr] 290 | *hashes [INFO] [stderr] | ______________^ [INFO] [stderr] 291 | | .get(&("geometry_msgs".into(), "PoseStamped".into())) [INFO] [stderr] 292 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&hashes[&("geometry_msgs".into(), "PoseStamped".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:296:14 [INFO] [stderr] | [INFO] [stderr] 296 | *hashes.get(&("sensor_msgs".into(), "Imu".into())).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hashes[&("sensor_msgs".into(), "Imu".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:300:14 [INFO] [stderr] | [INFO] [stderr] 300 | *hashes [INFO] [stderr] | ______________^ [INFO] [stderr] 301 | | .get(&("rosgraph_msgs".into(), "Clock".into())) [INFO] [stderr] 302 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&hashes[&("rosgraph_msgs".into(), "Clock".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:306:14 [INFO] [stderr] | [INFO] [stderr] 306 | *hashes.get(&("rosgraph_msgs".into(), "Log".into())).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&hashes[&("rosgraph_msgs".into(), "Log".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:318:14 [INFO] [stderr] | [INFO] [stderr] 318 | &message_map [INFO] [stderr] | ______________^ [INFO] [stderr] 319 | | .get(&("geometry_msgs".into(), "Vector3".into())) [INFO] [stderr] 320 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&message_map[&("geometry_msgs".into(), "Vector3".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:336:14 [INFO] [stderr] | [INFO] [stderr] 336 | &message_map [INFO] [stderr] | ______________^ [INFO] [stderr] 337 | | .get(&("geometry_msgs".into(), "PoseStamped".into())) [INFO] [stderr] 338 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&message_map[&("geometry_msgs".into(), "PoseStamped".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:401:14 [INFO] [stderr] | [INFO] [stderr] 401 | *hashes [INFO] [stderr] | ______________^ [INFO] [stderr] 402 | | .get(&("diagnostic_msgs".into(), "AddDiagnostics".into())) [INFO] [stderr] 403 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&hashes[&("diagnostic_msgs".into(), "AddDiagnostics".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/helpers.rs:407:14 [INFO] [stderr] | [INFO] [stderr] 407 | *hashes [INFO] [stderr] | ______________^ [INFO] [stderr] 408 | | .get(&("simple_srv".into(), "Something".into())) [INFO] [stderr] 409 | | .unwrap(), [INFO] [stderr] | |_________________________^ help: try this: `&hashes[&("simple_srv".into(), "Something".into())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.33s [INFO] running `"docker" "inspect" "c6a1e222ff5a48f2fe1b1dea20315438945f2f3a7b15c191d0a00779a340bc99"` [INFO] running `"docker" "rm" "-f" "c6a1e222ff5a48f2fe1b1dea20315438945f2f3a7b15c191d0a00779a340bc99"` [INFO] [stdout] c6a1e222ff5a48f2fe1b1dea20315438945f2f3a7b15c191d0a00779a340bc99