[INFO] crate rosbag 0.2.0 is already in cache
[INFO] extracting crate rosbag 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/rosbag/0.2.0
[INFO] extracting crate rosbag 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rosbag/0.2.0
[INFO] validating manifest of rosbag-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rosbag-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rosbag-0.2.0
[INFO] finished frobbing rosbag-0.2.0
[INFO] frobbed toml for rosbag-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rosbag/0.2.0/Cargo.toml
[INFO] started frobbing rosbag-0.2.0
[INFO] finished frobbing rosbag-0.2.0
[INFO] frobbed toml for rosbag-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rosbag/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rosbag-0.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rosbag/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 301e9b2335838f67f42616c910b89a3cca454da37485452a100c69e45bbd1d00
[INFO] running `"docker" "start" "-a" "301e9b2335838f67f42616c910b89a3cca454da37485452a100c69e45bbd1d00"`
[INFO] [stderr]     Checking rosbag v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/field_iter.rs:21:12
[INFO] [stderr]    |
[INFO] [stderr] 21 |         if self.buf.len() == 0 { return None; }
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/field_iter.rs:38:17
[INFO] [stderr]    |
[INFO] [stderr] 38 |                 0x20...0x7e => (),
[INFO] [stderr]    |                 ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_overlapping_arm)] on by default
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/field_iter.rs:34:17
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 b'=' => {
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cursor.rs:36:17
[INFO] [stderr]    |
[INFO] [stderr] 36 |         let n = self.next_u32()? as u64;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cursor.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let s = self.next_u32()? as u64;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cursor.rs:52:18
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let ns = self.next_u32()? as u64;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/msg_iter.rs:60:12
[INFO] [stderr]    |
[INFO] [stderr] 60 |         Ok(self.cursor.seek(offset as u64)?)
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 60 |         Ok(())
[INFO] [stderr]    |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/msg_iter.rs:60:29
[INFO] [stderr]    |
[INFO] [stderr] 60 |         Ok(self.cursor.seek(offset as u64)?)
[INFO] [stderr]    |                             ^^^^^^^^^^^^^ help: try: `u64::from(offset)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/msg_iter.rs:100:12
[INFO] [stderr]     |
[INFO] [stderr] 100 |         Ok(self.cursor.seek(offset as u64)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 100 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/msg_iter.rs:100:29
[INFO] [stderr]     |
[INFO] [stderr] 100 |         Ok(self.cursor.seek(offset as u64)?)
[INFO] [stderr]     |                             ^^^^^^^^^^^^^ help: try: `u64::from(offset)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/bag_header.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |         let n = c.next_u32()? as u64;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(c.next_u32()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/record_types/chunk.rs:16:23
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn decompress<'a>(&self, data: &'a [u8]) -> Result<Cow<'a, [u8]>> {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/record_types/connection.rs:88:15
[INFO] [stderr]    |
[INFO] [stderr] 88 |         while header.len() != 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!header.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/index_data.rs:43:33
[INFO] [stderr]    |
[INFO] [stderr] 43 |         let data = c.next_bytes(n as u64)?;
[INFO] [stderr]    |                                 ^^^^^^^^ help: try: `u64::from(n)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/chunk_info.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let data = c.next_bytes(n as u64)?;
[INFO] [stderr]    |                                 ^^^^^^^^ help: try: `u64::from(n)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/record_types/utils.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             0x20...0x7e => (),
[INFO] [stderr]    |             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/record_types/utils.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |             b'=' => {
[INFO] [stderr]    |             ^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/utils.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |     let s = LE::read_u32(&val[..4]) as u64;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LE::read_u32(&val[..4]))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/utils.rs:69:14
[INFO] [stderr]    |
[INFO] [stderr] 69 |     let ns = LE::read_u32(&val[4..]) as u64;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LE::read_u32(&val[4..]))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/record_types/mod.rs:27:15
[INFO] [stderr]    |
[INFO] [stderr] 27 |         while header.len() != 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!header.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/lib.rs:89:12
[INFO] [stderr]    |
[INFO] [stderr] 89 |         if &buf != VERSION_STRING.as_bytes() {
[INFO] [stderr]    |            ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |            |
[INFO] [stderr]    |            help: use the left value directly: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:97:5
[INFO] [stderr]     |
[INFO] [stderr] 97  | /     pub fn records<'a>(&'a self) -> RecordsIterator<'a> {
[INFO] [stderr] 98  | |         let mut cursor = Cursor::new(&self.data);
[INFO] [stderr] 99  | |         cursor.seek(13).expect("13 bytes already have been read");
[INFO] [stderr] 100 | |         RecordsIterator { cursor }
[INFO] [stderr] 101 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:118:12
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Ok(self.cursor.seek(pos)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/field_iter.rs:21:12
[INFO] [stderr]    |
[INFO] [stderr] 21 |         if self.buf.len() == 0 { return None; }
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.buf.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/field_iter.rs:38:17
[INFO] [stderr]    |
[INFO] [stderr] 38 |                 0x20...0x7e => (),
[INFO] [stderr]    |                 ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_overlapping_arm)] on by default
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/field_iter.rs:34:17
[INFO] [stderr]    |
[INFO] [stderr] 34 |                 b'=' => {
[INFO] [stderr]    |                 ^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cursor.rs:36:17
[INFO] [stderr]    |
[INFO] [stderr] 36 |         let n = self.next_u32()? as u64;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cursor.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |         let s = self.next_u32()? as u64;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/cursor.rs:52:18
[INFO] [stderr]    |
[INFO] [stderr] 52 |         let ns = self.next_u32()? as u64;
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.next_u32()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/msg_iter.rs:60:12
[INFO] [stderr]    |
[INFO] [stderr] 60 |         Ok(self.cursor.seek(offset as u64)?)
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 60 |         Ok(())
[INFO] [stderr]    |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/msg_iter.rs:60:29
[INFO] [stderr]    |
[INFO] [stderr] 60 |         Ok(self.cursor.seek(offset as u64)?)
[INFO] [stderr]    |                             ^^^^^^^^^^^^^ help: try: `u64::from(offset)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/msg_iter.rs:100:12
[INFO] [stderr]     |
[INFO] [stderr] 100 |         Ok(self.cursor.seek(offset as u64)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 100 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/msg_iter.rs:100:29
[INFO] [stderr]     |
[INFO] [stderr] 100 |         Ok(self.cursor.seek(offset as u64)?)
[INFO] [stderr]     |                             ^^^^^^^^^^^^^ help: try: `u64::from(offset)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/bag_header.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |         let n = c.next_u32()? as u64;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(c.next_u32()?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/record_types/chunk.rs:16:23
[INFO] [stderr]    |
[INFO] [stderr] 16 |     fn decompress<'a>(&self, data: &'a [u8]) -> Result<Cow<'a, [u8]>> {
[INFO] [stderr]    |                       ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/record_types/connection.rs:88:15
[INFO] [stderr]    |
[INFO] [stderr] 88 |         while header.len() != 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!header.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/index_data.rs:43:33
[INFO] [stderr]    |
[INFO] [stderr] 43 |         let data = c.next_bytes(n as u64)?;
[INFO] [stderr]    |                                 ^^^^^^^^ help: try: `u64::from(n)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/chunk_info.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 |         let data = c.next_bytes(n as u64)?;
[INFO] [stderr]    |                                 ^^^^^^^^ help: try: `u64::from(n)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: some ranges overlap
[INFO] [stderr]   --> src/record_types/utils.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             0x20...0x7e => (),
[INFO] [stderr]    |             ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: overlaps with this
[INFO] [stderr]   --> src/record_types/utils.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |             b'=' => {
[INFO] [stderr]    |             ^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/utils.rs:68:13
[INFO] [stderr]    |
[INFO] [stderr] 68 |     let s = LE::read_u32(&val[..4]) as u64;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LE::read_u32(&val[..4]))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/record_types/utils.rs:69:14
[INFO] [stderr]    |
[INFO] [stderr] 69 |     let ns = LE::read_u32(&val[4..]) as u64;
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LE::read_u32(&val[4..]))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/record_types/mod.rs:27:15
[INFO] [stderr]    |
[INFO] [stderr] 27 |         while header.len() != 0 {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!header.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]   --> src/lib.rs:89:12
[INFO] [stderr]    |
[INFO] [stderr] 89 |         if &buf != VERSION_STRING.as_bytes() {
[INFO] [stderr]    |            ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |            |
[INFO] [stderr]    |            help: use the left value directly: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:97:5
[INFO] [stderr]     |
[INFO] [stderr] 97  | /     pub fn records<'a>(&'a self) -> RecordsIterator<'a> {
[INFO] [stderr] 98  | |         let mut cursor = Cursor::new(&self.data);
[INFO] [stderr] 99  | |         cursor.seek(13).expect("13 bytes already have been read");
[INFO] [stderr] 100 | |         RecordsIterator { cursor }
[INFO] [stderr] 101 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/lib.rs:118:12
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Ok(self.cursor.seek(pos)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 118 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.23s
[INFO] running `"docker" "inspect" "301e9b2335838f67f42616c910b89a3cca454da37485452a100c69e45bbd1d00"`
[INFO] running `"docker" "rm" "-f" "301e9b2335838f67f42616c910b89a3cca454da37485452a100c69e45bbd1d00"`
[INFO] [stdout] 301e9b2335838f67f42616c910b89a3cca454da37485452a100c69e45bbd1d00