[INFO] crate rorschach 0.1.3 is already in cache [INFO] extracting crate rorschach 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/rorschach/0.1.3 [INFO] extracting crate rorschach 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rorschach/0.1.3 [INFO] validating manifest of rorschach-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rorschach-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rorschach-0.1.3 [INFO] finished frobbing rorschach-0.1.3 [INFO] frobbed toml for rorschach-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/rorschach/0.1.3/Cargo.toml [INFO] started frobbing rorschach-0.1.3 [INFO] finished frobbing rorschach-0.1.3 [INFO] frobbed toml for rorschach-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rorschach/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rorschach-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rorschach/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7532ece6dbed81cbaab45740373586d66c47ee871ec457d8e05f128186f63663 [INFO] running `"docker" "start" "-a" "7532ece6dbed81cbaab45740373586d66c47ee871ec457d8e05f128186f63663"` [INFO] [stderr] Checking ansi_term v0.8.0 [INFO] [stderr] Checking rorschach v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter/inline.rs:46:85 [INFO] [stderr] | [INFO] [stderr] 46 | let mut printer = Printer { newline: self.newline, split: self.split, printed: 0, output: output }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/formatter/inline.rs:46:85 [INFO] [stderr] | [INFO] [stderr] 46 | let mut printer = Printer { newline: self.newline, split: self.split, printed: 0, output: output }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/constant.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/garbage.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/unknown.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/padding.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/named.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/field/named.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | endian: self.endian.unwrap_or(Default::default()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.endian.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/field/mod.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 30 | | &Field::Constant(ref v) => v.bits(), [INFO] [stderr] 31 | | &Field::Garbage(ref v) => v.bits(), [INFO] [stderr] 32 | | &Field::Unknown(ref v) => v.bits(), [INFO] [stderr] 33 | | &Field::Padding(ref v) => v.bits(), [INFO] [stderr] 34 | | &Field::Named(ref v) => v.bits(), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] --> src/field/constant.rs:23:3 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 23 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Field::Constant(ref v) => v.bits(), [INFO] [stderr] 31 | Field::Garbage(ref v) => v.bits(), [INFO] [stderr] 32 | Field::Unknown(ref v) => v.bits(), [INFO] [stderr] 33 | Field::Padding(ref v) => v.bits(), [INFO] [stderr] 34 | Field::Named(ref v) => v.bits(), [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/garbage.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/unknown.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/padding.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/field/named.rs:46:3 [INFO] [stderr] | [INFO] [stderr] 46 | try!(buffer.read(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter/structured.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | match field { [INFO] [stderr] | _____________^ [INFO] [stderr] 41 | | &Field::Named(ref field) => { [INFO] [stderr] 42 | | let kind = field.kind().unwrap_or(TypeId::of::<()>()); [INFO] [stderr] 43 | | let style = self.style.and(field.style()); [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *field { [INFO] [stderr] 41 | Field::Named(ref field) => { [INFO] [stderr] 42 | let kind = field.kind().unwrap_or(TypeId::of::<()>()); [INFO] [stderr] 43 | let style = self.style.and(field.style()); [INFO] [stderr] 44 | [INFO] [stderr] 45 | if kind == TypeId::of::() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/formatter/structured.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | let kind = field.kind().unwrap_or(TypeId::of::<()>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(TypeId::of::<()>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `default` [INFO] [stderr] --> src/field/named.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | endian: self.endian.unwrap_or(Default::default()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.endian.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/field/mod.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 30 | | &Field::Constant(ref v) => v.bits(), [INFO] [stderr] 31 | | &Field::Garbage(ref v) => v.bits(), [INFO] [stderr] 32 | | &Field::Unknown(ref v) => v.bits(), [INFO] [stderr] 33 | | &Field::Padding(ref v) => v.bits(), [INFO] [stderr] 34 | | &Field::Named(ref v) => v.bits(), [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 29 | match *self { [INFO] [stderr] 30 | Field::Constant(ref v) => v.bits(), [INFO] [stderr] 31 | Field::Garbage(ref v) => v.bits(), [INFO] [stderr] 32 | Field::Unknown(ref v) => v.bits(), [INFO] [stderr] 33 | Field::Padding(ref v) => v.bits(), [INFO] [stderr] 34 | Field::Named(ref v) => v.bits(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter/structured.rs:40:4 [INFO] [stderr] | [INFO] [stderr] 40 | match field { [INFO] [stderr] | _____________^ [INFO] [stderr] 41 | | &Field::Named(ref field) => { [INFO] [stderr] 42 | | let kind = field.kind().unwrap_or(TypeId::of::<()>()); [INFO] [stderr] 43 | | let style = self.style.and(field.style()); [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 40 | match *field { [INFO] [stderr] 41 | Field::Named(ref field) => { [INFO] [stderr] 42 | let kind = field.kind().unwrap_or(TypeId::of::<()>()); [INFO] [stderr] 43 | let style = self.style.and(field.style()); [INFO] [stderr] 44 | [INFO] [stderr] 45 | if kind == TypeId::of::() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/formatter/structured.rs:42:31 [INFO] [stderr] | [INFO] [stderr] 42 | let kind = field.kind().unwrap_or(TypeId::of::<()>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(TypeId::of::<()>)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are trying to use classic C underflow conditions that will fail in Rust. [INFO] [stderr] --> src/formatter/structured.rs:209:7 [INFO] [stderr] | [INFO] [stderr] 209 | if bits - remaining > remaining { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::overflow_check_conditional)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#overflow_check_conditional [INFO] [stderr] [INFO] [stderr] warning: You are trying to use classic C underflow conditions that will fail in Rust. [INFO] [stderr] --> src/formatter/structured.rs:209:7 [INFO] [stderr] | [INFO] [stderr] 209 | if bits - remaining > remaining { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::overflow_check_conditional)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#overflow_check_conditional [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter/inline.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | match field { [INFO] [stderr] | _____________^ [INFO] [stderr] 50 | | &Field::Named(ref field) => { [INFO] [stderr] 51 | | try!(printer.print(&try!(field.read(input.by_ref())), [INFO] [stderr] 52 | | self.style.and(field.style()))); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *field { [INFO] [stderr] 50 | Field::Named(ref field) => { [INFO] [stderr] 51 | try!(printer.print(&try!(field.read(input.by_ref())), [INFO] [stderr] 52 | self.style.and(field.style()))); [INFO] [stderr] 53 | } [INFO] [stderr] 54 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/formatter/inline.rs:49:4 [INFO] [stderr] | [INFO] [stderr] 49 | match field { [INFO] [stderr] | _____________^ [INFO] [stderr] 50 | | &Field::Named(ref field) => { [INFO] [stderr] 51 | | try!(printer.print(&try!(field.read(input.by_ref())), [INFO] [stderr] 52 | | self.style.and(field.style()))); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | match *field { [INFO] [stderr] 50 | Field::Named(ref field) => { [INFO] [stderr] 51 | try!(printer.print(&try!(field.read(input.by_ref())), [INFO] [stderr] 52 | self.style.and(field.style()))); [INFO] [stderr] 53 | } [INFO] [stderr] 54 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rorschach`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `rorschach`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7532ece6dbed81cbaab45740373586d66c47ee871ec457d8e05f128186f63663"` [INFO] running `"docker" "rm" "-f" "7532ece6dbed81cbaab45740373586d66c47ee871ec457d8e05f128186f63663"` [INFO] [stdout] 7532ece6dbed81cbaab45740373586d66c47ee871ec457d8e05f128186f63663