[INFO] crate ropey 0.9.2 is already in cache [INFO] extracting crate ropey 0.9.2 into work/ex/clippy-test-run/sources/stable/reg/ropey/0.9.2 [INFO] extracting crate ropey 0.9.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ropey/0.9.2 [INFO] validating manifest of ropey-0.9.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ropey-0.9.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ropey-0.9.2 [INFO] finished frobbing ropey-0.9.2 [INFO] frobbed toml for ropey-0.9.2 written to work/ex/clippy-test-run/sources/stable/reg/ropey/0.9.2/Cargo.toml [INFO] started frobbing ropey-0.9.2 [INFO] finished frobbing ropey-0.9.2 [INFO] frobbed toml for ropey-0.9.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ropey/0.9.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ropey-0.9.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ropey/0.9.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e0fd840e03af3d77c7246529e33a89b43d67dab688c34f4918b536d8af9f6efc [INFO] running `"docker" "start" "-a" "e0fd840e03af3d77c7246529e33a89b43d67dab688c34f4918b536d8af9f6efc"` [INFO] [stderr] Checking wait-timeout v0.1.5 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking ropey v0.9.2 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:132:45 [INFO] [stderr] | [INFO] [stderr] 132 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:133:45 [INFO] [stderr] | [INFO] [stderr] 133 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:134:45 [INFO] [stderr] | [INFO] [stderr] 134 | #![cfg_attr(feature = "cargo-clippy", allow(needless_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_return` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:135:45 [INFO] [stderr] | [INFO] [stderr] 135 | #![cfg_attr(feature = "cargo-clippy", allow(redundant_field_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:136:45 [INFO] [stderr] | [INFO] [stderr] 136 | #![cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] Checking rusty-fork v0.2.1 [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:132:45 [INFO] [stderr] | [INFO] [stderr] 132 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rope.rs:88:48 [INFO] [stderr] | [INFO] [stderr] 88 | #[cfg_attr(feature = "cargo-clippy", allow(should_implement_trait))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/tree/node_children.rs:284:48 [INFO] [stderr] | [INFO] [stderr] 284 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rope.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | buffer.as_ptr().offset(valid_count as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer.as_ptr().add(valid_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:595:21 [INFO] [stderr] | [INFO] [stderr] 595 | self.nodes.as_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.nodes.as_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:596:21 [INFO] [stderr] | [INFO] [stderr] 596 | self.nodes.as_mut_ptr().offset((idx + 1) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.nodes.as_mut_ptr().add((idx + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:600:21 [INFO] [stderr] | [INFO] [stderr] 600 | self.info.as_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.info.as_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:601:21 [INFO] [stderr] | [INFO] [stderr] 601 | self.info.as_mut_ptr().offset((idx + 1) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.info.as_mut_ptr().add((idx + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:626:21 [INFO] [stderr] | [INFO] [stderr] 626 | self.nodes.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.nodes.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:631:21 [INFO] [stderr] | [INFO] [stderr] 631 | self.info.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.info.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:343:21 [INFO] [stderr] | [INFO] [stderr] 343 | self.buffer.as_ptr().offset(byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_ptr().add(byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:344:21 [INFO] [stderr] | [INFO] [stderr] 344 | self.buffer.as_mut_ptr().offset((byte_idx + amt) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_mut_ptr().add((byte_idx + amt))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | self.buffer.as_mut_ptr().offset(byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_mut_ptr().add(byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | self.buffer.as_ptr().offset(end_byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_ptr().add(end_byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:371:21 [INFO] [stderr] | [INFO] [stderr] 371 | self.buffer.as_mut_ptr().offset(start_byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_mut_ptr().add(start_byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:398:21 [INFO] [stderr] | [INFO] [stderr] 398 | self.buffer.as_ptr().offset(byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_ptr().add(byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | let end_ptr = unsafe { ptr.offset(text.len() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | let end_ptr = unsafe { start_ptr.offset(text.len() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start_ptr.add(text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:162:28 [INFO] [stderr] | [INFO] [stderr] 162 | while unsafe { ptr.offset(T::size() as isize) } < end_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:170:32 [INFO] [stderr] | [INFO] [stderr] 170 | ptr = unsafe { ptr.offset(T::size() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:284:28 [INFO] [stderr] | [INFO] [stderr] 284 | let end_ptr = unsafe { ptr.offset(len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:354:28 [INFO] [stderr] | [INFO] [stderr] 354 | let end_ptr = unsafe { ptr.offset(len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:362:28 [INFO] [stderr] | [INFO] [stderr] 362 | while unsafe { ptr.offset(T::size() as isize) } < end_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:370:32 [INFO] [stderr] | [INFO] [stderr] 370 | ptr = unsafe { ptr.offset(T::size() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:428:20 [INFO] [stderr] | [INFO] [stderr] 428 | let next_ptr = ptr.offset(T::size() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Checking proptest v0.8.7 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/simple_buffer.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> tests/clone_rope.rs:29:30 [INFO] [stderr] | [INFO] [stderr] 29 | .map(|(a, b)| a == b) [INFO] [stderr] | ______________________________^ [INFO] [stderr] 30 | | .fold(true, |acc, n| acc && n); [INFO] [stderr] | |______________________________________^ help: try: `.all(|n| n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> tests/clone_rope.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | .map(|(a, b)| a == b) [INFO] [stderr] | ______________________________^ [INFO] [stderr] 38 | | .fold(true, |acc, n| acc && n); [INFO] [stderr] | |______________________________________^ help: try: `.all(|n| n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> examples/simple_buffer.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / fn get_line<'a>(&'a self, idx: usize) -> RopeSlice<'a> { [INFO] [stderr] 28 | | self.text.line(idx) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> examples/simple_buffer.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / fn bytes<'a>(&'a self) -> Bytes<'a> { [INFO] [stderr] 32 | | self.text.bytes() [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> examples/simple_buffer.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / fn chars<'a>(&'a self) -> Chars<'a> { [INFO] [stderr] 36 | | self.text.chars() [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> examples/simple_buffer.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / fn lines<'a>(&'a self) -> Lines<'a> { [INFO] [stderr] 40 | | self.text.lines() [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> examples/simple_buffer.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / fn chunks<'a>(&'a self) -> Chunks<'a> { [INFO] [stderr] 44 | | self.text.chunks() [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> examples/simple_buffer.rs:51:12 [INFO] [stderr] | [INFO] [stderr] 51 | if text.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!text.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:132:45 [INFO] [stderr] | [INFO] [stderr] 132 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `inline_always` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:133:45 [INFO] [stderr] | [INFO] [stderr] 133 | #![cfg_attr(feature = "cargo-clippy", allow(inline_always))] [INFO] [stderr] | ^^^^^^^^^^^^^ help: change it to: `clippy::inline_always` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:134:45 [INFO] [stderr] | [INFO] [stderr] 134 | #![cfg_attr(feature = "cargo-clippy", allow(needless_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_return` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:135:45 [INFO] [stderr] | [INFO] [stderr] 135 | #![cfg_attr(feature = "cargo-clippy", allow(redundant_field_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `type_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:136:45 [INFO] [stderr] | [INFO] [stderr] 136 | #![cfg_attr(feature = "cargo-clippy", allow(type_complexity))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::type_complexity` [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> examples/graphemes_step.rs:113:1 [INFO] [stderr] | [INFO] [stderr] 113 | #[cfg_attr(rustfmt, rustfmt_skip)] // Because of the crazy long graphemes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> tests/lifetimes.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let e = rope.slice(4..500).slice(4..400).chunk_at_byte(50); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> tests/lifetimes.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let f = rope.slice(4..500).slice(4..400).chunk_at_char(50); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> tests/lifetimes.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let g = rope.slice(4..500).slice(4..400).chunk_at_line_break(3); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> tests/lifetimes.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | let (a, b, c, d, e, f, g, count, line, string) = { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> tests/lifetimes.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | let (a, b, c, d, e, f, g, count, line, string) = { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> tests/lifetimes.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | let (a, b, c, d, e, f, g, count, line, string) = { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> tests/clone_rope_to_thread.rs:52:30 [INFO] [stderr] | [INFO] [stderr] 52 | .map(|(a, b)| a == b) [INFO] [stderr] | ______________________________^ [INFO] [stderr] 53 | | .fold(true, |acc, n| acc && n); [INFO] [stderr] | |______________________________________^ help: try: `.all(|n| n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> tests/clone_rope_to_thread.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | .map(|(a, b)| a == b) [INFO] [stderr] | ______________________________^ [INFO] [stderr] 63 | | .fold(true, |acc, n| acc && n); [INFO] [stderr] | |______________________________________^ help: try: `.all(|n| n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> examples/graphemes_iter.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | chunks: chunks, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `chunks` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> examples/graphemes_iter.rs:75:1 [INFO] [stderr] | [INFO] [stderr] 75 | #[cfg_attr(rustfmt, rustfmt_skip)] // Because of the crazy long graphemes [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `collapsible_if` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:132:45 [INFO] [stderr] | [INFO] [stderr] 132 | #![cfg_attr(feature = "cargo-clippy", allow(collapsible_if))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::collapsible_if` [INFO] [stderr] [INFO] [stderr] warning: lint name `should_implement_trait` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/rope.rs:88:48 [INFO] [stderr] | [INFO] [stderr] 88 | #[cfg_attr(feature = "cargo-clippy", allow(should_implement_trait))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::should_implement_trait` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/tree/node_children.rs:284:48 [INFO] [stderr] | [INFO] [stderr] 284 | #[cfg_attr(feature = "cargo-clippy", allow(needless_range_loop))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:234:57 [INFO] [stderr] | [INFO] [stderr] 234 | fn pt_shrink_to_fit_01(ref char_idxs in vec(0usize..1000000, 0..1000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:257:57 [INFO] [stderr] | [INFO] [stderr] 257 | fn pt_shrink_to_fit_02(ref char_idxs in vec(0usize..1000000, 0..1000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:370:92 [INFO] [stderr] | [INFO] [stderr] 370 | fn pt_chunk_at_byte_slice(ref gen_text in "\\PC*\\n?\\PC*\\n?\\PC*", range in (0usize..1000000, 0usize..1000000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:370:109 [INFO] [stderr] | [INFO] [stderr] 370 | fn pt_chunk_at_byte_slice(ref gen_text in "\\PC*\\n?\\PC*\\n?\\PC*", range in (0usize..1000000, 0usize..1000000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:408:92 [INFO] [stderr] | [INFO] [stderr] 408 | fn pt_chunk_at_char_slice(ref gen_text in "\\PC*\\n?\\PC*\\n?\\PC*", range in (0usize..1000000, 0usize..1000000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:408:109 [INFO] [stderr] | [INFO] [stderr] 408 | fn pt_chunk_at_char_slice(ref gen_text in "\\PC*\\n?\\PC*\\n?\\PC*", range in (0usize..1000000, 0usize..1000000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:441:98 [INFO] [stderr] | [INFO] [stderr] 441 | fn pt_chunk_at_line_break_slice(ref gen_text in "\\PC*\\n?\\PC*\\n?\\PC*", range in (0usize..1000000, 0usize..1000000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:441:115 [INFO] [stderr] | [INFO] [stderr] 441 | fn pt_chunk_at_line_break_slice(ref gen_text in "\\PC*\\n?\\PC*\\n?\\PC*", range in (0usize..1000000, 0usize..1000000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:481:56 [INFO] [stderr] | [INFO] [stderr] 481 | fn pt_slice(ref text in "\\PC*", range in (0usize..1000000, 0usize..1000000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/quickcheck_tests.rs:481:73 [INFO] [stderr] | [INFO] [stderr] 481 | fn pt_slice(ref text in "\\PC*", range in (0usize..1000000, 0usize..1000000)) { [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/quickcheck_tests.rs:178:30 [INFO] [stderr] | [INFO] [stderr] 178 | fn pt_insert(char_idx in 0usize..(CHAR_LEN+1), ref ins_text in "\\PC*") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=CHAR_LEN` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/quickcheck_tests.rs:193:28 [INFO] [stderr] | [INFO] [stderr] 193 | fn pt_remove(range in (0usize..(CHAR_LEN+1), 0usize..(CHAR_LEN+1))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=CHAR_LEN` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/quickcheck_tests.rs:193:50 [INFO] [stderr] | [INFO] [stderr] 193 | fn pt_remove(range in (0usize..(CHAR_LEN+1), 0usize..(CHAR_LEN+1))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=CHAR_LEN` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/quickcheck_tests.rs:213:43 [INFO] [stderr] | [INFO] [stderr] 213 | fn pt_split_off_and_append(mut idx in 0usize..(CHAR_LEN+1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0usize..=CHAR_LEN` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/crlf.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | assert!(is_break(0, "".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/crlf.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | let text = "Hello world!".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Hello world!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/rope.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | buffer.as_ptr().offset(valid_count as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `buffer.as_ptr().add(valid_count)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:595:21 [INFO] [stderr] | [INFO] [stderr] 595 | self.nodes.as_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.nodes.as_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:596:21 [INFO] [stderr] | [INFO] [stderr] 596 | self.nodes.as_mut_ptr().offset((idx + 1) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.nodes.as_mut_ptr().add((idx + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:600:21 [INFO] [stderr] | [INFO] [stderr] 600 | self.info.as_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.info.as_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:601:21 [INFO] [stderr] | [INFO] [stderr] 601 | self.info.as_mut_ptr().offset((idx + 1) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.info.as_mut_ptr().add((idx + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:626:21 [INFO] [stderr] | [INFO] [stderr] 626 | self.nodes.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.nodes.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_children.rs:631:21 [INFO] [stderr] | [INFO] [stderr] 631 | self.info.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.info.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/tree/node_children.rs:770:5 [INFO] [stderr] | [INFO] [stderr] 770 | / fn search_char_idx_range_01() { [INFO] [stderr] 771 | | let mut children = NodeChildren::new(); [INFO] [stderr] 772 | | children.push(( [INFO] [stderr] 773 | | TextInfo::new(), [INFO] [stderr] ... | [INFO] [stderr] 844 | | assert_eq!(12, (at_11_13.1).1); [INFO] [stderr] 845 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:343:21 [INFO] [stderr] | [INFO] [stderr] 343 | self.buffer.as_ptr().offset(byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_ptr().add(byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:344:21 [INFO] [stderr] | [INFO] [stderr] 344 | self.buffer.as_mut_ptr().offset((byte_idx + amt) as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_mut_ptr().add((byte_idx + amt))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:349:21 [INFO] [stderr] | [INFO] [stderr] 349 | self.buffer.as_mut_ptr().offset(byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_mut_ptr().add(byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:370:21 [INFO] [stderr] | [INFO] [stderr] 370 | self.buffer.as_ptr().offset(end_byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_ptr().add(end_byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:371:21 [INFO] [stderr] | [INFO] [stderr] 371 | self.buffer.as_mut_ptr().offset(start_byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_mut_ptr().add(start_byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tree/node_text.rs:398:21 [INFO] [stderr] | [INFO] [stderr] 398 | self.buffer.as_ptr().offset(byte_idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.as_ptr().add(byte_idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | let end_ptr = unsafe { ptr.offset(text.len() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:155:28 [INFO] [stderr] | [INFO] [stderr] 155 | let end_ptr = unsafe { start_ptr.offset(text.len() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start_ptr.add(text.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:162:28 [INFO] [stderr] | [INFO] [stderr] 162 | while unsafe { ptr.offset(T::size() as isize) } < end_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:170:32 [INFO] [stderr] | [INFO] [stderr] 170 | ptr = unsafe { ptr.offset(T::size() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:284:28 [INFO] [stderr] | [INFO] [stderr] 284 | let end_ptr = unsafe { ptr.offset(len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:354:28 [INFO] [stderr] | [INFO] [stderr] 354 | let end_ptr = unsafe { ptr.offset(len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:362:28 [INFO] [stderr] | [INFO] [stderr] 362 | while unsafe { ptr.offset(T::size() as isize) } < end_ptr { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:370:32 [INFO] [stderr] | [INFO] [stderr] 370 | ptr = unsafe { ptr.offset(T::size() as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/str_utils.rs:428:20 [INFO] [stderr] | [INFO] [stderr] 428 | let next_ptr = ptr.offset(T::size() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(T::size())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.54s [INFO] running `"docker" "inspect" "e0fd840e03af3d77c7246529e33a89b43d67dab688c34f4918b536d8af9f6efc"` [INFO] running `"docker" "rm" "-f" "e0fd840e03af3d77c7246529e33a89b43d67dab688c34f4918b536d8af9f6efc"` [INFO] [stdout] e0fd840e03af3d77c7246529e33a89b43d67dab688c34f4918b536d8af9f6efc