[INFO] crate root-io 0.1.1 is already in cache [INFO] extracting crate root-io 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/root-io/0.1.1 [INFO] extracting crate root-io 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/root-io/0.1.1 [INFO] validating manifest of root-io-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of root-io-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing root-io-0.1.1 [INFO] finished frobbing root-io-0.1.1 [INFO] frobbed toml for root-io-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/root-io/0.1.1/Cargo.toml [INFO] started frobbing root-io-0.1.1 [INFO] finished frobbing root-io-0.1.1 [INFO] frobbed toml for root-io-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/root-io/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting root-io-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/root-io/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ed50c7db2d4a930949ade792f53092b9ad00b0469f44c3789077c00842b6de21 [INFO] running `"docker" "start" "-a" "ed50c7db2d4a930949ade792f53092b9ad00b0469f44c3789077c00842b6de21"` [INFO] [stderr] Compiling lzma-sys v0.1.13 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Checking root-io v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/file_item.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | s: s}; [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree_reader/column_fixed_into_iter.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | containers: containers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `containers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree_reader/column_var_into_iter.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | containers: containers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `containers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/core/file_item.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | s: s}; [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree_reader/column_fixed_into_iter.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | containers: containers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `containers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree_reader/column_var_into_iter.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | containers: containers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `containers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/file.rs:287:19 [INFO] [stderr] | [INFO] [stderr] 287 | uuid: 409442932018821, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `409_442_932_018_821` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/file.rs:303:21 [INFO] [stderr] | [INFO] [stderr] 303 | c_time: 1418768412, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_418_768_412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/core/file.rs:304:21 [INFO] [stderr] | [INFO] [stderr] 304 | m_time: 1418768412, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_418_768_412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / do_parse!(input, [INFO] [stderr] 45 | | len: switch!(be_u8, [INFO] [stderr] 46 | | 255 => call!(be_u32) | [INFO] [stderr] 47 | | a => value!(u32::from(a))) >> [INFO] [stderr] ... | [INFO] [stderr] 51 | | (s) [INFO] [stderr] 52 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/core/parsers.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn tlist<'s, 'c>(input: &'s[u8], context: &'c Context) -> nom::IResult<&'s[u8], TList<'c>> [INFO] [stderr] 73 | | where 's: 'c [INFO] [stderr] 74 | | { [INFO] [stderr] 75 | | let wrapped_raw = |i| raw(i, context); [INFO] [stderr] ... | [INFO] [stderr] 98 | | }})) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core/parsers.rs:213:50 [INFO] [stderr] | [INFO] [stderr] 213 | value!(!is_byte_count(bcnt) || bcnt as u64 == Flags::NEW_CLASSTAG.bits()), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(bcnt)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / do_parse!(input, [INFO] [stderr] 211 | | bcnt: be_u32 >> [INFO] [stderr] 212 | | tag: switch!( [INFO] [stderr] 213 | | value!(!is_byte_count(bcnt) || bcnt as u64 == Flags::NEW_CLASSTAG.bits()), [INFO] [stderr] ... | [INFO] [stderr] 226 | | (cl) [INFO] [stderr] 227 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / do_parse!(input, [INFO] [stderr] 211 | | bcnt: be_u32 >> [INFO] [stderr] 212 | | tag: switch!( [INFO] [stderr] 213 | | value!(!is_byte_count(bcnt) || bcnt as u64 == Flags::NEW_CLASSTAG.bits()), [INFO] [stderr] ... | [INFO] [stderr] 226 | | (cl) [INFO] [stderr] 227 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / do_parse!(input, [INFO] [stderr] 211 | | bcnt: be_u32 >> [INFO] [stderr] 212 | | tag: switch!( [INFO] [stderr] 213 | | value!(!is_byte_count(bcnt) || bcnt as u64 == Flags::NEW_CLASSTAG.bits()), [INFO] [stderr] ... | [INFO] [stderr] 226 | | (cl) [INFO] [stderr] 227 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/core/parsers.rs:236:1 [INFO] [stderr] | [INFO] [stderr] 236 | / pub fn class_name_and_buffer<'s, 'c>(input: &'s[u8], context: &'c Context) [INFO] [stderr] 237 | | -> nom::IResult<&'s[u8], (String, &'c[u8])> [INFO] [stderr] 238 | | where 's: 'c [INFO] [stderr] 239 | | { [INFO] [stderr] ... | [INFO] [stderr] 263 | | ) [INFO] [stderr] 264 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | / do_parse!(input, [INFO] [stderr] 257 | | ci: switch!(classinfo, [INFO] [stderr] 258 | | ClassInfo::New(s) => tuple!(value!(s), length_value!(checked_byte_count, call!(nom::rest))) | [INFO] [stderr] 259 | | ClassInfo::Exists(tag) => tuple!(value!(get_name_elsewhere(tag)), [INFO] [stderr] ... | [INFO] [stderr] 262 | | (ci) [INFO] [stderr] 263 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 76 [INFO] [stderr] --> src/core/tstreamer.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub(crate) fn tstreamer<'c>(raw: &Raw<'c>) -> IResult<&'c[u8], TStreamer> [INFO] [stderr] 91 | | { [INFO] [stderr] 92 | | let wrapped_tstreamerelem = |i| length_value!(i, checked_byte_count, tstreamerelement); [INFO] [stderr] 93 | | match raw.classinfo.as_str() { [INFO] [stderr] ... | [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/tstreamer.rs:157:1 [INFO] [stderr] | [INFO] [stderr] 157 | / named!( [INFO] [stderr] 158 | | tstreamerelement<&[u8], TStreamerElement>, [INFO] [stderr] 159 | | do_parse!(ver: be_u16 >> [INFO] [stderr] 160 | | name: length_value!(checked_byte_count, tnamed) >> [INFO] [stderr] ... | [INFO] [stderr] 179 | | ) [INFO] [stderr] 180 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | / match self { [INFO] [stderr] 187 | | &Base{ref el, ..} | &BasicType{ref el} | &BasicPointer{ref el, ..} | &Loop{ref el, ..} [INFO] [stderr] 188 | | | &Object{ref el} | &ObjectPointer{ref el} | &ObjectAny{ref el} | &ObjectAnyPointer{ref el} [INFO] [stderr] 189 | | | &String{ref el} | &Stl{ref el, ..} | &StlString{ref el, ..} => el, [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | match *self { [INFO] [stderr] 187 | Base{ref el, ..} | BasicType{ref el} | BasicPointer{ref el, ..} | Loop{ref el, ..} [INFO] [stderr] 188 | | Object{ref el} | ObjectPointer{ref el} | ObjectAny{ref el} | ObjectAnyPointer{ref el} [INFO] [stderr] 189 | | String{ref el} | Stl{ref el, ..} | StlString{ref el, ..} => el, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | / match self { [INFO] [stderr] 223 | | &TStreamer::Base {ref el, ..} => { [INFO] [stderr] 224 | | match el.el_type { [INFO] [stderr] 225 | | Object | Base | Named | TObject => quote!{#name}, [INFO] [stderr] ... | [INFO] [stderr] 290 | | _ => panic!("{:#?}", self), [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | match *self { [INFO] [stderr] 223 | TStreamer::Base {ref el, ..} => { [INFO] [stderr] 224 | match el.el_type { [INFO] [stderr] 225 | Object | Base | Named | TObject => quote!{#name}, [INFO] [stderr] 226 | // Not sure about the following branch... [INFO] [stderr] 227 | InvalidOrCounter(-1) => quote!{#name}, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | / match vtype { [INFO] [stderr] 282 | | &StlTypeID::Vector => { [INFO] [stderr] 283 | | quote!{Stl_vec} [INFO] [stderr] 284 | | }, [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 281 | match *vtype { [INFO] [stderr] 282 | StlTypeID::Vector => { [INFO] [stderr] 283 | quote!{Stl_vec} [INFO] [stderr] 284 | }, [INFO] [stderr] 285 | StlTypeID::Bitset => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:298:20 [INFO] [stderr] | [INFO] [stderr] 298 | let name = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 299 | | // `Base` types, i.e. types from which the current object inherited; [INFO] [stderr] 300 | | // In that case the name is actually the type [INFO] [stderr] 301 | | &TStreamer::Base{..} => &self.elem().name.name, [INFO] [stderr] 302 | | _ => &self.elem().type_name, [INFO] [stderr] 303 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 298 | let name = match *self { [INFO] [stderr] 299 | // `Base` types, i.e. types from which the current object inherited; [INFO] [stderr] 300 | // In that case the name is actually the type [INFO] [stderr] 301 | TStreamer::Base{..} => &self.elem().name.name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | / match self { [INFO] [stderr] 315 | | &TStreamer::Base {ref el, ..} => { [INFO] [stderr] 316 | | match el.el_type { [INFO] [stderr] 317 | | Object | Base | Named => quote!{length_value!(checked_byte_count, #name)}, [INFO] [stderr] ... | [INFO] [stderr] 390 | | _ => panic!("{:#?}", self), [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 314 | match *self { [INFO] [stderr] 315 | TStreamer::Base {ref el, ..} => { [INFO] [stderr] 316 | match el.el_type { [INFO] [stderr] 317 | Object | Base | Named => quote!{length_value!(checked_byte_count, #name)}, [INFO] [stderr] 318 | TObject => quote!{#name}, [INFO] [stderr] 319 | InvalidOrCounter(-1) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | / match vtype { [INFO] [stderr] 382 | | &StlTypeID::Vector => { [INFO] [stderr] 383 | | quote!{stl_vec} [INFO] [stderr] 384 | | }, [INFO] [stderr] ... | [INFO] [stderr] 387 | | } [INFO] [stderr] 388 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 381 | match *vtype { [INFO] [stderr] 382 | StlTypeID::Vector => { [INFO] [stderr] 383 | quote!{stl_vec} [INFO] [stderr] 384 | }, [INFO] [stderr] 385 | StlTypeID::Bitset => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/core/tstreamerinfo.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / pub(crate) fn tstreamerinfo<'s, 'c>(input: &'s[u8], context: &'c Context) -> IResult<&'s[u8], TStreamerInfo> [INFO] [stderr] 20 | | where 's: 'c [INFO] [stderr] 21 | | { [INFO] [stderr] 22 | | let wrapped_tobjarray = |i| tobjarray(i, &context); [INFO] [stderr] ... | [INFO] [stderr] 51 | | ) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/typeid.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | let t = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 89 | | &Primitive(ref id) | &Offset(ref id) => id.type_name().to_string(), [INFO] [stderr] 90 | | &Array(ref id) => format!("Vec<{}>", id.type_name().to_string()), [INFO] [stderr] 91 | | // "kObjectP"; might be null! [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => panic!("{:?}: type not implemented, yet", self), [INFO] [stderr] 100 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | let t = match *self { [INFO] [stderr] 89 | Primitive(ref id) | Offset(ref id) => id.type_name().to_string(), [INFO] [stderr] 90 | Array(ref id) => format!("Vec<{}>", id.type_name().to_string()), [INFO] [stderr] 91 | // "kObjectP"; might be null! [INFO] [stderr] 92 | ObjectP => "Option>".to_string(), [INFO] [stderr] 93 | String => "String".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/tree_reader/branch.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | .chain([self.fentries].into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 82 [INFO] [stderr] --> src/tree_reader/branch.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / fn tbranch<'s>(input: &'s [u8], context: & Context<'s>) -> IResult<&'s [u8], TBranch> { [INFO] [stderr] 111 | | let _curried_raw = |i| raw(i, context); [INFO] [stderr] 112 | | let wrapped_tobjarray = |i: &'s[u8]| length_value!(i, checked_byte_count, apply!(tobjarray, context)); [INFO] [stderr] 113 | | do_parse!(input, [INFO] [stderr] ... | [INFO] [stderr] 183 | | })) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/tree_reader/leafs.rs:169:1 [INFO] [stderr] | [INFO] [stderr] 169 | / fn tleafbase<'s>(input: &'s [u8], context: &'s Context<'s>) -> IResult<&'s [u8], TLeafBase> { [INFO] [stderr] 170 | | let _curried_raw = |i| raw(i, context); [INFO] [stderr] 171 | | do_parse!(input, [INFO] [stderr] 172 | | ver: be_u16 >> [INFO] [stderr] ... | [INFO] [stderr] 195 | | fleafcount } })) [INFO] [stderr] 196 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tree_reader/leafs.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / do_parse!(input, [INFO] [stderr] 172 | | ver: be_u16 >> [INFO] [stderr] 173 | | tnamed: length_value!(checked_byte_count, [INFO] [stderr] 174 | | tnamed) >> [INFO] [stderr] ... | [INFO] [stderr] 194 | | fisunsigned, [INFO] [stderr] 195 | | fleafcount } })) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 97 [INFO] [stderr] --> src/tree_reader/tree.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn ttree<'s>(input: &'s[u8], context: &Context) -> IResult<&'s[u8], Tree> { [INFO] [stderr] 107 | | let _curried_raw = |i| raw(i, context); [INFO] [stderr] 108 | | let none_or_u8_buf = |i: &'s [u8]| switch!(i, peek!(be_u32), [INFO] [stderr] 109 | | 0 => map!(call!(be_u32), | _ | None) | [INFO] [stderr] ... | [INFO] [stderr] 186 | | fbranchref } })) [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tree_reader/tree.rs:108:40 [INFO] [stderr] | [INFO] [stderr] 108 | let none_or_u8_buf = |i: &'s [u8]| switch!(i, peek!(be_u32), [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 109 | | 0 => map!(call!(be_u32), | _ | None) | [INFO] [stderr] 110 | | _ => map!( [INFO] [stderr] 111 | | map!(call!(_curried_raw), |r| r.obj.to_vec()), [INFO] [stderr] 112 | | Some)); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `root-io`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / do_parse!(input, [INFO] [stderr] 45 | | len: switch!(be_u8, [INFO] [stderr] 46 | | 255 => call!(be_u32) | [INFO] [stderr] 47 | | a => value!(u32::from(a))) >> [INFO] [stderr] ... | [INFO] [stderr] 51 | | (s) [INFO] [stderr] 52 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/core/parsers.rs:72:1 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn tlist<'s, 'c>(input: &'s[u8], context: &'c Context) -> nom::IResult<&'s[u8], TList<'c>> [INFO] [stderr] 73 | | where 's: 'c [INFO] [stderr] 74 | | { [INFO] [stderr] 75 | | let wrapped_raw = |i| raw(i, context); [INFO] [stderr] ... | [INFO] [stderr] 98 | | }})) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/core/parsers.rs:213:50 [INFO] [stderr] | [INFO] [stderr] 213 | value!(!is_byte_count(bcnt) || bcnt as u64 == Flags::NEW_CLASSTAG.bits()), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(bcnt)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / do_parse!(input, [INFO] [stderr] 211 | | bcnt: be_u32 >> [INFO] [stderr] 212 | | tag: switch!( [INFO] [stderr] 213 | | value!(!is_byte_count(bcnt) || bcnt as u64 == Flags::NEW_CLASSTAG.bits()), [INFO] [stderr] ... | [INFO] [stderr] 226 | | (cl) [INFO] [stderr] 227 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / do_parse!(input, [INFO] [stderr] 211 | | bcnt: be_u32 >> [INFO] [stderr] 212 | | tag: switch!( [INFO] [stderr] 213 | | value!(!is_byte_count(bcnt) || bcnt as u64 == Flags::NEW_CLASSTAG.bits()), [INFO] [stderr] ... | [INFO] [stderr] 226 | | (cl) [INFO] [stderr] 227 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / do_parse!(input, [INFO] [stderr] 211 | | bcnt: be_u32 >> [INFO] [stderr] 212 | | tag: switch!( [INFO] [stderr] 213 | | value!(!is_byte_count(bcnt) || bcnt as u64 == Flags::NEW_CLASSTAG.bits()), [INFO] [stderr] ... | [INFO] [stderr] 226 | | (cl) [INFO] [stderr] 227 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/core/parsers.rs:236:1 [INFO] [stderr] | [INFO] [stderr] 236 | / pub fn class_name_and_buffer<'s, 'c>(input: &'s[u8], context: &'c Context) [INFO] [stderr] 237 | | -> nom::IResult<&'s[u8], (String, &'c[u8])> [INFO] [stderr] 238 | | where 's: 'c [INFO] [stderr] 239 | | { [INFO] [stderr] ... | [INFO] [stderr] 263 | | ) [INFO] [stderr] 264 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/parsers.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | / do_parse!(input, [INFO] [stderr] 257 | | ci: switch!(classinfo, [INFO] [stderr] 258 | | ClassInfo::New(s) => tuple!(value!(s), length_value!(checked_byte_count, call!(nom::rest))) | [INFO] [stderr] 259 | | ClassInfo::Exists(tag) => tuple!(value!(get_name_elsewhere(tag)), [INFO] [stderr] ... | [INFO] [stderr] 262 | | (ci) [INFO] [stderr] 263 | | ) [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 76 [INFO] [stderr] --> src/core/tstreamer.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub(crate) fn tstreamer<'c>(raw: &Raw<'c>) -> IResult<&'c[u8], TStreamer> [INFO] [stderr] 91 | | { [INFO] [stderr] 92 | | let wrapped_tstreamerelem = |i| length_value!(i, checked_byte_count, tstreamerelement); [INFO] [stderr] 93 | | match raw.classinfo.as_str() { [INFO] [stderr] ... | [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/core/tstreamer.rs:157:1 [INFO] [stderr] | [INFO] [stderr] 157 | / named!( [INFO] [stderr] 158 | | tstreamerelement<&[u8], TStreamerElement>, [INFO] [stderr] 159 | | do_parse!(ver: be_u16 >> [INFO] [stderr] 160 | | name: length_value!(checked_byte_count, tnamed) >> [INFO] [stderr] ... | [INFO] [stderr] 179 | | ) [INFO] [stderr] 180 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:186:9 [INFO] [stderr] | [INFO] [stderr] 186 | / match self { [INFO] [stderr] 187 | | &Base{ref el, ..} | &BasicType{ref el} | &BasicPointer{ref el, ..} | &Loop{ref el, ..} [INFO] [stderr] 188 | | | &Object{ref el} | &ObjectPointer{ref el} | &ObjectAny{ref el} | &ObjectAnyPointer{ref el} [INFO] [stderr] 189 | | | &String{ref el} | &Stl{ref el, ..} | &StlString{ref el, ..} => el, [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 186 | match *self { [INFO] [stderr] 187 | Base{ref el, ..} | BasicType{ref el} | BasicPointer{ref el, ..} | Loop{ref el, ..} [INFO] [stderr] 188 | | Object{ref el} | ObjectPointer{ref el} | ObjectAny{ref el} | ObjectAnyPointer{ref el} [INFO] [stderr] 189 | | String{ref el} | Stl{ref el, ..} | StlString{ref el, ..} => el, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | / match self { [INFO] [stderr] 223 | | &TStreamer::Base {ref el, ..} => { [INFO] [stderr] 224 | | match el.el_type { [INFO] [stderr] 225 | | Object | Base | Named | TObject => quote!{#name}, [INFO] [stderr] ... | [INFO] [stderr] 290 | | _ => panic!("{:#?}", self), [INFO] [stderr] 291 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 222 | match *self { [INFO] [stderr] 223 | TStreamer::Base {ref el, ..} => { [INFO] [stderr] 224 | match el.el_type { [INFO] [stderr] 225 | Object | Base | Named | TObject => quote!{#name}, [INFO] [stderr] 226 | // Not sure about the following branch... [INFO] [stderr] 227 | InvalidOrCounter(-1) => quote!{#name}, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | / match vtype { [INFO] [stderr] 282 | | &StlTypeID::Vector => { [INFO] [stderr] 283 | | quote!{Stl_vec} [INFO] [stderr] 284 | | }, [INFO] [stderr] ... | [INFO] [stderr] 287 | | } [INFO] [stderr] 288 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 281 | match *vtype { [INFO] [stderr] 282 | StlTypeID::Vector => { [INFO] [stderr] 283 | quote!{Stl_vec} [INFO] [stderr] 284 | }, [INFO] [stderr] 285 | StlTypeID::Bitset => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:298:20 [INFO] [stderr] | [INFO] [stderr] 298 | let name = match self { [INFO] [stderr] | ____________________^ [INFO] [stderr] 299 | | // `Base` types, i.e. types from which the current object inherited; [INFO] [stderr] 300 | | // In that case the name is actually the type [INFO] [stderr] 301 | | &TStreamer::Base{..} => &self.elem().name.name, [INFO] [stderr] 302 | | _ => &self.elem().type_name, [INFO] [stderr] 303 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 298 | let name = match *self { [INFO] [stderr] 299 | // `Base` types, i.e. types from which the current object inherited; [INFO] [stderr] 300 | // In that case the name is actually the type [INFO] [stderr] 301 | TStreamer::Base{..} => &self.elem().name.name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | / match self { [INFO] [stderr] 315 | | &TStreamer::Base {ref el, ..} => { [INFO] [stderr] 316 | | match el.el_type { [INFO] [stderr] 317 | | Object | Base | Named => quote!{length_value!(checked_byte_count, #name)}, [INFO] [stderr] ... | [INFO] [stderr] 390 | | _ => panic!("{:#?}", self), [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 314 | match *self { [INFO] [stderr] 315 | TStreamer::Base {ref el, ..} => { [INFO] [stderr] 316 | match el.el_type { [INFO] [stderr] 317 | Object | Base | Named => quote!{length_value!(checked_byte_count, #name)}, [INFO] [stderr] 318 | TObject => quote!{#name}, [INFO] [stderr] 319 | InvalidOrCounter(-1) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/tstreamer.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | / match vtype { [INFO] [stderr] 382 | | &StlTypeID::Vector => { [INFO] [stderr] 383 | | quote!{stl_vec} [INFO] [stderr] 384 | | }, [INFO] [stderr] ... | [INFO] [stderr] 387 | | } [INFO] [stderr] 388 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 381 | match *vtype { [INFO] [stderr] 382 | StlTypeID::Vector => { [INFO] [stderr] 383 | quote!{stl_vec} [INFO] [stderr] 384 | }, [INFO] [stderr] 385 | StlTypeID::Bitset => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/core/tstreamerinfo.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / pub(crate) fn tstreamerinfo<'s, 'c>(input: &'s[u8], context: &'c Context) -> IResult<&'s[u8], TStreamerInfo> [INFO] [stderr] 20 | | where 's: 'c [INFO] [stderr] 21 | | { [INFO] [stderr] 22 | | let wrapped_tobjarray = |i| tobjarray(i, &context); [INFO] [stderr] ... | [INFO] [stderr] 51 | | ) [INFO] [stderr] 52 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/core/typeid.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | let t = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 89 | | &Primitive(ref id) | &Offset(ref id) => id.type_name().to_string(), [INFO] [stderr] 90 | | &Array(ref id) => format!("Vec<{}>", id.type_name().to_string()), [INFO] [stderr] 91 | | // "kObjectP"; might be null! [INFO] [stderr] ... | [INFO] [stderr] 99 | | _ => panic!("{:?}: type not implemented, yet", self), [INFO] [stderr] 100 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | let t = match *self { [INFO] [stderr] 89 | Primitive(ref id) | Offset(ref id) => id.type_name().to_string(), [INFO] [stderr] 90 | Array(ref id) => format!("Vec<{}>", id.type_name().to_string()), [INFO] [stderr] 91 | // "kObjectP"; might be null! [INFO] [stderr] 92 | ObjectP => "Option>".to_string(), [INFO] [stderr] 93 | String => "String".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/tree_reader/branch.rs:88:36 [INFO] [stderr] | [INFO] [stderr] 88 | .chain([self.fentries].into_iter()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 82 [INFO] [stderr] --> src/tree_reader/branch.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / fn tbranch<'s>(input: &'s [u8], context: & Context<'s>) -> IResult<&'s [u8], TBranch> { [INFO] [stderr] 111 | | let _curried_raw = |i| raw(i, context); [INFO] [stderr] 112 | | let wrapped_tobjarray = |i: &'s[u8]| length_value!(i, checked_byte_count, apply!(tobjarray, context)); [INFO] [stderr] 113 | | do_parse!(input, [INFO] [stderr] ... | [INFO] [stderr] 183 | | })) [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/tree_reader/leafs.rs:169:1 [INFO] [stderr] | [INFO] [stderr] 169 | / fn tleafbase<'s>(input: &'s [u8], context: &'s Context<'s>) -> IResult<&'s [u8], TLeafBase> { [INFO] [stderr] 170 | | let _curried_raw = |i| raw(i, context); [INFO] [stderr] 171 | | do_parse!(input, [INFO] [stderr] 172 | | ver: be_u16 >> [INFO] [stderr] ... | [INFO] [stderr] 195 | | fleafcount } })) [INFO] [stderr] 196 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tree_reader/leafs.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / do_parse!(input, [INFO] [stderr] 172 | | ver: be_u16 >> [INFO] [stderr] 173 | | tnamed: length_value!(checked_byte_count, [INFO] [stderr] 174 | | tnamed) >> [INFO] [stderr] ... | [INFO] [stderr] 194 | | fisunsigned, [INFO] [stderr] 195 | | fleafcount } })) [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 97 [INFO] [stderr] --> src/tree_reader/tree.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn ttree<'s>(input: &'s[u8], context: &Context) -> IResult<&'s[u8], Tree> { [INFO] [stderr] 107 | | let _curried_raw = |i| raw(i, context); [INFO] [stderr] 108 | | let none_or_u8_buf = |i: &'s [u8]| switch!(i, peek!(be_u32), [INFO] [stderr] 109 | | 0 => map!(call!(be_u32), | _ | None) | [INFO] [stderr] ... | [INFO] [stderr] 186 | | fbranchref } })) [INFO] [stderr] 187 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tree_reader/tree.rs:108:40 [INFO] [stderr] | [INFO] [stderr] 108 | let none_or_u8_buf = |i: &'s [u8]| switch!(i, peek!(be_u32), [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 109 | | 0 => map!(call!(be_u32), | _ | None) | [INFO] [stderr] 110 | | _ => map!( [INFO] [stderr] 111 | | map!(call!(_curried_raw), |r| r.obj.to_vec()), [INFO] [stderr] 112 | | Some)); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tests/read_simple.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | for m in schema.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `schema` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tests/read_esd.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | let mut s = exp as u32; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(exp)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/tests/read_esd.rs:122:15 [INFO] [stderr] | [INFO] [stderr] 122 | s |= (man as u32 & ((1<<(nbits+1))-1)) <<(23-nbits); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(man)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/tests/high_level_io.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | .map(|p| PathBuf::from(p)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/tests/high_level_io.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | ].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `root-io`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ed50c7db2d4a930949ade792f53092b9ad00b0469f44c3789077c00842b6de21"` [INFO] running `"docker" "rm" "-f" "ed50c7db2d4a930949ade792f53092b9ad00b0469f44c3789077c00842b6de21"` [INFO] [stdout] ed50c7db2d4a930949ade792f53092b9ad00b0469f44c3789077c00842b6de21