[INFO] crate roller 0.1.0 is already in cache [INFO] extracting crate roller 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/roller/0.1.0 [INFO] extracting crate roller 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/roller/0.1.0 [INFO] validating manifest of roller-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of roller-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing roller-0.1.0 [INFO] finished frobbing roller-0.1.0 [INFO] frobbed toml for roller-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/roller/0.1.0/Cargo.toml [INFO] started frobbing roller-0.1.0 [INFO] finished frobbing roller-0.1.0 [INFO] frobbed toml for roller-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/roller/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting roller-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/roller/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49efe0b09d884e1882a4c527f160048a843e0da7fa18e4002b2e3ecacb0da808 [INFO] running `"docker" "start" "-a" "49efe0b09d884e1882a4c527f160048a843e0da7fa18e4002b2e3ecacb0da808"` [INFO] [stderr] Checking roller v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | const INDEX_PATH: &'static str = ".roller_index.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | const CONFIG_PATH: &'static str = ".roller_config.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | if &file_extension != extension { [INFO] [stderr] | ---------------^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `file_extension` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | Err(_) => panic!("couldn't open file to get hash: {}", path), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | / match file.read_to_string(&mut s) { [INFO] [stderr] 173 | | Err(_) => panic!("couldn't read file to string: {}", path), [INFO] [stderr] 174 | | Ok(_) => (), [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = file.read_to_string(&mut s) { panic!("couldn't read file to string: {}", path) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | Err(_) => panic!("couldn't read file to string: {}", path), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / match write!(file, "{}", encoded) { [INFO] [stderr] 189 | | Err(_) => panic!(), [INFO] [stderr] 190 | | Ok(_) => (), [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ) { panic!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | const INDEX_PATH: &'static str = ".roller_index.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | const CONFIG_PATH: &'static str = ".roller_config.json"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | if &file_extension != extension { [INFO] [stderr] | ---------------^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `file_extension` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | Err(_) => panic!("couldn't open file to get hash: {}", path), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | / match file.read_to_string(&mut s) { [INFO] [stderr] 173 | | Err(_) => panic!("couldn't read file to string: {}", path), [INFO] [stderr] 174 | | Ok(_) => (), [INFO] [stderr] 175 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = file.read_to_string(&mut s) { panic!("couldn't read file to string: {}", path) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | Err(_) => panic!("couldn't read file to string: {}", path), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / match write!(file, "{}", encoded) { [INFO] [stderr] 189 | | Err(_) => panic!(), [INFO] [stderr] 190 | | Ok(_) => (), [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = $ dst . write_fmt ( format_args ! ( $ ( $ arg ) * ) ) { panic!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | Err(_) => panic!(), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.23s [INFO] running `"docker" "inspect" "49efe0b09d884e1882a4c527f160048a843e0da7fa18e4002b2e3ecacb0da808"` [INFO] running `"docker" "rm" "-f" "49efe0b09d884e1882a4c527f160048a843e0da7fa18e4002b2e3ecacb0da808"` [INFO] [stdout] 49efe0b09d884e1882a4c527f160048a843e0da7fa18e4002b2e3ecacb0da808