[INFO] crate rollbar 0.5.1 is already in cache [INFO] extracting crate rollbar 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/rollbar/0.5.1 [INFO] extracting crate rollbar 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rollbar/0.5.1 [INFO] validating manifest of rollbar-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rollbar-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rollbar-0.5.1 [INFO] finished frobbing rollbar-0.5.1 [INFO] frobbed toml for rollbar-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/rollbar/0.5.1/Cargo.toml [INFO] started frobbing rollbar-0.5.1 [INFO] finished frobbing rollbar-0.5.1 [INFO] frobbed toml for rollbar-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rollbar/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rollbar-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rollbar/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1c218c662afb550485501a14b54f333d7e7c65f500b53069da399e45efbe62c [INFO] running `"docker" "start" "-a" "c1c218c662afb550485501a14b54f333d7e7c65f500b53069da399e45efbe62c"` [INFO] [stderr] Checking rollbar v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:393:13 [INFO] [stderr] | [INFO] [stderr] 393 | trace: trace, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | trace: trace, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | trace: trace, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:393:13 [INFO] [stderr] | [INFO] [stderr] 393 | trace: trace, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trace` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:407:13 [INFO] [stderr] | [INFO] [stderr] 407 | trace: trace, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | trace: trace, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `trace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:433:13 [INFO] [stderr] | [INFO] [stderr] 433 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | const URL: &'static str = "https://api.rollbar.com/api/1/item/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | const URL: &'static str = "https://api.rollbar.com/api/1/item/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self { [INFO] [stderr] 120 | | &Level::CRITICAL => "critical".to_string(), [INFO] [stderr] 121 | | &Level::ERROR => "error".to_string(), [INFO] [stderr] 122 | | &Level::WARNING => "warning".to_string(), [INFO] [stderr] 123 | | &Level::INFO => "info".to_string(), [INFO] [stderr] 124 | | &Level::DEBUG => "debug".to_string() [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *self { [INFO] [stderr] 120 | Level::CRITICAL => "critical".to_string(), [INFO] [stderr] 121 | Level::ERROR => "error".to_string(), [INFO] [stderr] 122 | Level::WARNING => "warning".to_string(), [INFO] [stderr] 123 | Level::INFO => "info".to_string(), [INFO] [stderr] 124 | Level::DEBUG => "debug".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | send_strategy: Option, String) -> thread::JoinHandle>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:369:23 [INFO] [stderr] | [INFO] [stderr] 369 | pub fn from_panic(&'a mut self, panic_info: &'a panic::PanicInfo) -> ReportErrorBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:400:40 [INFO] [stderr] | [INFO] [stderr] 400 | pub fn from_error(&'a mut self, error: &'a E) -> ReportErrorBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:414:48 [INFO] [stderr] | [INFO] [stderr] 414 | pub fn from_error_message(&'a mut self, error_message: &'a T) -> ReportErrorBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:430:25 [INFO] [stderr] | [INFO] [stderr] 430 | pub fn from_message(&'a mut self, message: &'a str) -> ReportMessageBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:440:15 [INFO] [stderr] | [INFO] [stderr] 440 | / Box, String) -> [INFO] [stderr] 441 | | thread::JoinHandle>>); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / match self { [INFO] [stderr] 120 | | &Level::CRITICAL => "critical".to_string(), [INFO] [stderr] 121 | | &Level::ERROR => "error".to_string(), [INFO] [stderr] 122 | | &Level::WARNING => "warning".to_string(), [INFO] [stderr] 123 | | &Level::INFO => "info".to_string(), [INFO] [stderr] 124 | | &Level::DEBUG => "debug".to_string() [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 119 | match *self { [INFO] [stderr] 120 | Level::CRITICAL => "critical".to_string(), [INFO] [stderr] 121 | Level::ERROR => "error".to_string(), [INFO] [stderr] 122 | Level::WARNING => "warning".to_string(), [INFO] [stderr] 123 | Level::INFO => "info".to_string(), [INFO] [stderr] 124 | Level::DEBUG => "debug".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:135:20 [INFO] [stderr] | [INFO] [stderr] 135 | send_strategy: Option, String) -> thread::JoinHandle>>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:369:23 [INFO] [stderr] | [INFO] [stderr] 369 | pub fn from_panic(&'a mut self, panic_info: &'a panic::PanicInfo) -> ReportErrorBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:400:40 [INFO] [stderr] | [INFO] [stderr] 400 | pub fn from_error(&'a mut self, error: &'a E) -> ReportErrorBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:414:48 [INFO] [stderr] | [INFO] [stderr] 414 | pub fn from_error_message(&'a mut self, error_message: &'a T) -> ReportErrorBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:430:25 [INFO] [stderr] | [INFO] [stderr] 430 | pub fn from_message(&'a mut self, message: &'a str) -> ReportMessageBuilder<'a> { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:440:15 [INFO] [stderr] | [INFO] [stderr] 440 | / Box, String) -> [INFO] [stderr] 441 | | thread::JoinHandle>>); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:578:13 [INFO] [stderr] | [INFO] [stderr] 578 | / match description { [INFO] [stderr] 579 | | &Value::String(ref s) => assert!(!s.is_empty()), [INFO] [stderr] 580 | | _ => assert!(false) [INFO] [stderr] 581 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 674 | normalize_frames!(payload, expected_payload, 1); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:582:13 [INFO] [stderr] | [INFO] [stderr] 582 | / match message { [INFO] [stderr] 583 | | &Value::String(ref s) => assert!(!s.is_empty()), [INFO] [stderr] 584 | | _ => assert!(false) [INFO] [stderr] 585 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 674 | normalize_frames!(payload, expected_payload, 1); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:578:13 [INFO] [stderr] | [INFO] [stderr] 578 | / match description { [INFO] [stderr] 579 | | &Value::String(ref s) => assert!(!s.is_empty()), [INFO] [stderr] 580 | | _ => assert!(false) [INFO] [stderr] 581 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 724 | normalize_frames!(payload, expected_payload, 2); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:582:13 [INFO] [stderr] | [INFO] [stderr] 582 | / match message { [INFO] [stderr] 583 | | &Value::String(ref s) => assert!(!s.is_empty()), [INFO] [stderr] 584 | | _ => assert!(false) [INFO] [stderr] 585 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 724 | normalize_frames!(payload, expected_payload, 2); [INFO] [stderr] | ------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.38s [INFO] running `"docker" "inspect" "c1c218c662afb550485501a14b54f333d7e7c65f500b53069da399e45efbe62c"` [INFO] running `"docker" "rm" "-f" "c1c218c662afb550485501a14b54f333d7e7c65f500b53069da399e45efbe62c"` [INFO] [stdout] c1c218c662afb550485501a14b54f333d7e7c65f500b53069da399e45efbe62c