[INFO] crate rojo 0.4.13 is already in cache [INFO] extracting crate rojo 0.4.13 into work/ex/clippy-test-run/sources/stable/reg/rojo/0.4.13 [INFO] extracting crate rojo 0.4.13 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rojo/0.4.13 [INFO] validating manifest of rojo-0.4.13 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rojo-0.4.13 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rojo-0.4.13 [INFO] finished frobbing rojo-0.4.13 [INFO] frobbed toml for rojo-0.4.13 written to work/ex/clippy-test-run/sources/stable/reg/rojo/0.4.13/Cargo.toml [INFO] started frobbing rojo-0.4.13 [INFO] finished frobbing rojo-0.4.13 [INFO] frobbed toml for rojo-0.4.13 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rojo/0.4.13/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rojo-0.4.13 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rojo/0.4.13:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 287f193e26f82b52e1aa1265eb4cc5ed454c34bdf19788c485a2df1b6394c72c [INFO] running `"docker" "start" "-a" "287f193e26f82b52e1aa1265eb4cc5ed454c34bdf19788c485a2df1b6394c72c"` [INFO] [stderr] Checking buf_redux v0.6.3 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking deflate v0.7.19 [INFO] [stderr] Checking tiny_http v0.6.2 [INFO] [stderr] Checking inotify v0.6.1 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking rouille v2.2.0 [INFO] [stderr] Checking notify v4.0.7 [INFO] [stderr] Checking rojo v0.4.13 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/script_plugin.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | class_name: class_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plugins/script_plugin.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | class_name: class_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `class_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/commands/serve.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/commands/serve.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/commands/serve.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/commands/serve.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/project.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | Err(e) => return Err(ProjectLoadError::InvalidJson(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ProjectLoadError::InvalidJson(e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/project.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | Err(e) => return Err(ProjectLoadError::InvalidJson(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ProjectLoadError::InvalidJson(e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self { [INFO] [stderr] 34 | | &ProjectInitError::AlreadyExists => { [INFO] [stderr] 35 | | write!(f, "A project already exists at that location.") [INFO] [stderr] 36 | | }, [INFO] [stderr] ... | [INFO] [stderr] 39 | | }, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | ProjectInitError::AlreadyExists => { [INFO] [stderr] 35 | write!(f, "A project already exists at that location.") [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | ProjectInitError::FailedToCreate | ProjectInitError::FailedToWrite => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/project.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match fs::metadata(&package_path) { [INFO] [stderr] 84 | | Ok(_) => return Err(ProjectInitError::AlreadyExists), [INFO] [stderr] 85 | | Err(_) => {}, [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = fs::metadata(&package_path) { return Err(ProjectInitError::AlreadyExists) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/project.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/vfs/vfs_session.rs:56:50 [INFO] [stderr] | [INFO] [stderr] 56 | self.partitions.insert(name.to_string(), path.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/vfs/vfs_session.rs:103:35 [INFO] [stderr] | [INFO] [stderr] 103 | let mut child_route = route.iter().cloned().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/vfs/vfs_session.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / match self.read_path(&child_route, &path) { [INFO] [stderr] 107 | | Ok(child_item) => { [INFO] [stderr] 108 | | children.insert(name, child_item); [INFO] [stderr] 109 | | }, [INFO] [stderr] 110 | | Err(_) => {}, [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let Ok(child_item) = self.read_path(&child_route, &path) { [INFO] [stderr] 107 | children.insert(name, child_item); [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/vfs/vfs_session.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | route: route.iter().cloned().collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/vfs/vfs_session.rs:140:20 [INFO] [stderr] | [INFO] [stderr] 140 | route: route.iter().cloned().collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/vfs/vfs_session.rs:167:36 [INFO] [stderr] | [INFO] [stderr] 167 | elapsed.as_secs() as f64 + elapsed.subsec_nanos() as f64 * 1e-9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/vfs/vfs_session.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / match self.plugin_chain.handle_file_change(&route) { [INFO] [stderr] 174 | | Some(routes) => { [INFO] [stderr] 175 | | for route in routes { [INFO] [stderr] 176 | | self.change_history.push(VfsChange { [INFO] [stderr] ... | [INFO] [stderr] 182 | | None => {} [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 173 | if let Some(routes) = self.plugin_chain.handle_file_change(&route) { [INFO] [stderr] 174 | for route in routes { [INFO] [stderr] 175 | self.change_history.push(VfsChange { [INFO] [stderr] 176 | timestamp, [INFO] [stderr] 177 | route, [INFO] [stderr] 178 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/vfs/vfs_item.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match self { [INFO] [stderr] 25 | | &VfsItem::File { ref file_name , .. } => file_name, [INFO] [stderr] 26 | | &VfsItem::Dir { ref file_name , .. } => file_name, [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | VfsItem::File { ref file_name , .. } => file_name, [INFO] [stderr] 26 | VfsItem::Dir { ref file_name , .. } => file_name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/vfs/vfs_item.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &VfsItem::File { ref route, .. } => route, [INFO] [stderr] 33 | | &VfsItem::Dir { ref route, .. } => route, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | VfsItem::File { ref route, .. } => route, [INFO] [stderr] 33 | VfsItem::Dir { ref route, .. } => route, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/project.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match self { [INFO] [stderr] 34 | | &ProjectInitError::AlreadyExists => { [INFO] [stderr] 35 | | write!(f, "A project already exists at that location.") [INFO] [stderr] 36 | | }, [INFO] [stderr] ... | [INFO] [stderr] 39 | | }, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | match *self { [INFO] [stderr] 34 | ProjectInitError::AlreadyExists => { [INFO] [stderr] 35 | write!(f, "A project already exists at that location.") [INFO] [stderr] 36 | }, [INFO] [stderr] 37 | ProjectInitError::FailedToCreate | ProjectInitError::FailedToWrite => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/plugin.rs:24:41 [INFO] [stderr] | [INFO] [stderr] 24 | fn handle_file_change(&self, route: &Route) -> FileChangeResult; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/plugin.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn handle_file_change(&self, route: &Route) -> Option> { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::default_plugin::DefaultPlugin` [INFO] [stderr] --> src/plugins/default_plugin.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> DefaultPlugin { [INFO] [stderr] 15 | | DefaultPlugin [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/default_plugin.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match vfs_item { [INFO] [stderr] 22 | | &VfsItem::File { ref contents, .. } => { [INFO] [stderr] 23 | | let mut properties = HashMap::new(); [INFO] [stderr] 24 | | [INFO] [stderr] ... | [INFO] [stderr] 56 | | }, [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *vfs_item { [INFO] [stderr] 22 | VfsItem::File { ref contents, .. } => { [INFO] [stderr] 23 | let mut properties = HashMap::new(); [INFO] [stderr] 24 | [INFO] [stderr] 25 | properties.insert("Value".to_string(), RbxValue::String { [INFO] [stderr] 26 | value: contents.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/project.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match fs::metadata(&package_path) { [INFO] [stderr] 84 | | Ok(_) => return Err(ProjectInitError::AlreadyExists), [INFO] [stderr] 85 | | Err(_) => {}, [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = fs::metadata(&package_path) { return Err(ProjectInitError::AlreadyExists) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/plugins/default_plugin.rs:40:40 [INFO] [stderr] | [INFO] [stderr] 40 | for (_, child_item) in children { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 40 | for child_item in children.values() { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/project.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/default_plugin.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | / match plugins.transform_file(child_item) { [INFO] [stderr] 42 | | Some(rbx_item) => { [INFO] [stderr] 43 | | rbx_children.push(rbx_item); [INFO] [stderr] 44 | | }, [INFO] [stderr] 45 | | _ => {}, [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let Some(rbx_item) = plugins.transform_file(child_item) { [INFO] [stderr] 42 | rbx_children.push(rbx_item); [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::script_plugin::ScriptPlugin` [INFO] [stderr] --> src/plugins/script_plugin.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> ScriptPlugin { [INFO] [stderr] 24 | | ScriptPlugin [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/script_plugin.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match vfs_item { [INFO] [stderr] 31 | | &VfsItem::File { ref contents, .. } => { [INFO] [stderr] 32 | | let name = vfs_item.name(); [INFO] [stderr] 33 | | [INFO] [stderr] ... | [INFO] [stderr] 98 | | }, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *vfs_item { [INFO] [stderr] 31 | VfsItem::File { ref contents, .. } => { [INFO] [stderr] 32 | let name = vfs_item.name(); [INFO] [stderr] 33 | [INFO] [stderr] 34 | let (class_name, rbx_name) = { [INFO] [stderr] 35 | if let Some(captures) = SERVER_PATTERN.captures(name) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/plugins/script_plugin.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | .or(children.get(MODULE_INIT)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| children.get(MODULE_INIT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/plugins/script_plugin.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | .or(children.get(CLIENT_INIT)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| children.get(CLIENT_INIT))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/script_plugin.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | / match plugins.transform_file(child_item) { [INFO] [stderr] 90 | | Some(child_rbx_item) => { [INFO] [stderr] 91 | | rbx_item.children.push(child_rbx_item); [INFO] [stderr] 92 | | }, [INFO] [stderr] 93 | | _ => {}, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | if let Some(child_rbx_item) = plugins.transform_file(child_item) { [INFO] [stderr] 90 | rbx_item.children.push(child_rbx_item); [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::json_model_plugin::JsonModelPlugin` [INFO] [stderr] --> src/plugins/json_model_plugin.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> JsonModelPlugin { [INFO] [stderr] 19 | | JsonModelPlugin [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/vfs/vfs_session.rs:56:50 [INFO] [stderr] | [INFO] [stderr] 56 | self.partitions.insert(name.to_string(), path.into()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/json_model_plugin.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match vfs_item { [INFO] [stderr] 26 | | &VfsItem::File { ref contents, .. } => { [INFO] [stderr] 27 | | let rbx_name = match JSON_MODEL_PATTERN.captures(vfs_item.name()) { [INFO] [stderr] 28 | | Some(captures) => captures.get(1).unwrap().as_str().to_string(), [INFO] [stderr] ... | [INFO] [stderr] 78 | | }, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *vfs_item { [INFO] [stderr] 26 | VfsItem::File { ref contents, .. } => { [INFO] [stderr] 27 | let rbx_name = match JSON_MODEL_PATTERN.captures(vfs_item.name()) { [INFO] [stderr] 28 | Some(captures) => captures.get(1).unwrap().as_str().to_string(), [INFO] [stderr] 29 | None => return TransformFileResult::Pass, [INFO] [stderr] 30 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/json_model_plugin.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | / match plugins.transform_file(child_item) { [INFO] [stderr] 70 | | Some(child_rbx_item) => { [INFO] [stderr] 71 | | rbx_item.children.push(child_rbx_item); [INFO] [stderr] 72 | | }, [INFO] [stderr] 73 | | _ => {}, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(child_rbx_item) = plugins.transform_file(child_item) { [INFO] [stderr] 70 | rbx_item.children.push(child_rbx_item); [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/vfs/vfs_session.rs:103:35 [INFO] [stderr] | [INFO] [stderr] 103 | let mut child_route = route.iter().cloned().collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/vfs/vfs_session.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / match self.read_path(&child_route, &path) { [INFO] [stderr] 107 | | Ok(child_item) => { [INFO] [stderr] 108 | | children.insert(name, child_item); [INFO] [stderr] 109 | | }, [INFO] [stderr] 110 | | Err(_) => {}, [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let Ok(child_item) = self.read_path(&child_route, &path) { [INFO] [stderr] 107 | children.insert(name, child_item); [INFO] [stderr] 108 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/vfs/vfs_session.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | route: route.iter().cloned().collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/serve.rs:47:8 [INFO] [stderr] | [INFO] [stderr] 47 | if project.partitions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `project.partitions.is_empty()` [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/vfs/vfs_session.rs:140:20 [INFO] [stderr] | [INFO] [stderr] 140 | route: route.iter().cloned().collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/vfs/vfs_session.rs:167:36 [INFO] [stderr] | [INFO] [stderr] 167 | elapsed.as_secs() as f64 + elapsed.subsec_nanos() as f64 * 1e-9 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/vfs/vfs_session.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / match self.plugin_chain.handle_file_change(&route) { [INFO] [stderr] 174 | | Some(routes) => { [INFO] [stderr] 175 | | for route in routes { [INFO] [stderr] 176 | | self.change_history.push(VfsChange { [INFO] [stderr] ... | [INFO] [stderr] 182 | | None => {} [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 173 | if let Some(routes) = self.plugin_chain.handle_file_change(&route) { [INFO] [stderr] 174 | for route in routes { [INFO] [stderr] 175 | self.change_history.push(VfsChange { [INFO] [stderr] 176 | timestamp, [INFO] [stderr] 177 | route, [INFO] [stderr] 178 | }); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rojo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/vfs/vfs_item.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match self { [INFO] [stderr] 25 | | &VfsItem::File { ref file_name , .. } => file_name, [INFO] [stderr] 26 | | &VfsItem::Dir { ref file_name , .. } => file_name, [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | VfsItem::File { ref file_name , .. } => file_name, [INFO] [stderr] 26 | VfsItem::Dir { ref file_name , .. } => file_name, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/vfs/vfs_item.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &VfsItem::File { ref route, .. } => route, [INFO] [stderr] 33 | | &VfsItem::Dir { ref route, .. } => route, [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | VfsItem::File { ref route, .. } => route, [INFO] [stderr] 33 | VfsItem::Dir { ref route, .. } => route, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/plugin.rs:24:41 [INFO] [stderr] | [INFO] [stderr] 24 | fn handle_file_change(&self, route: &Route) -> FileChangeResult; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/plugin.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn handle_file_change(&self, route: &Route) -> Option> { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::default_plugin::DefaultPlugin` [INFO] [stderr] --> src/plugins/default_plugin.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> DefaultPlugin { [INFO] [stderr] 15 | | DefaultPlugin [INFO] [stderr] 16 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/default_plugin.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match vfs_item { [INFO] [stderr] 22 | | &VfsItem::File { ref contents, .. } => { [INFO] [stderr] 23 | | let mut properties = HashMap::new(); [INFO] [stderr] 24 | | [INFO] [stderr] ... | [INFO] [stderr] 56 | | }, [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *vfs_item { [INFO] [stderr] 22 | VfsItem::File { ref contents, .. } => { [INFO] [stderr] 23 | let mut properties = HashMap::new(); [INFO] [stderr] 24 | [INFO] [stderr] 25 | properties.insert("Value".to_string(), RbxValue::String { [INFO] [stderr] 26 | value: contents.clone(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/plugins/default_plugin.rs:40:40 [INFO] [stderr] | [INFO] [stderr] 40 | for (_, child_item) in children { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 40 | for child_item in children.values() { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/default_plugin.rs:41:21 [INFO] [stderr] | [INFO] [stderr] 41 | / match plugins.transform_file(child_item) { [INFO] [stderr] 42 | | Some(rbx_item) => { [INFO] [stderr] 43 | | rbx_children.push(rbx_item); [INFO] [stderr] 44 | | }, [INFO] [stderr] 45 | | _ => {}, [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | if let Some(rbx_item) = plugins.transform_file(child_item) { [INFO] [stderr] 42 | rbx_children.push(rbx_item); [INFO] [stderr] 43 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::script_plugin::ScriptPlugin` [INFO] [stderr] --> src/plugins/script_plugin.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> ScriptPlugin { [INFO] [stderr] 24 | | ScriptPlugin [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 20 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/script_plugin.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match vfs_item { [INFO] [stderr] 31 | | &VfsItem::File { ref contents, .. } => { [INFO] [stderr] 32 | | let name = vfs_item.name(); [INFO] [stderr] 33 | | [INFO] [stderr] ... | [INFO] [stderr] 98 | | }, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *vfs_item { [INFO] [stderr] 31 | VfsItem::File { ref contents, .. } => { [INFO] [stderr] 32 | let name = vfs_item.name(); [INFO] [stderr] 33 | [INFO] [stderr] 34 | let (class_name, rbx_name) = { [INFO] [stderr] 35 | if let Some(captures) = SERVER_PATTERN.captures(name) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/plugins/script_plugin.rs:64:26 [INFO] [stderr] | [INFO] [stderr] 64 | .or(children.get(MODULE_INIT)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| children.get(MODULE_INIT))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/plugins/script_plugin.rs:63:26 [INFO] [stderr] | [INFO] [stderr] 63 | .or(children.get(CLIENT_INIT)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| children.get(CLIENT_INIT))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/script_plugin.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | / match plugins.transform_file(child_item) { [INFO] [stderr] 90 | | Some(child_rbx_item) => { [INFO] [stderr] 91 | | rbx_item.children.push(child_rbx_item); [INFO] [stderr] 92 | | }, [INFO] [stderr] 93 | | _ => {}, [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | if let Some(child_rbx_item) = plugins.transform_file(child_item) { [INFO] [stderr] 90 | rbx_item.children.push(child_rbx_item); [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `plugins::json_model_plugin::JsonModelPlugin` [INFO] [stderr] --> src/plugins/json_model_plugin.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> JsonModelPlugin { [INFO] [stderr] 19 | | JsonModelPlugin [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/json_model_plugin.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match vfs_item { [INFO] [stderr] 26 | | &VfsItem::File { ref contents, .. } => { [INFO] [stderr] 27 | | let rbx_name = match JSON_MODEL_PATTERN.captures(vfs_item.name()) { [INFO] [stderr] 28 | | Some(captures) => captures.get(1).unwrap().as_str().to_string(), [INFO] [stderr] ... | [INFO] [stderr] 78 | | }, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *vfs_item { [INFO] [stderr] 26 | VfsItem::File { ref contents, .. } => { [INFO] [stderr] 27 | let rbx_name = match JSON_MODEL_PATTERN.captures(vfs_item.name()) { [INFO] [stderr] 28 | Some(captures) => captures.get(1).unwrap().as_str().to_string(), [INFO] [stderr] 29 | None => return TransformFileResult::Pass, [INFO] [stderr] 30 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/plugins/json_model_plugin.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | / match plugins.transform_file(child_item) { [INFO] [stderr] 70 | | Some(child_rbx_item) => { [INFO] [stderr] 71 | | rbx_item.children.push(child_rbx_item); [INFO] [stderr] 72 | | }, [INFO] [stderr] 73 | | _ => {}, [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let Some(child_rbx_item) = plugins.transform_file(child_item) { [INFO] [stderr] 70 | rbx_item.children.push(child_rbx_item); [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/serve.rs:47:8 [INFO] [stderr] | [INFO] [stderr] 47 | if project.partitions.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `project.partitions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rojo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "287f193e26f82b52e1aa1265eb4cc5ed454c34bdf19788c485a2df1b6394c72c"` [INFO] running `"docker" "rm" "-f" "287f193e26f82b52e1aa1265eb4cc5ed454c34bdf19788c485a2df1b6394c72c"` [INFO] [stdout] 287f193e26f82b52e1aa1265eb4cc5ed454c34bdf19788c485a2df1b6394c72c