[INFO] crate rogcat 0.2.17 is already in cache [INFO] extracting crate rogcat 0.2.17 into work/ex/clippy-test-run/sources/stable/reg/rogcat/0.2.17 [INFO] extracting crate rogcat 0.2.17 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rogcat/0.2.17 [INFO] validating manifest of rogcat-0.2.17 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rogcat-0.2.17 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rogcat-0.2.17 [INFO] finished frobbing rogcat-0.2.17 [INFO] frobbed toml for rogcat-0.2.17 written to work/ex/clippy-test-run/sources/stable/reg/rogcat/0.2.17/Cargo.toml [INFO] started frobbing rogcat-0.2.17 [INFO] finished frobbing rogcat-0.2.17 [INFO] frobbed toml for rogcat-0.2.17 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rogcat/0.2.17/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rogcat-0.2.17 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rogcat/0.2.17:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5832d40ef4afd6691e4c97e23c6201568a8d5aa2ee13417188fba09efdaac575 [INFO] running `"docker" "start" "-a" "5832d40ef4afd6691e4c97e23c6201568a8d5aa2ee13417188fba09efdaac575"` [INFO] [stderr] Compiling pest v2.1.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking clicolors-control v1.0.0 [INFO] [stderr] Checking zip v0.4.2 [INFO] [stderr] Checking config v0.9.2 [INFO] [stderr] Checking console v0.7.5 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Compiling pest_meta v2.1.0 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking tokio-process v0.2.3 [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking rogcat v0.2.17 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/filter.rs:98:33 [INFO] [stderr] | [INFO] [stderr] 98 | assert!(Filter::init_filter(&vec![]).is_ok()); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/filter.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | assert!(Filter::init_filter(&vec!["".to_owned()]).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["".to_owned()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/filter.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | assert!(Filter::init_filter(&vec!["a".to_owned()]).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["a".to_owned()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/filter.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | assert!(Filter::init_filter(&vec![".*".to_owned()]).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[".*".to_owned()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/filter.rs:102:33 [INFO] [stderr] | [INFO] [stderr] 102 | assert!(Filter::init_filter(&vec![".*".to_owned(), ".*".to_owned()]).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[".*".to_owned(), ".*".to_owned()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/filter.rs:103:33 [INFO] [stderr] | [INFO] [stderr] 103 | assert!(Filter::init_filter(&vec!["(".to_owned()]).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["(".to_owned()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:40:33 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn tempfile_with_content(c: &SVec) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:54:52 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn check_file_content(file: &PathBuf, content: &SVec) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tests/utils.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | .expect(&format!( [INFO] [stderr] | __________^ [INFO] [stderr] 67 | | "Error: rogcat binary not found, looked in `{:?}`. Do you need to run `cargo build`?", [INFO] [stderr] 68 | | dirs [INFO] [stderr] 69 | | )) [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|| panic!("Error: rogcat binary not found, looked in `{:?}`. Do you need to run `cargo build`?", dirs))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn run_rogcat(args: &SVec, input: Option) -> Result<(bool, SVec), Error> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tests/utils.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | if input.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:102:41 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn run_rogcat_with_input_file(args: &SVec, payload: &SVec) -> Result<(bool, SVec), Error> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/utils.rs:102:57 [INFO] [stderr] | [INFO] [stderr] 102 | pub fn run_rogcat_with_input_file(args: &SVec, payload: &SVec) -> Result<(bool, SVec), Error> { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/profiles.rs:33:48 [INFO] [stderr] | [INFO] [stderr] 33 | fn run_rogcat_with_config_and_input_file(args: &SVec, payload: &SVec) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tests/profiles.rs:33:64 [INFO] [stderr] | [INFO] [stderr] 33 | fn run_rogcat_with_config_and_input_file(args: &SVec, payload: &SVec) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tests/profiles.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | assert!(output.1.len() >= 1); // check for >1 if default location settings are found [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.1.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/tests/profiles.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | assert!(output.1.len() >= 1); // check for >1 if default location settings are found [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.1.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/tests/system.rs:22:42 [INFO] [stderr] | [INFO] [stderr] 22 | let result = run_rogcat(a, None).expect(&a.join(" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| { let msg = &a.join(" "); panic!(msg) }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.47s [INFO] running `"docker" "inspect" "5832d40ef4afd6691e4c97e23c6201568a8d5aa2ee13417188fba09efdaac575"` [INFO] running `"docker" "rm" "-f" "5832d40ef4afd6691e4c97e23c6201568a8d5aa2ee13417188fba09efdaac575"` [INFO] [stdout] 5832d40ef4afd6691e4c97e23c6201568a8d5aa2ee13417188fba09efdaac575