[INFO] crate rofl 0.0.1 is already in cache [INFO] extracting crate rofl 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/rofl/0.0.1 [INFO] extracting crate rofl 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rofl/0.0.1 [INFO] validating manifest of rofl-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rofl-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rofl-0.0.1 [INFO] finished frobbing rofl-0.0.1 [INFO] frobbed toml for rofl-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/rofl/0.0.1/Cargo.toml [INFO] started frobbing rofl-0.0.1 [INFO] finished frobbing rofl-0.0.1 [INFO] frobbed toml for rofl-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rofl/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rofl-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rofl/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc5b3d9d59c36e4d1cfa6b7ac3076af9cf525c75045688e33533ccc1b511a72e [INFO] running `"docker" "start" "-a" "dc5b3d9d59c36e4d1cfa6b7ac3076af9cf525c75045688e33533ccc1b511a72e"` [INFO] [stderr] Checking rgb v0.7.2 [INFO] [stderr] Checking macro-attr v0.2.0 [INFO] [stderr] Checking try_opt v0.1.1 [INFO] [stderr] Checking css-color-parser v0.1.2 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking serde_qs v0.2.2 [INFO] [stderr] Checking spectral v0.6.0 [INFO] [stderr] Checking gif-dispose v1.0.2 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking rofl v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> model/types.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | valign: valign, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `valign` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> resources/mod.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> resources/mod.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/animated_gif.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/animated_gif.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | bg_color: bg_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bg_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/animated_gif.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/text.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | Alignment{vertical: vertical, horizontal: horizontal} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/text.rs:47:39 [INFO] [stderr] | [INFO] [stderr] 47 | Alignment{vertical: vertical, horizontal: horizontal} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> model/types.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | valign: valign, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `valign` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> resources/mod.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> resources/mod.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/animated_gif.rs:315:13 [INFO] [stderr] | [INFO] [stderr] 315 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/animated_gif.rs:385:13 [INFO] [stderr] | [INFO] [stderr] 385 | bg_color: bg_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bg_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/animated_gif.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | writer: writer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/text.rs:47:19 [INFO] [stderr] | [INFO] [stderr] 47 | Alignment{vertical: vertical, horizontal: horizontal} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> util/text.rs:47:39 [INFO] [stderr] | [INFO] [stderr] 47 | Alignment{vertical: vertical, horizontal: horizontal} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/constants.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DEFAULT_FONT: &'static str = "Impact"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/caption.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/caption.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/caption.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | const EXPECTING_MSG: &'static str = "map or struct with image macro caption"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/color.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | const FIELDS: &'static [&'static str] = &["r", "g", "b"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/color.rs:12:26 [INFO] [stderr] | [INFO] [stderr] 12 | const FIELDS: &'static [&'static str] = &["r", "g", "b"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/color.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | const EXPECTING_MSG: &'static str = "CSS color string or array/map of RGB values"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | const WHOLESALE_CAPTION_FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:22:44 [INFO] [stderr] | [INFO] [stderr] 22 | const WHOLESALE_CAPTION_FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | const EXPECTING_MSG: &'static str = "representation of an image macro"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> resources/fonts.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | pub const FILE_EXTENSION: &'static str = "ttf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> lib.rs:93:14 [INFO] [stderr] | [INFO] [stderr] 93 | #[cfg(test)] #[macro_use] extern crate spectral; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/constants.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DEFAULT_FONT: &'static str = "Impact"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/caption.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/caption.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/caption.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | const EXPECTING_MSG: &'static str = "map or struct with image macro caption"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/color.rs:12:16 [INFO] [stderr] | [INFO] [stderr] 12 | const FIELDS: &'static [&'static str] = &["r", "g", "b"]; [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/color.rs:12:26 [INFO] [stderr] | [INFO] [stderr] 12 | const FIELDS: &'static [&'static str] = &["r", "g", "b"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/color.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | const EXPECTING_MSG: &'static str = "CSS color string or array/map of RGB values"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | const FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:22:34 [INFO] [stderr] | [INFO] [stderr] 22 | const WHOLESALE_CAPTION_FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:22:44 [INFO] [stderr] | [INFO] [stderr] 22 | const WHOLESALE_CAPTION_FIELDS: &'static [&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> model/de/image_macro.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | const EXPECTING_MSG: &'static str = "representation of an image macro"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> resources/fonts.rs:15:28 [INFO] [stderr] | [INFO] [stderr] 15 | pub const FILE_EXTENSION: &'static str = "ttf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> caption/task.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / let img; [INFO] [stderr] 93 | | if target_width != orig_width || target_height != orig_height { [INFO] [stderr] 94 | | debug!("Resizing template image `{}` from {}x{} to {}x{}", [INFO] [stderr] 95 | | self.template, orig_width, orig_height, target_width, target_height); [INFO] [stderr] ... | [INFO] [stderr] 99 | | img = template; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let img = if target_width != orig_width || target_height != orig_height { ..; template.resize(target_width, target_height, FilterType::Lanczos3) } else { ..; template };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> caption/task.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | / if let &Template::Animation(ref gif_anim) = template { [INFO] [stderr] 227 | | trace!("Writing animated GIF with {} frame(s)", gif_anim.frames_count()); [INFO] [stderr] 228 | | animated_gif::encode_modified(gif_anim, images, &mut result) [INFO] [stderr] 229 | | .map_err(CaptionError::Encode)?; [INFO] [stderr] ... | [INFO] [stderr] 251 | | })?; [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | if let Template::Animation(ref gif_anim) = *template { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> model/de/color.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | for &prefix in ["#", "0x", "$"].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> model/de/color.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | if css_color.a != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(css_color.a - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> model/de/color.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | if css_color.a != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> model/de/image_macro.rs:127:47 [INFO] [stderr] | [INFO] [stderr] 127 | let mut parts = key.split("_"); [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/de/image_macro.rs:258:16 [INFO] [stderr] | [INFO] [stderr] 258 | if simple_captions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!simple_captions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/de/image_macro.rs:262:16 [INFO] [stderr] | [INFO] [stderr] 262 | if simple_fields.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!simple_fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/de/image_macro.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | if simple_captions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!simple_captions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/types.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.captions.len() > 0 && self.captions.iter().any(|c| !c.text.is_empty()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.captions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/types.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | if self.captions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.captions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> model/types.rs:190:26 [INFO] [stderr] | [INFO] [stderr] 190 | pub(crate) fn to_rgb(&self) -> Rgb { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> model/types.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | pub(crate) fn to_rgba(&self, alpha: u8) -> Rgba { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> resources/templates.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | .and_then(|ext| IMAGE_FORMAT_EXTENSIONS.get(ext.as_str()).map(|f| *f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `IMAGE_FORMAT_EXTENSIONS.get(ext.as_str()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> util/animated_gif.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | self.writer.write(&self.buffer[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> util/text.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn origin_within(&self, rect: Rect) -> Point [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rofl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> caption/task.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / let img; [INFO] [stderr] 93 | | if target_width != orig_width || target_height != orig_height { [INFO] [stderr] 94 | | debug!("Resizing template image `{}` from {}x{} to {}x{}", [INFO] [stderr] 95 | | self.template, orig_width, orig_height, target_width, target_height); [INFO] [stderr] ... | [INFO] [stderr] 99 | | img = template; [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let img = if target_width != orig_width || target_height != orig_height { ..; template.resize(target_width, target_height, FilterType::Lanczos3) } else { ..; template };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> caption/task.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | / if let &Template::Animation(ref gif_anim) = template { [INFO] [stderr] 227 | | trace!("Writing animated GIF with {} frame(s)", gif_anim.frames_count()); [INFO] [stderr] 228 | | animated_gif::encode_modified(gif_anim, images, &mut result) [INFO] [stderr] 229 | | .map_err(CaptionError::Encode)?; [INFO] [stderr] ... | [INFO] [stderr] 251 | | })?; [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 226 | if let Template::Animation(ref gif_anim) = *template { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> model/de/color.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | for &prefix in ["#", "0x", "$"].into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> model/de/color.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | if css_color.a != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(css_color.a - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> model/de/color.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | if css_color.a != 1.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> model/de/image_macro.rs:127:47 [INFO] [stderr] | [INFO] [stderr] 127 | let mut parts = key.split("_"); [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/de/image_macro.rs:258:16 [INFO] [stderr] | [INFO] [stderr] 258 | if simple_captions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!simple_captions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/de/image_macro.rs:262:16 [INFO] [stderr] | [INFO] [stderr] 262 | if simple_fields.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!simple_fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/de/image_macro.rs:270:12 [INFO] [stderr] | [INFO] [stderr] 270 | if simple_captions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!simple_captions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/types.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.captions.len() > 0 && self.captions.iter().any(|c| !c.text.is_empty()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.captions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> model/types.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | if self.captions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.captions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> model/types.rs:190:26 [INFO] [stderr] | [INFO] [stderr] 190 | pub(crate) fn to_rgb(&self) -> Rgb { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> model/types.rs:196:27 [INFO] [stderr] | [INFO] [stderr] 196 | pub(crate) fn to_rgba(&self, alpha: u8) -> Rgba { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> resources/templates.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | .and_then(|ext| IMAGE_FORMAT_EXTENSIONS.get(ext.as_str()).map(|f| *f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `IMAGE_FORMAT_EXTENSIONS.get(ext.as_str()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> util/animated_gif.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | self.writer.write(&self.buffer[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> util/text.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn origin_within(&self, rect: Rect) -> Point [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rofl`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dc5b3d9d59c36e4d1cfa6b7ac3076af9cf525c75045688e33533ccc1b511a72e"` [INFO] running `"docker" "rm" "-f" "dc5b3d9d59c36e4d1cfa6b7ac3076af9cf525c75045688e33533ccc1b511a72e"` [INFO] [stdout] dc5b3d9d59c36e4d1cfa6b7ac3076af9cf525c75045688e33533ccc1b511a72e