[INFO] crate rocket_sync 0.1.0 is already in cache [INFO] extracting crate rocket_sync 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rocket_sync/0.1.0 [INFO] extracting crate rocket_sync 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rocket_sync/0.1.0 [INFO] validating manifest of rocket_sync-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rocket_sync-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rocket_sync-0.1.0 [INFO] finished frobbing rocket_sync-0.1.0 [INFO] frobbed toml for rocket_sync-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rocket_sync/0.1.0/Cargo.toml [INFO] started frobbing rocket_sync-0.1.0 [INFO] finished frobbing rocket_sync-0.1.0 [INFO] frobbed toml for rocket_sync-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rocket_sync/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rocket_sync-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rocket_sync/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53932f675c9bed03da79bf2b6fa9408caaa69c5dddc241e84f304a01b670ba5c [INFO] running `"docker" "start" "-a" "53932f675c9bed03da79bf2b6fa9408caaa69c5dddc241e84f304a01b670ba5c"` [INFO] [stderr] Checking rocket_sync v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | rpb: rpb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rpb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | bpm: bpm, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bpm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | rpb: rpb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rpb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | bpm: bpm, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bpm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(self.tracks[track_id].value_at(self.row)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.tracks[track_id].value_at(self.row))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | return Err(SyncError::TrackDoesntExist); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SyncError::TrackDoesntExist)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | Step => return a, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | Linear => return a + b * t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + b * t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:166:23 [INFO] [stderr] | [INFO] [stderr] 166 | Smooth => return a + b * (t*t * (3.0 - 2.0 * t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + b * (t*t * (3.0 - 2.0 * t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | Ramp => return a + b * t*t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + b * t*t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | NOOP => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(self.tracks[track_id].value_at(self.row)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(self.tracks[track_id].value_at(self.row))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | return Err(SyncError::TrackDoesntExist); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(SyncError::TrackDoesntExist)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | Step => return a, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | Linear => return a + b * t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + b * t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:166:23 [INFO] [stderr] | [INFO] [stderr] 166 | Smooth => return a + b * (t*t * (3.0 - 2.0 * t)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + b * (t*t * (3.0 - 2.0 * t))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:168:21 [INFO] [stderr] | [INFO] [stderr] 168 | Ramp => return a + b * t*t, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a + b * t*t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:170:21 [INFO] [stderr] | [INFO] [stderr] 170 | NOOP => return 0.0, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `0.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | let r: f64 = (self.time as f64 / 1000.0) * self.rps + 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SyncTrack` [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> SyncTrack { [INFO] [stderr] 86 | | SyncTrack { [INFO] [stderr] 87 | | keys: SmallVec::new(), [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:39 [INFO] [stderr] | [INFO] [stderr] 139 | ExactRow(n) => return self.keys[n].value as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.keys[n].value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:144:40 [INFO] [stderr] | [INFO] [stderr] 144 | AfterLastRow => return self.keys[self.keys.len() - 1].value as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.keys[self.keys.len() - 1].value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | BeforeFirstRow => return self.keys[0].value as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.keys[0].value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | let t: f64 = ((row - cur_key.row) as f64) / ((next_key.row - cur_key.row) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(row - cur_key.row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:52 [INFO] [stderr] | [INFO] [stderr] 156 | let t: f64 = ((row - cur_key.row) as f64) / ((next_key.row - cur_key.row) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(next_key.row - cur_key.row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | let a: f64 = cur_key.value as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cur_key.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | let b: f64 = (next_key.value - cur_key.value) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(next_key.value - cur_key.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:177:12 [INFO] [stderr] | [INFO] [stderr] 177 | if self.keys.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.keys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TrackKey` [INFO] [stderr] --> src/lib.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn new() -> TrackKey { [INFO] [stderr] 209 | | TrackKey { [INFO] [stderr] 210 | | row: 0, [INFO] [stderr] 211 | | value: 0.0, [INFO] [stderr] 212 | | key_type: KeyType::Step, [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 207 | impl Default for TrackKey { [INFO] [stderr] 208 | fn default() -> Self { [INFO] [stderr] 209 | Self::new() [INFO] [stderr] 210 | } [INFO] [stderr] 211 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | (bpm / 60.0) * (rpb as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(rpb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:36:23 [INFO] [stderr] | [INFO] [stderr] 36 | let r: f64 = (self.time as f64 / 1000.0) * self.rps + 0.5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.time)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `SyncTrack` [INFO] [stderr] --> src/lib.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn new() -> SyncTrack { [INFO] [stderr] 86 | | SyncTrack { [INFO] [stderr] 87 | | keys: SmallVec::new(), [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:39 [INFO] [stderr] | [INFO] [stderr] 139 | ExactRow(n) => return self.keys[n].value as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.keys[n].value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:144:40 [INFO] [stderr] | [INFO] [stderr] 144 | AfterLastRow => return self.keys[self.keys.len() - 1].value as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.keys[self.keys.len() - 1].value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | BeforeFirstRow => return self.keys[0].value as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.keys[0].value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | let t: f64 = ((row - cur_key.row) as f64) / ((next_key.row - cur_key.row) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(row - cur_key.row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:52 [INFO] [stderr] | [INFO] [stderr] 156 | let t: f64 = ((row - cur_key.row) as f64) / ((next_key.row - cur_key.row) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(next_key.row - cur_key.row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:157:22 [INFO] [stderr] | [INFO] [stderr] 157 | let a: f64 = cur_key.value as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(cur_key.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:158:22 [INFO] [stderr] | [INFO] [stderr] 158 | let b: f64 = (next_key.value - cur_key.value) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(next_key.value - cur_key.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:177:12 [INFO] [stderr] | [INFO] [stderr] 177 | if self.keys.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.keys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TrackKey` [INFO] [stderr] --> src/lib.rs:208:5 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn new() -> TrackKey { [INFO] [stderr] 209 | | TrackKey { [INFO] [stderr] 210 | | row: 0, [INFO] [stderr] 211 | | value: 0.0, [INFO] [stderr] 212 | | key_type: KeyType::Step, [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 207 | impl Default for TrackKey { [INFO] [stderr] 208 | fn default() -> Self { [INFO] [stderr] 209 | Self::new() [INFO] [stderr] 210 | } [INFO] [stderr] 211 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:219:20 [INFO] [stderr] | [INFO] [stderr] 219 | (bpm / 60.0) * (rpb as f64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(rpb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "53932f675c9bed03da79bf2b6fa9408caaa69c5dddc241e84f304a01b670ba5c"` [INFO] running `"docker" "rm" "-f" "53932f675c9bed03da79bf2b6fa9408caaa69c5dddc241e84f304a01b670ba5c"` [INFO] [stdout] 53932f675c9bed03da79bf2b6fa9408caaa69c5dddc241e84f304a01b670ba5c