[INFO] crate robinhood 0.1.1-alpha.1 is already in cache [INFO] extracting crate robinhood 0.1.1-alpha.1 into work/ex/clippy-test-run/sources/stable/reg/robinhood/0.1.1-alpha.1 [INFO] extracting crate robinhood 0.1.1-alpha.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/robinhood/0.1.1-alpha.1 [INFO] validating manifest of robinhood-0.1.1-alpha.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of robinhood-0.1.1-alpha.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing robinhood-0.1.1-alpha.1 [INFO] finished frobbing robinhood-0.1.1-alpha.1 [INFO] frobbed toml for robinhood-0.1.1-alpha.1 written to work/ex/clippy-test-run/sources/stable/reg/robinhood/0.1.1-alpha.1/Cargo.toml [INFO] started frobbing robinhood-0.1.1-alpha.1 [INFO] finished frobbing robinhood-0.1.1-alpha.1 [INFO] frobbed toml for robinhood-0.1.1-alpha.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/robinhood/0.1.1-alpha.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting robinhood-0.1.1-alpha.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/robinhood/0.1.1-alpha.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe2e27d187b7be1b09348ed33adf6b5c42a12649680f1aa9c89e15e9fe76ee47 [INFO] running `"docker" "start" "-a" "fe2e27d187b7be1b09348ed33adf6b5c42a12649680f1aa9c89e15e9fe76ee47"` [INFO] [stderr] Checking robinhood v0.1.1-alpha.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:513:13 [INFO] [stderr] | [INFO] [stderr] 513 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:514:13 [INFO] [stderr] | [INFO] [stderr] 514 | authorized: authorized, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authorized` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:774:13 [INFO] [stderr] | [INFO] [stderr] 774 | quantity: quantity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `quantity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:776:13 [INFO] [stderr] | [INFO] [stderr] 776 | instrument: instrument, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instrument` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:777:13 [INFO] [stderr] | [INFO] [stderr] 777 | account: account, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `account` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:513:13 [INFO] [stderr] | [INFO] [stderr] 513 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:514:13 [INFO] [stderr] | [INFO] [stderr] 514 | authorized: authorized, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authorized` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:774:13 [INFO] [stderr] | [INFO] [stderr] 774 | quantity: quantity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `quantity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:776:13 [INFO] [stderr] | [INFO] [stderr] 776 | instrument: instrument, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instrument` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:777:13 [INFO] [stderr] | [INFO] [stderr] 777 | account: account, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `account` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn new() -> ClientBuilder { [INFO] [stderr] 121 | | let mfa_callback = move |mfa_type: String| -> String { [INFO] [stderr] 122 | | use std::io::{stdin, stdout, Write}; [INFO] [stderr] 123 | | let mut s = String::new(); [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/lib.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn new() -> ClientBuilder { [INFO] [stderr] 121 | | let mfa_callback = move |mfa_type: String| -> String { [INFO] [stderr] 122 | | use std::io::{stdin, stdout, Write}; [INFO] [stderr] 123 | | let mut s = String::new(); [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/macros.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new_with_client(ref mut client : HTTPClient) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:536:1 [INFO] [stderr] | [INFO] [stderr] 536 | / iter_builder!( [INFO] [stderr] 537 | | Instruments => Instrument as InstrumentData, "https://api.robinhood.com/instruments/" { [INFO] [stderr] 538 | | min_tick_size: Option = None, [INFO] [stderr] 539 | | #[serde(rename = "type")] [INFO] [stderr] ... | [INFO] [stderr] 560 | | tradable_chain_id: Option = None [INFO] [stderr] 561 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/macros.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new_with_client(ref mut client : HTTPClient) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:536:1 [INFO] [stderr] | [INFO] [stderr] 536 | / iter_builder!( [INFO] [stderr] 537 | | Instruments => Instrument as InstrumentData, "https://api.robinhood.com/instruments/" { [INFO] [stderr] 538 | | min_tick_size: Option = None, [INFO] [stderr] 539 | | #[serde(rename = "type")] [INFO] [stderr] ... | [INFO] [stderr] 560 | | tradable_chain_id: Option = None [INFO] [stderr] 561 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/macros.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new_with_client(ref mut client : HTTPClient) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:640:1 [INFO] [stderr] | [INFO] [stderr] 640 | / iter_builder!( [INFO] [stderr] 641 | | Accounts => Account as AccountData, "https://api.robinhood.com/accounts/" { [INFO] [stderr] 642 | | deactivated: bool = None, [INFO] [stderr] 643 | | updated_at: DateTime = None, [INFO] [stderr] ... | [INFO] [stderr] 672 | | is_pinnacle_account: bool = None [INFO] [stderr] 673 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/macros.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new_with_client(ref mut client : HTTPClient) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:640:1 [INFO] [stderr] | [INFO] [stderr] 640 | / iter_builder!( [INFO] [stderr] 641 | | Accounts => Account as AccountData, "https://api.robinhood.com/accounts/" { [INFO] [stderr] 642 | | deactivated: bool = None, [INFO] [stderr] 643 | | updated_at: DateTime = None, [INFO] [stderr] ... | [INFO] [stderr] 672 | | is_pinnacle_account: bool = None [INFO] [stderr] 673 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/macros.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new_with_client(ref mut client : HTTPClient) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:684:1 [INFO] [stderr] | [INFO] [stderr] 684 | / iter_builder!( [INFO] [stderr] 685 | | Orders => Order as OrderData, "https://api.robinhood.com/orders/" { [INFO] [stderr] 686 | | account: String = None, [INFO] [stderr] 687 | | average_price: Option = None, [INFO] [stderr] ... | [INFO] [stderr] 714 | | url: String = None [INFO] [stderr] 715 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/macros.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new_with_client(ref mut client : HTTPClient) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:717:1 [INFO] [stderr] | [INFO] [stderr] 717 | / iter_builder!( [INFO] [stderr] 718 | | Positions => Position as PositionData, "https://api.robinhood.com/accounts/{account_id}/positions/" { [INFO] [stderr] 719 | | shares_held_for_stock_grants: String = None, [INFO] [stderr] 720 | | account: String = None, [INFO] [stderr] ... | [INFO] [stderr] 730 | | quantity: String = None [INFO] [stderr] 731 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:759:9 [INFO] [stderr] | [INFO] [stderr] 759 | ref mut client: HTTPClient, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/macros.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new_with_client(ref mut client : HTTPClient) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:684:1 [INFO] [stderr] | [INFO] [stderr] 684 | / iter_builder!( [INFO] [stderr] 685 | | Orders => Order as OrderData, "https://api.robinhood.com/orders/" { [INFO] [stderr] 686 | | account: String = None, [INFO] [stderr] 687 | | average_price: Option = None, [INFO] [stderr] ... | [INFO] [stderr] 714 | | url: String = None [INFO] [stderr] 715 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/macros.rs:62:28 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new_with_client(ref mut client : HTTPClient) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:717:1 [INFO] [stderr] | [INFO] [stderr] 717 | / iter_builder!( [INFO] [stderr] 718 | | Positions => Position as PositionData, "https://api.robinhood.com/accounts/{account_id}/positions/" { [INFO] [stderr] 719 | | shares_held_for_stock_grants: String = None, [INFO] [stderr] 720 | | account: String = None, [INFO] [stderr] ... | [INFO] [stderr] 730 | | quantity: String = None [INFO] [stderr] 731 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` directly on a function argument is ignored. Consider using a reference type instead. [INFO] [stderr] --> src/lib.rs:759:9 [INFO] [stderr] | [INFO] [stderr] 759 | ref mut client: HTTPClient, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.61s [INFO] running `"docker" "inspect" "fe2e27d187b7be1b09348ed33adf6b5c42a12649680f1aa9c89e15e9fe76ee47"` [INFO] running `"docker" "rm" "-f" "fe2e27d187b7be1b09348ed33adf6b5c42a12649680f1aa9c89e15e9fe76ee47"` [INFO] [stdout] fe2e27d187b7be1b09348ed33adf6b5c42a12649680f1aa9c89e15e9fe76ee47