[INFO] crate rob 0.1.0 is already in cache [INFO] extracting crate rob 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rob/0.1.0 [INFO] extracting crate rob 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rob/0.1.0 [INFO] validating manifest of rob-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rob-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rob-0.1.0 [INFO] finished frobbing rob-0.1.0 [INFO] frobbed toml for rob-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rob/0.1.0/Cargo.toml [INFO] started frobbing rob-0.1.0 [INFO] finished frobbing rob-0.1.0 [INFO] frobbed toml for rob-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rob/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rob-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rob/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7e95438f6a68e742bed6ece60ede4aaae0d51c29507bbb37d76f7d28786ccad [INFO] running `"docker" "start" "-a" "a7e95438f6a68e742bed6ece60ede4aaae0d51c29507bbb37d76f7d28786ccad"` [INFO] [stderr] Checking rob v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | is_owned: is_owned, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_owned` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | is_owned: is_owned, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_owned` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn into_raw(this: Self) -> (*mut T, bool) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn as_ref(this: &Self) -> Option<&'a T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn into_box(this: Self) -> Box { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_mut` usually take self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:156:19 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn to_mut(this: &mut Self) -> &mut T { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / fn ne(&self, other: &Rob<'a, T>) -> bool { [INFO] [stderr] 269 | | ::ne(&**self, &**other) [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:113:21 [INFO] [stderr] | [INFO] [stderr] 113 | pub fn into_raw(this: Self) -> (*mut T, bool) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn as_ref(this: &Self) -> Option<&'a T> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | pub fn into_box(this: Self) -> Box { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_mut` usually take self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:156:19 [INFO] [stderr] | [INFO] [stderr] 156 | pub fn to_mut(this: &mut Self) -> &mut T { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/lib.rs:268:5 [INFO] [stderr] | [INFO] [stderr] 268 | / fn ne(&self, other: &Rob<'a, T>) -> bool { [INFO] [stderr] 269 | | ::ne(&**self, &**other) [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "a7e95438f6a68e742bed6ece60ede4aaae0d51c29507bbb37d76f7d28786ccad"` [INFO] running `"docker" "rm" "-f" "a7e95438f6a68e742bed6ece60ede4aaae0d51c29507bbb37d76f7d28786ccad"` [INFO] [stdout] a7e95438f6a68e742bed6ece60ede4aaae0d51c29507bbb37d76f7d28786ccad