[INFO] crate rng 0.1.0 is already in cache [INFO] extracting crate rng 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rng/0.1.0 [INFO] extracting crate rng 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rng/0.1.0 [INFO] validating manifest of rng-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rng-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rng-0.1.0 [INFO] finished frobbing rng-0.1.0 [INFO] frobbed toml for rng-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rng/0.1.0/Cargo.toml [INFO] started frobbing rng-0.1.0 [INFO] finished frobbing rng-0.1.0 [INFO] frobbed toml for rng-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rng/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rng-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rng/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4bd9b763fbb2ed91e9c26c6f1ef878781c1be189c4aed4382ab5e56204544f31 [INFO] running `"docker" "start" "-a" "4bd9b763fbb2ed91e9c26c6f1ef878781c1be189c4aed4382ab5e56204544f31"` [INFO] [stderr] Checking rng v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `transmute` [INFO] [stderr] --> src/xorshift.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::mem::{transmute}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/xorshift.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/xorshift.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let r = s * 1181783497276652981_u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | let r = s * 1181783497276652981_u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `1_181_783_497_276_652_981_u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `transmute` [INFO] [stderr] --> src/xorshift.rs:4:16 [INFO] [stderr] | [INFO] [stderr] 4 | use std::mem::{transmute}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/xorshift.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | r [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/xorshift.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | let r = s * 1181783497276652981_u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/xorshift.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | let r = s * 1181783497276652981_u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `1_181_783_497_276_652_981_u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is used to index `seed` [INFO] [stderr] --> src/xorshift.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | for p in 0 .. 16 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 114 | for (p, ) in seed.iter().enumerate().take(16) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/xorshift.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | for p in 0 .. 16 { [INFO] [stderr] | ^^^^^^^ help: try replacing the loop by: `self.state[..16].clone_from_slice(&seed[..16])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is used to index `seed` [INFO] [stderr] --> src/xorshift.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | for p in 0 .. 16 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 114 | for (p, ) in seed.iter().enumerate().take(16) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/xorshift.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | for p in 0 .. 16 { [INFO] [stderr] | ^^^^^^^ help: try replacing the loop by: `self.state[..16].clone_from_slice(&seed[..16])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.12s [INFO] running `"docker" "inspect" "4bd9b763fbb2ed91e9c26c6f1ef878781c1be189c4aed4382ab5e56204544f31"` [INFO] running `"docker" "rm" "-f" "4bd9b763fbb2ed91e9c26c6f1ef878781c1be189c4aed4382ab5e56204544f31"` [INFO] [stdout] 4bd9b763fbb2ed91e9c26c6f1ef878781c1be189c4aed4382ab5e56204544f31