[INFO] crate rn 0.2.2 is already in cache
[INFO] extracting crate rn 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/rn/0.2.2
[INFO] extracting crate rn 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rn/0.2.2
[INFO] validating manifest of rn-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rn-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rn-0.2.2
[INFO] finished frobbing rn-0.2.2
[INFO] frobbed toml for rn-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/rn/0.2.2/Cargo.toml
[INFO] started frobbing rn-0.2.2
[INFO] finished frobbing rn-0.2.2
[INFO] frobbed toml for rn-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rn/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rn-0.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rn/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c4569d73273ab441ec9e73d2977a5a089f0752d9f7b9fc7bb033b0596b50a93b
[INFO] running `"docker" "start" "-a" "c4569d73273ab441ec9e73d2977a5a089f0752d9f7b9fc7bb033b0596b50a93b"`
[INFO] [stderr]    Compiling rust-lzma v0.2.1
[INFO] [stderr]     Checking semver v0.7.0
[INFO] [stderr]     Checking rn v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cache.rs:63:27
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let input = Input{envvars: envvars, args: vec!()};
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^ help: replace it with: `envvars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cache.rs:63:27
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let input = Input{envvars: envvars, args: vec!()};
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^ help: replace it with: `envvars`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/input.rs:67:27
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let input = Input{envvars: envvars, args: vec!()};
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^ help: replace it with: `envvars`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/input.rs:75:27
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let input = Input{envvars: envvars, args: vec!()};
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^ help: replace it with: `envvars`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/input.rs:67:27
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let input = Input{envvars: envvars, args: vec!()};
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^ help: replace it with: `envvars`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/input.rs:75:27
[INFO] [stderr]    |
[INFO] [stderr] 75 |         let input = Input{envvars: envvars, args: vec!()};
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^ help: replace it with: `envvars`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/input.rs:9:34
[INFO] [stderr]   |
[INFO] [stderr] 9 | const ENVVAR_VERSION_DIRECTORY: &'static str = "RN_DIR";
[INFO] [stderr]   |                                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/input.rs:10:21
[INFO] [stderr]    |
[INFO] [stderr] 10 | const ENVVAR_HOME: &'static str = "HOME";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/input.rs:11:35
[INFO] [stderr]    |
[INFO] [stderr] 11 | const DEFAULT_VERSION_DIRECTORY: &'static str = "/.rn/versions";
[INFO] [stderr]    |                                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/input.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         return PathBuf::from("/tmp/.rn/versions");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PathBuf::from("/tmp/.rn/versions")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/release.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     return elapsed.as_secs() > ONE_DAY;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `elapsed.as_secs() > ONE_DAY`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/shell.rs:4:12
[INFO] [stderr]   |
[INFO] [stderr] 4 | const OS: &'static str = "linux";
[INFO] [stderr]   |           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/version.rs:7:13
[INFO] [stderr]   |
[INFO] [stderr] 7 | const EXT: &'static str = "xz";
[INFO] [stderr]   |            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/version.rs:9:12
[INFO] [stderr]   |
[INFO] [stderr] 9 | const OS: &'static str = "linux";
[INFO] [stderr]   |           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let ref mut to_stderr = &mut ::std::io::stderr();
[INFO] [stderr]    |     ----^^^^^^^^^^^^^^^^^---------------------------- help: try: `let to_stderr = &mut (&mut ::std::io::stderr());`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let ref first_arg = input.args[1];
[INFO] [stderr]    |     ----^^^^^^^^^^^^^----------------- help: try: `let first_arg = &input.args[1];`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/input.rs:9:34
[INFO] [stderr]   |
[INFO] [stderr] 9 | const ENVVAR_VERSION_DIRECTORY: &'static str = "RN_DIR";
[INFO] [stderr]   |                                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/input.rs:10:21
[INFO] [stderr]    |
[INFO] [stderr] 10 | const ENVVAR_HOME: &'static str = "HOME";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/input.rs:11:35
[INFO] [stderr]    |
[INFO] [stderr] 11 | const DEFAULT_VERSION_DIRECTORY: &'static str = "/.rn/versions";
[INFO] [stderr]    |                                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/input.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         return PathBuf::from("/tmp/.rn/versions");
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PathBuf::from("/tmp/.rn/versions")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/release.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     return elapsed.as_secs() > ONE_DAY;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `elapsed.as_secs() > ONE_DAY`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/shell.rs:4:12
[INFO] [stderr]   |
[INFO] [stderr] 4 | const OS: &'static str = "linux";
[INFO] [stderr]   |           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/version.rs:7:13
[INFO] [stderr]   |
[INFO] [stderr] 7 | const EXT: &'static str = "xz";
[INFO] [stderr]   |            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/version.rs:9:12
[INFO] [stderr]   |
[INFO] [stderr] 9 | const OS: &'static str = "linux";
[INFO] [stderr]   |           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/package_json.rs:77:35
[INFO] [stderr]    |
[INFO] [stderr] 77 |         assert_eq!(parse_versions("{".as_bytes()), Err(ParseError::InvalidJson));
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/package_json.rs:82:35
[INFO] [stderr]    |
[INFO] [stderr] 82 |         assert_eq!(parse_versions("{}".as_bytes()),
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"{}"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/package_json.rs:88:35
[INFO] [stderr]    |
[INFO] [stderr] 88 |         assert_eq!(parse_versions(r#"{"engines":{"npm":"3.9.7"}}"#.as_bytes()),
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `br#"{"engines":{"npm":"3.9.7"}}"#`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/package_json.rs:95:35
[INFO] [stderr]    |
[INFO] [stderr] 95 |         assert_eq!(parse_versions(r#"{"engines":{"node":"6.1.0"}}"#.as_bytes()),
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `br#"{"engines":{"node":"6.1.0"}}"#`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let ref mut to_stderr = &mut ::std::io::stderr();
[INFO] [stderr]    |     ----^^^^^^^^^^^^^^^^^---------------------------- help: try: `let to_stderr = &mut (&mut ::std::io::stderr());`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let ref first_arg = input.args[1];
[INFO] [stderr]    |     ----^^^^^^^^^^^^^----------------- help: try: `let first_arg = &input.args[1];`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.59s
[INFO] running `"docker" "inspect" "c4569d73273ab441ec9e73d2977a5a089f0752d9f7b9fc7bb033b0596b50a93b"`
[INFO] running `"docker" "rm" "-f" "c4569d73273ab441ec9e73d2977a5a089f0752d9f7b9fc7bb033b0596b50a93b"`
[INFO] [stdout] c4569d73273ab441ec9e73d2977a5a089f0752d9f7b9fc7bb033b0596b50a93b