[INFO] crate rmpv 0.4.0 is already in cache [INFO] extracting crate rmpv 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/rmpv/0.4.0 [INFO] extracting crate rmpv 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rmpv/0.4.0 [INFO] validating manifest of rmpv-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rmpv-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rmpv-0.4.0 [INFO] finished frobbing rmpv-0.4.0 [INFO] frobbed toml for rmpv-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/rmpv/0.4.0/Cargo.toml [INFO] started frobbing rmpv-0.4.0 [INFO] finished frobbing rmpv-0.4.0 [INFO] frobbed toml for rmpv-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rmpv/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rmpv-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rmpv/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 80706020d748c63fd988481cb82901b881219d7ee0a2a18391bccdf8f7fe0a4e [INFO] running `"docker" "start" "-a" "80706020d748c63fd988481cb82901b881219d7ee0a2a18391bccdf8f7fe0a4e"` [INFO] [stderr] Checking rmpv v0.4.0 (/opt/crater/workdir) [INFO] [stderr] Checking quickcheck v0.3.2 [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decode/value_ref.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | let mut rd = rd; [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value.rs:20:35 [INFO] [stderr] | [INFO] [stderr] 20 | write_nil(wr).map_err(|err| Error::InvalidMarkerWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value.rs:23:41 [INFO] [stderr] | [INFO] [stderr] 23 | write_bool(wr, val).map_err(|err| Error::InvalidMarkerWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value.rs:65:40 [INFO] [stderr] | [INFO] [stderr] 65 | wr.write_all(data).map_err(|err| Error::InvalidDataWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidDataWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value_ref.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | write_nil(wr).map_err(|err| Error::InvalidMarkerWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value_ref.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | write_bool(wr, val).map_err(|err| Error::InvalidMarkerWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value_ref.rs:77:40 [INFO] [stderr] | [INFO] [stderr] 77 | wr.write_all(data).map_err(|err| Error::InvalidDataWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidDataWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:109:38 [INFO] [stderr] | [INFO] [stderr] 109 | Integer { n: IntPriv::PosInt(n as u64) } [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:115:38 [INFO] [stderr] | [INFO] [stderr] 115 | Integer { n: IntPriv::PosInt(n as u64) } [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:121:38 [INFO] [stderr] | [INFO] [stderr] 121 | Integer { n: IntPriv::PosInt(n as u64) } [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:42 [INFO] [stderr] | [INFO] [stderr] 140 | Integer { n: IntPriv::NegInt(n as i64) } [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:150:42 [INFO] [stderr] | [INFO] [stderr] 150 | Integer { n: IntPriv::NegInt(n as i64) } [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:160:42 [INFO] [stderr] | [INFO] [stderr] 160 | Integer { n: IntPriv::NegInt(n as i64) } [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1015:9 [INFO] [stderr] | [INFO] [stderr] 1015 | / match self { [INFO] [stderr] 1016 | | &ValueRef::Nil => Value::Nil, [INFO] [stderr] 1017 | | &ValueRef::Boolean(val) => Value::Boolean(val), [INFO] [stderr] 1018 | | &ValueRef::Integer(val) => Value::Integer(val), [INFO] [stderr] ... | [INFO] [stderr] 1029 | | &ValueRef::Ext(ty, buf) => Value::Ext(ty, buf.to_vec()), [INFO] [stderr] 1030 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1015 | match *self { [INFO] [stderr] 1016 | ValueRef::Nil => Value::Nil, [INFO] [stderr] 1017 | ValueRef::Boolean(val) => Value::Boolean(val), [INFO] [stderr] 1018 | ValueRef::Integer(val) => Value::Integer(val), [INFO] [stderr] 1019 | ValueRef::F32(val) => Value::F32(val), [INFO] [stderr] 1020 | ValueRef::F64(val) => Value::F64(val), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: defining a method called `index` on this type; consider implementing the `std::ops::Index` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:1033:5 [INFO] [stderr] | [INFO] [stderr] 1033 | / pub fn index(&self, index: usize) -> &ValueRef { [INFO] [stderr] 1034 | | self.as_array().and_then(|v| v.get(index)).unwrap_or(&NIL_REF) [INFO] [stderr] 1035 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:1164:26 [INFO] [stderr] | [INFO] [stderr] 1164 | ValueRef::Binary(v.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | assert_eq!(ValueRef::from(4294967295u32), read_value_ref(&mut rd).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_294_967_295u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | assert_eq!(ValueRef::from(18446744073709551615u64), read_value_ref(&mut rd).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | assert_eq!(ValueRef::from(2147483647), read_value_ref(&mut rd).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:136:31 [INFO] [stderr] | [INFO] [stderr] 136 | assert_eq!(ValueRef::from(9223372036854775807i64), read_value_ref(&mut rd).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | assert_eq!(ValueRef::F32(3.4028234e38_f32), read_value_ref(&mut rd).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `3.402_823_4e38_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:454:45 [INFO] [stderr] | [INFO] [stderr] 454 | (ValueRef::from(42), ValueRef::from(100500)), [INFO] [stderr] | ^^^^^^ help: consider: `100_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:552:45 [INFO] [stderr] | [INFO] [stderr] 552 | (ValueRef::from(42), ValueRef::from(100500)), [INFO] [stderr] | ^^^^^^ help: consider: `100_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:584:44 [INFO] [stderr] | [INFO] [stderr] 584 | ValueRef::from(100500) [INFO] [stderr] | ^^^^^^ help: consider: `100_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode_ref.rs:661:41 [INFO] [stderr] | [INFO] [stderr] 661 | Value::from(100500) [INFO] [stderr] | ^^^^^^ help: consider: `100_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/value.rs:24:51 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!("3.1415", format!("{}", Value::F32(3.1415))); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/value.rs:25:51 [INFO] [stderr] | [INFO] [stderr] 25 | assert_eq!("3.1415", format!("{}", Value::F64(3.1415))); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/value.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(Value::F32(3.1415), Value::from(3.1415f32)); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f32::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/value.rs:119:48 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(Value::F32(3.1415), Value::from(3.1415f32)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/value.rs:124:27 [INFO] [stderr] | [INFO] [stderr] 124 | assert_eq!(Value::F64(3.1415), Value::from(3.1415f64)); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/value.rs:124:48 [INFO] [stderr] | [INFO] [stderr] 124 | assert_eq!(Value::F64(3.1415), Value::from(3.1415f64)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rmpv`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0425]: cannot find function `U64` in this scope [INFO] [stderr] --> benches/value.rs:99:31 [INFO] [stderr] | [INFO] [stderr] 99 | let val = Array(vec![Nil, U64(42), F64(3.1415), [INFO] [stderr] | ^^^ did you mean `F64`? [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/value.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0425, E0554. [INFO] [stderr] For more information about an error, try `rustc --explain E0425`. [INFO] [stderr] error: Could not compile `rmpv`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encode_ref.rs:55:31 [INFO] [stderr] | [INFO] [stderr] 55 | let val = ValueRef::from(-9223372036854775808i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encode_ref.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | &ValueRef::F32(3.4028234e38_f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `3.402_823_4e38_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/decode_ref.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | assert_eq!(ValueRef::F32(3.4028234e38_f32), read_value_ref(&mut rd).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/encode_ref.rs:62:30 [INFO] [stderr] | [INFO] [stderr] 62 | fn check_packed_eq(expected: &Vec, actual: &ValueRef) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/encode_ref.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | &ValueRef::F32(3.4028234e38_f32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decode/value_ref.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | let mut rd = rd; [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/decode.rs:84:39 [INFO] [stderr] | [INFO] [stderr] 84 | (Value::from(42), Value::from(100500)), [INFO] [stderr] | ^^^^^^ help: consider: `100_500` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value.rs:20:35 [INFO] [stderr] | [INFO] [stderr] 20 | write_nil(wr).map_err(|err| Error::InvalidMarkerWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value.rs:23:41 [INFO] [stderr] | [INFO] [stderr] 23 | write_bool(wr, val).map_err(|err| Error::InvalidMarkerWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value.rs:65:40 [INFO] [stderr] | [INFO] [stderr] 65 | wr.write_all(data).map_err(|err| Error::InvalidDataWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidDataWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value_ref.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | write_nil(wr).map_err(|err| Error::InvalidMarkerWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value_ref.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | write_bool(wr, val).map_err(|err| Error::InvalidMarkerWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode/value_ref.rs:77:40 [INFO] [stderr] | [INFO] [stderr] 77 | wr.write_all(data).map_err(|err| Error::InvalidDataWrite(err))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidDataWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:109:38 [INFO] [stderr] | [INFO] [stderr] 109 | Integer { n: IntPriv::PosInt(n as u64) } [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:115:38 [INFO] [stderr] | [INFO] [stderr] 115 | Integer { n: IntPriv::PosInt(n as u64) } [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:121:38 [INFO] [stderr] | [INFO] [stderr] 121 | Integer { n: IntPriv::PosInt(n as u64) } [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:42 [INFO] [stderr] | [INFO] [stderr] 140 | Integer { n: IntPriv::NegInt(n as i64) } [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:150:42 [INFO] [stderr] | [INFO] [stderr] 150 | Integer { n: IntPriv::NegInt(n as i64) } [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:160:42 [INFO] [stderr] | [INFO] [stderr] 160 | Integer { n: IntPriv::NegInt(n as i64) } [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:1015:9 [INFO] [stderr] | [INFO] [stderr] 1015 | / match self { [INFO] [stderr] 1016 | | &ValueRef::Nil => Value::Nil, [INFO] [stderr] 1017 | | &ValueRef::Boolean(val) => Value::Boolean(val), [INFO] [stderr] 1018 | | &ValueRef::Integer(val) => Value::Integer(val), [INFO] [stderr] ... | [INFO] [stderr] 1029 | | &ValueRef::Ext(ty, buf) => Value::Ext(ty, buf.to_vec()), [INFO] [stderr] 1030 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1015 | match *self { [INFO] [stderr] 1016 | ValueRef::Nil => Value::Nil, [INFO] [stderr] 1017 | ValueRef::Boolean(val) => Value::Boolean(val), [INFO] [stderr] 1018 | ValueRef::Integer(val) => Value::Integer(val), [INFO] [stderr] 1019 | ValueRef::F32(val) => Value::F32(val), [INFO] [stderr] 1020 | ValueRef::F64(val) => Value::F64(val), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: defining a method called `index` on this type; consider implementing the `std::ops::Index` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:1033:5 [INFO] [stderr] | [INFO] [stderr] 1033 | / pub fn index(&self, index: usize) -> &ValueRef { [INFO] [stderr] 1034 | | self.as_array().and_then(|v| v.get(index)).unwrap_or(&NIL_REF) [INFO] [stderr] 1035 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:1164:26 [INFO] [stderr] | [INFO] [stderr] 1164 | ValueRef::Binary(v.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "80706020d748c63fd988481cb82901b881219d7ee0a2a18391bccdf8f7fe0a4e"` [INFO] running `"docker" "rm" "-f" "80706020d748c63fd988481cb82901b881219d7ee0a2a18391bccdf8f7fe0a4e"` [INFO] [stdout] 80706020d748c63fd988481cb82901b881219d7ee0a2a18391bccdf8f7fe0a4e