[INFO] crate rmp-serialize 0.8.0 is already in cache [INFO] extracting crate rmp-serialize 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/rmp-serialize/0.8.0 [INFO] extracting crate rmp-serialize 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rmp-serialize/0.8.0 [INFO] validating manifest of rmp-serialize-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rmp-serialize-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rmp-serialize-0.8.0 [INFO] finished frobbing rmp-serialize-0.8.0 [INFO] frobbed toml for rmp-serialize-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/rmp-serialize/0.8.0/Cargo.toml [INFO] started frobbing rmp-serialize-0.8.0 [INFO] finished frobbing rmp-serialize-0.8.0 [INFO] frobbed toml for rmp-serialize-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rmp-serialize/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rmp-serialize-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rmp-serialize/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f986a697575d8bb2652ccd8e2ad398ee1c3d321d3fae23a6111d9c8dcb05d0db [INFO] running `"docker" "start" "-a" "f986a697575d8bb2652ccd8e2ad398ee1c3d321d3fae23a6111d9c8dcb05d0db"` [INFO] [stderr] Checking rmp-serialize v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | Decoder { rd: rd } [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | wr: wr, [INFO] [stderr] | ^^^^^^ help: replace it with: `wr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode.rs:98:19 [INFO] [stderr] | [INFO] [stderr] 98 | Decoder { rd: rd } [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | wr: wr, [INFO] [stderr] | ^^^^^^ help: replace it with: `wr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/decode.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | Ok(try!(read_nil(&mut self.rd))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/decode.rs:122:12 [INFO] [stderr] | [INFO] [stderr] 122 | Ok(try!(read_nil(&mut self.rd))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode.rs:191:51 [INFO] [stderr] | [INFO] [stderr] 191 | try!(self.rd.read_exact(&mut buf).map_err(|err| Error::InvalidDataRead(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidDataRead` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | write_nil(&mut self.wr).map_err(|err| ValueWriteError::InvalidMarkerWrite(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ValueWriteError::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode.rs:45:47 [INFO] [stderr] | [INFO] [stderr] 45 | write_bool(&mut self.wr, val).map_err(|err| ValueWriteError::InvalidMarkerWrite(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ValueWriteError::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | self.emit_u64(val as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | self.emit_u64(val as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | self.emit_u64(val as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/decode.rs:191:51 [INFO] [stderr] | [INFO] [stderr] 191 | try!(self.rd.read_exact(&mut buf).map_err(|err| Error::InvalidDataRead(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::InvalidDataRead` [INFO] [stderr] | [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | self.emit_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | self.emit_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | self.emit_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | write_nil(&mut self.wr).map_err(|err| ValueWriteError::InvalidMarkerWrite(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ValueWriteError::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/encode.rs:45:47 [INFO] [stderr] | [INFO] [stderr] 45 | write_bool(&mut self.wr, val).map_err(|err| ValueWriteError::InvalidMarkerWrite(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ValueWriteError::InvalidMarkerWrite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:49:23 [INFO] [stderr] | [INFO] [stderr] 49 | self.emit_u64(val as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | self.emit_u64(val as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | self.emit_u64(val as u64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | self.emit_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | self.emit_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:78:23 [INFO] [stderr] | [INFO] [stderr] 78 | self.emit_i64(val as i64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encoder.rs:76:15 [INFO] [stderr] | [INFO] [stderr] 76 | let val = 4294967295u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_294_967_295u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encoder.rs:86:15 [INFO] [stderr] | [INFO] [stderr] 86 | let val = 18446744073709551615u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encoder.rs:126:16 [INFO] [stderr] | [INFO] [stderr] 126 | let val = -2147483648i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `2_147_483_648i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encoder.rs:136:16 [INFO] [stderr] | [INFO] [stderr] 136 | let val = -9223372036854775808i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encoder.rs:146:15 [INFO] [stderr] | [INFO] [stderr] 146 | let val = 3.4028234e38_f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `3.402_823_4e38_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encoder.rs:190:40 [INFO] [stderr] | [INFO] [stderr] 190 | let val = Decoded { id: 42, value: 100500 }; [INFO] [stderr] | ^^^^^^ help: consider: `100_500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/encoder.rs:200:23 [INFO] [stderr] | [INFO] [stderr] 200 | let val = (42u32, 100500u32); [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_500u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let val =` [INFO] [stderr] --> tests/encoder.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | let val = (); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/encoder.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | val.encode(&mut Encoder::new(&mut &mut buf[..])).ok().unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 13 | ().encode(&mut Encoder::new(&mut &mut buf[..])).ok().unwrap(); [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let val =` [INFO] [stderr] --> tests/encoder.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | let val = (); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> tests/encoder.rs:24:11 [INFO] [stderr] | [INFO] [stderr] 24 | match val.encode(&mut Encoder::new(&mut &mut buf[..])) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 24 | match ().encode(&mut Encoder::new(&mut &mut buf[..])) { [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/encoder.rs:146:15 [INFO] [stderr] | [INFO] [stderr] 146 | let val = 3.4028234e38_f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.87s [INFO] running `"docker" "inspect" "f986a697575d8bb2652ccd8e2ad398ee1c3d321d3fae23a6111d9c8dcb05d0db"` [INFO] running `"docker" "rm" "-f" "f986a697575d8bb2652ccd8e2ad398ee1c3d321d3fae23a6111d9c8dcb05d0db"` [INFO] [stdout] f986a697575d8bb2652ccd8e2ad398ee1c3d321d3fae23a6111d9c8dcb05d0db