[INFO] crate rmp 0.8.7 is already in cache [INFO] extracting crate rmp 0.8.7 into work/ex/clippy-test-run/sources/stable/reg/rmp/0.8.7 [INFO] extracting crate rmp 0.8.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rmp/0.8.7 [INFO] validating manifest of rmp-0.8.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rmp-0.8.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rmp-0.8.7 [INFO] finished frobbing rmp-0.8.7 [INFO] frobbed toml for rmp-0.8.7 written to work/ex/clippy-test-run/sources/stable/reg/rmp/0.8.7/Cargo.toml [INFO] started frobbing rmp-0.8.7 [INFO] finished frobbing rmp-0.8.7 [INFO] frobbed toml for rmp-0.8.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rmp/0.8.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rmp-0.8.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rmp/0.8.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d4d7d4693c680e564bc4c6d153e806759ff30afe5cd1a852b87bac88e238e211 [INFO] running `"docker" "start" "-a" "d4d7d4693c680e564bc4c6d153e806759ff30afe5cd1a852b87bac88e238e211"` [INFO] [stderr] Checking rmp v0.8.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decode/ext.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] --> src/decode/ext.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/sint.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | val if -2147483648 <= val && val < -32768 => write_i32(wr, val as i32).and(Ok(Marker::I32)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/sint.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | val if val < -2147483648 => write_i64(wr, val).and(Ok(Marker::I64)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/sint.rs:165:22 [INFO] [stderr] | [INFO] [stderr] 165 | val if val < 4294967296 => write_u32(wr, val as u32).and(Ok(Marker::U32)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/uint.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | } else if val < 4294967296 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'decode::str::read_str_ref': useless, use `read_str_from_slice` instead [INFO] [stderr] --> src/decode/mod.rs:21:66 [INFO] [stderr] | [INFO] [stderr] 21 | pub use self::str::{read_str_len, read_str, read_str_from_slice, read_str_ref, DecodeStringError}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/sint.rs:156:17 [INFO] [stderr] | [INFO] [stderr] 156 | val if -2147483648 <= val && val < -32768 => write_i32(wr, val as i32).and(Ok(Marker::I32)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/sint.rs:157:23 [INFO] [stderr] | [INFO] [stderr] 157 | val if val < -2147483648 => write_i64(wr, val).and(Ok(Marker::I64)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/sint.rs:165:22 [INFO] [stderr] | [INFO] [stderr] 165 | val if val < 4294967296 => write_u32(wr, val as u32).and(Ok(Marker::U32)), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/encode/uint.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | } else if val < 4294967296 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_296` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'decode::str::read_str_ref': useless, use `read_str_from_slice` instead [INFO] [stderr] --> src/decode/mod.rs:21:66 [INFO] [stderr] | [INFO] [stderr] 21 | pub use self::str::{read_str_len, read_str, read_str_from_slice, read_str_ref, DecodeStringError}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decode/str.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn read_str<'r, R>(rd: &mut R, mut buf: &'r mut [u8]) -> Result<&'r str, DecodeStringError<'r>> [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/marker.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn to_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/str.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | Marker::FixStr(size) => Ok((size as u32, 1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/str.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | Marker::Str8 => Ok((read_data_u8(rd)? as u32, 2)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_data_u8(rd)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/str.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | Marker::Str16 => Ok((read_data_u16(rd)? as u32, 3)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_data_u16(rd)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/decode/str.rs:110:36 [INFO] [stderr] | [INFO] [stderr] 110 | pub fn read_str<'r, R>(rd: &mut R, mut buf: &'r mut [u8]) -> Result<&'r str, DecodeStringError<'r>> [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/decode/str.rs:139:60 [INFO] [stderr] | [INFO] [stderr] 139 | Err(err) => Err(DecodeStringError::InvalidDataRead(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: The function/method `from_utf8` doesn't need a mutable reference [INFO] [stderr] --> src/decode/str.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | match from_utf8(&mut &head[nread..]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/decode/ext.rs:130:57 [INFO] [stderr] | [INFO] [stderr] 130 | Err(err) => Err(ValueReadError::InvalidDataRead(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/ext.rs:160:25 [INFO] [stderr] | [INFO] [stderr] 160 | Marker::Ext8 => try!(read_data_u8(rd)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 160 | Marker::Ext8 => u32::from(match $ expr { [INFO] [stderr] 161 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 162 | :: Err ( err ) => { [INFO] [stderr] 163 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 164 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/ext.rs:161:26 [INFO] [stderr] | [INFO] [stderr] 161 | Marker::Ext16 => try!(read_data_u16(rd)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | Marker::Ext16 => u32::from(match $ expr { [INFO] [stderr] 162 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 163 | :: Err ( err ) => { [INFO] [stderr] 164 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 165 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/marker.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn to_u8(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:321:38 [INFO] [stderr] | [INFO] [stderr] 321 | Marker::FixArray(size) => Ok(size as u32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:322:31 [INFO] [stderr] | [INFO] [stderr] 322 | Marker::Array16 => Ok(try!(read_data_u16(rd)) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | Marker::Array16 => Ok(u32::from(match $ expr { [INFO] [stderr] 323 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 324 | :: Err ( err ) => { [INFO] [stderr] 325 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 326 | $ crate :: convert :: From :: from ( err ) ) } })), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:341:36 [INFO] [stderr] | [INFO] [stderr] 341 | Marker::FixMap(size) => Ok(size as u32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:342:29 [INFO] [stderr] | [INFO] [stderr] 342 | Marker::Map16 => Ok(try!(read_data_u16(rd)) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 342 | Marker::Map16 => Ok(u32::from(match $ expr { [INFO] [stderr] 343 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 344 | :: Err ( err ) => { [INFO] [stderr] 345 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 346 | $ crate :: convert :: From :: from ( err ) ) } })), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:357:28 [INFO] [stderr] | [INFO] [stderr] 357 | Marker::Bin8 => Ok(try!(read_data_u8(rd)) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 357 | Marker::Bin8 => Ok(u32::from(match $ expr { [INFO] [stderr] 358 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 359 | :: Err ( err ) => { [INFO] [stderr] 360 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 361 | $ crate :: convert :: From :: from ( err ) ) } })), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:358:29 [INFO] [stderr] | [INFO] [stderr] 358 | Marker::Bin16 => Ok(try!(read_data_u16(rd)) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 358 | Marker::Bin16 => Ok(u32::from(match $ expr { [INFO] [stderr] 359 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 360 | :: Err ( err ) => { [INFO] [stderr] 361 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 362 | $ crate :: convert :: From :: from ( err ) ) } })), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/str.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | Marker::FixStr(size) => Ok((size as u32, 1)), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/str.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | Marker::Str8 => Ok((read_data_u8(rd)? as u32, 2)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_data_u8(rd)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/str.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | Marker::Str16 => Ok((read_data_u16(rd)? as u32, 3)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(read_data_u16(rd)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/decode/str.rs:139:60 [INFO] [stderr] | [INFO] [stderr] 139 | Err(err) => Err(DecodeStringError::InvalidDataRead(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: The function/method `from_utf8` doesn't need a mutable reference [INFO] [stderr] --> src/decode/str.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | match from_utf8(&mut &head[nread..]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/decode/ext.rs:130:57 [INFO] [stderr] | [INFO] [stderr] 130 | Err(err) => Err(ValueReadError::InvalidDataRead(From::from(err))), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/ext.rs:160:25 [INFO] [stderr] | [INFO] [stderr] 160 | Marker::Ext8 => try!(read_data_u8(rd)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 160 | Marker::Ext8 => u32::from(match $ expr { [INFO] [stderr] 161 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 162 | :: Err ( err ) => { [INFO] [stderr] 163 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 164 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/ext.rs:161:26 [INFO] [stderr] | [INFO] [stderr] 161 | Marker::Ext16 => try!(read_data_u16(rd)) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | Marker::Ext16 => u32::from(match $ expr { [INFO] [stderr] 162 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 163 | :: Err ( err ) => { [INFO] [stderr] 164 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 165 | $ crate :: convert :: From :: from ( err ) ) } }), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:321:38 [INFO] [stderr] | [INFO] [stderr] 321 | Marker::FixArray(size) => Ok(size as u32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:322:31 [INFO] [stderr] | [INFO] [stderr] 322 | Marker::Array16 => Ok(try!(read_data_u16(rd)) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 322 | Marker::Array16 => Ok(u32::from(match $ expr { [INFO] [stderr] 323 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 324 | :: Err ( err ) => { [INFO] [stderr] 325 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 326 | $ crate :: convert :: From :: from ( err ) ) } })), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:341:36 [INFO] [stderr] | [INFO] [stderr] 341 | Marker::FixMap(size) => Ok(size as u32), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:342:29 [INFO] [stderr] | [INFO] [stderr] 342 | Marker::Map16 => Ok(try!(read_data_u16(rd)) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 342 | Marker::Map16 => Ok(u32::from(match $ expr { [INFO] [stderr] 343 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 344 | :: Err ( err ) => { [INFO] [stderr] 345 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 346 | $ crate :: convert :: From :: from ( err ) ) } })), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:357:28 [INFO] [stderr] | [INFO] [stderr] 357 | Marker::Bin8 => Ok(try!(read_data_u8(rd)) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 357 | Marker::Bin8 => Ok(u32::from(match $ expr { [INFO] [stderr] 358 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 359 | :: Err ( err ) => { [INFO] [stderr] 360 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 361 | $ crate :: convert :: From :: from ( err ) ) } })), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode/mod.rs:358:29 [INFO] [stderr] | [INFO] [stderr] 358 | Marker::Bin16 => Ok(try!(read_data_u16(rd)) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 358 | Marker::Bin16 => Ok(u32::from(match $ expr { [INFO] [stderr] 359 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 360 | :: Err ( err ) => { [INFO] [stderr] 361 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 362 | $ crate :: convert :: From :: from ( err ) ) } })), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `rmp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/array.rs:26:68 [INFO] [stderr] | [INFO] [stderr] 26 | assert_eq!(Marker::Array32, write_array_len(&mut &mut buf[..], 4294967295).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/bin.rs:26:64 [INFO] [stderr] | [INFO] [stderr] 26 | assert_eq!(Marker::Bin32, write_bin_len(&mut &mut buf[..], 4294967295).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/ext.rs:72:65 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(Marker::Ext32, write_ext_meta(&mut &mut buf[..], 4294967295, 16).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/float.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | write_f32(&mut &mut buf[..], 3.4028234e38_f32).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `3.402_823_4e38_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:50:34 [INFO] [stderr] | [INFO] [stderr] 50 | write_u32(&mut &mut buf[..], 4294967295).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:59:34 [INFO] [stderr] | [INFO] [stderr] 59 | write_u64(&mut &mut buf[..], 18446744073709551615).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:111:35 [INFO] [stderr] | [INFO] [stderr] 111 | write_i32(&mut &mut buf[..], -2147483648).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:120:35 [INFO] [stderr] | [INFO] [stderr] 120 | write_i64(&mut &mut buf[..], -9223372036854775808).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:156:59 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(Marker::U32, write_uint(&mut &mut buf[..], 4294967295).ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:165:59 [INFO] [stderr] | [INFO] [stderr] 165 | assert_eq!(Marker::U64, write_uint(&mut &mut buf[..], 18446744073709551615).ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:210:60 [INFO] [stderr] | [INFO] [stderr] 210 | assert_eq!(Marker::I32, write_sint(&mut &mut buf[..], -2147483648).ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:219:59 [INFO] [stderr] | [INFO] [stderr] 219 | assert_eq!(Marker::U32, write_sint(&mut &mut buf[..], 2147483647).ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:228:60 [INFO] [stderr] | [INFO] [stderr] 228 | assert_eq!(Marker::I64, write_sint(&mut &mut buf[..], -9223372036854775808).ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/int.rs:237:59 [INFO] [stderr] | [INFO] [stderr] 237 | assert_eq!(Marker::U64, write_sint(&mut &mut buf[..], 9223372036854775807).ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/map.rs:26:64 [INFO] [stderr] | [INFO] [stderr] 26 | assert_eq!(Marker::Map32, write_map_len(&mut &mut buf[..], 4294967295).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/encode/string.rs:35:64 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(Marker::Str32, write_str_len(&mut &mut buf[..], 4294967295).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/sint.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | assert_eq!(-2147483648, read_i32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/sint.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | assert_eq!(2147483647, read_i32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/sint.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(-9223372036854775808, read_i64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/sint.rs:167:16 [INFO] [stderr] | [INFO] [stderr] 167 | assert_eq!(9223372036854775807, read_i64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/sint.rs:251:17 [INFO] [stderr] | [INFO] [stderr] 251 | assert_eq!(-2147483648, read_int(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/sint.rs:260:16 [INFO] [stderr] | [INFO] [stderr] 260 | assert_eq!(2147483647, read_int(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_147_483_647` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/sint.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | assert_eq!(-9223372036854775808i64, read_int(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_808i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/sint.rs:278:16 [INFO] [stderr] | [INFO] [stderr] 278 | assert_eq!(9223372036854775807i64, read_int(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/uint.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | assert_eq!(4294967295, read_u32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/uint.rs:143:16 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(4294967295u64, read_int(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_294_967_295u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/uint.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | assert_eq!(4294967296u64, read_int(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_294_967_296u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/uint.rs:167:16 [INFO] [stderr] | [INFO] [stderr] 167 | assert_eq!(18446744073709551615u64, read_int(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/float.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(3.4028234e38_f32, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `3.402_823_4e38_f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/string.rs:110:16 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(4294967295, read_str_len(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/bin.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | assert_eq!(4294967295, read_bin_len(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/array.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | assert_eq!(4294967295, read_array_len(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/func/decode/ext.rs:126:43 [INFO] [stderr] | [INFO] [stderr] 126 | assert_eq!(ExtMeta { typeid: 1, size: 4294967295 }, read_ext_meta(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/func/encode/float.rs:7:34 [INFO] [stderr] | [INFO] [stderr] 7 | write_f32(&mut &mut buf[..], 3.4028234e38_f32).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/func/decode/null.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | assert!(buf.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/decode/float.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | assert_eq!(0.0, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/decode/float.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | assert_eq!(0.0, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> tests/func/decode/float.rs:20:16 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(3.4028234e38_f32, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.402_823_5e38` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/decode/float.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(3.4028234e38_f32, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/decode/float.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(3.4028234e38_f32, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/decode/float.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | assert_eq!(f32::INFINITY, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/decode/float.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | assert_eq!(f32::INFINITY, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/decode/float.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(f32::NEG_INFINITY, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/decode/float.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | assert_eq!(f32::NEG_INFINITY, read_f32(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/decode/float.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(0.0, read_f64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/decode/float.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | assert_eq!(0.0, read_f64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/decode/float.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(-0.0, read_f64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/decode/float.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(-0.0, read_f64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/decode/float.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(f64::INFINITY, read_f64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/decode/float.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(f64::INFINITY, read_f64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/decode/float.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(f64::NEG_INFINITY, read_f64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/decode/float.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | assert_eq!(f64::NEG_INFINITY, read_f64(&mut cur).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> tests/func/decode/string.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | / loop { [INFO] [stderr] 232 | | match read_str_from_slice(unparsed) { [INFO] [stderr] 233 | | Ok((chunk, tail)) => { [INFO] [stderr] 234 | | chunks.push(chunk); [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok((chunk, tail)) = read_str_from_slice(unparsed) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/mirror.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | xs == decode::read_f32(&mut &buf[..]).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(xs - decode::read_f32(&mut &buf[..]).unwrap()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/mirror.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | xs == decode::read_f32(&mut &buf[..]).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/func/mirror.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | xs == decode::read_f64(&mut &buf[..]).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(xs - decode::read_f64(&mut &buf[..]).unwrap()).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/func/mirror.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | xs == decode::read_f64(&mut &buf[..]).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rmp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d4d7d4693c680e564bc4c6d153e806759ff30afe5cd1a852b87bac88e238e211"` [INFO] running `"docker" "rm" "-f" "d4d7d4693c680e564bc4c6d153e806759ff30afe5cd1a852b87bac88e238e211"` [INFO] [stdout] d4d7d4693c680e564bc4c6d153e806759ff30afe5cd1a852b87bac88e238e211