[INFO] crate rmb 0.0.2 is already in cache [INFO] extracting crate rmb 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/rmb/0.0.2 [INFO] extracting crate rmb 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rmb/0.0.2 [INFO] validating manifest of rmb-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rmb-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rmb-0.0.2 [INFO] finished frobbing rmb-0.0.2 [INFO] frobbed toml for rmb-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/rmb/0.0.2/Cargo.toml [INFO] started frobbing rmb-0.0.2 [INFO] finished frobbing rmb-0.0.2 [INFO] frobbed toml for rmb-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rmb/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rmb-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rmb/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef3042686d7d1ce496f4034f7e806cdb592a9da5308c91ab61a7d6f92084df1b [INFO] running `"docker" "start" "-a" "ef3042686d7d1ce496f4034f7e806cdb592a9da5308c91ab61a7d6f92084df1b"` [INFO] [stderr] Checking subprocess v0.1.18 [INFO] [stderr] Checking rmb v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/app.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | let home_dir = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/store.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | let mut home = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/app.rs:89:20 [INFO] [stderr] | [INFO] [stderr] 89 | let home_dir = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/store.rs:45:20 [INFO] [stderr] | [INFO] [stderr] 45 | let mut home = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/app.rs:113:47 [INFO] [stderr] | [INFO] [stderr] 113 | fn find_last_command(shell: &Shell, histfile: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/app.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / let mut skip: usize = 0; [INFO] [stderr] 137 | | if shell == &Shell::ZSH { [INFO] [stderr] 138 | | skip = last_command_str.find(";").unwrap_or_else(|| 0) + 1; [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let skip = if shell == &Shell::ZSH { last_command_str.find(";").unwrap_or_else(|| 0) + 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:138:38 [INFO] [stderr] | [INFO] [stderr] 138 | skip = last_command_str.find(";").unwrap_or_else(|| 0) + 1; [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/app.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / match shell { [INFO] [stderr] 148 | | &Shell::ZSH => { [INFO] [stderr] 149 | | arg = String::from("source ~/.zshrc && ") + &cmd_string; [INFO] [stderr] 150 | | cmd = "zsh".to_string(); [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | match *shell { [INFO] [stderr] 148 | Shell::ZSH => { [INFO] [stderr] 149 | arg = String::from("source ~/.zshrc && ") + &cmd_string; [INFO] [stderr] 150 | cmd = "zsh".to_string(); [INFO] [stderr] 151 | }, [INFO] [stderr] 152 | Shell::BASH => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/app.rs:241:12 [INFO] [stderr] | [INFO] [stderr] 241 | Ok(run_cmd(&self.shell, cmd.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 241 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/app.rs:250:12 [INFO] [stderr] | [INFO] [stderr] 250 | Ok(run_cmd(&self.shell, cmd.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 250 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/app.rs:113:47 [INFO] [stderr] | [INFO] [stderr] 113 | fn find_last_command(shell: &Shell, histfile: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/app.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / let mut skip: usize = 0; [INFO] [stderr] 137 | | if shell == &Shell::ZSH { [INFO] [stderr] 138 | | skip = last_command_str.find(";").unwrap_or_else(|| 0) + 1; [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let skip = if shell == &Shell::ZSH { last_command_str.find(";").unwrap_or_else(|| 0) + 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/app.rs:138:38 [INFO] [stderr] | [INFO] [stderr] 138 | skip = last_command_str.find(";").unwrap_or_else(|| 0) + 1; [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/app.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | / match shell { [INFO] [stderr] 148 | | &Shell::ZSH => { [INFO] [stderr] 149 | | arg = String::from("source ~/.zshrc && ") + &cmd_string; [INFO] [stderr] 150 | | cmd = "zsh".to_string(); [INFO] [stderr] ... | [INFO] [stderr] 155 | | } [INFO] [stderr] 156 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 147 | match *shell { [INFO] [stderr] 148 | Shell::ZSH => { [INFO] [stderr] 149 | arg = String::from("source ~/.zshrc && ") + &cmd_string; [INFO] [stderr] 150 | cmd = "zsh".to_string(); [INFO] [stderr] 151 | }, [INFO] [stderr] 152 | Shell::BASH => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/app.rs:241:12 [INFO] [stderr] | [INFO] [stderr] 241 | Ok(run_cmd(&self.shell, cmd.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 241 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/app.rs:250:12 [INFO] [stderr] | [INFO] [stderr] 250 | Ok(run_cmd(&self.shell, cmd.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 250 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.92s [INFO] running `"docker" "inspect" "ef3042686d7d1ce496f4034f7e806cdb592a9da5308c91ab61a7d6f92084df1b"` [INFO] running `"docker" "rm" "-f" "ef3042686d7d1ce496f4034f7e806cdb592a9da5308c91ab61a7d6f92084df1b"` [INFO] [stdout] ef3042686d7d1ce496f4034f7e806cdb592a9da5308c91ab61a7d6f92084df1b