[INFO] crate rline 0.1.2 is already in cache [INFO] extracting crate rline 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/rline/0.1.2 [INFO] extracting crate rline 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rline/0.1.2 [INFO] validating manifest of rline-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rline-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rline-0.1.2 [INFO] finished frobbing rline-0.1.2 [INFO] frobbed toml for rline-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/rline/0.1.2/Cargo.toml [INFO] started frobbing rline-0.1.2 [INFO] finished frobbing rline-0.1.2 [INFO] frobbed toml for rline-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rline/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rline-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rline/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29e9124b061cff9d30dbba94f350d4fd8541164ca362256cb8ae3b024436a3c2 [INFO] running `"docker" "start" "-a" "29e9124b061cff9d30dbba94f350d4fd8541164ca362256cb8ae3b024436a3c2"` [INFO] [stderr] Compiling rline v0.1.2 (/opt/crater/workdir) [INFO] [stderr] Checking uid v0.1.4 [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | block_in_if_condition_stmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | redundant_field_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | block_in_if_condition_stmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_field_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:3 [INFO] [stderr] | [INFO] [stderr] 23 | redundant_field_names, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_field_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | block_in_if_condition_stmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:22:3 [INFO] [stderr] | [INFO] [stderr] 22 | block_in_if_condition_stmt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:436:3 [INFO] [stderr] | [INFO] [stderr] 436 | / pub fn reset<'s, S>(&'s mut self, line: S, cursor: usize, clear_undo: bool) [INFO] [stderr] 437 | | where [INFO] [stderr] 438 | | S: AsRef, [INFO] [stderr] 439 | | { [INFO] [stderr] ... | [INFO] [stderr] 447 | | } [INFO] [stderr] 448 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:452:3 [INFO] [stderr] | [INFO] [stderr] 452 | / pub fn inspect<'slf, F, R>(&'slf mut self, inspector: F) -> R [INFO] [stderr] 453 | | where [INFO] [stderr] 454 | | F: FnOnce(&CStr, usize) -> R, [INFO] [stderr] 455 | | { [INFO] [stderr] ... | [INFO] [stderr] 469 | | inspector(s, pos) [INFO] [stderr] 470 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rline`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:436:3 [INFO] [stderr] | [INFO] [stderr] 436 | / pub fn reset<'s, S>(&'s mut self, line: S, cursor: usize, clear_undo: bool) [INFO] [stderr] 437 | | where [INFO] [stderr] 438 | | S: AsRef, [INFO] [stderr] 439 | | { [INFO] [stderr] ... | [INFO] [stderr] 447 | | } [INFO] [stderr] 448 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_lifetimes)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:452:3 [INFO] [stderr] | [INFO] [stderr] 452 | / pub fn inspect<'slf, F, R>(&'slf mut self, inspector: F) -> R [INFO] [stderr] 453 | | where [INFO] [stderr] 454 | | F: FnOnce(&CStr, usize) -> R, [INFO] [stderr] 455 | | { [INFO] [stderr] ... | [INFO] [stderr] 469 | | inspector(s, pos) [INFO] [stderr] 470 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:525:24 [INFO] [stderr] | [INFO] [stderr] 525 | assert_eq!(rl.feed('\n' as u8).unwrap(), CString::new("").unwrap()) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | warnings, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::char_lit_as_u8)] implied by #[deny(warnings)] [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:535:24 [INFO] [stderr] | [INFO] [stderr] 535 | assert_eq!(rl.feed('\n' as u8).unwrap(), CString::new("first").unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:540:24 [INFO] [stderr] | [INFO] [stderr] 540 | assert_eq!(rl.feed('\n' as u8).unwrap(), CString::new("second").unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:547:24 [INFO] [stderr] | [INFO] [stderr] 547 | assert_eq!(rl.feed('a' as u8), None); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:550:24 [INFO] [stderr] | [INFO] [stderr] 550 | assert_eq!(rl.feed('b' as u8), None); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'b' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:553:24 [INFO] [stderr] | [INFO] [stderr] 553 | assert_eq!(rl.feed('c' as u8), None); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'c' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:561:24 [INFO] [stderr] | [INFO] [stderr] 561 | assert_eq!(rl.feed('x' as u8), None); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'x' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:562:24 [INFO] [stderr] | [INFO] [stderr] 562 | assert_eq!(rl.feed('y' as u8), None); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'y' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:563:24 [INFO] [stderr] | [INFO] [stderr] 563 | assert_eq!(rl.feed('z' as u8), None); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:569:24 [INFO] [stderr] | [INFO] [stderr] 569 | assert_eq!(rl.feed('x' as u8), None); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'x' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:571:24 [INFO] [stderr] | [INFO] [stderr] 571 | assert_eq!(rl.feed('\n' as u8).unwrap(), CString::new("axbc").unwrap()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:576:24 [INFO] [stderr] | [INFO] [stderr] 576 | assert_eq!(rl.feed('y' as u8), None); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'y' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] error: aborting due to 14 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rline`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "29e9124b061cff9d30dbba94f350d4fd8541164ca362256cb8ae3b024436a3c2"` [INFO] running `"docker" "rm" "-f" "29e9124b061cff9d30dbba94f350d4fd8541164ca362256cb8ae3b024436a3c2"` [INFO] [stdout] 29e9124b061cff9d30dbba94f350d4fd8541164ca362256cb8ae3b024436a3c2