[INFO] crate rlife 0.1.0 is already in cache [INFO] extracting crate rlife 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rlife/0.1.0 [INFO] extracting crate rlife 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rlife/0.1.0 [INFO] validating manifest of rlife-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rlife-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rlife-0.1.0 [INFO] finished frobbing rlife-0.1.0 [INFO] frobbed toml for rlife-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rlife/0.1.0/Cargo.toml [INFO] started frobbing rlife-0.1.0 [INFO] finished frobbing rlife-0.1.0 [INFO] frobbed toml for rlife-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rlife/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rlife-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rlife/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05c59d79af30c9261fc8668158c7d7b672e9a0f4b19aafe71cf11adc3fafb34d [INFO] running `"docker" "start" "-a" "05c59d79af30c9261fc8668158c7d7b672e9a0f4b19aafe71cf11adc3fafb34d"` [INFO] [stderr] Checking rlife v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/lib.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | write!(f, "\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/processing.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 76 | | if self.get_birth().contains(&living_cells_around) { [INFO] [stderr] 77 | | grid.set_cell_state(row, col, true).unwrap(); // Shouldn't fail [INFO] [stderr] 78 | | } // else: remains false [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 75 | } else if self.get_birth().contains(&living_cells_around) { [INFO] [stderr] 76 | grid.set_cell_state(row, col, true).unwrap(); // Shouldn't fail [INFO] [stderr] 77 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/processing.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 125 | | if self.get_birth().contains(&living_cells_around) { [INFO] [stderr] 126 | | grid.set_cell_state( [INFO] [stderr] 127 | | (row as i64 + vertical_offset) as usize, [INFO] [stderr] ... | [INFO] [stderr] 131 | | } // else: remains false [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | } else if self.get_birth().contains(&living_cells_around) { [INFO] [stderr] 125 | grid.set_cell_state( [INFO] [stderr] 126 | (row as i64 + vertical_offset) as usize, [INFO] [stderr] 127 | (col as i64 + horizontal_offset) as usize, [INFO] [stderr] 128 | true, [INFO] [stderr] 129 | ).unwrap(); // Shouldn't fail [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/processing.rs:75:24 [INFO] [stderr] | [INFO] [stderr] 75 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 76 | | if self.get_birth().contains(&living_cells_around) { [INFO] [stderr] 77 | | grid.set_cell_state(row, col, true).unwrap(); // Shouldn't fail [INFO] [stderr] 78 | | } // else: remains false [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 75 | } else if self.get_birth().contains(&living_cells_around) { [INFO] [stderr] 76 | grid.set_cell_state(row, col, true).unwrap(); // Shouldn't fail [INFO] [stderr] 77 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/processing.rs:124:24 [INFO] [stderr] | [INFO] [stderr] 124 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 125 | | if self.get_birth().contains(&living_cells_around) { [INFO] [stderr] 126 | | grid.set_cell_state( [INFO] [stderr] 127 | | (row as i64 + vertical_offset) as usize, [INFO] [stderr] ... | [INFO] [stderr] 131 | | } // else: remains false [INFO] [stderr] 132 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | } else if self.get_birth().contains(&living_cells_around) { [INFO] [stderr] 125 | grid.set_cell_state( [INFO] [stderr] 126 | (row as i64 + vertical_offset) as usize, [INFO] [stderr] 127 | (col as i64 + horizontal_offset) as usize, [INFO] [stderr] 128 | true, [INFO] [stderr] 129 | ).unwrap(); // Shouldn't fail [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/file.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | let ruleset = ruleset_line [INFO] [stderr] | _______________________^ [INFO] [stderr] 146 | | .split_whitespace() [INFO] [stderr] 147 | | .filter(|s| *s != "#R") [INFO] [stderr] 148 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|s| *s != "#R").next()` with `find(|s| *s != "#R")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/file.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | let ruleset = ruleset_line [INFO] [stderr] | _______________________^ [INFO] [stderr] 227 | | .split_whitespace() [INFO] [stderr] 228 | | .filter(|s| *s != "#R") [INFO] [stderr] 229 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|s| *s != "#R").next()` with `find(|s| *s != "#R")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/file.rs:312:5 [INFO] [stderr] | [INFO] [stderr] 312 | / let mut brth: Vec = Vec::new(); [INFO] [stderr] 313 | | if *lines.front().unwrap() == "#N" { [INFO] [stderr] 314 | | lines.pop_front().unwrap(); [INFO] [stderr] 315 | | srvl = vec![2, 3]; [INFO] [stderr] ... | [INFO] [stderr] 332 | | } [INFO] [stderr] 333 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let brth = if *lines.front().unwrap() == "#N" { ..; < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) } else { ..; Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/file.rs:319:23 [INFO] [stderr] | [INFO] [stderr] 319 | let ruleset = ruleset_line [INFO] [stderr] | _______________________^ [INFO] [stderr] 320 | | .split_whitespace() [INFO] [stderr] 321 | | .filter(|s| *s != "#R") [INFO] [stderr] 322 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|s| *s != "#R").next()` with `find(|s| *s != "#R")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file.rs:324:48 [INFO] [stderr] | [INFO] [stderr] 324 | let ruleset: Vec<&str> = ruleset.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/file.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | / let mut brth: Vec = Vec::new(); [INFO] [stderr] 390 | | if *lines.front().unwrap() == "#N" { [INFO] [stderr] 391 | | lines.pop_front().unwrap(); [INFO] [stderr] 392 | | srvl = vec![2, 3]; [INFO] [stderr] ... | [INFO] [stderr] 409 | | } [INFO] [stderr] 410 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let brth = if *lines.front().unwrap() == "#N" { ..; < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) } else { ..; Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/file.rs:396:23 [INFO] [stderr] | [INFO] [stderr] 396 | let ruleset = ruleset_line [INFO] [stderr] | _______________________^ [INFO] [stderr] 397 | | .split_whitespace() [INFO] [stderr] 398 | | .filter(|s| *s != "#R") [INFO] [stderr] 399 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|s| *s != "#R").next()` with `find(|s| *s != "#R")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file.rs:401:48 [INFO] [stderr] | [INFO] [stderr] 401 | let ruleset: Vec<&str> = ruleset.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | frmt: &String, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 52 | frmt: &str, [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `frmt.clone()` to [INFO] [stderr] | [INFO] [stderr] 63 | format: frmt.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:54:15 [INFO] [stderr] | [INFO] [stderr] 54 | srvl: &Vec, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 54 | srvl: &[u8], [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `srvl.clone()` to [INFO] [stderr] | [INFO] [stderr] 65 | survival: srvl.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | brth: &Vec, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 55 | brth: &[u8], [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `brth.clone()` to [INFO] [stderr] | [INFO] [stderr] 66 | birth: brth.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:78:15 [INFO] [stderr] | [INFO] [stderr] 78 | frmt: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:80:15 [INFO] [stderr] | [INFO] [stderr] 80 | srvl: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:81:15 [INFO] [stderr] | [INFO] [stderr] 81 | brth: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:96:40 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn set_format(&mut self, frmt: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 96 | pub fn set_format(&mut self, frmt: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `frmt.clone()` to [INFO] [stderr] | [INFO] [stderr] 97 | self.format = frmt.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn set_survival(&mut self, srvl: &Vec) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 111 | pub fn set_survival(&mut self, srvl: &[u8]) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `srvl.clone()` to [INFO] [stderr] | [INFO] [stderr] 112 | self.survival = srvl.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:121:39 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn set_birth(&mut self, brth: &Vec) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 121 | pub fn set_birth(&mut self, brth: &[u8]) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `brth.clone()` to [INFO] [stderr] | [INFO] [stderr] 122 | self.birth = brth.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/file.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | let ruleset = ruleset_line [INFO] [stderr] | _______________________^ [INFO] [stderr] 146 | | .split_whitespace() [INFO] [stderr] 147 | | .filter(|s| *s != "#R") [INFO] [stderr] 148 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(|s| *s != "#R").next()` with `find(|s| *s != "#R")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/file.rs:226:23 [INFO] [stderr] | [INFO] [stderr] 226 | let ruleset = ruleset_line [INFO] [stderr] | _______________________^ [INFO] [stderr] 227 | | .split_whitespace() [INFO] [stderr] 228 | | .filter(|s| *s != "#R") [INFO] [stderr] 229 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|s| *s != "#R").next()` with `find(|s| *s != "#R")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/file.rs:312:5 [INFO] [stderr] | [INFO] [stderr] 312 | / let mut brth: Vec = Vec::new(); [INFO] [stderr] 313 | | if *lines.front().unwrap() == "#N" { [INFO] [stderr] 314 | | lines.pop_front().unwrap(); [INFO] [stderr] 315 | | srvl = vec![2, 3]; [INFO] [stderr] ... | [INFO] [stderr] 332 | | } [INFO] [stderr] 333 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let brth = if *lines.front().unwrap() == "#N" { ..; < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) } else { ..; Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/file.rs:319:23 [INFO] [stderr] | [INFO] [stderr] 319 | let ruleset = ruleset_line [INFO] [stderr] | _______________________^ [INFO] [stderr] 320 | | .split_whitespace() [INFO] [stderr] 321 | | .filter(|s| *s != "#R") [INFO] [stderr] 322 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|s| *s != "#R").next()` with `find(|s| *s != "#R")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file.rs:324:48 [INFO] [stderr] | [INFO] [stderr] 324 | let ruleset: Vec<&str> = ruleset.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/file.rs:389:5 [INFO] [stderr] | [INFO] [stderr] 389 | / let mut brth: Vec = Vec::new(); [INFO] [stderr] 390 | | if *lines.front().unwrap() == "#N" { [INFO] [stderr] 391 | | lines.pop_front().unwrap(); [INFO] [stderr] 392 | | srvl = vec![2, 3]; [INFO] [stderr] ... | [INFO] [stderr] 409 | | } [INFO] [stderr] 410 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let brth = if *lines.front().unwrap() == "#N" { ..; < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) } else { ..; Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/file.rs:396:23 [INFO] [stderr] | [INFO] [stderr] 396 | let ruleset = ruleset_line [INFO] [stderr] | _______________________^ [INFO] [stderr] 397 | | .split_whitespace() [INFO] [stderr] 398 | | .filter(|s| *s != "#R") [INFO] [stderr] 399 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `filter(|s| *s != "#R").next()` with `find(|s| *s != "#R")` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/file.rs:401:48 [INFO] [stderr] | [INFO] [stderr] 401 | let ruleset: Vec<&str> = ruleset.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:52:15 [INFO] [stderr] | [INFO] [stderr] 52 | frmt: &String, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 52 | frmt: &str, [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `frmt.clone()` to [INFO] [stderr] | [INFO] [stderr] 63 | format: frmt.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:54:15 [INFO] [stderr] | [INFO] [stderr] 54 | srvl: &Vec, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 54 | srvl: &[u8], [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `srvl.clone()` to [INFO] [stderr] | [INFO] [stderr] 65 | survival: srvl.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | brth: &Vec, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 55 | brth: &[u8], [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `brth.clone()` to [INFO] [stderr] | [INFO] [stderr] 66 | birth: brth.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:78:15 [INFO] [stderr] | [INFO] [stderr] 78 | frmt: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:80:15 [INFO] [stderr] | [INFO] [stderr] 80 | srvl: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:81:15 [INFO] [stderr] | [INFO] [stderr] 81 | brth: &Vec, [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:96:40 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn set_format(&mut self, frmt: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 96 | pub fn set_format(&mut self, frmt: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `frmt.clone()` to [INFO] [stderr] | [INFO] [stderr] 97 | self.format = frmt.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn set_survival(&mut self, srvl: &Vec) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 111 | pub fn set_survival(&mut self, srvl: &[u8]) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `srvl.clone()` to [INFO] [stderr] | [INFO] [stderr] 112 | self.survival = srvl.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:121:39 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn set_birth(&mut self, brth: &Vec) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 121 | pub fn set_birth(&mut self, brth: &[u8]) { [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: change `brth.clone()` to [INFO] [stderr] | [INFO] [stderr] 122 | self.birth = brth.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> tests/sanity_check.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / fn test_toroidal_load_file() { [INFO] [stderr] 9 | | let grid = Grid::from_file("tests/input_files/sanity_check_toroidal.life").unwrap(); [INFO] [stderr] 10 | | [INFO] [stderr] 11 | | // Check the `Grid` is correct [INFO] [stderr] ... | [INFO] [stderr] 43 | | assert_eq!(false, grid.get_cell_state(4, 4)); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> tests/sanity_check.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / fn test_toroidal_next_gen() { [INFO] [stderr] 48 | | let grid = Grid::from_file("tests/input_files/sanity_check_toroidal.life").unwrap(); [INFO] [stderr] 49 | | [INFO] [stderr] 50 | | let new_grid = grid.next_gen(); [INFO] [stderr] ... | [INFO] [stderr] 84 | | assert_eq!(false, new_grid.get_cell_state(4, 4)); [INFO] [stderr] 85 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 42 [INFO] [stderr] --> tests/sanity_check.rs:136:1 [INFO] [stderr] | [INFO] [stderr] 136 | / fn test_resizable_next_gen() { [INFO] [stderr] 137 | | let grid = Grid::from_file("tests/input_files/sanity_check_resizable.life").unwrap(); [INFO] [stderr] 138 | | [INFO] [stderr] 139 | | let new_grid = grid.next_gen(); [INFO] [stderr] ... | [INFO] [stderr] 183 | | assert_eq!(false, new_grid.get_cell_state(4, 6)); [INFO] [stderr] 184 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.85s [INFO] running `"docker" "inspect" "05c59d79af30c9261fc8668158c7d7b672e9a0f4b19aafe71cf11adc3fafb34d"` [INFO] running `"docker" "rm" "-f" "05c59d79af30c9261fc8668158c7d7b672e9a0f4b19aafe71cf11adc3fafb34d"` [INFO] [stdout] 05c59d79af30c9261fc8668158c7d7b672e9a0f4b19aafe71cf11adc3fafb34d