[INFO] crate rlbot 0.2.0 is already in cache [INFO] extracting crate rlbot 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/rlbot/0.2.0 [INFO] extracting crate rlbot 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rlbot/0.2.0 [INFO] validating manifest of rlbot-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rlbot-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rlbot-0.2.0 [INFO] finished frobbing rlbot-0.2.0 [INFO] frobbed toml for rlbot-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/rlbot/0.2.0/Cargo.toml [INFO] started frobbing rlbot-0.2.0 [INFO] finished frobbing rlbot-0.2.0 [INFO] frobbed toml for rlbot-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rlbot/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rlbot-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rlbot/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 170e9c169766f7d0dbe15859649db97caaeba0c583980bd664ea2acc05baff25 [INFO] running `"docker" "start" "-a" "170e9c169766f7d0dbe15859649db97caaeba0c583980bd664ea2acc05baff25"` [INFO] [stderr] Compiling winapi v0.3.6 [INFO] [stderr] Checking widestring v0.3.0 [INFO] [stderr] Checking ratelimit v0.4.4 [INFO] [stderr] Checking approx v0.3.1 [INFO] [stderr] Checking flatbuffers v0.5.0 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking winproc v0.5.1 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking rlbot v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rlbot_generated.rs:82:40 [INFO] [stderr] | [INFO] [stderr] 82 | const ENUM_NAMES_TILE_STATE: [&'static str; 4] = ["Unknown", "Filled", "Damaged", "Open"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rlbot_generated.rs:150:41 [INFO] [stderr] | [INFO] [stderr] 150 | const ENUM_NAMES_RENDER_TYPE: [&'static str; 8] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rlbot_generated.rs:342:50 [INFO] [stderr] | [INFO] [stderr] 342 | const ENUM_NAMES_QUICK_CHAT_SELECTION: [&'static str; 58] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rlbot_generated.rs:82:40 [INFO] [stderr] | [INFO] [stderr] 82 | const ENUM_NAMES_TILE_STATE: [&'static str; 4] = ["Unknown", "Filled", "Damaged", "Open"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rlbot_generated.rs:150:41 [INFO] [stderr] | [INFO] [stderr] 150 | const ENUM_NAMES_RENDER_TYPE: [&'static str; 8] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/rlbot_generated.rs:342:50 [INFO] [stderr] | [INFO] [stderr] 342 | const ENUM_NAMES_QUICK_CHAT_SELECTION: [&'static str; 58] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/packeteer.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn next(&mut self) -> Result> { [INFO] [stderr] 41 | | self.spin(Self::try_next) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/packeteer.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if game_time != self.prev_game_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(game_time - self.prev_game_time).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/packeteer.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if game_time != self.prev_game_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/packeteer.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if game_time != self.prev_game_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(game_time - self.prev_game_time).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/packeteer.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if game_time != self.prev_game_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/physicist.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn next(&mut self) -> Result> { [INFO] [stderr] 40 | | self.spin(|this| Ok(this.try_next()?)) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:454:24 [INFO] [stderr] | [INFO] [stderr] 454 | pub fn new<'a>(_x: f32, _y: f32, _z: f32) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:461:13 [INFO] [stderr] | [INFO] [stderr] 461 | / pub fn x<'a>(&'a self) -> f32 { [INFO] [stderr] 462 | | self.x_.from_little_endian() [INFO] [stderr] 463 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / pub fn y<'a>(&'a self) -> f32 { [INFO] [stderr] 465 | | self.y_.from_little_endian() [INFO] [stderr] 466 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:467:13 [INFO] [stderr] | [INFO] [stderr] 467 | / pub fn z<'a>(&'a self) -> f32 { [INFO] [stderr] 468 | | self.z_.from_little_endian() [INFO] [stderr] 469 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:520:24 [INFO] [stderr] | [INFO] [stderr] 520 | pub fn new<'a>(_pitch: f32, _yaw: f32, _roll: f32) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:527:13 [INFO] [stderr] | [INFO] [stderr] 527 | / pub fn pitch<'a>(&'a self) -> f32 { [INFO] [stderr] 528 | | self.pitch_.from_little_endian() [INFO] [stderr] 529 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | / pub fn yaw<'a>(&'a self) -> f32 { [INFO] [stderr] 531 | | self.yaw_.from_little_endian() [INFO] [stderr] 532 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:533:13 [INFO] [stderr] | [INFO] [stderr] 533 | / pub fn roll<'a>(&'a self) -> f32 { [INFO] [stderr] 534 | | self.roll_.from_little_endian() [INFO] [stderr] 535 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:594:24 [INFO] [stderr] | [INFO] [stderr] 594 | pub fn new<'a>(_x: f32, _y: f32, _z: f32, _w: f32) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:602:13 [INFO] [stderr] | [INFO] [stderr] 602 | / pub fn x<'a>(&'a self) -> f32 { [INFO] [stderr] 603 | | self.x_.from_little_endian() [INFO] [stderr] 604 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | / pub fn y<'a>(&'a self) -> f32 { [INFO] [stderr] 606 | | self.y_.from_little_endian() [INFO] [stderr] 607 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:608:13 [INFO] [stderr] | [INFO] [stderr] 608 | / pub fn z<'a>(&'a self) -> f32 { [INFO] [stderr] 609 | | self.z_.from_little_endian() [INFO] [stderr] 610 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:611:13 [INFO] [stderr] | [INFO] [stderr] 611 | / pub fn w<'a>(&'a self) -> f32 { [INFO] [stderr] 612 | | self.w_.from_little_endian() [INFO] [stderr] 613 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:660:24 [INFO] [stderr] | [INFO] [stderr] 660 | pub fn new<'a>(_val: f32) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:665:13 [INFO] [stderr] | [INFO] [stderr] 665 | / pub fn val<'a>(&'a self) -> f32 { [INFO] [stderr] 666 | | self.val_.from_little_endian() [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:665:28 [INFO] [stderr] | [INFO] [stderr] 665 | pub fn val<'a>(&'a self) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:714:24 [INFO] [stderr] | [INFO] [stderr] 714 | pub fn new<'a>(_val: bool) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:719:13 [INFO] [stderr] | [INFO] [stderr] 719 | / pub fn val<'a>(&'a self) -> bool { [INFO] [stderr] 720 | | self.val_.from_little_endian() [INFO] [stderr] 721 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:719:28 [INFO] [stderr] | [INFO] [stderr] 719 | pub fn val<'a>(&'a self) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3349:40 [INFO] [stderr] | [INFO] [stderr] 3349 | pub fn add_x(&mut self, x: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3354:40 [INFO] [stderr] | [INFO] [stderr] 3354 | pub fn add_y(&mut self, y: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3359:40 [INFO] [stderr] | [INFO] [stderr] 3359 | pub fn add_z(&mut self, z: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3459:48 [INFO] [stderr] | [INFO] [stderr] 3459 | pub fn add_pitch(&mut self, pitch: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3464:44 [INFO] [stderr] | [INFO] [stderr] 3464 | pub fn add_yaw(&mut self, yaw: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3469:46 [INFO] [stderr] | [INFO] [stderr] 3469 | pub fn add_roll(&mut self, roll: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3834:60 [INFO] [stderr] | [INFO] [stderr] 3834 | pub fn add_boostAmount(&mut self, boostAmount: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3839:50 [INFO] [stderr] | [INFO] [stderr] 3839 | pub fn add_jumped(&mut self, jumped: &'b Bool) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3844:62 [INFO] [stderr] | [INFO] [stderr] 3844 | pub fn add_doubleJumped(&mut self, doubleJumped: &'b Bool) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3923:60 [INFO] [stderr] | [INFO] [stderr] 3923 | pub fn add_respawnTime(&mut self, respawnTime: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rlbot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/packeteer.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn next(&mut self) -> Result> { [INFO] [stderr] 41 | | self.spin(Self::try_next) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/packeteer.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if game_time != self.prev_game_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(game_time - self.prev_game_time).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/packeteer.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | if game_time != self.prev_game_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/packeteer.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if game_time != self.prev_game_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(game_time - self.prev_game_time).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/packeteer.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | if game_time != self.prev_game_time { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/physicist.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn next(&mut self) -> Result> { [INFO] [stderr] 40 | | self.spin(|this| Ok(this.try_next()?)) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:454:24 [INFO] [stderr] | [INFO] [stderr] 454 | pub fn new<'a>(_x: f32, _y: f32, _z: f32) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:461:13 [INFO] [stderr] | [INFO] [stderr] 461 | / pub fn x<'a>(&'a self) -> f32 { [INFO] [stderr] 462 | | self.x_.from_little_endian() [INFO] [stderr] 463 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:464:13 [INFO] [stderr] | [INFO] [stderr] 464 | / pub fn y<'a>(&'a self) -> f32 { [INFO] [stderr] 465 | | self.y_.from_little_endian() [INFO] [stderr] 466 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:467:13 [INFO] [stderr] | [INFO] [stderr] 467 | / pub fn z<'a>(&'a self) -> f32 { [INFO] [stderr] 468 | | self.z_.from_little_endian() [INFO] [stderr] 469 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:520:24 [INFO] [stderr] | [INFO] [stderr] 520 | pub fn new<'a>(_pitch: f32, _yaw: f32, _roll: f32) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:527:13 [INFO] [stderr] | [INFO] [stderr] 527 | / pub fn pitch<'a>(&'a self) -> f32 { [INFO] [stderr] 528 | | self.pitch_.from_little_endian() [INFO] [stderr] 529 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:530:13 [INFO] [stderr] | [INFO] [stderr] 530 | / pub fn yaw<'a>(&'a self) -> f32 { [INFO] [stderr] 531 | | self.yaw_.from_little_endian() [INFO] [stderr] 532 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:533:13 [INFO] [stderr] | [INFO] [stderr] 533 | / pub fn roll<'a>(&'a self) -> f32 { [INFO] [stderr] 534 | | self.roll_.from_little_endian() [INFO] [stderr] 535 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:594:24 [INFO] [stderr] | [INFO] [stderr] 594 | pub fn new<'a>(_x: f32, _y: f32, _z: f32, _w: f32) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:602:13 [INFO] [stderr] | [INFO] [stderr] 602 | / pub fn x<'a>(&'a self) -> f32 { [INFO] [stderr] 603 | | self.x_.from_little_endian() [INFO] [stderr] 604 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | / pub fn y<'a>(&'a self) -> f32 { [INFO] [stderr] 606 | | self.y_.from_little_endian() [INFO] [stderr] 607 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:608:13 [INFO] [stderr] | [INFO] [stderr] 608 | / pub fn z<'a>(&'a self) -> f32 { [INFO] [stderr] 609 | | self.z_.from_little_endian() [INFO] [stderr] 610 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:611:13 [INFO] [stderr] | [INFO] [stderr] 611 | / pub fn w<'a>(&'a self) -> f32 { [INFO] [stderr] 612 | | self.w_.from_little_endian() [INFO] [stderr] 613 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:660:24 [INFO] [stderr] | [INFO] [stderr] 660 | pub fn new<'a>(_val: f32) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:665:13 [INFO] [stderr] | [INFO] [stderr] 665 | / pub fn val<'a>(&'a self) -> f32 { [INFO] [stderr] 666 | | self.val_.from_little_endian() [INFO] [stderr] 667 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:665:28 [INFO] [stderr] | [INFO] [stderr] 665 | pub fn val<'a>(&'a self) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/rlbot_generated.rs:714:24 [INFO] [stderr] | [INFO] [stderr] 714 | pub fn new<'a>(_val: bool) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/rlbot_generated.rs:719:13 [INFO] [stderr] | [INFO] [stderr] 719 | / pub fn val<'a>(&'a self) -> bool { [INFO] [stderr] 720 | | self.val_.from_little_endian() [INFO] [stderr] 721 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:719:28 [INFO] [stderr] | [INFO] [stderr] 719 | pub fn val<'a>(&'a self) -> bool { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3349:40 [INFO] [stderr] | [INFO] [stderr] 3349 | pub fn add_x(&mut self, x: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3354:40 [INFO] [stderr] | [INFO] [stderr] 3354 | pub fn add_y(&mut self, y: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3359:40 [INFO] [stderr] | [INFO] [stderr] 3359 | pub fn add_z(&mut self, z: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3459:48 [INFO] [stderr] | [INFO] [stderr] 3459 | pub fn add_pitch(&mut self, pitch: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3464:44 [INFO] [stderr] | [INFO] [stderr] 3464 | pub fn add_yaw(&mut self, yaw: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3469:46 [INFO] [stderr] | [INFO] [stderr] 3469 | pub fn add_roll(&mut self, roll: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3834:60 [INFO] [stderr] | [INFO] [stderr] 3834 | pub fn add_boostAmount(&mut self, boostAmount: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3839:50 [INFO] [stderr] | [INFO] [stderr] 3839 | pub fn add_jumped(&mut self, jumped: &'b Bool) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3844:62 [INFO] [stderr] | [INFO] [stderr] 3844 | pub fn add_doubleJumped(&mut self, doubleJumped: &'b Bool) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/rlbot_generated.rs:3923:60 [INFO] [stderr] | [INFO] [stderr] 3923 | pub fn add_respawnTime(&mut self, respawnTime: &'b Float) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Float` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rlbot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "170e9c169766f7d0dbe15859649db97caaeba0c583980bd664ea2acc05baff25"` [INFO] running `"docker" "rm" "-f" "170e9c169766f7d0dbe15859649db97caaeba0c583980bd664ea2acc05baff25"` [INFO] [stdout] 170e9c169766f7d0dbe15859649db97caaeba0c583980bd664ea2acc05baff25