[INFO] crate rkv 0.7.0 is already in cache [INFO] extracting crate rkv 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/rkv/0.7.0 [INFO] extracting crate rkv 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rkv/0.7.0 [INFO] validating manifest of rkv-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rkv-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rkv-0.7.0 [INFO] finished frobbing rkv-0.7.0 [INFO] frobbed toml for rkv-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/rkv/0.7.0/Cargo.toml [INFO] started frobbing rkv-0.7.0 [INFO] finished frobbing rkv-0.7.0 [INFO] frobbed toml for rkv-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rkv/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rkv-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rkv/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08e3df919cff632d5fa8c02106af62b62680840009b48be64205b5edd304d06e [INFO] running `"docker" "start" "-a" "08e3df919cff632d5fa8c02106af62b62680840009b48be64205b5edd304d06e"` [INFO] [stderr] Compiling lmdb-sys v0.8.0 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking lmdb-rkv v0.9.0 [INFO] [stderr] Checking rkv v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/value.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn to_tag(self) -> u8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/iterator.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/iterator.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/env.rs:335:5 [INFO] [stderr] | [INFO] [stderr] 335 | / fn test_round_trip_and_transactions() { [INFO] [stderr] 336 | | let root = Builder::new().prefix("test_round_trip_and_transactions").tempdir().expect("tempdir"); [INFO] [stderr] 337 | | fs::create_dir_all(root.path()).expect("dir created"); [INFO] [stderr] 338 | | let k = Rkv::new(root.path()).expect("new succeeded"); [INFO] [stderr] ... | [INFO] [stderr] 432 | | } [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/env.rs:644:5 [INFO] [stderr] | [INFO] [stderr] 644 | / fn test_iter() { [INFO] [stderr] 645 | | let root = Builder::new().prefix("test_iter").tempdir().expect("tempdir"); [INFO] [stderr] 646 | | fs::create_dir_all(root.path()).expect("dir created"); [INFO] [stderr] 647 | | let k = Rkv::new(root.path()).expect("new succeeded"); [INFO] [stderr] ... | [INFO] [stderr] 714 | | assert!(iter.next().is_none()); [INFO] [stderr] 715 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 47 [INFO] [stderr] --> src/env.rs:777:5 [INFO] [stderr] | [INFO] [stderr] 777 | / fn test_multiple_store_iter() { [INFO] [stderr] 778 | | let root = Builder::new().prefix("test_multiple_store_iter").tempdir().expect("tempdir"); [INFO] [stderr] 779 | | fs::create_dir_all(root.path()).expect("dir created"); [INFO] [stderr] 780 | | let k = Rkv::new(root.path()).expect("new succeeded"); [INFO] [stderr] ... | [INFO] [stderr] 885 | | assert!(iter.next().is_none()); [INFO] [stderr] 886 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/value.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn to_tag(self) -> u8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/simple-store.rs:41:54 [INFO] [stderr] | [INFO] [stderr] 41 | writer.put(store, "instant", &Value::Instant(1528318073700)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_528_318_073_700` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> examples/iterator.rs:42:39 [INFO] [stderr] | [INFO] [stderr] 42 | while let Some((country, city)) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for (country, city) in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> examples/iterator.rs:51:39 [INFO] [stderr] | [INFO] [stderr] 51 | while let Some((country, city)) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for (country, city) in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> examples/iterator.rs:58:39 [INFO] [stderr] | [INFO] [stderr] 58 | while let Some((country, city)) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for (country, city) in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.81s [INFO] running `"docker" "inspect" "08e3df919cff632d5fa8c02106af62b62680840009b48be64205b5edd304d06e"` [INFO] running `"docker" "rm" "-f" "08e3df919cff632d5fa8c02106af62b62680840009b48be64205b5edd304d06e"` [INFO] [stdout] 08e3df919cff632d5fa8c02106af62b62680840009b48be64205b5edd304d06e