[INFO] crate rix 0.3.0 is already in cache [INFO] extracting crate rix 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/rix/0.3.0 [INFO] extracting crate rix 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rix/0.3.0 [INFO] validating manifest of rix-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rix-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rix-0.3.0 [INFO] finished frobbing rix-0.3.0 [INFO] frobbed toml for rix-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/rix/0.3.0/Cargo.toml [INFO] started frobbing rix-0.3.0 [INFO] finished frobbing rix-0.3.0 [INFO] frobbed toml for rix-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rix/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rix-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rix/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 291526af033c8950cef0177c4e74bf67f951c1688bcf0206b6b7d02b310802c9 [INFO] running `"docker" "start" "-a" "291526af033c8950cef0177c4e74bf67f951c1688bcf0206b6b7d02b310802c9"` [INFO] [stderr] Checking rix v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `error` [INFO] [stderr] --> src/client/sync.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use error; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde_json` [INFO] [stderr] --> src/client/message.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use serde_json; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/client/message.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `error` [INFO] [stderr] --> src/client/message.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use error; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `error` [INFO] [stderr] --> src/client/sync.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use error; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde_json` [INFO] [stderr] --> src/client/message.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use serde_json; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/client/message.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `error` [INFO] [stderr] --> src/client/message.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use error; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/client/sync.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let mut request = hyper::Request::new(hyper::Method::Get, [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/client/sync.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | let mut request = hyper::Request::new(hyper::Method::Get, [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/sync.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | .filter_map(|x| match x { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 54 | | &Some(ref x) => Some(x), [INFO] [stderr] 55 | | &None => None [INFO] [stderr] 56 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | .filter_map(|x| match *x { [INFO] [stderr] 54 | Some(ref x) => Some(x), [INFO] [stderr] 55 | None => None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/client/sync.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | .filter_map(|x| match x { [INFO] [stderr] | _____________________________^ [INFO] [stderr] 54 | | &Some(ref x) => Some(x), [INFO] [stderr] 55 | | &None => None [INFO] [stderr] 56 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | .filter_map(|x| match *x { [INFO] [stderr] 54 | Some(ref x) => Some(x), [INFO] [stderr] 55 | None => None [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.90s [INFO] running `"docker" "inspect" "291526af033c8950cef0177c4e74bf67f951c1688bcf0206b6b7d02b310802c9"` [INFO] running `"docker" "rm" "-f" "291526af033c8950cef0177c4e74bf67f951c1688bcf0206b6b7d02b310802c9"` [INFO] [stdout] 291526af033c8950cef0177c4e74bf67f951c1688bcf0206b6b7d02b310802c9