[INFO] crate rivet 0.0.1 is already in cache [INFO] extracting crate rivet 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/rivet/0.0.1 [INFO] extracting crate rivet 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rivet/0.0.1 [INFO] validating manifest of rivet-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rivet-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rivet-0.0.1 [INFO] finished frobbing rivet-0.0.1 [INFO] frobbed toml for rivet-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/rivet/0.0.1/Cargo.toml [INFO] started frobbing rivet-0.0.1 [INFO] finished frobbing rivet-0.0.1 [INFO] frobbed toml for rivet-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rivet/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rivet-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rivet/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b268a81c1e0a47e16538ce387b4909714b3df7453b633b354732d942b5c75bf3 [INFO] running `"docker" "start" "-a" "b268a81c1e0a47e16538ce387b4909714b3df7453b633b354732d942b5c75bf3"` [INFO] [stderr] Checking string-interner v0.6.3 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking rivet v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/lib.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/builtins.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `nom::*` [INFO] [stderr] --> src/lexer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | use nom::*; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 31 | | if let Token::Id(ref s) = input.tok[0] { [INFO] [stderr] 32 | | // the first part of the returned value is the remaining slice [INFO] [stderr] 33 | | IResult::Done(input.slice(1..), Ast::Symbol(s.to_owned())) [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | } else if let Token::Id(ref s) = input.tok[0] { [INFO] [stderr] 31 | // the first part of the returned value is the remaining slice [INFO] [stderr] 32 | IResult::Done(input.slice(1..), Ast::Symbol(s.to_owned())) [INFO] [stderr] 33 | } else { [INFO] [stderr] 34 | // BUGGO: TODO [INFO] [stderr] 35 | IResult::Error(error_code!(ErrorKind::Custom(42))) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 47 | | if let Token::Id(ref s) = input.tok[0] { [INFO] [stderr] 48 | | if s == "true" { [INFO] [stderr] 49 | | IResult::Done(input.slice(1..), Ast::Bool(true)) [INFO] [stderr] ... | [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | } else if let Token::Id(ref s) = input.tok[0] { [INFO] [stderr] 47 | if s == "true" { [INFO] [stderr] 48 | IResult::Done(input.slice(1..), Ast::Bool(true)) [INFO] [stderr] 49 | } else if s == "false" { [INFO] [stderr] 50 | IResult::Done(input.slice(1..), Ast::Bool(false)) [INFO] [stderr] 51 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 69 | | if let Token::Int(i) = input.tok[0] { [INFO] [stderr] 70 | | IResult::Done(input.slice(1..), Ast::Int(i)) [INFO] [stderr] 71 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | } else if let Token::Int(i) = input.tok[0] { [INFO] [stderr] 69 | IResult::Done(input.slice(1..), Ast::Int(i)) [INFO] [stderr] 70 | } else { [INFO] [stderr] 71 | // BUGGO: TODO [INFO] [stderr] 72 | IResult::Error(error_code!(ErrorKind::Custom(42))) [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if let Token::String(ref s) = input.tok[0] { [INFO] [stderr] 85 | | // the first part of the returned value is the remaining slice [INFO] [stderr] 86 | | IResult::Done(input.slice(1..), Ast::String(s.to_owned())) [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if let Token::String(ref s) = input.tok[0] { [INFO] [stderr] 84 | // the first part of the returned value is the remaining slice [INFO] [stderr] 85 | IResult::Done(input.slice(1..), Ast::String(s.to_owned())) [INFO] [stderr] 86 | } else { [INFO] [stderr] 87 | // BUGGO: TODO [INFO] [stderr] 88 | IResult::Error(error_code!(ErrorKind::Custom(42))) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 103 | | if let Token::Comment(ref s) = input.tok[0] { [INFO] [stderr] 104 | | // the first part of the returned value is the remaining slice [INFO] [stderr] 105 | | IResult::Done(input.slice(1..), Ast::Comment(s.to_owned())) [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | } else if let Token::Comment(ref s) = input.tok[0] { [INFO] [stderr] 103 | // the first part of the returned value is the remaining slice [INFO] [stderr] 104 | IResult::Done(input.slice(1..), Ast::Comment(s.to_owned())) [INFO] [stderr] 105 | } else { [INFO] [stderr] 106 | // BUGGO: TODO [INFO] [stderr] 107 | IResult::Error(error_code!(ErrorKind::Custom(42))) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/vm.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/lib.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/builtins.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `nom::*` [INFO] [stderr] --> src/lexer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | use nom::*; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:30:12 [INFO] [stderr] | [INFO] [stderr] 30 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 31 | | if let Token::Id(ref s) = input.tok[0] { [INFO] [stderr] 32 | | // the first part of the returned value is the remaining slice [INFO] [stderr] 33 | | IResult::Done(input.slice(1..), Ast::Symbol(s.to_owned())) [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 30 | } else if let Token::Id(ref s) = input.tok[0] { [INFO] [stderr] 31 | // the first part of the returned value is the remaining slice [INFO] [stderr] 32 | IResult::Done(input.slice(1..), Ast::Symbol(s.to_owned())) [INFO] [stderr] 33 | } else { [INFO] [stderr] 34 | // BUGGO: TODO [INFO] [stderr] 35 | IResult::Error(error_code!(ErrorKind::Custom(42))) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 47 | | if let Token::Id(ref s) = input.tok[0] { [INFO] [stderr] 48 | | if s == "true" { [INFO] [stderr] 49 | | IResult::Done(input.slice(1..), Ast::Bool(true)) [INFO] [stderr] ... | [INFO] [stderr] 59 | | } [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | } else if let Token::Id(ref s) = input.tok[0] { [INFO] [stderr] 47 | if s == "true" { [INFO] [stderr] 48 | IResult::Done(input.slice(1..), Ast::Bool(true)) [INFO] [stderr] 49 | } else if s == "false" { [INFO] [stderr] 50 | IResult::Done(input.slice(1..), Ast::Bool(false)) [INFO] [stderr] 51 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:68:12 [INFO] [stderr] | [INFO] [stderr] 68 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 69 | | if let Token::Int(i) = input.tok[0] { [INFO] [stderr] 70 | | IResult::Done(input.slice(1..), Ast::Int(i)) [INFO] [stderr] 71 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | } else if let Token::Int(i) = input.tok[0] { [INFO] [stderr] 69 | IResult::Done(input.slice(1..), Ast::Int(i)) [INFO] [stderr] 70 | } else { [INFO] [stderr] 71 | // BUGGO: TODO [INFO] [stderr] 72 | IResult::Error(error_code!(ErrorKind::Custom(42))) [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 84 | | if let Token::String(ref s) = input.tok[0] { [INFO] [stderr] 85 | | // the first part of the returned value is the remaining slice [INFO] [stderr] 86 | | IResult::Done(input.slice(1..), Ast::String(s.to_owned())) [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 83 | } else if let Token::String(ref s) = input.tok[0] { [INFO] [stderr] 84 | // the first part of the returned value is the remaining slice [INFO] [stderr] 85 | IResult::Done(input.slice(1..), Ast::String(s.to_owned())) [INFO] [stderr] 86 | } else { [INFO] [stderr] 87 | // BUGGO: TODO [INFO] [stderr] 88 | IResult::Error(error_code!(ErrorKind::Custom(42))) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:102:12 [INFO] [stderr] | [INFO] [stderr] 102 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 103 | | if let Token::Comment(ref s) = input.tok[0] { [INFO] [stderr] 104 | | // the first part of the returned value is the remaining slice [INFO] [stderr] 105 | | IResult::Done(input.slice(1..), Ast::Comment(s.to_owned())) [INFO] [stderr] ... | [INFO] [stderr] 109 | | } [INFO] [stderr] 110 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 102 | } else if let Token::Comment(ref s) = input.tok[0] { [INFO] [stderr] 103 | // the first part of the returned value is the remaining slice [INFO] [stderr] 104 | IResult::Done(input.slice(1..), Ast::Comment(s.to_owned())) [INFO] [stderr] 105 | } else { [INFO] [stderr] 106 | // BUGGO: TODO [INFO] [stderr] 107 | IResult::Error(error_code!(ErrorKind::Custom(42))) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cmp` [INFO] [stderr] --> src/vm.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cmp; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `vm::Value::*` [INFO] [stderr] --> src/vm.rs:304:9 [INFO] [stderr] | [INFO] [stderr] 304 | use vm::Value::*; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `builtins` [INFO] [stderr] --> src/vm.rs:305:9 [INFO] [stderr] | [INFO] [stderr] 305 | use builtins; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_id` [INFO] [stderr] --> src/lexer.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | fn is_id(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_int` [INFO] [stderr] --> src/vm.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | fn get_int(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_block` [INFO] [stderr] --> src/vm.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn get_block(&self) -> Option<&[Ast]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_symbol` [INFO] [stderr] --> src/vm.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | fn get_symbol(&self) -> Option<&str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `quote` [INFO] [stderr] --> src/vm.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | fn quote(&self) -> Ast { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lexer.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / named!(lex_word(&str) -> Token, do_parse!( [INFO] [stderr] 78 | | s: take_till_s!(char::is_whitespace) >> [INFO] [stderr] 79 | | (Token::Id(s.to_string())) [INFO] [stderr] 80 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lexer.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if self.tok.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lexer.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | if self.tok.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:100:8 [INFO] [stderr] | [INFO] [stderr] 100 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/vm.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / match self { [INFO] [stderr] 133 | | &Value::Int(i) => Value::Int(i), [INFO] [stderr] 134 | | &Value::Bool(b) => Value::Bool(b), [INFO] [stderr] 135 | | &Value::Symbol(s) => Value::Symbol(s), [INFO] [stderr] ... | [INFO] [stderr] 138 | | &Value::String(ref v) => Value::String(v.clone()), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | match *self { [INFO] [stderr] 133 | Value::Int(i) => Value::Int(i), [INFO] [stderr] 134 | Value::Bool(b) => Value::Bool(b), [INFO] [stderr] 135 | Value::Symbol(s) => Value::Symbol(s), [INFO] [stderr] 136 | Value::Builtin(ref f) => Value::Builtin(*f), [INFO] [stderr] 137 | Value::Block(ref v) => Value::Block(v.clone()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::Vm` [INFO] [stderr] --> src/vm.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / pub fn new() -> Self { [INFO] [stderr] 152 | | Vm { [INFO] [stderr] 153 | | stack: Vec::new(), [INFO] [stderr] 154 | | dictionary: HashMap::new(), [INFO] [stderr] 155 | | symbols: string_interner::DefaultStringInterner::default(), [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/vm.rs:201:34 [INFO] [stderr] | [INFO] [stderr] 201 | Value::Builtin(_) => format!(""), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/vm.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | format!("{}", res) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `res.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_id` [INFO] [stderr] --> src/lexer.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | fn is_id(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_int` [INFO] [stderr] --> src/vm.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | fn get_int(&self) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_block` [INFO] [stderr] --> src/vm.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | fn get_block(&self) -> Option<&[Ast]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_symbol` [INFO] [stderr] --> src/vm.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | fn get_symbol(&self) -> Option<&str> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `quote` [INFO] [stderr] --> src/vm.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | fn quote(&self) -> Ast { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lexer.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / named!(lex_word(&str) -> Token, do_parse!( [INFO] [stderr] 78 | | s: take_till_s!(char::is_whitespace) >> [INFO] [stderr] 79 | | (Token::Id(s.to_string())) [INFO] [stderr] 80 | | )); [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lexer.rs:124:12 [INFO] [stderr] | [INFO] [stderr] 124 | if self.tok.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/lexer.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | if self.tok.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:44:8 [INFO] [stderr] | [INFO] [stderr] 44 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:100:8 [INFO] [stderr] | [INFO] [stderr] 100 | if input.tok.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.tok.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/vm.rs:132:9 [INFO] [stderr] | [INFO] [stderr] 132 | / match self { [INFO] [stderr] 133 | | &Value::Int(i) => Value::Int(i), [INFO] [stderr] 134 | | &Value::Bool(b) => Value::Bool(b), [INFO] [stderr] 135 | | &Value::Symbol(s) => Value::Symbol(s), [INFO] [stderr] ... | [INFO] [stderr] 138 | | &Value::String(ref v) => Value::String(v.clone()), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | match *self { [INFO] [stderr] 133 | Value::Int(i) => Value::Int(i), [INFO] [stderr] 134 | Value::Bool(b) => Value::Bool(b), [INFO] [stderr] 135 | Value::Symbol(s) => Value::Symbol(s), [INFO] [stderr] 136 | Value::Builtin(ref f) => Value::Builtin(*f), [INFO] [stderr] 137 | Value::Block(ref v) => Value::Block(v.clone()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::Vm` [INFO] [stderr] --> src/vm.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | / pub fn new() -> Self { [INFO] [stderr] 152 | | Vm { [INFO] [stderr] 153 | | stack: Vec::new(), [INFO] [stderr] 154 | | dictionary: HashMap::new(), [INFO] [stderr] 155 | | symbols: string_interner::DefaultStringInterner::default(), [INFO] [stderr] 156 | | } [INFO] [stderr] 157 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/vm.rs:201:34 [INFO] [stderr] | [INFO] [stderr] 201 | Value::Builtin(_) => format!(""), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/vm.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | format!("{}", res) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `res.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if let Err(_) = rl.load_history("history.txt") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 18 | | println!("No previous history."); [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____- help: try this: `if rl.load_history("history.txt").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:17:12 [INFO] [stderr] | [INFO] [stderr] 17 | if let Err(_) = rl.load_history("history.txt") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 18 | | println!("No previous history."); [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____- help: try this: `if rl.load_history("history.txt").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.31s [INFO] running `"docker" "inspect" "b268a81c1e0a47e16538ce387b4909714b3df7453b633b354732d942b5c75bf3"` [INFO] running `"docker" "rm" "-f" "b268a81c1e0a47e16538ce387b4909714b3df7453b633b354732d942b5c75bf3"` [INFO] [stdout] b268a81c1e0a47e16538ce387b4909714b3df7453b633b354732d942b5c75bf3