[INFO] crate riscan-pro 0.2.1 is already in cache [INFO] extracting crate riscan-pro 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/riscan-pro/0.2.1 [INFO] extracting crate riscan-pro 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riscan-pro/0.2.1 [INFO] validating manifest of riscan-pro-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of riscan-pro-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing riscan-pro-0.2.1 [INFO] finished frobbing riscan-pro-0.2.1 [INFO] frobbed toml for riscan-pro-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/riscan-pro/0.2.1/Cargo.toml [INFO] started frobbing riscan-pro-0.2.1 [INFO] finished frobbing riscan-pro-0.2.1 [INFO] frobbed toml for riscan-pro-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riscan-pro/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting riscan-pro-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/riscan-pro/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53d5756ba9ec896c291209acff763951f5563bb6e3db4b38f303cb16a56897b1 [INFO] running `"docker" "start" "-a" "53d5756ba9ec896c291209acff763951f5563bb6e3db4b38f303cb16a56897b1"` [INFO] [stderr] Checking xmltree v0.6.1 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking alga v0.5.4 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking riscan-pro v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/camera_calibration.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | let y = (v - self.cy) / self.fy; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/camera_calibration.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | let r = (x.powi(2) + y.powi(2)).sqrt().atan().powi(2).sqrt(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/point.rs:257:13 [INFO] [stderr] --> src/camera_calibration.rs:91:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 257 | point: point, [INFO] [stderr] 91 | let y = (v - self.cy) / self.fy; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] --> src/project.rs:75:13 [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] | [INFO] [stderr] --> src/camera_calibration.rs:92:13 [INFO] [stderr] 75 | camera_calibrations: camera_calibrations, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `camera_calibrations` [INFO] [stderr] 92 | let r = (x.powi(2) + y.powi(2)).sqrt().atan().powi(2).sqrt(); [INFO] [stderr] | [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:76:13 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/point.rs:257:13 [INFO] [stderr] 76 | mount_calibrations: mount_calibrations, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_calibrations` [INFO] [stderr] 257 | point: point, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:77:13 [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] 77 | scan_positions: scan_positions, [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scan_positions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | camera_calibrations: camera_calibrations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `camera_calibrations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | mount_calibrations: mount_calibrations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mount_calibrations` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/project.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | scan_positions: scan_positions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scan_positions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:26:30 [INFO] [stderr] | [INFO] [stderr] 26 | assert_relative_eq!(-0.003724941, matrix[(0, 1)], epsilon = 1e-9); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.003_724_941` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | assert_relative_eq!(0.18508641, matrix[(0, 3)], epsilon = 1e-8); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.185_086_41` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/point.rs:295:29 [INFO] [stderr] | [INFO] [stderr] 295 | let scan_position = project.scan_positions.get("SP01").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&project.scan_positions["SP01"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/point.rs:296:21 [INFO] [stderr] | [INFO] [stderr] 296 | let image = scan_position.images.get("SP01 - Image001").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&scan_position.images["SP01 - Image001"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/project.rs:234:33 [INFO] [stderr] | [INFO] [stderr] 234 | let mount_calibration = project [INFO] [stderr] | _________________________________^ [INFO] [stderr] 235 | | .mount_calibrations [INFO] [stderr] 236 | | .get("Infratec_VarioCAM_HD_15mm_11-16-2015_Preston") [INFO] [stderr] 237 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 234 | let mount_calibration = &project [INFO] [stderr] 235 | .mount_calibrations["Infratec_VarioCAM_HD_15mm_11-16-2015_Preston"]; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/project.rs:245:30 [INFO] [stderr] | [INFO] [stderr] 245 | let scan_position1 = project.scan_positions.get("SP01").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&project.scan_positions["SP01"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/scan_position.rs:167:29 [INFO] [stderr] | [INFO] [stderr] 167 | let scan_position = project.scan_positions.get("SP01").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&project.scan_positions["SP01"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 56.08s [INFO] running `"docker" "inspect" "53d5756ba9ec896c291209acff763951f5563bb6e3db4b38f303cb16a56897b1"` [INFO] running `"docker" "rm" "-f" "53d5756ba9ec896c291209acff763951f5563bb6e3db4b38f303cb16a56897b1"` [INFO] [stdout] 53d5756ba9ec896c291209acff763951f5563bb6e3db4b38f303cb16a56897b1