[INFO] crate rinpg 0.1.24 is already in cache [INFO] extracting crate rinpg 0.1.24 into work/ex/clippy-test-run/sources/stable/reg/rinpg/0.1.24 [INFO] extracting crate rinpg 0.1.24 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rinpg/0.1.24 [INFO] validating manifest of rinpg-0.1.24 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rinpg-0.1.24 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rinpg-0.1.24 [INFO] finished frobbing rinpg-0.1.24 [INFO] frobbed toml for rinpg-0.1.24 written to work/ex/clippy-test-run/sources/stable/reg/rinpg/0.1.24/Cargo.toml [INFO] started frobbing rinpg-0.1.24 [INFO] finished frobbing rinpg-0.1.24 [INFO] frobbed toml for rinpg-0.1.24 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rinpg/0.1.24/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rinpg-0.1.24 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rinpg/0.1.24:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c5b1b092d614452ad63897a6fe37124c3de5dbfb442178f7f6f4ffc83d1ace9 [INFO] running `"docker" "start" "-a" "7c5b1b092d614452ad63897a6fe37124c3de5dbfb442178f7f6f4ffc83d1ace9"` [INFO] [stderr] Checking rinpg v0.1.24 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 50 | | if command.is_present("verbose") { [INFO] [stderr] 51 | | &["--target=wasm32-unknown-emscripten", "--verbose"] [INFO] [stderr] 52 | | }else{ [INFO] [stderr] 53 | | &["--target=wasm32-unknown-emscripten"] [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | }elseif command.is_present("verbose") { [INFO] [stderr] 50 | &["--target=wasm32-unknown-emscripten", "--verbose"] [INFO] [stderr] 51 | }else{ [INFO] [stderr] 52 | &["--target=wasm32-unknown-emscripten"] [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:70:10 [INFO] [stderr] | [INFO] [stderr] 70 | }else{ [INFO] [stderr] | __________^ [INFO] [stderr] 71 | | if command.is_present("release"){ [INFO] [stderr] 72 | | if command.is_present("verbose") { [INFO] [stderr] 73 | | &["--release", "--verbose"] [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 70 | }elseif command.is_present("release"){ [INFO] [stderr] 71 | if command.is_present("verbose") { [INFO] [stderr] 72 | &["--release", "--verbose"] [INFO] [stderr] 73 | }else{ [INFO] [stderr] 74 | &["--release"] [INFO] [stderr] 75 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:63:14 [INFO] [stderr] | [INFO] [stderr] 63 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 64 | | if command.is_present("verbose") { [INFO] [stderr] 65 | | &["--target=wasm32-unknown-unknown", "--verbose"] [INFO] [stderr] 66 | | }else{ [INFO] [stderr] 67 | | &["--target=wasm32-unknown-unknown"] [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | }elseif command.is_present("verbose") { [INFO] [stderr] 64 | &["--target=wasm32-unknown-unknown", "--verbose"] [INFO] [stderr] 65 | }else{ [INFO] [stderr] 66 | &["--target=wasm32-unknown-unknown"] [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 78 | | if command.is_present("verbose") { [INFO] [stderr] 79 | | &["--verbose"] [INFO] [stderr] 80 | | }else{ [INFO] [stderr] 81 | | &[] [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | }elseif command.is_present("verbose") { [INFO] [stderr] 78 | &["--verbose"] [INFO] [stderr] 79 | }else{ [INFO] [stderr] 80 | &[] [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:90:10 [INFO] [stderr] | [INFO] [stderr] 90 | }else{ [INFO] [stderr] | __________^ [INFO] [stderr] 91 | | if platform == "emscripten" { [INFO] [stderr] 92 | | let flags = "-C link-arg=--emrun -C link-arg=-s -C link-arg=ASSERTIONS=1 -C link-arg=-s -C link-arg=ALLOW_MEMORY_GROWTH=1 -C link-arg=-s -C link-arg=USE_WEBGL2=1"; [INFO] [stderr] 93 | | if let Some(data) = command.value_of("data"){ [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | }elseif platform == "emscripten" { [INFO] [stderr] 91 | let flags = "-C link-arg=--emrun -C link-arg=-s -C link-arg=ASSERTIONS=1 -C link-arg=-s -C link-arg=ALLOW_MEMORY_GROWTH=1 -C link-arg=-s -C link-arg=USE_WEBGL2=1"; [INFO] [stderr] 92 | if let Some(data) = command.value_of("data"){ [INFO] [stderr] 93 | let data = Path::new(data); [INFO] [stderr] 94 | let data = format!(" -C link-arg=--preload-file -C link-arg={}@{}", data.display(), data.display()); [INFO] [stderr] 95 | flags.to_owned() + &data [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | / if platform == "emscripten"{ [INFO] [stderr] 209 | | if output.status.success(){ [INFO] [stderr] 210 | | let mut output = Command::new("cargo") [INFO] [stderr] 211 | | .arg(command) [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 208 | if platform == "emscripten" && output.status.success() { [INFO] [stderr] 209 | let mut output = Command::new("cargo") [INFO] [stderr] 210 | .arg(command) [INFO] [stderr] 211 | .arg("--no-default-features") [INFO] [stderr] 212 | .arg("--message-format=json") [INFO] [stderr] 213 | .arg("--features") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:49:14 [INFO] [stderr] | [INFO] [stderr] 49 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 50 | | if command.is_present("verbose") { [INFO] [stderr] 51 | | &["--target=wasm32-unknown-emscripten", "--verbose"] [INFO] [stderr] 52 | | }else{ [INFO] [stderr] 53 | | &["--target=wasm32-unknown-emscripten"] [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 49 | }elseif command.is_present("verbose") { [INFO] [stderr] 50 | &["--target=wasm32-unknown-emscripten", "--verbose"] [INFO] [stderr] 51 | }else{ [INFO] [stderr] 52 | &["--target=wasm32-unknown-emscripten"] [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:70:10 [INFO] [stderr] | [INFO] [stderr] 70 | }else{ [INFO] [stderr] | __________^ [INFO] [stderr] 71 | | if command.is_present("release"){ [INFO] [stderr] 72 | | if command.is_present("verbose") { [INFO] [stderr] 73 | | &["--release", "--verbose"] [INFO] [stderr] ... | [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 70 | }elseif command.is_present("release"){ [INFO] [stderr] 71 | if command.is_present("verbose") { [INFO] [stderr] 72 | &["--release", "--verbose"] [INFO] [stderr] 73 | }else{ [INFO] [stderr] 74 | &["--release"] [INFO] [stderr] 75 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:63:14 [INFO] [stderr] | [INFO] [stderr] 63 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 64 | | if command.is_present("verbose") { [INFO] [stderr] 65 | | &["--target=wasm32-unknown-unknown", "--verbose"] [INFO] [stderr] 66 | | }else{ [INFO] [stderr] 67 | | &["--target=wasm32-unknown-unknown"] [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 63 | }elseif command.is_present("verbose") { [INFO] [stderr] 64 | &["--target=wasm32-unknown-unknown", "--verbose"] [INFO] [stderr] 65 | }else{ [INFO] [stderr] 66 | &["--target=wasm32-unknown-unknown"] [INFO] [stderr] 67 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | }else{ [INFO] [stderr] | ______________^ [INFO] [stderr] 78 | | if command.is_present("verbose") { [INFO] [stderr] 79 | | &["--verbose"] [INFO] [stderr] 80 | | }else{ [INFO] [stderr] 81 | | &[] [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | }elseif command.is_present("verbose") { [INFO] [stderr] 78 | &["--verbose"] [INFO] [stderr] 79 | }else{ [INFO] [stderr] 80 | &[] [INFO] [stderr] 81 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:90:10 [INFO] [stderr] | [INFO] [stderr] 90 | }else{ [INFO] [stderr] | __________^ [INFO] [stderr] 91 | | if platform == "emscripten" { [INFO] [stderr] 92 | | let flags = "-C link-arg=--emrun -C link-arg=-s -C link-arg=ASSERTIONS=1 -C link-arg=-s -C link-arg=ALLOW_MEMORY_GROWTH=1 -C link-arg=-s -C link-arg=USE_WEBGL2=1"; [INFO] [stderr] 93 | | if let Some(data) = command.value_of("data"){ [INFO] [stderr] ... | [INFO] [stderr] 102 | | } [INFO] [stderr] 103 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | }elseif platform == "emscripten" { [INFO] [stderr] 91 | let flags = "-C link-arg=--emrun -C link-arg=-s -C link-arg=ASSERTIONS=1 -C link-arg=-s -C link-arg=ALLOW_MEMORY_GROWTH=1 -C link-arg=-s -C link-arg=USE_WEBGL2=1"; [INFO] [stderr] 92 | if let Some(data) = command.value_of("data"){ [INFO] [stderr] 93 | let data = Path::new(data); [INFO] [stderr] 94 | let data = format!(" -C link-arg=--preload-file -C link-arg={}@{}", data.display(), data.display()); [INFO] [stderr] 95 | flags.to_owned() + &data [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | / if platform == "emscripten"{ [INFO] [stderr] 209 | | if output.status.success(){ [INFO] [stderr] 210 | | let mut output = Command::new("cargo") [INFO] [stderr] 211 | | .arg(command) [INFO] [stderr] ... | [INFO] [stderr] 246 | | } [INFO] [stderr] 247 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 208 | if platform == "emscripten" && output.status.success() { [INFO] [stderr] 209 | let mut output = Command::new("cargo") [INFO] [stderr] 210 | .arg(command) [INFO] [stderr] 211 | .arg("--no-default-features") [INFO] [stderr] 212 | .arg("--message-format=json") [INFO] [stderr] 213 | .arg("--features") [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.80s [INFO] running `"docker" "inspect" "7c5b1b092d614452ad63897a6fe37124c3de5dbfb442178f7f6f4ffc83d1ace9"` [INFO] running `"docker" "rm" "-f" "7c5b1b092d614452ad63897a6fe37124c3de5dbfb442178f7f6f4ffc83d1ace9"` [INFO] [stdout] 7c5b1b092d614452ad63897a6fe37124c3de5dbfb442178f7f6f4ffc83d1ace9