[INFO] crate rincon_test_helper 0.1.0 is already in cache [INFO] extracting crate rincon_test_helper 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rincon_test_helper/0.1.0 [INFO] extracting crate rincon_test_helper 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rincon_test_helper/0.1.0 [INFO] validating manifest of rincon_test_helper-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rincon_test_helper-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rincon_test_helper-0.1.0 [INFO] finished frobbing rincon_test_helper-0.1.0 [INFO] frobbed toml for rincon_test_helper-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rincon_test_helper/0.1.0/Cargo.toml [INFO] started frobbing rincon_test_helper-0.1.0 [INFO] finished frobbing rincon_test_helper-0.1.0 [INFO] frobbed toml for rincon_test_helper-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rincon_test_helper/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rincon_test_helper-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rincon_test_helper/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba051916207ec1438973766b414663ef2acdfd7e4ec0d7a5a2bca2f0c717d8b8 [INFO] running `"docker" "start" "-a" "ba051916207ec1438973766b414663ef2acdfd7e4ec0d7a5a2bca2f0c717d8b8"` [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking rincon_core v0.1.0 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking rincon_client v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Compiling derive-error-chain v0.11.2 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking dotenv v0.11.0 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking tokio-io-timeout v0.1.3 [INFO] [stderr] Checking hyper-timeout v0.1.1 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking rincon_connector v0.1.0 [INFO] [stderr] Checking rincon_test_helper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:93:74 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn arango_session_test(test: Test, clean_up: CleanUp) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:118:87 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn arango_session_test_with_user_db(user: &str, database: &str, test: Test) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:147:76 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn arango_system_db_test(test: Test, clean_up: CleanUp) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:173:74 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn arango_user_db_test(test: Test, clean_up: CleanUp) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:206:79 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn arango_test_with_user_db(user: &str, database: &str, test: Test) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:236:81 [INFO] [stderr] | [INFO] [stderr] 236 | pub fn arango_test_with_document_collection(collection: &str, test: Test) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:273:77 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn arango_test_with_edge_collection(collection: &str, test: Test) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:93:74 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn arango_session_test(test: Test, clean_up: CleanUp) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:118:87 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn arango_session_test_with_user_db(user: &str, database: &str, test: Test) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:147:76 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn arango_system_db_test(test: Test, clean_up: CleanUp) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:173:74 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn arango_user_db_test(test: Test, clean_up: CleanUp) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:206:79 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn arango_test_with_user_db(user: &str, database: &str, test: Test) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:236:81 [INFO] [stderr] | [INFO] [stderr] 236 | pub fn arango_test_with_document_collection(collection: &str, test: Test) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:273:77 [INFO] [stderr] | [INFO] [stderr] 273 | pub fn arango_test_with_edge_collection(collection: &str, test: Test) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:256:10 [INFO] [stderr] | [INFO] [stderr] 256 | .expect(&format!("Error on creating document collection: {}", collection)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error on creating document collection: {}", collection))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:293:10 [INFO] [stderr] | [INFO] [stderr] 293 | .expect(&format!("Error on creating edge collection: {}", collection)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error on creating edge collection: {}", collection))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:324:10 [INFO] [stderr] | [INFO] [stderr] 324 | .expect(&format!("Error deleting lock file: {:?}", &lock_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error deleting lock file: {:?}", &lock_file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:330:10 [INFO] [stderr] | [INFO] [stderr] 330 | .expect(&format!("Could not get list of accessible databases for connection: {:?}", conn)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not get list of accessible databases for connection: {:?}", conn))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:256:10 [INFO] [stderr] | [INFO] [stderr] 256 | .expect(&format!("Error on creating document collection: {}", collection)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error on creating document collection: {}", collection))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:293:10 [INFO] [stderr] | [INFO] [stderr] 293 | .expect(&format!("Error on creating edge collection: {}", collection)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error on creating edge collection: {}", collection))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:324:10 [INFO] [stderr] | [INFO] [stderr] 324 | .expect(&format!("Error deleting lock file: {:?}", &lock_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Error deleting lock file: {:?}", &lock_file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:330:10 [INFO] [stderr] | [INFO] [stderr] 330 | .expect(&format!("Could not get list of accessible databases for connection: {:?}", conn)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not get list of accessible databases for connection: {:?}", conn))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 29s [INFO] running `"docker" "inspect" "ba051916207ec1438973766b414663ef2acdfd7e4ec0d7a5a2bca2f0c717d8b8"` [INFO] running `"docker" "rm" "-f" "ba051916207ec1438973766b414663ef2acdfd7e4ec0d7a5a2bca2f0c717d8b8"` [INFO] [stdout] ba051916207ec1438973766b414663ef2acdfd7e4ec0d7a5a2bca2f0c717d8b8