[INFO] crate rincon_connector 0.1.0 is already in cache [INFO] extracting crate rincon_connector 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rincon_connector/0.1.0 [INFO] extracting crate rincon_connector 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rincon_connector/0.1.0 [INFO] validating manifest of rincon_connector-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rincon_connector-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rincon_connector-0.1.0 [INFO] finished frobbing rincon_connector-0.1.0 [INFO] frobbed toml for rincon_connector-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rincon_connector/0.1.0/Cargo.toml [INFO] started frobbing rincon_connector-0.1.0 [INFO] finished frobbing rincon_connector-0.1.0 [INFO] frobbed toml for rincon_connector-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rincon_connector/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rincon_connector-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rincon_connector/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] adb10e7e72c1c289b7c68e053b06b63da76b80ba1cc25d7729bb0875a9e6166c [INFO] running `"docker" "start" "-a" "adb10e7e72c1c289b7c68e053b06b63da76b80ba1cc25d7729bb0875a9e6166c"` [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking rincon_core v0.1.0 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-io v0.1.11 [INFO] [stderr] Checking tokio-threadpool v0.1.11 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.8 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-fs v0.1.5 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.5 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio v0.1.15 [INFO] [stderr] Compiling derive-error-chain v0.11.2 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking dotenv v0.11.0 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking tokio-io-timeout v0.1.3 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-timeout v0.1.1 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking rincon_connector v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/mod.rs:320:41 [INFO] [stderr] | [INFO] [stderr] 320 | fn http_method_for_operation(operation: &Operation) -> hyper::Method { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Operation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/http/tests.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | self.operation.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.operation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/http/mod.rs:320:41 [INFO] [stderr] | [INFO] [stderr] 320 | fn http_method_for_operation(operation: &Operation) -> hyper::Method { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `Operation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 23s [INFO] running `"docker" "inspect" "adb10e7e72c1c289b7c68e053b06b63da76b80ba1cc25d7729bb0875a9e6166c"` [INFO] running `"docker" "rm" "-f" "adb10e7e72c1c289b7c68e053b06b63da76b80ba1cc25d7729bb0875a9e6166c"` [INFO] [stdout] adb10e7e72c1c289b7c68e053b06b63da76b80ba1cc25d7729bb0875a9e6166c