[INFO] crate rimd 0.0.1 is already in cache [INFO] extracting crate rimd 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/rimd/0.0.1 [INFO] extracting crate rimd 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rimd/0.0.1 [INFO] validating manifest of rimd-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rimd-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rimd-0.0.1 [INFO] finished frobbing rimd-0.0.1 [INFO] frobbed toml for rimd-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/rimd/0.0.1/Cargo.toml [INFO] started frobbing rimd-0.0.1 [INFO] finished frobbing rimd-0.0.1 [INFO] frobbed toml for rimd-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rimd/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rimd-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rimd/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 70ed81f6260d30a7ffc59a04ab2b1582160f630494ed438d7f52706d156219ff [INFO] running `"docker" "start" "-a" "70ed81f6260d30a7ffc59a04ab2b1582160f630494ed438d7f52706d156219ff"` [INFO] [stderr] Checking rimd v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | vtime: vtime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vtime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | vtime: vtime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vtime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:273:21 [INFO] [stderr] | [INFO] [stderr] 273 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/meta.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/meta.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/meta.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(SMF { format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | division: division } ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `division` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | copyright: copyright, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copyright` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | ticks: ticks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ticks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | ticks: ticks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ticks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | vtime: vtime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vtime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | vtime: vtime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `vtime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:273:21 [INFO] [stderr] | [INFO] [stderr] 273 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/meta.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | command: command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/meta.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | data: data [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/meta.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(SMF { format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | division: division } ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `division` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | copyright: copyright, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copyright` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | ticks: ticks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ticks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/writer.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | ticks: ticks, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ticks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/builder.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | else { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 105 | | if me.data(1) < you.data(1) { [INFO] [stderr] 106 | | Ordering::Less [INFO] [stderr] 107 | | } else if me.data(1) > you.data(1) { [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 104 | else if me.data(1) < you.data(1) { [INFO] [stderr] 105 | Ordering::Less [INFO] [stderr] 106 | } else if me.data(1) > you.data(1) { [INFO] [stderr] 107 | Ordering::Greater [INFO] [stderr] 108 | } else { [INFO] [stderr] 109 | res [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/builder.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | else { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 105 | | if me.data(1) < you.data(1) { [INFO] [stderr] 106 | | Ordering::Less [INFO] [stderr] 107 | | } else if me.data(1) > you.data(1) { [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 104 | else if me.data(1) < you.data(1) { [INFO] [stderr] 105 | Ordering::Less [INFO] [stderr] 106 | } else if me.data(1) > you.data(1) { [INFO] [stderr] 107 | Ordering::Greater [INFO] [stderr] 108 | } else { [INFO] [stderr] 109 | res [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/builder.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / fn ne(&self, other: &AbsoluteEvent) -> bool { [INFO] [stderr] 79 | | !(self.eq(other)) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::SMFBuilder` [INFO] [stderr] --> src/builder.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / pub fn new() -> SMFBuilder { [INFO] [stderr] 191 | | SMFBuilder { [INFO] [stderr] 192 | | tracks: Vec::new(), [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 184 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:101:51 [INFO] [stderr] | [INFO] [stderr] 101 | MetaCommand::SequenceNumber => format!("Sequence Number"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Sequence Number".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:105:52 [INFO] [stderr] | [INFO] [stderr] 105 | MetaCommand::CopyrightNotice => format!("Copyright Notice"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Copyright Notice".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:109:38 [INFO] [stderr] | [INFO] [stderr] 109 | Err(_) => format!("[invalid string data]"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"[invalid string data]".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | Err(_) => format!("[invalid string data]"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"[invalid string data]".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:120:46 [INFO] [stderr] | [INFO] [stderr] 120 | MetaCommand::LyricText => format!("LyricText"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"LyricText".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:121:47 [INFO] [stderr] | [INFO] [stderr] 121 | MetaCommand::MarkerText => format!("MarkerText"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"MarkerText".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:122:45 [INFO] [stderr] | [INFO] [stderr] 122 | MetaCommand::CuePoint => format!("CuePoint"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"CuePoint".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:125:47 [INFO] [stderr] | [INFO] [stderr] 125 | MetaCommand::EndOfTrack => format!("End Of Track"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"End Of Track".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:127:48 [INFO] [stderr] | [INFO] [stderr] 127 | MetaCommand::SMPTEOffset => format!("SMPTEOffset"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SMPTEOffset".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/meta.rs:130:69 [INFO] [stderr] | [INFO] [stderr] 130 | 2usize.pow(self.data[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:140:59 [INFO] [stderr] | [INFO] [stderr] 140 | MetaCommand::SequencerSpecificEvent => format!("SequencerSpecificEvent"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SequencerSpecificEvent".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/meta.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | res |= self.data[i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | let tracks = (header[10] as u16) << 8 | header[11] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | let tracks = (header[10] as u16) << 8 | header[11] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(header[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | let division = (header[12] as i16) << 8 | header[13] as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(header[12])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:31:51 [INFO] [stderr] | [INFO] [stderr] 31 | let division = (header[12] as i16) << 8 | header[13] as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i16::from(header[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | ((buf[0] as u32) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | (buf[1] as u32) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | (buf[2] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | (buf[3] as u32)) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reader.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | / match event.event { [INFO] [stderr] 107 | | Event::Meta(ref me) => { [INFO] [stderr] 108 | | match me.command { [INFO] [stderr] 109 | | MetaCommand::CopyrightNotice => copyright = Some(try!(me.data_as_text())), [INFO] [stderr] ... | [INFO] [stderr] 114 | | _ => {} [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let Event::Meta(ref me) = event.event { [INFO] [stderr] 107 | match me.command { [INFO] [stderr] 108 | MetaCommand::CopyrightNotice => copyright = Some(try!(me.data_as_text())), [INFO] [stderr] 109 | MetaCommand::SequenceOrTrackName => name = Some(try!(me.data_as_text())), [INFO] [stderr] 110 | _ => {} [INFO] [stderr] 111 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:152:20 [INFO] [stderr] | [INFO] [stderr] 152 | res |= next as u64 & val_mask; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(next)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | res = res << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `res <<= 7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reader.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / match smf { [INFO] [stderr] 165 | | Ok(ref mut s) => { [INFO] [stderr] 166 | | for _ in 0..s.tracks.capacity() { [INFO] [stderr] 167 | | s.tracks.push(try!(SMFReader::parse_track(reader))); [INFO] [stderr] ... | [INFO] [stderr] 170 | | _ => {} [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Ok(ref mut s) = smf { [INFO] [stderr] 165 | for _ in 0..s.tracks.capacity() { [INFO] [stderr] 166 | s.tracks.push(try!(SMFReader::parse_track(reader))); [INFO] [stderr] 167 | } [INFO] [stderr] 168 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/writer.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | cur = cur >> 7; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cur >>= 7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match event { [INFO] [stderr] 115 | | &Event::Midi(ref midi) => { [INFO] [stderr] 116 | | vec.extend(midi.data.iter()); [INFO] [stderr] 117 | | *length += midi.data.len() as u32; [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *event { [INFO] [stderr] 115 | Event::Midi(ref midi) => { [INFO] [stderr] 116 | vec.extend(midi.data.iter()); [INFO] [stderr] 117 | *length += midi.data.len() as u32; [INFO] [stderr] 118 | } [INFO] [stderr] 119 | Event::Meta(ref meta) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/writer.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | *length = (*length)>>8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*length >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/writer.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match name { [INFO] [stderr] 168 | | Some(n) => { [INFO] [stderr] 169 | | let namemeta = Event::Meta(MetaEvent::sequence_or_track_name(n)); [INFO] [stderr] 170 | | length += SMFWriter::write_vtime(0,&mut vec).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 173 | | None => {} [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | if let Some(n) = name { [INFO] [stderr] 168 | let namemeta = Event::Meta(MetaEvent::sequence_or_track_name(n)); [INFO] [stderr] 169 | length += SMFWriter::write_vtime(0,&mut vec).unwrap(); [INFO] [stderr] 170 | self.write_event(&mut vec, &namemeta, &mut length, &mut saw_eot); [INFO] [stderr] 171 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/util.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | if NSTRS.as_bytes()[nmt+1] == ' ' as u8{ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/util.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | &NSTRS[nmt..(nmt+1)] [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `nmt..=nmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/util.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | try!(reader.read(&mut b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: item `Event` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | / impl Event { [INFO] [stderr] 105 | | /// Return the number of bytes this event uses. [INFO] [stderr] 106 | | pub fn len(&self) -> usize { [INFO] [stderr] 107 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `TrackEvent` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | / impl TrackEvent { [INFO] [stderr] 136 | | pub fn fmt_with_time_offset(&self, cur_time: u64) -> String { [INFO] [stderr] 137 | | format!("time: {}\t{}",(self.vtime+cur_time),self.event) [INFO] [stderr] 138 | | } [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rimd`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/builder.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / fn ne(&self, other: &AbsoluteEvent) -> bool { [INFO] [stderr] 79 | | !(self.eq(other)) [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `builder::SMFBuilder` [INFO] [stderr] --> src/builder.rs:190:5 [INFO] [stderr] | [INFO] [stderr] 190 | / pub fn new() -> SMFBuilder { [INFO] [stderr] 191 | | SMFBuilder { [INFO] [stderr] 192 | | tracks: Vec::new(), [INFO] [stderr] 193 | | } [INFO] [stderr] 194 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 184 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:101:51 [INFO] [stderr] | [INFO] [stderr] 101 | MetaCommand::SequenceNumber => format!("Sequence Number"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Sequence Number".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:105:52 [INFO] [stderr] | [INFO] [stderr] 105 | MetaCommand::CopyrightNotice => format!("Copyright Notice"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Copyright Notice".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:109:38 [INFO] [stderr] | [INFO] [stderr] 109 | Err(_) => format!("[invalid string data]"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"[invalid string data]".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:116:38 [INFO] [stderr] | [INFO] [stderr] 116 | Err(_) => format!("[invalid string data]"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"[invalid string data]".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:120:46 [INFO] [stderr] | [INFO] [stderr] 120 | MetaCommand::LyricText => format!("LyricText"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"LyricText".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:121:47 [INFO] [stderr] | [INFO] [stderr] 121 | MetaCommand::MarkerText => format!("MarkerText"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"MarkerText".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:122:45 [INFO] [stderr] | [INFO] [stderr] 122 | MetaCommand::CuePoint => format!("CuePoint"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"CuePoint".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:125:47 [INFO] [stderr] | [INFO] [stderr] 125 | MetaCommand::EndOfTrack => format!("End Of Track"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"End Of Track".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:127:48 [INFO] [stderr] | [INFO] [stderr] 127 | MetaCommand::SMPTEOffset => format!("SMPTEOffset"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SMPTEOffset".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/meta.rs:130:69 [INFO] [stderr] | [INFO] [stderr] 130 | 2usize.pow(self.data[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/meta.rs:140:59 [INFO] [stderr] | [INFO] [stderr] 140 | MetaCommand::SequencerSpecificEvent => format!("SequencerSpecificEvent"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"SequencerSpecificEvent".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/meta.rs:154:20 [INFO] [stderr] | [INFO] [stderr] 154 | res |= self.data[i] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.data[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | let tracks = (header[10] as u16) << 8 | header[11] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(header[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | let tracks = (header[10] as u16) << 8 | header[11] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(header[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | let division = (header[12] as i16) << 8 | header[13] as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(header[12])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:31:51 [INFO] [stderr] | [INFO] [stderr] 31 | let division = (header[12] as i16) << 8 | header[13] as i16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i16::from(header[13])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:88:14 [INFO] [stderr] | [INFO] [stderr] 88 | ((buf[0] as u32) << 24 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | (buf[1] as u32) << 16 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | (buf[2] as u32) << 8 | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:91:14 [INFO] [stderr] | [INFO] [stderr] 91 | (buf[3] as u32)) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(buf[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reader.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | / match event.event { [INFO] [stderr] 107 | | Event::Meta(ref me) => { [INFO] [stderr] 108 | | match me.command { [INFO] [stderr] 109 | | MetaCommand::CopyrightNotice => copyright = Some(try!(me.data_as_text())), [INFO] [stderr] ... | [INFO] [stderr] 114 | | _ => {} [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let Event::Meta(ref me) = event.event { [INFO] [stderr] 107 | match me.command { [INFO] [stderr] 108 | MetaCommand::CopyrightNotice => copyright = Some(try!(me.data_as_text())), [INFO] [stderr] 109 | MetaCommand::SequenceOrTrackName => name = Some(try!(me.data_as_text())), [INFO] [stderr] 110 | _ => {} [INFO] [stderr] 111 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:152:20 [INFO] [stderr] | [INFO] [stderr] 152 | res |= next as u64 & val_mask; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(next)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/reader.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | res = res << 7; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `res <<= 7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/reader.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / match smf { [INFO] [stderr] 165 | | Ok(ref mut s) => { [INFO] [stderr] 166 | | for _ in 0..s.tracks.capacity() { [INFO] [stderr] 167 | | s.tracks.push(try!(SMFReader::parse_track(reader))); [INFO] [stderr] ... | [INFO] [stderr] 170 | | _ => {} [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Ok(ref mut s) = smf { [INFO] [stderr] 165 | for _ in 0..s.tracks.capacity() { [INFO] [stderr] 166 | s.tracks.push(try!(SMFReader::parse_track(reader))); [INFO] [stderr] 167 | } [INFO] [stderr] 168 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/writer.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | cur = cur >> 7; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cur >>= 7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/writer.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match event { [INFO] [stderr] 115 | | &Event::Midi(ref midi) => { [INFO] [stderr] 116 | | vec.extend(midi.data.iter()); [INFO] [stderr] 117 | | *length += midi.data.len() as u32; [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *event { [INFO] [stderr] 115 | Event::Midi(ref midi) => { [INFO] [stderr] 116 | vec.extend(midi.data.iter()); [INFO] [stderr] 117 | *length += midi.data.len() as u32; [INFO] [stderr] 118 | } [INFO] [stderr] 119 | Event::Meta(ref meta) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/writer.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | *length = (*length)>>8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*length >>= 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/writer.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match name { [INFO] [stderr] 168 | | Some(n) => { [INFO] [stderr] 169 | | let namemeta = Event::Meta(MetaEvent::sequence_or_track_name(n)); [INFO] [stderr] 170 | | length += SMFWriter::write_vtime(0,&mut vec).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 173 | | None => {} [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 167 | if let Some(n) = name { [INFO] [stderr] 168 | let namemeta = Event::Meta(MetaEvent::sequence_or_track_name(n)); [INFO] [stderr] 169 | length += SMFWriter::write_vtime(0,&mut vec).unwrap(); [INFO] [stderr] 170 | self.write_event(&mut vec, &namemeta, &mut length, &mut saw_eot); [INFO] [stderr] 171 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/util.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | if NSTRS.as_bytes()[nmt+1] == ' ' as u8{ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/util.rs:14:20 [INFO] [stderr] | [INFO] [stderr] 14 | &NSTRS[nmt..(nmt+1)] [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `nmt..=nmt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/util.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | try!(reader.read(&mut b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: item `Event` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | / impl Event { [INFO] [stderr] 105 | | /// Return the number of bytes this event uses. [INFO] [stderr] 106 | | pub fn len(&self) -> usize { [INFO] [stderr] 107 | | match *self { [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: item `TrackEvent` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | / impl TrackEvent { [INFO] [stderr] 136 | | pub fn fmt_with_time_offset(&self, cur_time: u64) -> String { [INFO] [stderr] 137 | | format!("time: {}\t{}",(self.vtime+cur_time),self.event) [INFO] [stderr] 138 | | } [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rimd`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "70ed81f6260d30a7ffc59a04ab2b1582160f630494ed438d7f52706d156219ff"` [INFO] running `"docker" "rm" "-f" "70ed81f6260d30a7ffc59a04ab2b1582160f630494ed438d7f52706d156219ff"` [INFO] [stdout] 70ed81f6260d30a7ffc59a04ab2b1582160f630494ed438d7f52706d156219ff