[INFO] crate rift 0.5.1 is already in cache
[INFO] extracting crate rift 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/rift/0.5.1
[INFO] extracting crate rift 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rift/0.5.1
[INFO] validating manifest of rift-0.5.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rift-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rift-0.5.1
[INFO] finished frobbing rift-0.5.1
[INFO] frobbed toml for rift-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/rift/0.5.1/Cargo.toml
[INFO] started frobbing rift-0.5.1
[INFO] finished frobbing rift-0.5.1
[INFO] frobbed toml for rift-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rift/0.5.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rift-0.5.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rift/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 49b254103facd7c7a468a1a2bb365814b4d4c2b23ac0384f60be1375ccc5dc0e
[INFO] running `"docker" "start" "-a" "49b254103facd7c7a468a1a2bb365814b4d4c2b23ac0384f60be1375ccc5dc0e"`
[INFO] [stderr]     Checking rift v0.5.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/protocol/binary.rs:40:32
[INFO] [stderr]    |
[INFO] [stderr] 40 |         TBinaryInputProtocol { strict: strict, transport: transport }
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^ help: replace it with: `strict`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/protocol/binary.rs:40:48
[INFO] [stderr]    |
[INFO] [stderr] 40 |         TBinaryInputProtocol { strict: strict, transport: transport }
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/binary.rs:223:33
[INFO] [stderr]     |
[INFO] [stderr] 223 |         TBinaryOutputProtocol { strict: strict, transport: transport }
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: replace it with: `strict`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/binary.rs:223:49
[INFO] [stderr]     |
[INFO] [stderr] 223 |         TBinaryOutputProtocol { strict: strict, transport: transport }
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/protocol/compact.rs:54:12
[INFO] [stderr]    |
[INFO] [stderr] 54 |            transport: transport
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]    |
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/protocol/binary.rs:40:32
[INFO] [stderr]    |
[INFO] [stderr] 40 |         TBinaryInputProtocol { strict: strict, transport: transport }
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^ help: replace it with: `strict`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/protocol/binary.rs:40:48
[INFO] [stderr]    |
[INFO] [stderr] 40 |         TBinaryInputProtocol { strict: strict, transport: transport }
[INFO] [stderr]    |                                                ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/binary.rs:223:33
[INFO] [stderr]     |
[INFO] [stderr] 223 |         TBinaryOutputProtocol { strict: strict, transport: transport }
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: replace it with: `strict`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/binary.rs:223:49
[INFO] [stderr]     |
[INFO] [stderr] 223 |         TBinaryOutputProtocol { strict: strict, transport: transport }
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/protocol/compact.rs:54:12
[INFO] [stderr]    |
[INFO] [stderr] 54 |            transport: transport
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/compact.rs:304:12
[INFO] [stderr]     |
[INFO] [stderr] 304 |            transport: transport
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:434:13
[INFO] [stderr]     |
[INFO] [stderr] 434 |             message_type: message_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:435:13
[INFO] [stderr]     |
[INFO] [stderr] 435 |             sequence_number: sequence_number
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:478:13
[INFO] [stderr]     |
[INFO] [stderr] 478 |             field_type: field_type,
[INFO] [stderr] 
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:496:27
[INFO] [stderr]     |
[INFO] [stderr] 496 |         TListIdentifier { element_type: element_type, size: size }
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:496:55
[INFO] [stderr]     |
[INFO] [stderr] 496 |         TListIdentifier { element_type: element_type, size: size }
[INFO] [stderr]     |                                                       ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:512:26
[INFO] [stderr]     |
[INFO] [stderr] 512 |         TSetIdentifier { element_type: element_type, size: size }
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:512:54
[INFO] [stderr]     |
[INFO] [stderr] 512 |         TSetIdentifier { element_type: element_type, size: size }
[INFO] [stderr]     |                                                      ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:534:84
[INFO] [stderr]     |
[INFO] [stderr] 534 |         TMapIdentifier { key_type: key_type.into(), value_type: value_type.into(), size: size }
[INFO] [stderr]     |                                                                                    ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/simple.rs:99:13
[INFO] [stderr]    |
[INFO] [stderr] 99 |             processor: processor
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/transport/buffered.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             inner: inner,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/transport/framed.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             inner: inner,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:235:31
[INFO] [stderr]     |
[INFO] [stderr] 235 |         Ok(ApplicationError { kind: kind, message: message })
[INFO] [stderr]     |                               ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:235:43
[INFO] [stderr]     |
[INFO] [stderr] 235 |         Ok(ApplicationError { kind: kind, message: message })
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^ help: replace it with: `message`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:350:26
[INFO] [stderr]     |
[INFO] [stderr] 350 |         TransportError { kind: kind, message: message.into() }
[INFO] [stderr]     |                          ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:481:25
[INFO] [stderr]     |
[INFO] [stderr] 481 |         ProtocolError { kind: kind, message: message.into() }
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:567:28
[INFO] [stderr]     |
[INFO] [stderr] 567 |         ApplicationError { kind: kind, message: message.into() }
[INFO] [stderr]     |                            ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/compact.rs:304:12
[INFO] [stderr]     |
[INFO] [stderr] 304 |            transport: transport
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transport`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:434:13
[INFO] [stderr]     |
[INFO] [stderr] 434 |             message_type: message_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:435:13
[INFO] [stderr]     |
[INFO] [stderr] 435 |             sequence_number: sequence_number
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sequence_number`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:478:13
[INFO] [stderr]     |
[INFO] [stderr] 478 |             field_type: field_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:496:27
[INFO] [stderr]     |
[INFO] [stderr] 496 |         TListIdentifier { element_type: element_type, size: size }
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:496:55
[INFO] [stderr]     |
[INFO] [stderr] 496 |         TListIdentifier { element_type: element_type, size: size }
[INFO] [stderr]     |                                                       ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:512:26
[INFO] [stderr]     |
[INFO] [stderr] 512 |         TSetIdentifier { element_type: element_type, size: size }
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:512:54
[INFO] [stderr]     |
[INFO] [stderr] 512 |         TSetIdentifier { element_type: element_type, size: size }
[INFO] [stderr]     |                                                      ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/protocol/mod.rs:534:84
[INFO] [stderr]     |
[INFO] [stderr] 534 |         TMapIdentifier { key_type: key_type.into(), value_type: value_type.into(), size: size }
[INFO] [stderr]     |                                                                                    ^^^^^^^^^^ help: replace it with: `size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/server/simple.rs:99:13
[INFO] [stderr]    |
[INFO] [stderr] 99 |             processor: processor
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/transport/buffered.rs:64:13
[INFO] [stderr]    |
[INFO] [stderr] 64 |             inner: inner,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/transport/framed.rs:54:13
[INFO] [stderr]    |
[INFO] [stderr] 54 |             inner: inner,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:235:31
[INFO] [stderr]     |
[INFO] [stderr] 235 |         Ok(ApplicationError { kind: kind, message: message })
[INFO] [stderr]     |                               ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:235:43
[INFO] [stderr]     |
[INFO] [stderr] 235 |         Ok(ApplicationError { kind: kind, message: message })
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^ help: replace it with: `message`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:350:26
[INFO] [stderr]     |
[INFO] [stderr] 350 |         TransportError { kind: kind, message: message.into() }
[INFO] [stderr]     |                          ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:481:25
[INFO] [stderr]     |
[INFO] [stderr] 481 |         ProtocolError { kind: kind, message: message.into() }
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/errors.rs:567:28
[INFO] [stderr]     |
[INFO] [stderr] 567 |         ApplicationError { kind: kind, message: message.into() }
[INFO] [stderr]     |                            ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/protocol/binary.rs:30:40
[INFO] [stderr]    |
[INFO] [stderr] 30 | const BINARY_PROTOCOL_VERSION_1: u32 = 0x80010000;
[INFO] [stderr]    |                                        ^^^^^^^^^^ help: consider: `0x8001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/protocol/compact.rs:258:44
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let val_type = try!(u8_to_type((type_header & 0x0F)));
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/protocol/compact.rs:258:44
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let val_type = try!(u8_to_type((type_header & 0x0F)));
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/protocol/binary.rs:30:40
[INFO] [stderr]    |
[INFO] [stderr] 30 | const BINARY_PROTOCOL_VERSION_1: u32 = 0x80010000;
[INFO] [stderr]    |                                        ^^^^^^^^^^ help: consider: `0x8001_0000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/protocol/compact.rs:258:44
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let val_type = try!(u8_to_type((type_header & 0x0F)));
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]    --> src/protocol/compact.rs:258:44
[INFO] [stderr]     |
[INFO] [stderr] 258 |             let val_type = try!(u8_to_type((type_header & 0x0F)));
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/protocol/binary.rs:235:54
[INFO] [stderr]     |
[INFO] [stderr] 235 |             let header = BINARY_PROTOCOL_VERSION_1 | (message_type as u32);
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(message_type)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/protocol/compact.rs:65:29
[INFO] [stderr]    |
[INFO] [stderr] 65 |             element_count = possible_element_count as i32;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(possible_element_count)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/protocol/binary.rs:235:54
[INFO] [stderr]     |
[INFO] [stderr] 235 |             let header = BINARY_PROTOCOL_VERSION_1 | (message_type as u32);
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(message_type)`
[INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change
[INFO] [stderr]    --> src/protocol/compact.rs:164:48
[INFO] [stderr]     |
[INFO] [stderr] 164 |                     self.last_read_field_id += field_delta as i16;
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^ help: try: `i16::from(field_delta)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/protocol/compact.rs:65:29
[INFO] [stderr]    |
[INFO] [stderr] 65 |             element_count = possible_element_count as i32;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(possible_element_count)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change
[INFO] [stderr]    --> src/protocol/compact.rs:164:48
[INFO] [stderr]     |
[INFO] [stderr] 164 |                     self.last_read_field_id += field_delta as i16;
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^ help: try: `i16::from(field_delta)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/protocol/mod.rs:733:20
[INFO] [stderr]     |
[INFO] [stderr] 733 |       field_ident.id.ok_or(
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 734 | |         ::Error::Protocol(
[INFO] [stderr] 735 | |             ::ProtocolError {
[INFO] [stderr] 736 | |                 kind: ::ProtocolErrorKind::Unknown,
[INFO] [stderr] ...   |
[INFO] [stderr] 739 | |         )
[INFO] [stderr] 740 | |     )
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 733 |     field_ident.id.ok_or_else(|| ::Error::Protocol(
[INFO] [stderr] 734 |             ::ProtocolError {
[INFO] [stderr] 735 |                 kind: ::ProtocolErrorKind::Unknown,
[INFO] [stderr] 736 |                 message: format!("missing field in in {:?}", field_ident)
[INFO] [stderr] 737 |             }
[INFO] [stderr] 738 |         ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/server/simple.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 | /             match r {
[INFO] [stderr] 160 | |                 Err(e) => {
[INFO] [stderr] 161 | |                     warn!("processor failed with error: {:?}", e);
[INFO] [stderr] 162 | |                     break; // FIXME: close here
[INFO] [stderr] 163 | |                 },
[INFO] [stderr] 164 | |                 Ok(_) => (),
[INFO] [stderr] 165 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 159 |             if let Err(e) = r {
[INFO] [stderr] 160 |     warn!("processor failed with error: {:?}", e);
[INFO] [stderr] 161 |     break; // FIXME: close here
[INFO] [stderr] 162 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/server/multiplexed.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 | /         if self.processors.contains_key(&name) {
[INFO] [stderr] 33 | |             false
[INFO] [stderr] 34 | |         } else {
[INFO] [stderr] 35 | |             self.processors.insert(name, processor);
[INFO] [stderr] 36 | |             true
[INFO] [stderr] 37 | |         }
[INFO] [stderr]    | |_________^ help: consider using: `self.processors.entry(name)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/protocol/mod.rs:733:20
[INFO] [stderr]     |
[INFO] [stderr] 733 |       field_ident.id.ok_or(
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 734 | |         ::Error::Protocol(
[INFO] [stderr] 735 | |             ::ProtocolError {
[INFO] [stderr] 736 | |                 kind: ::ProtocolErrorKind::Unknown,
[INFO] [stderr] ...   |
[INFO] [stderr] 739 | |         )
[INFO] [stderr] 740 | |     )
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 733 |     field_ident.id.ok_or_else(|| ::Error::Protocol(
[INFO] [stderr] 734 |             ::ProtocolError {
[INFO] [stderr] 735 |                 kind: ::ProtocolErrorKind::Unknown,
[INFO] [stderr] 736 |                 message: format!("missing field in in {:?}", field_ident)
[INFO] [stderr] 737 |             }
[INFO] [stderr] 738 |         ))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/server/simple.rs:159:13
[INFO] [stderr]     |
[INFO] [stderr] 159 | /             match r {
[INFO] [stderr] 160 | |                 Err(e) => {
[INFO] [stderr] 161 | |                     warn!("processor failed with error: {:?}", e);
[INFO] [stderr] 162 | |                     break; // FIXME: close here
[INFO] [stderr] 163 | |                 },
[INFO] [stderr] 164 | |                 Ok(_) => (),
[INFO] [stderr] 165 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `transport::socket::TTcpTransport`
[INFO] [stderr]   --> src/transport/socket.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn new() -> TTcpTransport {
[INFO] [stderr] 36 | |        TTcpTransport {
[INFO] [stderr] 37 | |            stream: None,
[INFO] [stderr] 38 | |        }
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 27 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/transport/socket.rs:52:16
[INFO] [stderr]    |
[INFO] [stderr] 52 |           if let Some(_) = self.stream {
[INFO] [stderr]    |  _________-      ^^^^^^^
[INFO] [stderr] 53 | |             Err(
[INFO] [stderr] 54 | |                 ::Error::Transport(
[INFO] [stderr] 55 | |                     TransportError::new(TransportErrorKind::AlreadyOpen, "transport previously opened")
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |             }
[INFO] [stderr] 66 | |         }
[INFO] [stderr]    | |_________- help: try this: `if self.stream.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr] 
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 159 |             if let Err(e) = r {
[INFO] [stderr] 160 |     warn!("processor failed with error: {:?}", e);
[INFO] [stderr] 161 |     break; // FIXME: close here
[INFO] [stderr] 162 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/server/multiplexed.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 | /         if self.processors.contains_key(&name) {
[INFO] [stderr] 33 | |             false
[INFO] [stderr] 34 | |         } else {
[INFO] [stderr] 35 | |             self.processors.insert(name, processor);
[INFO] [stderr] 36 | |             true
[INFO] [stderr] 37 | |         }
[INFO] [stderr]    | |_________^ help: consider using: `self.processors.entry(name)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `readable_bytes`
[INFO] [stderr]    --> src/transport/buffered.rs:234:18
[INFO] [stderr]     |
[INFO] [stderr] 234 |         for i in 0..10 { readable_bytes[i] = i as u8; }
[INFO] [stderr]     |                  ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 234 |         for (i, <item>) in readable_bytes.iter_mut().enumerate() { readable_bytes[i] = i as u8; }
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `buf`.
[INFO] [stderr]    --> src/transport/buffered.rs:249:18
[INFO] [stderr]     |
[INFO] [stderr] 249 |         for i in 0..8 { buf[i] = 0; }
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 249 |         for <item> in &mut buf { buf[i] = 0; }
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `transport::socket::TTcpTransport`
[INFO] [stderr]   --> src/transport/socket.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     pub fn new() -> TTcpTransport {
[INFO] [stderr] 36 | |        TTcpTransport {
[INFO] [stderr] 37 | |            stream: None,
[INFO] [stderr] 38 | |        }
[INFO] [stderr] 39 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 27 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/transport/socket.rs:52:16
[INFO] [stderr]    |
[INFO] [stderr] 52 |           if let Some(_) = self.stream {
[INFO] [stderr]    |  _________-      ^^^^^^^
[INFO] [stderr] 53 | |             Err(
[INFO] [stderr] 54 | |                 ::Error::Transport(
[INFO] [stderr] 55 | |                     TransportError::new(TransportErrorKind::AlreadyOpen, "transport previously opened")
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |             }
[INFO] [stderr] 66 | |         }
[INFO] [stderr]    | |_________- help: try this: `if self.stream.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.50s
[INFO] running `"docker" "inspect" "49b254103facd7c7a468a1a2bb365814b4d4c2b23ac0384f60be1375ccc5dc0e"`
[INFO] running `"docker" "rm" "-f" "49b254103facd7c7a468a1a2bb365814b4d4c2b23ac0384f60be1375ccc5dc0e"`
[INFO] [stdout] 49b254103facd7c7a468a1a2bb365814b4d4c2b23ac0384f60be1375ccc5dc0e