[INFO] crate riffol 0.3.0 is already in cache [INFO] extracting crate riffol 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/riffol/0.3.0 [INFO] extracting crate riffol 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riffol/0.3.0 [INFO] validating manifest of riffol-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of riffol-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing riffol-0.3.0 [INFO] finished frobbing riffol-0.3.0 [INFO] frobbed toml for riffol-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/riffol/0.3.0/Cargo.toml [INFO] started frobbing riffol-0.3.0 [INFO] finished frobbing riffol-0.3.0 [INFO] frobbed toml for riffol-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riffol/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting riffol-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/riffol/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce0463f688a24d1a2b0f94de0dfede42f2adc3ceb9ab145b2de1a6940527d4ad [INFO] running `"docker" "start" "-a" "ce0463f688a24d1a2b0f94de0dfede42f2adc3ceb9ab145b2de1a6940527d4ad"` [INFO] [stderr] Compiling pest_generator v2.1.0 [INFO] [stderr] Compiling nereon_derive v0.4.3 [INFO] [stderr] Checking stderrlog v0.4.1 [INFO] [stderr] Checking syslog v4.0.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking nereon v0.4.4 [INFO] [stderr] Checking riffol v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/config.rs:484:37 [INFO] [stderr] | [INFO] [stderr] 484 | assert!(get_limits(&config, &vec!["2".to_owned()]).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["2".to_owned()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/config.rs:485:37 [INFO] [stderr] | [INFO] [stderr] 485 | assert!(get_limits(&config, &vec!["1".to_owned()]).is_ok()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["1".to_owned()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/config.rs:490:37 [INFO] [stderr] | [INFO] [stderr] 490 | assert!(get_limits(&config, &vec!["1".to_owned()]).is_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&["1".to_owned()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/stream.rs:273:30 [INFO] [stderr] | [INFO] [stderr] 273 | Stream::Stdout => Ok(println!("{}", line)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.73s [INFO] running `"docker" "inspect" "ce0463f688a24d1a2b0f94de0dfede42f2adc3ceb9ab145b2de1a6940527d4ad"` [INFO] running `"docker" "rm" "-f" "ce0463f688a24d1a2b0f94de0dfede42f2adc3ceb9ab145b2de1a6940527d4ad"` [INFO] [stdout] ce0463f688a24d1a2b0f94de0dfede42f2adc3ceb9ab145b2de1a6940527d4ad