[INFO] crate riemann_client 0.7.0 is already in cache
[INFO] extracting crate riemann_client 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/riemann_client/0.7.0
[INFO] extracting crate riemann_client 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riemann_client/0.7.0
[INFO] validating manifest of riemann_client-0.7.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of riemann_client-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing riemann_client-0.7.0
[INFO] finished frobbing riemann_client-0.7.0
[INFO] frobbed toml for riemann_client-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/riemann_client/0.7.0/Cargo.toml
[INFO] started frobbing riemann_client-0.7.0
[INFO] finished frobbing riemann_client-0.7.0
[INFO] frobbed toml for riemann_client-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riemann_client/0.7.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting riemann_client-0.7.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/riemann_client/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a4a6f671f13bff6c6e1ffb046f1481c3bbdf50b99ff4f6c145d6c553a8f9ca75
[INFO] running `"docker" "start" "-a" "a4a6f671f13bff6c6e1ffb046f1481c3bbdf50b99ff4f6c145d6c553a8f9ca75"`
[INFO] [stderr]     Checking riemann_client v0.7.0 (/opt/crater/workdir)
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/proto/mod_pb.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/proto/mod_pb.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/proto/mod_pb.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/client/mod.rs:57:9
[INFO] [stderr]    |
[INFO] [stderr] 57 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/proto/mod_pb.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/client/mod.rs:57:9
[INFO] [stderr]    |
[INFO] [stderr] 57 |         return Ok(());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `size`
[INFO] [stderr]   --> src/transport/mod.rs:40:39
[INFO] [stderr]    |
[INFO] [stderr] 40 |         try!(self.stream.write_all(&[((size >>  0) & 0xFF) as u8]));
[INFO] [stderr]    |                                       ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/transport/mod.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |         size += (try!(input_stream.read_raw_byte()) as u32) << 24;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 51 |         size += u32::from(match $ expr {
[INFO] [stderr] 52 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 53 | :: Err ( err ) => {
[INFO] [stderr] 54 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 55 | $ crate :: convert :: From :: from ( err ) ) } }) << 24;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/transport/mod.rs:52:17
[INFO] [stderr]    |
[INFO] [stderr] 52 |         size += (try!(input_stream.read_raw_byte()) as u32) << 16;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 52 |         size += u32::from(match $ expr {
[INFO] [stderr] 53 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 54 | :: Err ( err ) => {
[INFO] [stderr] 55 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 56 | $ crate :: convert :: From :: from ( err ) ) } }) << 16;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/transport/mod.rs:53:17
[INFO] [stderr]    |
[INFO] [stderr] 53 |         size += (try!(input_stream.read_raw_byte()) as u32) <<  8;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 53 |         size += u32::from(match $ expr {
[INFO] [stderr] 54 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 55 | :: Err ( err ) => {
[INFO] [stderr] 56 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 57 | $ crate :: convert :: From :: from ( err ) ) } }) <<  8;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(try!(input_stream.read_raw_byte()) as u32)`
[INFO] [stderr]   --> src/transport/mod.rs:54:17
[INFO] [stderr]    |
[INFO] [stderr] 54 |         size += (try!(input_stream.read_raw_byte()) as u32) <<  0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/transport/mod.rs:54:17
[INFO] [stderr]    |
[INFO] [stderr] 54 |         size += (try!(input_stream.read_raw_byte()) as u32) <<  0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 54 |         size += u32::from(match $ expr {
[INFO] [stderr] 55 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 56 | :: Err ( err ) => {
[INFO] [stderr] 57 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 58 | $ crate :: convert :: From :: from ( err ) ) } }) <<  0;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 | /         fn description<'a>(&'a self) -> &'a str {
[INFO] [stderr] 53 | |             match *self {
[INFO] [stderr] 54 | |                 Error::Io(ref e) => e.description(),
[INFO] [stderr] 55 | |                 Error::Protobuf(ref e) => e.description(),
[INFO] [stderr] 56 | |                 Error::Riemann(ref s) => s
[INFO] [stderr] 57 | |             }
[INFO] [stderr] 58 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `size`
[INFO] [stderr]   --> src/transport/mod.rs:40:39
[INFO] [stderr]    |
[INFO] [stderr] 40 |         try!(self.stream.write_all(&[((size >>  0) & 0xFF) as u8]));
[INFO] [stderr]    |                                       ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/transport/mod.rs:51:17
[INFO] [stderr]    |
[INFO] [stderr] 51 |         size += (try!(input_stream.read_raw_byte()) as u32) << 24;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 51 |         size += u32::from(match $ expr {
[INFO] [stderr] 52 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 53 | :: Err ( err ) => {
[INFO] [stderr] 54 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 55 | $ crate :: convert :: From :: from ( err ) ) } }) << 24;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/transport/mod.rs:52:17
[INFO] [stderr]    |
[INFO] [stderr] 52 |         size += (try!(input_stream.read_raw_byte()) as u32) << 16;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 52 |         size += u32::from(match $ expr {
[INFO] [stderr] 53 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 54 | :: Err ( err ) => {
[INFO] [stderr] 55 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 56 | $ crate :: convert :: From :: from ( err ) ) } }) << 16;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/transport/mod.rs:53:17
[INFO] [stderr]    |
[INFO] [stderr] 53 |         size += (try!(input_stream.read_raw_byte()) as u32) <<  8;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 53 |         size += u32::from(match $ expr {
[INFO] [stderr] 54 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 55 | :: Err ( err ) => {
[INFO] [stderr] 56 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 57 | $ crate :: convert :: From :: from ( err ) ) } }) <<  8;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(try!(input_stream.read_raw_byte()) as u32)`
[INFO] [stderr]   --> src/transport/mod.rs:54:17
[INFO] [stderr]    |
[INFO] [stderr] 54 |         size += (try!(input_stream.read_raw_byte()) as u32) <<  0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/transport/mod.rs:54:17
[INFO] [stderr]    |
[INFO] [stderr] 54 |         size += (try!(input_stream.read_raw_byte()) as u32) <<  0;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 54 |         size += u32::from(match $ expr {
[INFO] [stderr] 55 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result
[INFO] [stderr] 56 | :: Err ( err ) => {
[INFO] [stderr] 57 | return $ crate :: result :: Result :: Err (
[INFO] [stderr] 58 | $ crate :: convert :: From :: from ( err ) ) } }) <<  0;
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/lib.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 | /         fn description<'a>(&'a self) -> &'a str {
[INFO] [stderr] 53 | |             match *self {
[INFO] [stderr] 54 | |                 Error::Io(ref e) => e.description(),
[INFO] [stderr] 55 | |                 Error::Protobuf(ref e) => e.description(),
[INFO] [stderr] 56 | |                 Error::Riemann(ref s) => s
[INFO] [stderr] 57 | |             }
[INFO] [stderr] 58 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> tests/from.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     Query::from(Query::new());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Query::from()`: `Query::new()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:94:55
[INFO] [stderr]    |
[INFO] [stderr] 94 |                 let mut res: Vec<String> = attr.split("=").map(|s| s.to_string()).collect();
[INFO] [stderr]    |                                                       ^^^ help: try using a char instead: `'='`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let response =`
[INFO] [stderr]    --> src/main.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 |         let response = client.event(event).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_unit_value)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.20s
[INFO] running `"docker" "inspect" "a4a6f671f13bff6c6e1ffb046f1481c3bbdf50b99ff4f6c145d6c553a8f9ca75"`
[INFO] running `"docker" "rm" "-f" "a4a6f671f13bff6c6e1ffb046f1481c3bbdf50b99ff4f6c145d6c553a8f9ca75"`
[INFO] [stdout] a4a6f671f13bff6c6e1ffb046f1481c3bbdf50b99ff4f6c145d6c553a8f9ca75