[INFO] crate riak 0.3.4 is already in cache
[INFO] extracting crate riak 0.3.4 into work/ex/clippy-test-run/sources/stable/reg/riak/0.3.4
[INFO] extracting crate riak 0.3.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riak/0.3.4
[INFO] validating manifest of riak-0.3.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of riak-0.3.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing riak-0.3.4
[INFO] finished frobbing riak-0.3.4
[INFO] frobbed toml for riak-0.3.4 written to work/ex/clippy-test-run/sources/stable/reg/riak/0.3.4/Cargo.toml
[INFO] started frobbing riak-0.3.4
[INFO] finished frobbing riak-0.3.4
[INFO] frobbed toml for riak-0.3.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/riak/0.3.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting riak-0.3.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/riak/0.3.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 912eb6f28b60bb41d135cbbce6849b8521f179b9af58f88d3914aca4a63d8372
[INFO] running `"docker" "start" "-a" "912eb6f28b60bb41d135cbbce6849b8521f179b9af58f88d3914aca4a63d8372"`
[INFO] [stderr]     Checking riak v0.3.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:228:13
[INFO] [stderr]     |
[INFO] [stderr] 228 |             context: context,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `context`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:229:13
[INFO] [stderr]     |
[INFO] [stderr] 229 |             data_type: data_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:230:13
[INFO] [stderr]     |
[INFO] [stderr] 230 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:282:13
[INFO] [stderr]     |
[INFO] [stderr] 282 |             field: field,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `field`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:283:13
[INFO] [stderr]     |
[INFO] [stderr] 283 |             counter_value: counter_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:284:13
[INFO] [stderr]     |
[INFO] [stderr] 284 |             set_value: set_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `set_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:285:13
[INFO] [stderr]     |
[INFO] [stderr] 285 |             register_value: register_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `register_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:286:13
[INFO] [stderr]     |
[INFO] [stderr] 286 |             flag_value: flag_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flag_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:287:13
[INFO] [stderr]     |
[INFO] [stderr] 287 |             map_value: map_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:311:13
[INFO] [stderr]     |
[INFO] [stderr] 311 |             field_type: field_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:353:13
[INFO] [stderr]     |
[INFO] [stderr] 353 |             counter_value: counter_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:355:13
[INFO] [stderr]     |
[INFO] [stderr] 355 |             map_value: map_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/preflist.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             partition: partition,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/preflist.rs:18:13
[INFO] [stderr]    |
[INFO] [stderr] 18 |             is_primary: is_primary,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_primary`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/stream.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             connection: connection,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stream.rs:177:13
[INFO] [stderr]     |
[INFO] [stderr] 177 |             bucket: bucket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `bucket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stream.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 |             connection: connection,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stream.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 |             connection: connection,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stream.rs:325:13
[INFO] [stderr]     |
[INFO] [stderr] 325 |             request: request,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `request`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/yokozuna.rs:259:13
[INFO] [stderr]     |
[INFO] [stderr] 259 |             pairs: pairs,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `pairs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/connection.rs:49:21
[INFO] [stderr]    |
[INFO] [stderr] 49 |                     peer_addr: peer_addr,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/connection.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 |                     tcpstream: tcpstream,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcpstream`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/connection.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |                     timeout: timeout,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: replace it with: `timeout`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_dt.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_kv.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_search.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_ts.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_yokozuna.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             connection: connection,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             timeout: timeout,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `timeout`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:228:13
[INFO] [stderr]     |
[INFO] [stderr] 228 |             context: context,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `context`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:229:13
[INFO] [stderr]     |
[INFO] [stderr] 229 |             data_type: data_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:230:13
[INFO] [stderr]     |
[INFO] [stderr] 230 |             value: value,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:282:13
[INFO] [stderr]     |
[INFO] [stderr] 282 |             field: field,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `field`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:283:13
[INFO] [stderr]     |
[INFO] [stderr] 283 |             counter_value: counter_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:284:13
[INFO] [stderr]     |
[INFO] [stderr] 284 |             set_value: set_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `set_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:285:13
[INFO] [stderr]     |
[INFO] [stderr] 285 |             register_value: register_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `register_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:286:13
[INFO] [stderr]     |
[INFO] [stderr] 286 |             flag_value: flag_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flag_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:287:13
[INFO] [stderr]     |
[INFO] [stderr] 287 |             map_value: map_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:311:13
[INFO] [stderr]     |
[INFO] [stderr] 311 |             field_type: field_type,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_type`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:353:13
[INFO] [stderr]     |
[INFO] [stderr] 353 |             counter_value: counter_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/data_type.rs:355:13
[INFO] [stderr]     |
[INFO] [stderr] 355 |             map_value: map_value,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_value`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/preflist.rs:16:13
[INFO] [stderr]    |
[INFO] [stderr] 16 |             partition: partition,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/preflist.rs:18:13
[INFO] [stderr]    |
[INFO] [stderr] 18 |             is_primary: is_primary,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_primary`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/stream.rs:35:13
[INFO] [stderr]    |
[INFO] [stderr] 35 |             connection: connection,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stream.rs:177:13
[INFO] [stderr]     |
[INFO] [stderr] 177 |             bucket: bucket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `bucket`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stream.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 |             connection: connection,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stream.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 |             connection: connection,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/stream.rs:325:13
[INFO] [stderr]     |
[INFO] [stderr] 325 |             request: request,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `request`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/yokozuna.rs:259:13
[INFO] [stderr]     |
[INFO] [stderr] 259 |             pairs: pairs,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `pairs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/connection.rs:49:21
[INFO] [stderr]    |
[INFO] [stderr] 49 |                     peer_addr: peer_addr,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `peer_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/connection.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 |                     tcpstream: tcpstream,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tcpstream`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/connection.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |                     timeout: timeout,
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: replace it with: `timeout`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(renamed_and_removed_lints)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_dt.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_kv.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_search.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_ts.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak_yokozuna.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             connection: connection,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `connection`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             timeout: timeout,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `timeout`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/secondary_index.rs:104:27
[INFO] [stderr]     |
[INFO] [stderr] 104 |             Err(error) => return Err(RiakErr::ProtobufError(error)),
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(RiakErr::ProtobufError(error))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/yokozuna.rs:68:27
[INFO] [stderr]    |
[INFO] [stderr] 68 |             Err(error) => return Err(RiakErr::ProtobufError(error)),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(RiakErr::ProtobufError(error))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/secondary_index.rs:104:27
[INFO] [stderr]     |
[INFO] [stderr] 104 |             Err(error) => return Err(RiakErr::ProtobufError(error)),
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(RiakErr::ProtobufError(error))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/yokozuna.rs:68:27
[INFO] [stderr]    |
[INFO] [stderr] 68 |             Err(error) => return Err(RiakErr::ProtobufError(error)),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(RiakErr::ProtobufError(error))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore
[INFO] [stderr]  --> src/rpb/riak.rs:6:10
[INFO] [stderr]   |
[INFO] [stderr] 6 | #![allow(clippy)]
[INFO] [stderr]   |          ^^^^^^ help: change it to: `clippy::all`
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/bucket.rs:264:37
[INFO] [stderr]     |
[INFO] [stderr] 264 |     pub fn get_postcommit(&self) -> Option<HashMap<Vec<u8>, (Vec<u8>, Vec<u8>)>> {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bucket.rs:266:12
[INFO] [stderr]     |
[INFO] [stderr] 266 |         if postcommit.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!postcommit.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/bucket.rs:299:36
[INFO] [stderr]     |
[INFO] [stderr] 299 |     pub fn get_precommit(&self) -> Option<HashMap<Vec<u8>, (Vec<u8>, Vec<u8>)>> {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bucket.rs:301:12
[INFO] [stderr]     |
[INFO] [stderr] 301 |         if precommit.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!precommit.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/bucket.rs:745:37
[INFO] [stderr]     |
[INFO] [stderr] 745 |     pub fn get_postcommit(&self) -> Option<HashMap<Vec<u8>, (Vec<u8>, Vec<u8>)>> {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bucket.rs:747:12
[INFO] [stderr]     |
[INFO] [stderr] 747 |         if postcommit.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!postcommit.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/bucket.rs:780:36
[INFO] [stderr]     |
[INFO] [stderr] 780 |     pub fn get_precommit(&self) -> Option<HashMap<Vec<u8>, (Vec<u8>, Vec<u8>)>> {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bucket.rs:782:12
[INFO] [stderr]     |
[INFO] [stderr] 782 |         if precommit.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!precommit.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:208:9
[INFO] [stderr]     |
[INFO] [stderr] 208 | /         let mut context: Option<Vec<u8>> = None;
[INFO] [stderr] 209 | |         if dt_fetch_resp.has_context() {
[INFO] [stderr] 210 | |             context = Some(dt_fetch_resp.take_context());
[INFO] [stderr] 211 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> context = if dt_fetch_resp.has_context() { Some(dt_fetch_resp.take_context()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:222:9
[INFO] [stderr]     |
[INFO] [stderr] 222 | /         let mut value: Option<DataTypeValue> = None;
[INFO] [stderr] 223 | |         if dt_fetch_resp.has_value() {
[INFO] [stderr] 224 | |             value = Some(DataTypeValue::new_from_rpb(dt_fetch_resp.take_value()));
[INFO] [stderr] 225 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> value = if dt_fetch_resp.has_value() { Some(DataTypeValue::new_from_rpb(dt_fetch_resp.take_value())) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:252:9
[INFO] [stderr]     |
[INFO] [stderr] 252 | /         let mut counter_value: Option<i64> = None;
[INFO] [stderr] 253 | |         if rpb_map_entry.has_counter_value() {
[INFO] [stderr] 254 | |             counter_value = Some(rpb_map_entry.get_counter_value());
[INFO] [stderr] 255 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> counter_value = if rpb_map_entry.has_counter_value() { Some(rpb_map_entry.get_counter_value()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:264:9
[INFO] [stderr]     |
[INFO] [stderr] 264 | /         let mut register_value: Option<Vec<u8>> = None;
[INFO] [stderr] 265 | |         if rpb_map_entry.has_register_value() {
[INFO] [stderr] 266 | |             register_value = Some(rpb_map_entry.take_register_value());
[INFO] [stderr] 267 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> register_value = if rpb_map_entry.has_register_value() { Some(rpb_map_entry.take_register_value()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:270:9
[INFO] [stderr]     |
[INFO] [stderr] 270 | /         let mut flag_value: Option<bool> = None;
[INFO] [stderr] 271 | |         if rpb_map_entry.has_flag_value() {
[INFO] [stderr] 272 | |             flag_value = Some(rpb_map_entry.get_flag_value());
[INFO] [stderr] 273 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> flag_value = if rpb_map_entry.has_flag_value() { Some(rpb_map_entry.get_flag_value()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:344:9
[INFO] [stderr]     |
[INFO] [stderr] 344 | /         let mut counter_value: Option<i64> = None;
[INFO] [stderr] 345 | |         if dt_value.has_counter_value() {
[INFO] [stderr] 346 | |             counter_value = Some(dt_value.get_counter_value());
[INFO] [stderr] 347 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> counter_value = if dt_value.has_counter_value() { Some(dt_value.get_counter_value()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/object.rs:800:12
[INFO] [stderr]     |
[INFO] [stderr] 800 |         if self.0.get_indexes().len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.0.get_indexes().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/stream.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         loop {
[INFO] [stderr] 46 | |             let next_buckets = match self.next() {
[INFO] [stderr] 47 | |                 Some(result) => {
[INFO] [stderr] 48 | |                     match result {
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |             buckets.extend(next_buckets.iter().cloned());
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(result) = self.next() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/stream.rs:62:5
[INFO] [stderr]     |
[INFO] [stderr] 62  | /     pub fn next(&mut self) -> Option<Result<Vec<Vec<u8>>, RiakErr>> {
[INFO] [stderr] 63  | |         if self.done {
[INFO] [stderr] 64  | |             return None;
[INFO] [stderr] 65  | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 155 | |         }
[INFO] [stderr] 156 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/stream.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 | /         loop {
[INFO] [stderr] 189 | |             let new_keys = match self.next() {
[INFO] [stderr] 190 | |                 Some(result) => {
[INFO] [stderr] 191 | |                     match result {
[INFO] [stderr] ...   |
[INFO] [stderr] 198 | |             keys.extend(new_keys);
[INFO] [stderr] 199 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(result) = self.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/stream.rs:205:5
[INFO] [stderr]     |
[INFO] [stderr] 205 | /     pub fn next(&mut self) -> Option<Result<Vec<Vec<u8>>, RiakErr>> {
[INFO] [stderr] 206 | |         if self.done {
[INFO] [stderr] 207 | |             return None;
[INFO] [stderr] 208 | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 300 | |         }
[INFO] [stderr] 301 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/stream.rs:345:5
[INFO] [stderr]     |
[INFO] [stderr] 345 | /     pub fn next(&mut self) -> Option<Result<IndexResp, RiakErr>> {
[INFO] [stderr] 346 | |         // short circuit if there's nothing more
[INFO] [stderr] 347 | |         if self.done {
[INFO] [stderr] 348 | |             return None;
[INFO] [stderr] ...   |
[INFO] [stderr] 392 | |         }
[INFO] [stderr] 393 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/yokozuna.rs:198:12
[INFO] [stderr]     |
[INFO] [stderr] 198 |         if self.0.get_fl().len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.0.get_fl().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/connection.rs:31:54
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 let timeout_duration = Duration::new(timeout as u64, 0);
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/connection.rs:132:24
[INFO] [stderr]     |
[INFO] [stderr] 132 |         recv_bytes |= ((recv_header[0] as u32) << 24) | ((recv_header[1] as u32) << 16) |
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(recv_header[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/connection.rs:132:58
[INFO] [stderr]     |
[INFO] [stderr] 132 |         recv_bytes |= ((recv_header[0] as u32) << 24) | ((recv_header[1] as u32) << 16) |
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(recv_header[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/connection.rs:133:24
[INFO] [stderr]     |
[INFO] [stderr] 133 |                       ((recv_header[2] as u32) << 8) |
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(recv_header[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/connection.rs:134:23
[INFO] [stderr]     |
[INFO] [stderr] 134 |                       (recv_header[3] as u32);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(recv_header[3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/bucket.rs:264:37
[INFO] [stderr]     |
[INFO] [stderr] 264 |     pub fn get_postcommit(&self) -> Option<HashMap<Vec<u8>, (Vec<u8>, Vec<u8>)>> {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bucket.rs:266:12
[INFO] [stderr]     |
[INFO] [stderr] 266 |         if postcommit.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!postcommit.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/bucket.rs:299:36
[INFO] [stderr]     |
[INFO] [stderr] 299 |     pub fn get_precommit(&self) -> Option<HashMap<Vec<u8>, (Vec<u8>, Vec<u8>)>> {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bucket.rs:301:12
[INFO] [stderr]     |
[INFO] [stderr] 301 |         if precommit.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!precommit.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/bucket.rs:745:37
[INFO] [stderr]     |
[INFO] [stderr] 745 |     pub fn get_postcommit(&self) -> Option<HashMap<Vec<u8>, (Vec<u8>, Vec<u8>)>> {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bucket.rs:747:12
[INFO] [stderr]     |
[INFO] [stderr] 747 |         if postcommit.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!postcommit.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/bucket.rs:780:36
[INFO] [stderr]     |
[INFO] [stderr] 780 |     pub fn get_precommit(&self) -> Option<HashMap<Vec<u8>, (Vec<u8>, Vec<u8>)>> {
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/bucket.rs:782:12
[INFO] [stderr]     |
[INFO] [stderr] 782 |         if precommit.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!precommit.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:208:9
[INFO] [stderr]     |
[INFO] [stderr] 208 | /         let mut context: Option<Vec<u8>> = None;
[INFO] [stderr] 209 | |         if dt_fetch_resp.has_context() {
[INFO] [stderr] 210 | |             context = Some(dt_fetch_resp.take_context());
[INFO] [stderr] 211 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> context = if dt_fetch_resp.has_context() { Some(dt_fetch_resp.take_context()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:222:9
[INFO] [stderr]     |
[INFO] [stderr] 222 | /         let mut value: Option<DataTypeValue> = None;
[INFO] [stderr] 223 | |         if dt_fetch_resp.has_value() {
[INFO] [stderr] 224 | |             value = Some(DataTypeValue::new_from_rpb(dt_fetch_resp.take_value()));
[INFO] [stderr] 225 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> value = if dt_fetch_resp.has_value() { Some(DataTypeValue::new_from_rpb(dt_fetch_resp.take_value())) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:252:9
[INFO] [stderr]     |
[INFO] [stderr] 252 | /         let mut counter_value: Option<i64> = None;
[INFO] [stderr] 253 | |         if rpb_map_entry.has_counter_value() {
[INFO] [stderr] 254 | |             counter_value = Some(rpb_map_entry.get_counter_value());
[INFO] [stderr] 255 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> counter_value = if rpb_map_entry.has_counter_value() { Some(rpb_map_entry.get_counter_value()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:264:9
[INFO] [stderr]     |
[INFO] [stderr] 264 | /         let mut register_value: Option<Vec<u8>> = None;
[INFO] [stderr] 265 | |         if rpb_map_entry.has_register_value() {
[INFO] [stderr] 266 | |             register_value = Some(rpb_map_entry.take_register_value());
[INFO] [stderr] 267 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> register_value = if rpb_map_entry.has_register_value() { Some(rpb_map_entry.take_register_value()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:270:9
[INFO] [stderr]     |
[INFO] [stderr] 270 | /         let mut flag_value: Option<bool> = None;
[INFO] [stderr] 271 | |         if rpb_map_entry.has_flag_value() {
[INFO] [stderr] 272 | |             flag_value = Some(rpb_map_entry.get_flag_value());
[INFO] [stderr] 273 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> flag_value = if rpb_map_entry.has_flag_value() { Some(rpb_map_entry.get_flag_value()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/data_type.rs:344:9
[INFO] [stderr]     |
[INFO] [stderr] 344 | /         let mut counter_value: Option<i64> = None;
[INFO] [stderr] 345 | |         if dt_value.has_counter_value() {
[INFO] [stderr] 346 | |             counter_value = Some(dt_value.get_counter_value());
[INFO] [stderr] 347 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> counter_value = if dt_value.has_counter_value() { Some(dt_value.get_counter_value()) } else { None };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/object.rs:800:12
[INFO] [stderr]     |
[INFO] [stderr] 800 |         if self.0.get_indexes().len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.0.get_indexes().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]   --> src/stream.rs:45:9
[INFO] [stderr]    |
[INFO] [stderr] 45 | /         loop {
[INFO] [stderr] 46 | |             let next_buckets = match self.next() {
[INFO] [stderr] 47 | |                 Some(result) => {
[INFO] [stderr] 48 | |                     match result {
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |             buckets.extend(next_buckets.iter().cloned());
[INFO] [stderr] 56 | |         }
[INFO] [stderr]    | |_________^ help: try: `while let Some(result) = self.next() { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/stream.rs:62:5
[INFO] [stderr]     |
[INFO] [stderr] 62  | /     pub fn next(&mut self) -> Option<Result<Vec<Vec<u8>>, RiakErr>> {
[INFO] [stderr] 63  | |         if self.done {
[INFO] [stderr] 64  | |             return None;
[INFO] [stderr] 65  | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 155 | |         }
[INFO] [stderr] 156 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/stream.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 | /         loop {
[INFO] [stderr] 189 | |             let new_keys = match self.next() {
[INFO] [stderr] 190 | |                 Some(result) => {
[INFO] [stderr] 191 | |                     match result {
[INFO] [stderr] ...   |
[INFO] [stderr] 198 | |             keys.extend(new_keys);
[INFO] [stderr] 199 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(result) = self.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/stream.rs:205:5
[INFO] [stderr]     |
[INFO] [stderr] 205 | /     pub fn next(&mut self) -> Option<Result<Vec<Vec<u8>>, RiakErr>> {
[INFO] [stderr] 206 | |         if self.done {
[INFO] [stderr] 207 | |             return None;
[INFO] [stderr] 208 | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 300 | |         }
[INFO] [stderr] 301 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/stream.rs:345:5
[INFO] [stderr]     |
[INFO] [stderr] 345 | /     pub fn next(&mut self) -> Option<Result<IndexResp, RiakErr>> {
[INFO] [stderr] 346 | |         // short circuit if there's nothing more
[INFO] [stderr] 347 | |         if self.done {
[INFO] [stderr] 348 | |             return None;
[INFO] [stderr] ...   |
[INFO] [stderr] 392 | |         }
[INFO] [stderr] 393 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/yokozuna.rs:198:12
[INFO] [stderr]     |
[INFO] [stderr] 198 |         if self.0.get_fl().len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.0.get_fl().is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/connection.rs:31:54
[INFO] [stderr]    |
[INFO] [stderr] 31 |                 let timeout_duration = Duration::new(timeout as u64, 0);
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/connection.rs:132:24
[INFO] [stderr]     |
[INFO] [stderr] 132 |         recv_bytes |= ((recv_header[0] as u32) << 24) | ((recv_header[1] as u32) << 16) |
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(recv_header[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/connection.rs:132:58
[INFO] [stderr]     |
[INFO] [stderr] 132 |         recv_bytes |= ((recv_header[0] as u32) << 24) | ((recv_header[1] as u32) << 16) |
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(recv_header[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/connection.rs:133:24
[INFO] [stderr]     |
[INFO] [stderr] 133 |                       ((recv_header[2] as u32) << 8) |
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(recv_header[2])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/connection.rs:134:23
[INFO] [stderr]     |
[INFO] [stderr] 134 |                       (recv_header[3] as u32);
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(recv_header[3])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/lib.rs:203:55
[INFO] [stderr]     |
[INFO] [stderr] 203 |                                                       &vec![]) {
[INFO] [stderr]     |                                                       ^^^^^^^ help: you can use a slice directly: `&[]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/lib.rs:203:55
[INFO] [stderr]     |
[INFO] [stderr] 203 |                                                       &vec![]) {
[INFO] [stderr]     |                                                       ^^^^^^^ help: you can use a slice directly: `&[]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> tests/object.rs:11:21
[INFO] [stderr]    |
[INFO] [stderr] 11 | const bucket_type: &'static str = "tests/object.rs";
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> tests/object.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 | const bucket: &'static str = "test_bucket";
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> tests/object.rs:13:13
[INFO] [stderr]    |
[INFO] [stderr] 13 | const key: &'static str = "test_key";
[INFO] [stderr]    |            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/client_basics.rs:30:31
[INFO] [stderr]    |
[INFO] [stderr] 30 |     assert_eq!(found_backend, "leveldb".as_bytes());
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"leveldb"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/client_basics.rs:33:39
[INFO] [stderr]    |
[INFO] [stderr] 33 |     let contents = ObjectContent::new("this is a test".as_bytes());
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"this is a test"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/client_basics.rs:43:37
[INFO] [stderr]    |
[INFO] [stderr] 43 |     assert_eq!(content.get_value(), "this is a test".as_bytes());
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"this is a test"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/client_basics.rs:58:23
[INFO] [stderr]    |
[INFO] [stderr] 58 |         if *bucket == "testbucket".as_bytes() {
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"testbucket"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/client_basics.rs:68:20
[INFO] [stderr]    |
[INFO] [stderr] 68 |         if *key == "testkey".as_bytes() {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"testkey"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> tests/client_basics.rs:79:9
[INFO] [stderr]    |
[INFO] [stderr] 79 |         lives_on_nodes = lives_on_nodes + 1;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lives_on_nodes += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> tests/client_basics.rs:95:16
[INFO] [stderr]    |
[INFO] [stderr] 95 |                "leveldb".as_bytes());
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"leveldb"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 10.49s
[INFO] running `"docker" "inspect" "912eb6f28b60bb41d135cbbce6849b8521f179b9af58f88d3914aca4a63d8372"`
[INFO] running `"docker" "rm" "-f" "912eb6f28b60bb41d135cbbce6849b8521f179b9af58f88d3914aca4a63d8372"`
[INFO] [stdout] 912eb6f28b60bb41d135cbbce6849b8521f179b9af58f88d3914aca4a63d8372