[INFO] crate rgmk 0.3.0 is already in cache [INFO] extracting crate rgmk 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/rgmk/0.3.0 [INFO] extracting crate rgmk 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rgmk/0.3.0 [INFO] validating manifest of rgmk-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rgmk-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rgmk-0.3.0 [INFO] finished frobbing rgmk-0.3.0 [INFO] frobbed toml for rgmk-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/rgmk/0.3.0/Cargo.toml [INFO] started frobbing rgmk-0.3.0 [INFO] finished frobbing rgmk-0.3.0 [INFO] frobbed toml for rgmk-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rgmk/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rgmk-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rgmk/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25cdfa7cd112dee4b4b39e2ec0eb5cb09ea9e3ac5d1efa5f7769f52cad880664 [INFO] running `"docker" "start" "-a" "25cdfa7cd112dee4b4b39e2ec0eb5cb09ea9e3ac5d1efa5f7769f52cad880664"` [INFO] [stderr] Checking rgmk v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/serde/txtr.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | const TYPE_ID: &'static [u8; 4] = b"TXTR"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/serde/txtr.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | const TYPE_ID: &'static [u8; 4] = b"TXTR"; [INFO] [stderr] | -^^^^^^^-------- help: consider removing `'static`: `&[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serde/mod.rs:207:18 [INFO] [stderr] | [INFO] [stderr] 207 | expected_id: &'static [u8; 4], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serde/mod.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | expected_type: &'static [u8; 4], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serde/mod.rs:207:18 [INFO] [stderr] | [INFO] [stderr] 207 | expected_id: &'static [u8; 4], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serde/mod.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | expected_type: &'static [u8; 4], [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.11s [INFO] running `"docker" "inspect" "25cdfa7cd112dee4b4b39e2ec0eb5cb09ea9e3ac5d1efa5f7769f52cad880664"` [INFO] running `"docker" "rm" "-f" "25cdfa7cd112dee4b4b39e2ec0eb5cb09ea9e3ac5d1efa5f7769f52cad880664"` [INFO] [stdout] 25cdfa7cd112dee4b4b39e2ec0eb5cb09ea9e3ac5d1efa5f7769f52cad880664